)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"97acee53eab157bab70f6a9ced943f1bed979836","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70229dc7_b55e07ea","updated":"2024-08-29 04:28:32.000000000","message":"This looks mostly OK but is missing compat code for the object.","commit_id":"09192c2ad16f2a0ee359cfff064c9e9af76ec05d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"b29b60521a77188865e1c144213ecb87ff0f22aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"406cd97f_ec9b6f66","updated":"2024-09-01 06:55:25.000000000","message":"recheck","commit_id":"13a05f9c84572594d95793b6bb8dd10506ffce7d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a7150f48b4fa9cc3e876e7cf762c9ffeabdfbb95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a4827e1b_03136d38","updated":"2024-10-21 00:01:00.000000000","message":"recheck","commit_id":"a8caa0ceb920e339521ee844e962041e66a46626"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"113da75b374d2f53124088099840d95cf76563b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8bc5cf50_9148f70d","updated":"2024-11-25 18:07:10.000000000","message":"looking at the rest of the seriese it starts to be in merge conflcit after this patch.\n\nim still generally ok with this and the follwoup sbut since \n\nhttps://review.opendev.org/c/openstack/nova-specs/+/932387 is now merged it might be worth rebasing the serise on teh top of master","commit_id":"bddca0f2b6438525cdcfa736cc9fea5cf0ce36a0"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"7541fbf8bce1e05aeaa344a4f0eebae5a4033b72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4b72446b_3f8a2b79","updated":"2024-12-30 18:49:05.000000000","message":"recheck","commit_id":"a2664b27e296f7eead7a56a0dcaad1a3842977d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3b31796503bed34312baf48f3195a2e0ed90dad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a88706ce_e5b54325","updated":"2025-01-30 21:16:43.000000000","message":"recheck ceph multistore failed to download cephadm","commit_id":"bfe59599174d0ccfa8a95a811aa9b4de38fd95c1"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6b2a594cdfb7ce786d15de31cbfa77998c478562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"bbbd418f_e78ab6c7","updated":"2025-02-05 03:13:18.000000000","message":"Looks OK to me. Will upgrade to +2 when the third patch is approved.","commit_id":"d93f1ec0c6935498d17a63ca9e47598eed33f33a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"701f79e91c0ed9d0d07a0f0bf1876cc22b397e39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"72d1e9c2_29e048a7","updated":"2025-02-18 10:21:13.000000000","message":"I\u0027m fine with the object change but I\u0027d want to only merge this patch once we approve the whole series","commit_id":"62be38adfd9d6c9f7de0aeaa88b556bb5634cbfd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cec68a8cda32d64032e5d0b499c8304d94e260e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"b74371d7_4aa7a981","updated":"2025-02-24 12:15:12.000000000","message":"https://review.opendev.org/c/openstack/tempest/+/942492 has merged and i have rehceked the third patch. assuming that passes (it should) ill approve all 3 in about an hour or two.","commit_id":"253dfc76ebca70f12aee7b39e916ee77e2b9f819"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fa77a94006a689d31fabe3fe07596fc512af7c62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"7269b2d4_724a294c","updated":"2025-02-24 15:14:43.000000000","message":"https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1cb/924844/42/check/nova-ovs-hybrid-plug/1cb518b/testr_results.html\n\nspice test passed on the third patch so elevating to +2w","commit_id":"253dfc76ebca70f12aee7b39e916ee77e2b9f819"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2ebf4956e4d2d9d03e2d58a7fd0524942482a458","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"a58c0031_2befb562","updated":"2025-02-22 00:06:40.000000000","message":"recheck `tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON. test_create_list_show_delete_interfaces_by_network_port` nova.exception.NovaException: Cell 1412e499-25c9-49cd-8c84-b67c8189ca88 is not responding or returned an exception, hence instance info is not available.","commit_id":"253dfc76ebca70f12aee7b39e916ee77e2b9f819"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c2e1735fb8e1650d237f7bd6e3480e8a93481f49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"8e1c3116_9a5b86da","updated":"2025-02-24 19:50:40.000000000","message":"recheck kernel paninc in grenade multi node ...","commit_id":"253dfc76ebca70f12aee7b39e916ee77e2b9f819"}],"nova/objects/console_auth_token.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"97acee53eab157bab70f6a9ced943f1bed979836","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":87,"context_line":"        super().obj_make_compatible(primitive, target_version)"},{"line_number":88,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":89,"context_line":"        if target_version \u003c (1, 2) and \u0027expires\u0027 in primitive:"},{"line_number":90,"context_line":"            primitive.pop(\u0027expires\u0027, None)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a35458d8_a17ce2cf","line":88,"updated":"2024-08-29 04:28:32.000000000","message":"We need to add handling of an 1.3 object with `tls_port` being backported to a 1.2 object without `tls_port`.","commit_id":"09192c2ad16f2a0ee359cfff064c9e9af76ec05d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b4522db6812fe8b754112cdddabc520a65c3ab8","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":87,"context_line":"        super().obj_make_compatible(primitive, target_version)"},{"line_number":88,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":89,"context_line":"        if target_version \u003c (1, 2) and \u0027expires\u0027 in primitive:"},{"line_number":90,"context_line":"            primitive.pop(\u0027expires\u0027, None)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"46d56ac6_89ab99f1","line":88,"in_reply_to":"2a684044_1c08219f","updated":"2024-08-29 10:55:52.000000000","message":"apparently the grenade failure was in a diffent patch not this one but still good catch","commit_id":"09192c2ad16f2a0ee359cfff064c9e9af76ec05d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"6c1219f1fe64b0b95825d97a6b65b1c29e4a3c82","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":87,"context_line":"        super().obj_make_compatible(primitive, target_version)"},{"line_number":88,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":89,"context_line":"        if target_version \u003c (1, 2) and \u0027expires\u0027 in primitive:"},{"line_number":90,"context_line":"            primitive.pop(\u0027expires\u0027, None)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"13d58a74_e0a07ca3","line":88,"in_reply_to":"46d56ac6_89ab99f1","updated":"2024-08-30 01:05:51.000000000","message":"Done","commit_id":"09192c2ad16f2a0ee359cfff064c9e9af76ec05d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d00bfdccd16dbb7b0ba0d1a7932f7b3c30772e30","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":87,"context_line":"        super().obj_make_compatible(primitive, target_version)"},{"line_number":88,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":89,"context_line":"        if target_version \u003c (1, 2) and \u0027expires\u0027 in primitive:"},{"line_number":90,"context_line":"            primitive.pop(\u0027expires\u0027, None)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2a684044_1c08219f","line":88,"in_reply_to":"758e3a31_01f0cdd1","updated":"2024-08-29 10:54:23.000000000","message":"if its now clear whats requried we need to add\n\n if target_version \u003c (1, 3) and \u0027expires\u0027 in primitive:\n            primitive.pop(\u0027tls_port\u0027, None)\n            \nbefore\n\n if target_version \u003c (1, 2) and \u0027expires\u0027 in primitive:\n            primitive.pop(\u0027expires\u0027, None)\n\n\nwe back level form newest to oldest so the order is imporant","commit_id":"09192c2ad16f2a0ee359cfff064c9e9af76ec05d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e9f1aa1cd995aab8a035939323580f4b89a9d573","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":87,"context_line":"        super().obj_make_compatible(primitive, target_version)"},{"line_number":88,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":89,"context_line":"        if target_version \u003c (1, 2) and \u0027expires\u0027 in primitive:"},{"line_number":90,"context_line":"            primitive.pop(\u0027expires\u0027, None)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"758e3a31_01f0cdd1","line":88,"in_reply_to":"a35458d8_a17ce2cf","updated":"2024-08-29 10:53:03.000000000","message":"ah thanks, i saw the greneade job fialed last night and didnt have a chance to see why but this would explain it.","commit_id":"09192c2ad16f2a0ee359cfff064c9e9af76ec05d"}],"nova/tests/unit/objects/test_console_auth_token.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"97acee53eab157bab70f6a9ced943f1bed979836","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            self.context, \u0027fake-host\u0027)"},{"line_number":187,"context_line":"        mock_destroy.assert_called_once_with("},{"line_number":188,"context_line":"            self.context, \u0027fake-host\u0027)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class TestConsoleAuthToken(test_objects._LocalTest,"},{"line_number":192,"context_line":"                           _TestConsoleAuthToken):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0168fda_70192f0b","line":189,"updated":"2024-08-29 04:28:32.000000000","message":"We should add a test for compatibility here to cover object version backporting. For example: https://github.com/openstack/nova/blob/8fb5a76872b68736e795212b047223562001e38d/nova/tests/unit/objects/test_image_meta.py#L541","commit_id":"09192c2ad16f2a0ee359cfff064c9e9af76ec05d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"6c1219f1fe64b0b95825d97a6b65b1c29e4a3c82","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            self.context, \u0027fake-host\u0027)"},{"line_number":187,"context_line":"        mock_destroy.assert_called_once_with("},{"line_number":188,"context_line":"            self.context, \u0027fake-host\u0027)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class TestConsoleAuthToken(test_objects._LocalTest,"},{"line_number":192,"context_line":"                           _TestConsoleAuthToken):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4985e316_abbf490d","line":189,"in_reply_to":"c0168fda_70192f0b","updated":"2024-08-30 01:05:51.000000000","message":"Done","commit_id":"09192c2ad16f2a0ee359cfff064c9e9af76ec05d"}]}