)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"caefa1fc34e87494af835c330210172202f59393","unresolved":true,"context_lines":[{"line_number":12,"context_line":"property. We did have a check for this, but it explicitly checked for"},{"line_number":13,"context_line":"the \u0027imageRef\u0027 being set to null - which isn\u0027t permitted by the schemas"},{"line_number":14,"context_line":"-instead of the empty string that is expected when creating a BFV"},{"line_number":15,"context_line":"instance. Correct this check."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id3442c3d315e6bb63e6c3675f4ab104885b3884f"},{"line_number":18,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"47b3ed5b_00721c45","line":15,"updated":"2024-08-28 16:43:59.000000000","message":"ack  source_type\u003dimage,destination_type\u003dlocal and boot_index\u003d0\n\nis perfectly valid provided   imageRef is not also set.\n\nso if you fixed the check then cool works for me.\n\nif your preventign decalring that bdm for the root disk that is a backward incompatbale api change and its not conssitent behavior so ill check what in the actully pacth ane resolve this comment shortly.\n\nim expect source_type\u003dimage,destination_type\u003dlocal to be allow if it also has an source id and imageRef is the empty stirng","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d68b82e819ea5c5ed5e88a290631b8ab4af55948","unresolved":false,"context_lines":[{"line_number":12,"context_line":"property. We did have a check for this, but it explicitly checked for"},{"line_number":13,"context_line":"the \u0027imageRef\u0027 being set to null - which isn\u0027t permitted by the schemas"},{"line_number":14,"context_line":"-instead of the empty string that is expected when creating a BFV"},{"line_number":15,"context_line":"instance. Correct this check."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id3442c3d315e6bb63e6c3675f4ab104885b3884f"},{"line_number":18,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"78b7f89a_439b50c6","line":15,"in_reply_to":"47b3ed5b_00721c45","updated":"2024-08-28 17:11:43.000000000","message":"\u003e ack  source_type\u003dimage,destination_type\u003dlocal and boot_index\u003d0\n\u003e \n\u003e is perfectly valid provided   imageRef is not also set.\n\u003e \n\u003e so if you fixed the check then cool works for me.\n\nYes, this is what I\u0027ve fixed.\n\n\u003e if your preventign decalring that bdm for the root disk that is a backward incompatbale api change and its not conssitent behavior so ill check what in the actully pacth ane resolve this comment shortly.\n\u003e \n\u003e im expect source_type\u003dimage,destination_type\u003dlocal to be allow if it also has an source id and imageRef is the empty stirng\n\nYes, this is currently allowed and I don\u0027t change it. However, I do think we might want to prevent this in the future, or at least prevent what options are allowed. For example, attempting to set `volume_size` should be either be rejected outright or rejected if it\u0027s \u003e `flavor.disk`. To be clear though, I am not changing this here.","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"11b8fb2466e34e4837a970ff96177d1565bf2a94","unresolved":true,"context_lines":[{"line_number":12,"context_line":"property. We did have a check for this, but it explicitly checked for"},{"line_number":13,"context_line":"the \u0027imageRef\u0027 being set to null - which isn\u0027t permitted by the schemas"},{"line_number":14,"context_line":"-instead of the empty string that is expected when creating a BFV"},{"line_number":15,"context_line":"instance. Correct this check."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id3442c3d315e6bb63e6c3675f4ab104885b3884f"},{"line_number":18,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a9b1573d_f3c1ef1a","line":15,"in_reply_to":"78b7f89a_439b50c6","updated":"2024-08-28 17:17:34.000000000","message":"yep it should be `rejected if volume_size \u003e flavor.disk`\n\nwe shoudl support setting the volume_size on all local volumes because that is used for both swap and ephemeral disk\n\nso that should not depend on teh boot index.\n\nagain consistency is important and we shoudl not be special casing the root disk","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad89b6f44eaf785a50c722d021aa971ea06d3181","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3c15722_1e956d19","updated":"2025-10-24 12:36:43.000000000","message":"I think gibi isn\u0027t coming to this at this point 😄","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4c9e4f9ef4f0acaf9e0674f4940d6820705b53a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe7d5047_42efd4be","updated":"2024-08-28 16:26:15.000000000","message":"Makes sense, nice find. +1 waiting for CI","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f37d6ab68f8051bbb29c4e87bde09e787f44aaf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e7b3666f_be50b0d4","updated":"2024-08-30 00:07:09.000000000","message":"Upgrading to +2, CI is green. For image_ref both `None` and `\u0027\u0027` mean BFV, so missing handling of `\u0027\u0027` looks to me like an oversight and this fix seems valid IMHO.","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e7cc67e4bc7f00b613b3c055cfc44a57ac02b4a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a94a30bf_9522ec37","updated":"2024-08-30 00:21:26.000000000","message":"it pains me to not fix this by making the local volume cosnitent\nbut your not preventing something that prvisouldy worked form working since it 500ed and this is at least a better errror then that.\n\n\nill hold +w till tomrorow in case gibi wants to chime in otherwise ill approve before i finish for the day.","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a0e76d967a7eb8e7fa803eaca32979246f5e1513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b339d0ec_eda5a11b","updated":"2024-08-28 16:22:32.000000000","message":"recheck ssh timeout ERROR tempest.lib.common.ssh paramiko.ssh_exception.NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 172.24.5.253","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fecae1b54deef20b80fc154ea0c40c00145e8cf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d6acade_1c523a90","updated":"2024-08-28 10:06:42.000000000","message":"recheck unrelated failure","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8995faeedc397c931f388407db06fed0478274dd","unresolved":true,"context_lines":[{"line_number":512,"context_line":"            # Sets the legacy_bdm flag if we got a legacy block device mapping."},{"line_number":513,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d True"},{"line_number":514,"context_line":"        elif block_device_mapping_v2:"},{"line_number":515,"context_line":"            # Have to check whether --image is given, see bug 1433609"},{"line_number":516,"context_line":"            image_ref \u003d server_dict.get(\u0027imageRef\u0027)"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                block_device_mapping \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"108e9009_6803cbe6","line":515,"range":{"start_line":515,"start_character":62,"end_line":515,"end_character":69},"updated":"2024-08-28 16:46:40.000000000","message":"that should really be https://bugs.launchpad.net/nova/+bug/1377958\n\ni think i want gibis input on this but i think we likely shoudl not have fixed this the way we did in the past.","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18bb770c6eb4c41b5f9cfb16d10f28587ee20919","unresolved":true,"context_lines":[{"line_number":512,"context_line":"            # Sets the legacy_bdm flag if we got a legacy block device mapping."},{"line_number":513,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d True"},{"line_number":514,"context_line":"        elif block_device_mapping_v2:"},{"line_number":515,"context_line":"            # Have to check whether --image is given, see bug 1433609"},{"line_number":516,"context_line":"            image_ref \u003d server_dict.get(\u0027imageRef\u0027)"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                block_device_mapping \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"e3af678a_dc975367","line":515,"range":{"start_line":515,"start_character":62,"end_line":515,"end_character":69},"in_reply_to":"108e9009_6803cbe6","updated":"2024-08-28 17:02:23.000000000","message":"so im conflcited.\n\ni think it shoudl be supproted and this shoudl be fixed in the future so that it is but i guess since we have been blocking it while teh request had image_ref: null\nwhich translates to None we could maintain the block even it futher encodeign a delta between BFV and non BFV that should not exist.\n\n@gibi i have remvoed my -1 but i still would prefer to eventually fix this properly.\n\ni agree that nova\u0027s code does not handel this properly today so im inclided to say lets fix the current 500 but we shoudl  revisit the orginal fix and make that request work in a seprate change.\n\nim just not sure who is going to have time to go and do that.","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"11b8fb2466e34e4837a970ff96177d1565bf2a94","unresolved":true,"context_lines":[{"line_number":512,"context_line":"            # Sets the legacy_bdm flag if we got a legacy block device mapping."},{"line_number":513,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d True"},{"line_number":514,"context_line":"        elif block_device_mapping_v2:"},{"line_number":515,"context_line":"            # Have to check whether --image is given, see bug 1433609"},{"line_number":516,"context_line":"            image_ref \u003d server_dict.get(\u0027imageRef\u0027)"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                block_device_mapping \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"7a6cb4ea_b893e6f6","line":515,"range":{"start_line":515,"start_character":62,"end_line":515,"end_character":69},"in_reply_to":"713cacce_593068be","updated":"2024-08-28 17:17:34.000000000","message":"im not sure this shoudl requrie a spec. we are allow to convert 500 errros into 200 OKs or 400 error without a microverion bump.\n\nwhich is kind of why i would prefer to fix it in thie patch as otherwise it woudl require a trivial spec and a microverison","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d68b82e819ea5c5ed5e88a290631b8ab4af55948","unresolved":true,"context_lines":[{"line_number":512,"context_line":"            # Sets the legacy_bdm flag if we got a legacy block device mapping."},{"line_number":513,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d True"},{"line_number":514,"context_line":"        elif block_device_mapping_v2:"},{"line_number":515,"context_line":"            # Have to check whether --image is given, see bug 1433609"},{"line_number":516,"context_line":"            image_ref \u003d server_dict.get(\u0027imageRef\u0027)"},{"line_number":517,"context_line":"            try:"},{"line_number":518,"context_line":"                block_device_mapping \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"713cacce_593068be","line":515,"range":{"start_line":515,"start_character":62,"end_line":515,"end_character":69},"in_reply_to":"e3af678a_dc975367","updated":"2024-08-28 17:11:43.000000000","message":"You\u0027ll see that I have a `TODO` in the functional test. I am happy to move that TODO here. I would also be happy to fix this via a small spec, but I\u0027m only going to do that if the thing will actually get reviewed (i.e. it\u0027s important enough to warrant the attention) 😄","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"}],"nova/tests/functional/regressions/test_bug_2077980.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"caefa1fc34e87494af835c330210172202f59393","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            client.OpenStackApiException, self.api.post_server,"},{"line_number":47,"context_line":"            {\u0027server\u0027: server})"},{"line_number":48,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":49,"context_line":"        self.assertIn(\"Mapping image to local is not supported.\", str(ex))"}],"source_content_type":"text/x-python","patch_set":1,"id":"0c3e32f3_60681a1e","line":49,"updated":"2024-08-28 16:43:59.000000000","message":"-1 i dont think this is correct.\n\nthe ablity to specify the image uuid in teh bdms shoudl not change between BFV and local.\n\nthat is inconsitent api behavior.\n\nim welcome to being convicned otherwise but we want to normalise the behavior between boot form image and boot from volume not diverage futher.\n\nnit: the regression patch is ment to be in a repoduce before the fix.","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d68b82e819ea5c5ed5e88a290631b8ab4af55948","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            client.OpenStackApiException, self.api.post_server,"},{"line_number":47,"context_line":"            {\u0027server\u0027: server})"},{"line_number":48,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":49,"context_line":"        self.assertIn(\"Mapping image to local is not supported.\", str(ex))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffc63491_072bfb35","line":49,"in_reply_to":"0c3e32f3_60681a1e","updated":"2024-08-28 17:11:43.000000000","message":"I mean, I can change the exception message to say it is not *currently* supported, but I\u0027m not really adding anything new here, rather fixing an existing check that has broken, so... 🤷","commit_id":"53eb2cdeab4d25c8842d1f76e074ed3c24323d0d"}]}