)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"81780a69874f85fc52102615987beff0c4bcf71a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9167da4b_4d9701c4","updated":"2024-10-29 15:39:12.000000000","message":"recheck","commit_id":"6ce633f12f4a7a80e0020f77e56a1e96d59e6ec7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dece7bf40a75295891fb08221cbc07c6d3149b29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a6f83672_525bce48","updated":"2025-02-27 02:24:04.000000000","message":"again just a skim pass this also looks reasonable","commit_id":"d0ab88b5abab27530278acb567b799fa7585029b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"879a5e7d48cadc3e77068fda92ef0170d3a23207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f093a098_05d163dd","updated":"2025-02-25 07:07:45.000000000","message":"recheck","commit_id":"d0ab88b5abab27530278acb567b799fa7585029b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3d35fac0ebc1d45159a57efc668153c82951b4e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"272b856f_3777e800","updated":"2025-06-11 02:52:04.000000000","message":"recheck it\u0027s strange that the error appears only in py310","commit_id":"00a0f10d1b3da0c6d2ec0ab3d06fcf97abf67cf6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0b67fd94ea296ee2071b6ed5d9f0a3d8b3ed93b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"af33b303_cfe0a886","updated":"2025-06-18 02:52:01.000000000","message":"recheck","commit_id":"3c393738aa60932b45dbf38f9a9ce6c9fc19d84c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"291844f85ab21a05a068e5737e47871de8286956","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"7e77ef1a_ec229f18","updated":"2025-08-07 13:05:37.000000000","message":"recheck ping failed in grenade","commit_id":"a40fecba3fb11d623d4af17b93d0f41c77246bed"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7b0257876a1a8e85fb71a2b2dbd7b91a4e39f63a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"2074aa2b_50146fab","updated":"2025-08-27 08:32:24.000000000","message":"that one was easy to review.","commit_id":"a0522e83c1d6aa4e69bf62418843b351653e22be"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"50b8f0df0fbaf8713dafb87232d12d39dfb992a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"357766cf_2cd9b4cf","updated":"2025-08-27 14:31:12.000000000","message":"I have check revision of objets are properly done.\nCompatibility using previous version of object is ok.\nEnum used.\nThis patch is clearly easier to review compared to the previous one. \\o/\nLGTM.","commit_id":"6e1144339005e00b7bace5c61c49acf71d8ce361"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"17925e75b9045977e80639e5181d6c7e9fbec644","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"f385a0a4_9b9268ac","updated":"2025-08-28 04:06:24.000000000","message":"recheck","commit_id":"dc6641baad3f6902f238ace14ace6defb029a828"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b5803f41748e2c8e9fe6b0fcd7e2e96215773f16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"24826996_d8655db2","updated":"2025-08-28 13:01:53.000000000","message":"recheck error indicates an infra problem","commit_id":"dc6641baad3f6902f238ace14ace6defb029a828"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5c26a273fe159dfe31e77ee60abaf8873d7c3b8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"e788c7eb_81cd5c0a","updated":"2025-08-28 06:25:51.000000000","message":"recheck grenade failed for unrelated reason.","commit_id":"dc6641baad3f6902f238ace14ace6defb029a828"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"771846f739053aa0a80f2e885e6a8576a0014a2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"3f4061cb_8a746775","updated":"2025-08-28 16:40:08.000000000","message":"recheck the job was stuck are flavor creation without explicit error...","commit_id":"dc6641baad3f6902f238ace14ace6defb029a828"}],"nova/objects/fields.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"584a460a40abe28dd4ab3123e751fd2d0ea8bfc7","unresolved":true,"context_lines":[{"line_number":565,"context_line":"class MemEncryptionModel(BaseNovaEnum):"},{"line_number":566,"context_line":"    AMD_SEV \u003d \"amd-sev\""},{"line_number":567,"context_line":"    AMD_SEV_ES \u003d \"amd-sev-es\""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    ALL \u003d (AMD_SEV, AMD_SEV_ES)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"6cca4bb9_3c5146bf","line":568,"updated":"2025-02-27 02:40:39.000000000","message":"so looking at the spec again a third option would be to add “any”\nwhich would translate to not addign a required trait\nthat wold provide a way for people to opt into any avaiabel memory encyption while allowing you to assume the absence of the extra spec/iamge property mean plain sev.","commit_id":"d0ab88b5abab27530278acb567b799fa7585029b"},{"author":{"_account_id":35307,"name":"Taketani Ryo","email":"taketani.ryo@fujitsu.com","username":"r-taketn0517"},"change_message_id":"e5265f89ab455abed1760abc8fdcb096889cb53f","unresolved":true,"context_lines":[{"line_number":565,"context_line":"class MemEncryptionModel(BaseNovaEnum):"},{"line_number":566,"context_line":"    AMD_SEV \u003d \"amd-sev\""},{"line_number":567,"context_line":"    AMD_SEV_ES \u003d \"amd-sev-es\""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    ALL \u003d (AMD_SEV, AMD_SEV_ES)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"e40879b3_206f9948","line":568,"in_reply_to":"6cca4bb9_3c5146bf","updated":"2025-06-11 11:16:28.000000000","message":"@smooney@redhat.com\nLet me clarify my understanding of your concern regarding the specification. Currently, this feature enables plain SEV when hw_mem_encryption_model is not specified. Is your suggestion that this feature should also allow users to select any available memory encryption model?","commit_id":"d0ab88b5abab27530278acb567b799fa7585029b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"09a75194f3623a69b858697aff3c71eb28566dd7","unresolved":false,"context_lines":[{"line_number":565,"context_line":"class MemEncryptionModel(BaseNovaEnum):"},{"line_number":566,"context_line":"    AMD_SEV \u003d \"amd-sev\""},{"line_number":567,"context_line":"    AMD_SEV_ES \u003d \"amd-sev-es\""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    ALL \u003d (AMD_SEV, AMD_SEV_ES)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"2987dbb4_42467e4e","line":568,"in_reply_to":"e40879b3_206f9948","updated":"2025-06-11 11:52:43.000000000","message":"I think we discussed this https://review.opendev.org/c/openstack/nova/+/925685/comment/61098790_79a512ad/ and agreed with the current approach but lmk if I misunderstand your intention.","commit_id":"d0ab88b5abab27530278acb567b799fa7585029b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"50b8f0df0fbaf8713dafb87232d12d39dfb992a3","unresolved":false,"context_lines":[{"line_number":566,"context_line":"    AMD_SEV \u003d \"amd-sev\""},{"line_number":567,"context_line":"    AMD_SEV_ES \u003d \"amd-sev-es\""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    ALL \u003d (AMD_SEV, AMD_SEV_ES)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"class MaxPhyAddrMode(BaseNovaEnum):"}],"source_content_type":"text/x-python","patch_set":32,"id":"b3b6ae2d_79014f85","line":569,"updated":"2025-08-27 14:31:12.000000000","message":"+1 for enums","commit_id":"6e1144339005e00b7bace5c61c49acf71d8ce361"}],"nova/objects/image_meta.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7b0257876a1a8e85fb71a2b2dbd7b91a4e39f63a","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    # ImageMetaPropsPayload must also be bumped. See its docstring for details."},{"line_number":207,"context_line":"    VERSION \u003d \u00271.42\u0027"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def obj_make_compatible(self, primitive, target_version):  # noqa: C901"},{"line_number":210,"context_line":"        super(ImageMetaProps, self).obj_make_compatible(primitive,"},{"line_number":211,"context_line":"                                                        target_version)"},{"line_number":212,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"}],"source_content_type":"text/x-python","patch_set":30,"id":"fe671a5a_ed8c03fa","line":209,"range":{"start_line":209,"start_character":62,"end_line":209,"end_character":75},"updated":"2025-08-27 08:32:24.000000000","message":"hmmm, that\u0027s sad... the function shall be decoupled given it becomes too complex, but that shouldn\u0027t be done in that patch.","commit_id":"a0522e83c1d6aa4e69bf62418843b351653e22be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0f195cbe94b65248ca90b4b87c10607155ffd7e6","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    # ImageMetaPropsPayload must also be bumped. See its docstring for details."},{"line_number":207,"context_line":"    VERSION \u003d \u00271.42\u0027"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def obj_make_compatible(self, primitive, target_version):  # noqa: C901"},{"line_number":210,"context_line":"        super(ImageMetaProps, self).obj_make_compatible(primitive,"},{"line_number":211,"context_line":"                                                        target_version)"},{"line_number":212,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"}],"source_content_type":"text/x-python","patch_set":30,"id":"18809f6f_881b6226","line":209,"range":{"start_line":209,"start_character":62,"end_line":209,"end_character":75},"in_reply_to":"fe671a5a_ed8c03fa","updated":"2025-08-28 17:48:35.000000000","message":"actuly i think this is fine to keep\n\nthe function is long but i dont consder a ordered chain of ifs to be complex\n\nso i woudl not decompose this i would keep this as is and consider if we want to do a V2 in teh future that is equal to 1.42 so we can reset the number\n\nbut im fine with permently excluding this form teh complexity check until we decied to do a v2","commit_id":"a0522e83c1d6aa4e69bf62418843b351653e22be"}]}