)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bbd98cb830abce2ff6597d0fdcdf7680be43d010","unresolved":true,"context_lines":[{"line_number":10,"context_line":"8.0.0 or higher."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint igb-vif-model"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/928582"},{"line_number":15,"context_line":"Change-Id: I6a1d8058c640e5dc015889610c4ae864ed9a5ccb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"6413fc94_42359b73","line":13,"updated":"2024-09-10 10:22:32.000000000","message":"Here you can see the manual test results from a devstack VM booting a nova guest with igb: https://paste.opendev.org/show/bNXiQMydztZ8dnZHwgIy/","commit_id":"6839bb16af21127201427cb0c53ac20e4efcfb27"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85390320cf856695659b90bc46af00c8fb2cde21","unresolved":true,"context_lines":[{"line_number":10,"context_line":"8.0.0 or higher."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint igb-vif-model"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/928582"},{"line_number":15,"context_line":"Change-Id: I6a1d8058c640e5dc015889610c4ae864ed9a5ccb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fcdf292_c8fe250f","line":13,"in_reply_to":"6413fc94_42359b73","updated":"2024-10-25 17:09:59.000000000","message":"yep i have also replicated this.","commit_id":"6839bb16af21127201427cb0c53ac20e4efcfb27"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"489373f9d32347691ec2e4e2421ea5e5add8cc45","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint igb-vif-model"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/928582"},{"line_number":15,"context_line":"Change-Id: I6a1d8058c640e5dc015889610c4ae864ed9a5ccb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"2162d2bd_41a05fb2","line":14,"updated":"2024-09-23 13:49:04.000000000","message":"the functional test will keep failing due to \n```\n2024-09-23 13:03:30,306 ERROR [nova.scheduler.request_filter] Computed trait name \u0027COMPUTE_NET_VIF_MODEL_IGB\u0027 is not valid; is os-traits up to date?\n```\nuntil the os-traits is released and the os-traits version is bumped","commit_id":"557db2f9b1c6d0c173ea4effc966fbbb601f1af8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68c74d9a1fc01d26434c72004a8be0ef88c4ec1f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint igb-vif-model"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/928582"},{"line_number":15,"context_line":"Change-Id: I6a1d8058c640e5dc015889610c4ae864ed9a5ccb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fb1c70fa_230aab6b","line":14,"in_reply_to":"2162d2bd_41a05fb2","updated":"2024-10-24 11:14:47.000000000","message":"Done","commit_id":"557db2f9b1c6d0c173ea4effc966fbbb601f1af8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85390320cf856695659b90bc46af00c8fb2cde21","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Implements: blueprint igb-vif-model"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/928582"},{"line_number":15,"context_line":"(merged, released as 3.2.0)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6a1d8058c640e5dc015889610c4ae864ed9a5ccb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"79903cab_b653fb62","line":15,"updated":"2024-10-25 17:09:59.000000000","message":"nit: we could remove the depend on now","commit_id":"07295b0f9944d316bfe8de25ecd659ced506433b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b403ff0b280599050f189d68cd8a6cfcb45d804b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b1a55bdd_dba69261","updated":"2024-09-09 12:15:26.000000000","message":"oh your adding the trait here... i guess that is ok but any reason to have this as a seperate patch?\n\ni would personably merge this with the previous one. we willl also need a trivial release note for this","commit_id":"483da51cd2ec01451d5bb2187fb8912e1605d15b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"493f7de2ed889d73c06173d23c86bb2224c12336","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"38dbb987_6baccbd5","in_reply_to":"b1a55bdd_dba69261","updated":"2024-09-09 12:16:31.000000000","message":"answering my own question i guess you are keeping the object change seperate form the driver change which is fine\n\nso in that case you just need the release note, test coverge and verions checks here","commit_id":"483da51cd2ec01451d5bb2187fb8912e1605d15b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"64bc560aa95657b4af7de79ce04b8922568b2c75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4443d181_70267b1d","updated":"2024-10-04 14:38:08.000000000","message":"recheck global version bump landed.","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6af0b4ef5c87ced0a095f6f87f97b88d49788048","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cc58991e_42cda5be","updated":"2024-10-09 11:04:18.000000000","message":"recheck grenade-skip-level-always unrelated error\nDetails: {\u0027type\u0027: \u0027RouterNotFound\u0027, \u0027message\u0027: \u0027Router 212601dc-82ca-45a6-a2bc-140f8d89df2a could not be found\u0027, \u0027detail\u0027: \u0027\u0027}","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"67b19ed6c1571b06bb03a4f24c903504521a88f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"49fc3ca1_598ab584","updated":"2024-10-07 10:36:21.000000000","message":"recheck nova-livemigration job failed due to compute failing to start properly\n\nOct 04 14:54:59.371843 np0038712059 nova-compute[85124]: ERROR nova.compute.manager nova.exception.Invalid: Invalid \u0027[compute] cpu_shared_set\u0027 config: one or more of the configured CPUs is not online. Online cpuset(s): [0, 1, 2, 3], configured cpuset(s): [0, 1, 2, 3, 4, 5]\n7962\t\n\nhttps://zuul.opendev.org/t/openstack/build/93e5dca3b79348e5a8d3f5fecda82382/log/controller/logs/screen-n-cpu.txt?severity\u003d4#7961","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"69ea3bed670d496e06945319ec5118ab125dad81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9449d33b_de5991c4","updated":"2024-10-04 11:24:58.000000000","message":"we need to bump os-traits 3.2.0 in global requirements.","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b05c790c7f58c55c25d73a3384d63ae9828cee5a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ec1d1f97_b593e615","updated":"2024-10-17 01:35:47.000000000","message":"Very nice work :-)\n\nI\u0027m leaving a few suggestions. Hope these make sense","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68c74d9a1fc01d26434c72004a8be0ef88c4ec1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"60d40ce4_b26ab524","in_reply_to":"ec1d1f97_b593e615","updated":"2024-10-24 11:14:47.000000000","message":"Thanks for the review fixed and responded inline.","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"}],"nova/tests/functional/libvirt/test_vif_model.py":[{"author":{"_account_id":29455,"name":"Jason Grosso","email":"jgrosso@redhat.com","username":"jgrosso"},"change_message_id":"9a60dbde36b1f3348b85f2ee5e49c9992b51b693","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            }"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_boot_with_vif_model_igb(self):"},{"line_number":59,"context_line":"        orig_create \u003d nova.virt.libvirt.guest.Guest.create"},{"line_number":60,"context_line":"        self.xml \u003d \"\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"f4dea602_f4bf7d3e","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":36},"updated":"2024-10-15 19:42:15.000000000","message":"Hey Gibi just so i understand with this change we can use vms to test SRIOV, where before we used Baremetal hardware. my question is about configurations of imagess When we created an image/flavor do we need to be cognizant of the difference between physical and virtual disk sizes , networking. I noticed from other code we need machine type q35 and Qemu 8.0 and libvirt 9.3.0.","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef447efe38a57e6542b3b7f1e8c44c05942a780a","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            }"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_boot_with_vif_model_igb(self):"},{"line_number":59,"context_line":"        orig_create \u003d nova.virt.libvirt.guest.Guest.create"},{"line_number":60,"context_line":"        self.xml \u003d \"\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"73b87d15_ba1b77b7","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":36},"in_reply_to":"52eeefd4_811d0124","updated":"2024-10-16 13:57:47.000000000","message":"Just extending Takashi\u0027s answer. \n\nIf we are controlling the system that creates the VM for our testing env, e.g. we create the VMs ourselves on some baremetal node, then that baremetal node only need the new enough libvirt and qemu version installed and we need to create the domain.xml of the VM with certain tags(see the doc patch top of the series for details, or ping me on IRC and I can paste an example domain.xml for reference). \n\nHowever in most of our test envs we don\u0027t control the baremetal node, and not fully control the VM creation process, but get a VM from some cloud provider. In this case we can only get a VM with igb NIC if the cloud provider supports creating such VM. All of our cloud providers use openstack, so they need to actually deploy this patch series before we can request an igb capable VMs from them via the nova API they provide.\n\nOne hack would be to add an extra level of nesting. Asking a plain VM (L1) from our cloud provider, then in that VM install libvirt and qemu and start a nested VM (L2) with an igb NIC. Then in L2 we could deploy nova with PCI passthrough config, and then nova could start a guest VM (L3) and pass through the emulated PCI device. This will be at least extremely slow due to the nesting, and potentially unstable. \n\nNow if you are only looking at testing this specific patch series and not PCI passthrough with igb then we can do that today already if the L1 VM we get from the nodepool runs a new enough libvirt and qemu. Then we just deploy nova there as usual and ask nova to boot us a VM with igb by setting hw_vif_model\u003digb on the glance image. Then we can ssh into the VM(L2) nova booted and check if it got a PCI device that is an igb NIC. I think this can all be doable in upstream tempest today depending on this nova series.","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85390320cf856695659b90bc46af00c8fb2cde21","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            }"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_boot_with_vif_model_igb(self):"},{"line_number":59,"context_line":"        orig_create \u003d nova.virt.libvirt.guest.Guest.create"},{"line_number":60,"context_line":"        self.xml \u003d \"\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"cbefe37e_cd836871","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":36},"in_reply_to":"73b87d15_ba1b77b7","updated":"2024-10-25 17:09:59.000000000","message":"for this cycle we can start by just testing creating vms with nova in the vms we are provided form teh guest and assertign that igb is used correctly.\n\nnext cycle when  providers that supproting this we can  upload iamges with this imave properly so that we recive  vms form them that supprot sriov\n\nthat will likely need a sperate nodepool lable and nodeset so that we can target those providres for a job that will then test sriov in teh 1st party ci.\n\nthe focus for integration test this cycle shoudl jsut eb on can nova crate a vm with this interface.\n\nunfortuanly cirros does not have the required driver for networking to work so beyond a simple boot test we cant do much more.\nwe could do a console show i guess and check that igb show up btu we cant ssh in yet without use a different image.\n\n\nif you use a full-fat rhel/ubuntu image with the igb kernel module we can have a tempest test that will boot a vm with this image and then ssh in and performa extra assertions.\n\nWithout that white box, the best way to test this from an integration perspective as it can simply ssh to the comptue node and assert the xml is correct. i.e. that the interface the vm booted with has model\u003digb","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fe443503c22ad634e4212ed234dc0056cdde0ffd","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            }"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_boot_with_vif_model_igb(self):"},{"line_number":59,"context_line":"        orig_create \u003d nova.virt.libvirt.guest.Guest.create"},{"line_number":60,"context_line":"        self.xml \u003d \"\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"2467b81c_883459b6","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":36},"in_reply_to":"cbefe37e_cd836871","updated":"2024-10-29 10:37:14.000000000","message":"Yeah, what sean said. We can\u0027t just test igb with our current gate jobs given cirros doesn\u0027t support it. But if we are able to have a periodic gate job for using whitebox checks, then we could test it.","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9d4d36ea983468e649a3c219fbe54c25fe48ce16","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            }"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_boot_with_vif_model_igb(self):"},{"line_number":59,"context_line":"        orig_create \u003d nova.virt.libvirt.guest.Guest.create"},{"line_number":60,"context_line":"        self.xml \u003d \"\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"52eeefd4_811d0124","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":36},"in_reply_to":"f4dea602_f4bf7d3e","updated":"2024-10-16 03:38:43.000000000","message":"I think what we only care are QEMU version and libvirt version because we need that these actually supports igb image. I don\u0027t think anything related to disk size may be involved here. Regarding networking, the driver is used only for virtual networking as SRIOV support uses pci passthrough mechanism instead, so I don\u0027t think you have to care about the networking functions used in the vm","commit_id":"127e0ac3082f55250e88cf1bc93df7fea119355d"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b05c790c7f58c55c25d73a3384d63ae9828cee5a","unresolved":true,"context_lines":[{"line_number":28187,"context_line":"                self.assertEqual(bus_from_trait in buses, bus_traits[trait])"},{"line_number":28188,"context_line":""},{"line_number":28189,"context_line":"    @mock.patch.object("},{"line_number":28190,"context_line":"        host.Host, \u0027has_min_version\u0027, new\u003dmock.Mock(return_value\u003dTrue))"},{"line_number":28191,"context_line":"    def test_vif_model_traits(self):"},{"line_number":28192,"context_line":"        \"\"\"Test getting vif model traits per virt type.\"\"\""},{"line_number":28193,"context_line":"        for virt_type, models in libvirt_vif.SUPPORTED_VIF_MODELS.items():"}],"source_content_type":"text/x-python","patch_set":13,"id":"287e7ae3_2b36539e","line":28190,"range":{"start_line":28190,"start_character":38,"end_line":28190,"end_character":70},"updated":"2024-10-17 01:35:47.000000000","message":"I wonder if this can be `return_value\u003dTrue` to use the consistent method for both `test_vif_model_traits` and `test_vif_model_traits_old_version_no_igb_support` ?","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68c74d9a1fc01d26434c72004a8be0ef88c4ec1f","unresolved":false,"context_lines":[{"line_number":28187,"context_line":"                self.assertEqual(bus_from_trait in buses, bus_traits[trait])"},{"line_number":28188,"context_line":""},{"line_number":28189,"context_line":"    @mock.patch.object("},{"line_number":28190,"context_line":"        host.Host, \u0027has_min_version\u0027, new\u003dmock.Mock(return_value\u003dTrue))"},{"line_number":28191,"context_line":"    def test_vif_model_traits(self):"},{"line_number":28192,"context_line":"        \"\"\"Test getting vif model traits per virt type.\"\"\""},{"line_number":28193,"context_line":"        for virt_type, models in libvirt_vif.SUPPORTED_VIF_MODELS.items():"}],"source_content_type":"text/x-python","patch_set":13,"id":"df76a825_ae4586f0","line":28190,"range":{"start_line":28190,"start_character":38,"end_line":28190,"end_character":70},"in_reply_to":"287e7ae3_2b36539e","updated":"2024-10-24 11:14:47.000000000","message":"Done","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b05c790c7f58c55c25d73a3384d63ae9828cee5a","unresolved":true,"context_lines":[{"line_number":28216,"context_line":"            vif_models \u003d self.drvr._get_vif_model_traits()"},{"line_number":28217,"context_line":"            self.assertFalse(vif_models[\u0027COMPUTE_NET_VIF_MODEL_IGB\u0027])"},{"line_number":28218,"context_line":""},{"line_number":28219,"context_line":"        mock_has_min_version.assert_called_with((9, 3, 0), (8, 0, 0))"},{"line_number":28220,"context_line":""},{"line_number":28221,"context_line":"    def test_video_model_traits(self):"},{"line_number":28222,"context_line":"        \"\"\"Test getting video model traits per virt type.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"ad40893b_434ca61a","line":28219,"range":{"start_line":28219,"start_character":7,"end_line":28219,"end_character":69},"updated":"2024-10-17 01:35:47.000000000","message":"Maybe we can add this to test_vif_model_traits, too ?","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68c74d9a1fc01d26434c72004a8be0ef88c4ec1f","unresolved":false,"context_lines":[{"line_number":28216,"context_line":"            vif_models \u003d self.drvr._get_vif_model_traits()"},{"line_number":28217,"context_line":"            self.assertFalse(vif_models[\u0027COMPUTE_NET_VIF_MODEL_IGB\u0027])"},{"line_number":28218,"context_line":""},{"line_number":28219,"context_line":"        mock_has_min_version.assert_called_with((9, 3, 0), (8, 0, 0))"},{"line_number":28220,"context_line":""},{"line_number":28221,"context_line":"    def test_video_model_traits(self):"},{"line_number":28222,"context_line":"        \"\"\"Test getting video model traits per virt type.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"16c0025d_22c8545d","line":28219,"range":{"start_line":28219,"start_character":7,"end_line":28219,"end_character":69},"in_reply_to":"ad40893b_434ca61a","updated":"2024-10-24 11:14:47.000000000","message":"Done","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b05c790c7f58c55c25d73a3384d63ae9828cee5a","unresolved":true,"context_lines":[{"line_number":12998,"context_line":"        # remove version dependent vif models if we are on older libvirt/qemu"},{"line_number":12999,"context_line":"        igb_supported \u003d self._host.has_min_version("},{"line_number":13000,"context_line":"            MIN_IGB_LIBVIRT_VERSION, MIN_IGB_QEMU_VERSION)"},{"line_number":13001,"context_line":"        if not igb_supported:"},{"line_number":13002,"context_line":"            supported_models \u003d ["},{"line_number":13003,"context_line":"                model for model in supported_models"},{"line_number":13004,"context_line":"                if model !\u003d network_model.VIF_MODEL_IGB]"},{"line_number":13005,"context_line":""},{"line_number":13006,"context_line":"        # construct the corresponding standard trait from the VIF model name"},{"line_number":13007,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":13,"id":"8782c7df_e9229b63","line":13004,"range":{"start_line":13001,"start_character":29,"end_line":13004,"end_character":56},"updated":"2024-10-17 01:35:47.000000000","message":"`supported_models.remove(network_model.VIF_MODEL_IGB)` may be simpler","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68c74d9a1fc01d26434c72004a8be0ef88c4ec1f","unresolved":true,"context_lines":[{"line_number":12998,"context_line":"        # remove version dependent vif models if we are on older libvirt/qemu"},{"line_number":12999,"context_line":"        igb_supported \u003d self._host.has_min_version("},{"line_number":13000,"context_line":"            MIN_IGB_LIBVIRT_VERSION, MIN_IGB_QEMU_VERSION)"},{"line_number":13001,"context_line":"        if not igb_supported:"},{"line_number":13002,"context_line":"            supported_models \u003d ["},{"line_number":13003,"context_line":"                model for model in supported_models"},{"line_number":13004,"context_line":"                if model !\u003d network_model.VIF_MODEL_IGB]"},{"line_number":13005,"context_line":""},{"line_number":13006,"context_line":"        # construct the corresponding standard trait from the VIF model name"},{"line_number":13007,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":13,"id":"c288c948_adec2a58","line":13004,"range":{"start_line":13001,"start_character":29,"end_line":13004,"end_character":56},"in_reply_to":"8782c7df_e9229b63","updated":"2024-10-24 11:14:47.000000000","message":"not all the virt type has igb listed. E.g for lxc and for parallels igb is not in the list as those virt type never support igb. Therefore the suggested remove call would raise a ValueError in those configuration.","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0251c0034826be126f7a309cd16b712c15df6ee1","unresolved":false,"context_lines":[{"line_number":12998,"context_line":"        # remove version dependent vif models if we are on older libvirt/qemu"},{"line_number":12999,"context_line":"        igb_supported \u003d self._host.has_min_version("},{"line_number":13000,"context_line":"            MIN_IGB_LIBVIRT_VERSION, MIN_IGB_QEMU_VERSION)"},{"line_number":13001,"context_line":"        if not igb_supported:"},{"line_number":13002,"context_line":"            supported_models \u003d ["},{"line_number":13003,"context_line":"                model for model in supported_models"},{"line_number":13004,"context_line":"                if model !\u003d network_model.VIF_MODEL_IGB]"},{"line_number":13005,"context_line":""},{"line_number":13006,"context_line":"        # construct the corresponding standard trait from the VIF model name"},{"line_number":13007,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":13,"id":"0d66dfb4_4b8ba34b","line":13004,"range":{"start_line":13001,"start_character":29,"end_line":13004,"end_character":56},"in_reply_to":"c288c948_adec2a58","updated":"2024-10-24 12:28:07.000000000","message":"Ah, ok. We can add a logic to handle missing IGB but that eventually complicates the logic so I\u0027m fine with the proposal.","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fe443503c22ad634e4212ed234dc0056cdde0ffd","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# Minimum versions supporting igb hw_vif_model"},{"line_number":264,"context_line":"MIN_IGB_LIBVIRT_VERSION \u003d (9, 3, 0)"},{"line_number":265,"context_line":"MIN_IGB_QEMU_VERSION \u003d (8, 0, 0)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"REGISTER_IMAGE_PROPERTY_DEFAULTS \u003d ["},{"line_number":268,"context_line":"    \u0027hw_machine_type\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"8bc663d3_12b6ed5b","line":265,"updated":"2024-10-29 10:37:14.000000000","message":"noted, fortunately we should bump the min version during this cycle","commit_id":"07295b0f9944d316bfe8de25ecd659ced506433b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85390320cf856695659b90bc46af00c8fb2cde21","unresolved":false,"context_lines":[{"line_number":13001,"context_line":"        if not igb_supported:"},{"line_number":13002,"context_line":"            supported_models \u003d ["},{"line_number":13003,"context_line":"                model for model in supported_models"},{"line_number":13004,"context_line":"                if model !\u003d network_model.VIF_MODEL_IGB]"},{"line_number":13005,"context_line":""},{"line_number":13006,"context_line":"        # construct the corresponding standard trait from the VIF model name"},{"line_number":13007,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":15,"id":"22824b2d_866da811","line":13004,"updated":"2024-10-25 17:09:59.000000000","message":"+1\nyou could also just set the bool to false to get the same effect","commit_id":"07295b0f9944d316bfe8de25ecd659ced506433b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"85390320cf856695659b90bc46af00c8fb2cde21","unresolved":false,"context_lines":[{"line_number":13007,"context_line":"        return {"},{"line_number":13008,"context_line":"            f\u0027COMPUTE_NET_VIF_MODEL_{model.replace(\"-\", \"_\").upper()}\u0027: model"},{"line_number":13009,"context_line":"            in supported_models for model in all_models"},{"line_number":13010,"context_line":"        }"},{"line_number":13011,"context_line":""},{"line_number":13012,"context_line":"    def _get_iommu_model_traits(self) -\u003e ty.Dict[str, bool]:"},{"line_number":13013,"context_line":"        \"\"\"Get iommu model traits based on the currently enabled virt_type."}],"source_content_type":"text/x-python","patch_set":15,"id":"938cd0f7_03e3c265","line":13010,"updated":"2024-10-25 17:09:59.000000000","message":"but that would require you to do the is supproted check when constrting the map which is less clean so im happy with the current approch","commit_id":"07295b0f9944d316bfe8de25ecd659ced506433b"}],"requirements.txt":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b05c790c7f58c55c25d73a3384d63ae9828cee5a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"oslo.versionedobjects\u003e\u003d1.35.0 # Apache-2.0"},{"line_number":53,"context_line":"os-brick\u003e\u003d6.0 # Apache-2.0"},{"line_number":54,"context_line":"os-resource-classes\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":55,"context_line":"os-traits\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":56,"context_line":"os-vif\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":57,"context_line":"castellan\u003e\u003d0.16.0 # Apache-2.0"},{"line_number":58,"context_line":"microversion-parse\u003e\u003d0.2.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":13,"id":"f70adcbb_6cba3fab","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":29},"updated":"2024-10-17 01:35:47.000000000","message":"Just for record.\n```\n$ git diff 3.1.0..3.2.0\ndiff --git a/os_traits/compute/net.py b/os_traits/compute/net.py\nindex 2792e5e..466785c 100644\n--- a/os_traits/compute/net.py\n+++ b/os_traits/compute/net.py\n@@ -35,4 +35,5 @@ TRAITS \u003d [\n     \u0027VIF_MODEL_VIRTIO\u0027,\n     \u0027VIF_MODEL_VMXNET\u0027,\n     \u0027VIF_MODEL_VMXNET3\u0027,\n+    \u0027VIF_MODEL_IGB\u0027,\n ]\n```","commit_id":"40d3355023065915bf8f27a64e64dc3e1890a951"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fe443503c22ad634e4212ed234dc0056cdde0ffd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"oslo.versionedobjects\u003e\u003d1.35.0 # Apache-2.0"},{"line_number":53,"context_line":"os-brick\u003e\u003d6.0 # Apache-2.0"},{"line_number":54,"context_line":"os-resource-classes\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":55,"context_line":"os-traits\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":56,"context_line":"os-vif\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":57,"context_line":"castellan\u003e\u003d0.16.0 # Apache-2.0"},{"line_number":58,"context_line":"microversion-parse\u003e\u003d0.2.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":15,"id":"ecd3dc93_fe2e422d","line":55,"updated":"2024-10-29 10:37:14.000000000","message":"lgtm, was released https://review.opendev.org/c/openstack/releases/+/930629","commit_id":"07295b0f9944d316bfe8de25ecd659ced506433b"}]}