)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d40a929210907b5efbd250e802876e495d08d89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0e2cf9d_af138f39","updated":"2024-09-09 12:05:22.000000000","message":"i kind of like this in general but you have an extra print","commit_id":"ee94881668eccc5be5c29ed3400b8e8c99a0e9e6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"38e87d0df1dba48ffb0bc9405de8323ad79679d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2f8f1ea0_1b5df33c","updated":"2024-10-15 07:06:57.000000000","message":"recheck \nhttps://zuul.opendev.org/t/openstack/build/ad738184842d46ec92f0920c992703b2/log/compute1/logs/screen-n-cpu.txt#8025\nso we reverted https://review.opendev.org/c/openstack/nova/+/932327","commit_id":"eb430dc20719175b046b4c3e887c5392eae1ded0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"33fdcaafbc2d46d93244bfe6e8f9b0efbf010a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f85abce_9381475f","updated":"2024-10-11 15:55:42.000000000","message":"recheck a bunch of post failures","commit_id":"eb430dc20719175b046b4c3e887c5392eae1ded0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"17ca4c1c9060aca1d6d74e52e771a28d2878797e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"054f6cc1_59ae0241","updated":"2024-10-14 11:46:48.000000000","message":"recheck bug/2084451","commit_id":"eb430dc20719175b046b4c3e887c5392eae1ded0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dda00fc3bfbe874ea549eac8aa8b6886c1c90388","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4bdd43c3_245623bc","updated":"2024-10-11 10:20:39.000000000","message":"recheck unrelated","commit_id":"eb430dc20719175b046b4c3e887c5392eae1ded0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0380679b0ad1a422448a2ee9fe91724f20885796","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9f1b1eb5_28248449","updated":"2024-10-16 14:00:18.000000000","message":"Thank you !","commit_id":"eb77ae3147dc4310c2cfef39b55a7261e3120ff6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"78bdb69f9da2b9365c3f0347480cfaa91a34fc0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b54b2f67_568e70cc","updated":"2024-10-29 09:31:31.000000000","message":"I\u0027m cool with only using the helper method just for the needed objects.","commit_id":"b36b7b3a66a0768e448655fd438a67bb667a7081"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a0cadb48238fed5c0126960257c3cd7001270731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e80566a1_853286c1","updated":"2024-10-25 12:56:29.000000000","message":"nice clean refactor ahead of the actual change. looks good to me","commit_id":"b36b7b3a66a0768e448655fd438a67bb667a7081"}],"nova/objects/base.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"19fe2c45004bacec4466a2fb2848c09c3ee9766b","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                   (field, value, version))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def raise_on_too_new_values(version, primitive, field, new_values):"},{"line_number":72,"context_line":"    value \u003d primitive.get(field, None)"},{"line_number":73,"context_line":"    if value in new_values:"},{"line_number":74,"context_line":"        raise exception.ObjectActionError("}],"source_content_type":"text/x-python","patch_set":6,"id":"c885c155_3f569406","line":71,"updated":"2024-10-15 15:26:31.000000000","message":"Because these two (values/value) are quite similar, I wonder if it makes sense to add only _values and always pass a tuple even only a single value is checked.","commit_id":"eb430dc20719175b046b4c3e887c5392eae1ded0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e86c6b4f57b8088cfaa68c11a8a4d86515ea64f3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                   (field, value, version))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def raise_on_too_new_values(version, primitive, field, new_values):"},{"line_number":72,"context_line":"    value \u003d primitive.get(field, None)"},{"line_number":73,"context_line":"    if value in new_values:"},{"line_number":74,"context_line":"        raise exception.ObjectActionError("}],"source_content_type":"text/x-python","patch_set":6,"id":"0ef4148d_4c96d34e","line":71,"in_reply_to":"c885c155_3f569406","updated":"2024-10-16 13:44:19.000000000","message":"Done","commit_id":"eb430dc20719175b046b4c3e887c5392eae1ded0"}],"nova/objects/image_meta.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"712e637a471e292059ccc571cfda9943aac2c8bb","unresolved":true,"context_lines":[{"line_number":237,"context_line":"            if policy \u003d\u003d fields.PCINUMAAffinityPolicy.SOCKET:"},{"line_number":238,"context_line":"                raise exception.ObjectActionError("},{"line_number":239,"context_line":"                    action\u003d\u0027obj_make_compatible\u0027,"},{"line_number":240,"context_line":"                    reason\u003d\u0027hw_numa_affinity_policy\u003d%s not supported \u0027"},{"line_number":241,"context_line":"                           \u0027in version %s\u0027 %"},{"line_number":242,"context_line":"                           (policy, target_version))"},{"line_number":243,"context_line":"        if target_version \u003c (1, 27):"}],"source_content_type":"text/x-python","patch_set":1,"id":"90bf5ada_db234547","side":"PARENT","line":240,"updated":"2024-09-09 10:18:47.000000000","message":"this was actually a bug in the exception message referring to hw_numa_affinity_policy instead of hw_pci_numa_affinity_policy","commit_id":"1ecab6dbc573fb0a60e35382269374193158b7f0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d40a929210907b5efbd250e802876e495d08d89","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            if policy \u003d\u003d fields.PCINUMAAffinityPolicy.SOCKET:"},{"line_number":238,"context_line":"                raise exception.ObjectActionError("},{"line_number":239,"context_line":"                    action\u003d\u0027obj_make_compatible\u0027,"},{"line_number":240,"context_line":"                    reason\u003d\u0027hw_numa_affinity_policy\u003d%s not supported \u0027"},{"line_number":241,"context_line":"                           \u0027in version %s\u0027 %"},{"line_number":242,"context_line":"                           (policy, target_version))"},{"line_number":243,"context_line":"        if target_version \u003c (1, 27):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4e3127fb_c633db96","side":"PARENT","line":240,"in_reply_to":"90bf5ada_db234547","updated":"2024-09-09 12:05:22.000000000","message":"Ack ya that was a bug","commit_id":"1ecab6dbc573fb0a60e35382269374193158b7f0"}],"nova/objects/pci_device.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d40a929210907b5efbd250e802876e495d08d89","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        if target_version \u003c (1, 6) and \u0027uuid\u0027 in primitive:"},{"line_number":138,"context_line":"            del primitive[\u0027uuid\u0027]"},{"line_number":139,"context_line":"        if target_version \u003c (1, 7) and \u0027dev_type\u0027 in primitive:"},{"line_number":140,"context_line":"            print(\"primitive\", primitive)"},{"line_number":141,"context_line":"            base.raise_on_too_new_value("},{"line_number":142,"context_line":"                target_version, primitive,"},{"line_number":143,"context_line":"                \u0027dev_type\u0027, fields.PciDeviceType.VDPA)"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b752cb9_8aa2feaa","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":2},"updated":"2024-09-09 12:05:22.000000000","message":"perhaps not print :) if you want to have a debug log here thats fine but im guessing this was ment to be removed","commit_id":"ee94881668eccc5be5c29ed3400b8e8c99a0e9e6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"843344a648cf03d5b9a31973b6f8d6ed36b01874","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        if target_version \u003c (1, 6) and \u0027uuid\u0027 in primitive:"},{"line_number":138,"context_line":"            del primitive[\u0027uuid\u0027]"},{"line_number":139,"context_line":"        if target_version \u003c (1, 7) and \u0027dev_type\u0027 in primitive:"},{"line_number":140,"context_line":"            print(\"primitive\", primitive)"},{"line_number":141,"context_line":"            base.raise_on_too_new_value("},{"line_number":142,"context_line":"                target_version, primitive,"},{"line_number":143,"context_line":"                \u0027dev_type\u0027, fields.PciDeviceType.VDPA)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d2eec2e_236b4fd5","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":2},"in_reply_to":"6b752cb9_8aa2feaa","updated":"2024-09-10 09:39:11.000000000","message":"Done","commit_id":"ee94881668eccc5be5c29ed3400b8e8c99a0e9e6"}]}