)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"696f97d7d663f2c6a729eb9eaf6e411d2897fd9a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-11 02:27:40 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"only saftey check bootable files created form glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for blank files that are created by nova such as swap"},{"line_number":10,"context_line":"disks and ephemeral disks we do not need need to saftey"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fe16868c_76129401","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":11},"updated":"2024-09-11 13:36:45.000000000","message":"nit: safety","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46ae6925a89e22d8bf2c9c4a71de56bcbd187d11","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-11 02:27:40 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"only saftey check bootable files created form glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for blank files that are created by nova such as swap"},{"line_number":10,"context_line":"disks and ephemeral disks we do not need need to saftey"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"69e6a316_2d783163","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":11},"in_reply_to":"d7b2f04d_c616fcd4","updated":"2024-09-11 18:50:41.000000000","message":"Done","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b31fa18c4cb1412cda28713cbcdfe7867d06a01f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-11 02:27:40 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"only saftey check bootable files created form glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for blank files that are created by nova such as swap"},{"line_number":10,"context_line":"disks and ephemeral disks we do not need need to saftey"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d7b2f04d_c616fcd4","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":11},"in_reply_to":"fe16868c_76129401","updated":"2024-09-11 14:16:35.000000000","message":"+1","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b31fa18c4cb1412cda28713cbcdfe7867d06a01f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"only saftey check bootable files created form glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for blank files that are created by nova such as swap"},{"line_number":10,"context_line":"disks and ephemeral disks we do not need need to saftey"},{"line_number":11,"context_line":"check them as they alwasy are just bare filesystems."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"in the future we should refactor the qcow imagebackend to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b87b3e82_145e035a","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":55},"updated":"2024-09-11 14:16:35.000000000","message":"safety","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46ae6925a89e22d8bf2c9c4a71de56bcbd187d11","unresolved":false,"context_lines":[{"line_number":7,"context_line":"only saftey check bootable files created form glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for blank files that are created by nova such as swap"},{"line_number":10,"context_line":"disks and ephemeral disks we do not need need to saftey"},{"line_number":11,"context_line":"check them as they alwasy are just bare filesystems."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"in the future we should refactor the qcow imagebackend to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"eead384d_8c6fd565","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":55},"in_reply_to":"b87b3e82_145e035a","updated":"2024-09-11 18:50:41.000000000","message":"Done","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b31fa18c4cb1412cda28713cbcdfe7867d06a01f","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for blank files that are created by nova such as swap"},{"line_number":10,"context_line":"disks and ephemeral disks we do not need need to saftey"},{"line_number":11,"context_line":"check them as they alwasy are just bare filesystems."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"in the future we should refactor the qcow imagebackend to"},{"line_number":14,"context_line":"not require backing files for swap and ephemeral disks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"54336d64_3bb12ce3","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":25},"updated":"2024-09-11 14:16:35.000000000","message":"always","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46ae6925a89e22d8bf2c9c4a71de56bcbd187d11","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"for blank files that are created by nova such as swap"},{"line_number":10,"context_line":"disks and ephemeral disks we do not need need to saftey"},{"line_number":11,"context_line":"check them as they alwasy are just bare filesystems."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"in the future we should refactor the qcow imagebackend to"},{"line_number":14,"context_line":"not require backing files for swap and ephemeral disks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b42e195b_e015bc37","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":25},"in_reply_to":"54336d64_3bb12ce3","updated":"2024-09-11 18:50:41.000000000","message":"Done","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b31fa18c4cb1412cda28713cbcdfe7867d06a01f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"in the future we should refactor the qcow imagebackend to"},{"line_number":14,"context_line":"not require backing files for swap and ephemeral disks"},{"line_number":15,"context_line":"but for now we simply disable the check to workaround"},{"line_number":16,"context_line":"the addtion of the gpt image inspector and the incompatiblity"},{"line_number":17,"context_line":"with vfat. future versions of oslo will account for vfat boot"},{"line_number":18,"context_line":"recored. this is a minimal patch to aovid needing a new oslo"},{"line_number":19,"context_line":"release for 2024.2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f10f7e2_33044039","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":11},"updated":"2024-09-11 14:16:35.000000000","message":"addition","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46ae6925a89e22d8bf2c9c4a71de56bcbd187d11","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in the future we should refactor the qcow imagebackend to"},{"line_number":14,"context_line":"not require backing files for swap and ephemeral disks"},{"line_number":15,"context_line":"but for now we simply disable the check to workaround"},{"line_number":16,"context_line":"the addtion of the gpt image inspector and the incompatiblity"},{"line_number":17,"context_line":"with vfat. future versions of oslo will account for vfat boot"},{"line_number":18,"context_line":"recored. this is a minimal patch to aovid needing a new oslo"},{"line_number":19,"context_line":"release for 2024.2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f4b3fd2f_52d2e5e8","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":11},"in_reply_to":"3f10f7e2_33044039","updated":"2024-09-11 18:50:41.000000000","message":"Done","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b03b265512a4b2fea3a9e5383a78b58ea32ff48","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For blank files that are created by nova such as swap"},{"line_number":10,"context_line":"disks and ephemeral disks we do not need need to safety"},{"line_number":11,"context_line":"check them as they always are just bare filesystems."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In the future we should refactor the qcow imagebackend to"},{"line_number":14,"context_line":"not require backing files for swap and ephemeral disks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0e208ec8_a4d8fcd8","line":11,"range":{"start_line":11,"start_character":20,"end_line":11,"end_character":52},"updated":"2024-09-12 16:38:14.000000000","message":"I know I\u0027m getting too pedantic with this stuff, but this is not why we don\u0027t need to check them. They\u0027re not bare filesystems in all cases (i.e. a filesystem in a flat file, but can be an empty filesystem in a qcow for example). They\u0027re safe because we created both halves and that they don\u0027t have any concerning backing/data file exploit stuff in them.\n\nI just keep pointing this out because in five years when someone tries to re-contextualize all this, we want to make sure we don\u0027t poison that context with incorrect information. Right now we have a good handle on all these details, but they will be easy to forget/confuse later.","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5ef401d176d24d1a5d530cf4c9b89214be83c9ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eea9f0ce_9db033f6","updated":"2024-09-11 15:21:44.000000000","message":"\u003e openstack-meta-content-provider https://softwarefactory-project.io/zuul/t/rdoproject.org/build/7d2dd6e02d564ef284e30314886da5d9 : SUCCESS in 1h 25m 16s\nnova-operator-tempest-multinode https://softwarefactory-project.io/zuul/t/rdoproject.org/build/ffc11952aa384e29931878a149b250f3 : FAILURE in 21m 34s\nnova-operator-tempest-multinode-ceph https://softwarefactory-project.io/zuul/t/rdoproject.org/build/aef9c5fdaca743e69bc43b0ab1fcb00e : FAILURE in 22m 47s\n\nBoth failure is due to the same missing build from the meta-content-provider so it is not related to this nova change itself.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"696f97d7d663f2c6a729eb9eaf6e411d2897fd9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d8fc376d_1aab3d47","updated":"2024-09-11 13:36:45.000000000","message":"Here, we make a clear assumption on the fact that non-bootable disks are only created by Nova as ephemerals, hence us skipping the check. I\u0027m fine with that assumption for now, given oslo will support the VFAT check shortly.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"f04588bbdf18b675fb45900d373930f7a7d07279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71f39839_f00c3476","updated":"2024-09-11 07:36:20.000000000","message":"LGTM. just a minor nit (typo) in comment.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b31fa18c4cb1412cda28713cbcdfe7867d06a01f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"418ddf6c_5a641290","updated":"2024-09-11 14:16:35.000000000","message":"Sorry I didn\u0027t get to review this yesterday...\n\nI\u0027m a bit concerned about the terminology of calling these safe because \"bootable or not\". It has nothing to do with it being bootable. It doesn\u0027t even have anything to do with it being the first disk and thus the \"boot disk\". It has to do with the source of the content being trusted, untrusted, or in this case \"created out of thin air.\" In addition to thinking it\u0027s incorrect for this trusted case, I\u0027d hate to see someone else come along and write more code that depends on the `bootable` flag to these functions, thinking it meant something real about bootability.\n\nAm I the only one with that concern?","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c890ed499d9983e00e9c88016ad3619d802214d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0228a602_924d98e4","updated":"2024-09-11 04:44:43.000000000","message":"check rdo experimental","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c94553561ae9c09d3e38583eeae3b8a022f768d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fda6be3b_0a551a9e","updated":"2024-09-11 15:22:28.000000000","message":"check rdo experimental","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8e9adc9f58690e5c086dce79ecbda42d6fb4ede","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7d132fa8_c8af5bdc","in_reply_to":"418ddf6c_5a641290","updated":"2024-09-11 14:55:15.000000000","message":"i choose bootable intentionally as i was hoping to use the same flag to contol if we carete backing files in the future for the qcow backend\n\ni.e. non bootable disks (ephmeral/swap) would in the future not have any backing files\n\nand only the bootable root disk would\n\ni could use a diffent name but that was why i choose that name for the flag.\n\ndo you have a prefernce for what to call it.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d0816d33992fd459d5358d4e5076bb563715344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dc40cc16_97ffb087","in_reply_to":"eea9f0ce_9db033f6","updated":"2024-09-11 19:05:21.000000000","message":"this might be becasue we dont have a depends on\n\nso we might need to tweak the job def to alwasy depend on the nova-operator to make it work properly.\n\nletts look into that speratly via https://review.opendev.org/c/openstack/nova/+/927762","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b03b265512a4b2fea3a9e5383a78b58ea32ff48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8257ec52_12886363","updated":"2024-09-12 16:38:14.000000000","message":"I think we need to be a little clearer with the code comments at least, but those things are able to be fixed later and we need to get this in for rc1. If there\u0027s a respin for some reason, I think tightening up these words would be good.","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"786776100ca9a7adfd716eca907e27cf0c2b3fb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4b957253_968d5d61","updated":"2024-09-17 16:13:54.000000000","message":"recheck osc 7.1.1 should now be available","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a087ef03aa0e2da82a853c071550fec14569dda3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"694f1319_0e15789a","updated":"2024-09-18 22:31:11.000000000","message":"recheck pin and dependent patch merged","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c8110d3d2814a90e43028afe946f8047eb13661","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a394245f_22ac0820","updated":"2024-09-19 01:03:10.000000000","message":"recheck unrelated volume attachment failure\n\n\"failed to attach volume c26d1561-5baf-4c27-9e84-6a851d8028fa to server 3ca17a6f-d6d8-4dd8-a197-ac423432fef6 within the required time\"","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"164d69083bb17bf816d0f57667949208ec4765fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7ec0afa3_9124db87","updated":"2024-09-12 00:51:04.000000000","message":"rehceck Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ff3d12c1eb5c471efd8c8d580201bfb0e7a381d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"203aa873_d32118a9","updated":"2024-09-12 16:58:32.000000000","message":"the fix makes sense to me.","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3c7efa3866254e886322e867491e868a8a31f4b","unresolved":true,"context_lines":[{"line_number":15062,"context_line":"                    \u0027qcow2\u0027,"},{"line_number":15063,"context_line":"                    disk_info_byname[\u0027disk.local\u0027][\u0027virt_disk_size\u0027],"},{"line_number":15064,"context_line":"                    backing_file\u003dephemeral_backing,"},{"line_number":15065,"context_line":"                    bootable\u003dFalse"},{"line_number":15066,"context_line":"                ),"},{"line_number":15067,"context_line":"            ])"},{"line_number":15068,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"46975ec8_806401f4","line":15065,"updated":"2024-09-10 19:03:50.000000000","message":"and here we have boot a root disk that is bootabel and an ephemeral disk that is not","commit_id":"858ab0536de4cd2233bc9c37b933b8aa4116b482"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"164d69083bb17bf816d0f57667949208ec4765fc","unresolved":false,"context_lines":[{"line_number":15062,"context_line":"                    \u0027qcow2\u0027,"},{"line_number":15063,"context_line":"                    disk_info_byname[\u0027disk.local\u0027][\u0027virt_disk_size\u0027],"},{"line_number":15064,"context_line":"                    backing_file\u003dephemeral_backing,"},{"line_number":15065,"context_line":"                    bootable\u003dFalse"},{"line_number":15066,"context_line":"                ),"},{"line_number":15067,"context_line":"            ])"},{"line_number":15068,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"08159589_39bef5c0","line":15065,"in_reply_to":"46975ec8_806401f4","updated":"2024-09-12 00:51:04.000000000","message":"Acknowledged","commit_id":"858ab0536de4cd2233bc9c37b933b8aa4116b482"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3c7efa3866254e886322e867491e868a8a31f4b","unresolved":true,"context_lines":[{"line_number":16630,"context_line":"        backend.disks[\u0027disk.swap\u0027].cache.assert_called_once_with("},{"line_number":16631,"context_line":"            fetch_func\u003dmock.ANY, filename\u003d\u0027swap_%i\u0027 % expected,"},{"line_number":16632,"context_line":"            size\u003dexpected * units.Mi, context\u003dself.context, swap_mb\u003dexpected,"},{"line_number":16633,"context_line":"            bootable\u003dFalse)"},{"line_number":16634,"context_line":""},{"line_number":16635,"context_line":"    @mock.patch.object(nova.virt.libvirt.imagebackend.Image, \u0027cache\u0027)"},{"line_number":16636,"context_line":"    def test_create_vz_container_with_swap(self, mock_cache):"}],"source_content_type":"text/x-python","patch_set":2,"id":"53a6aba2_6629a8cc","line":16633,"updated":"2024-09-10 19:03:50.000000000","message":"this is testing the swap code path.","commit_id":"858ab0536de4cd2233bc9c37b933b8aa4116b482"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"164d69083bb17bf816d0f57667949208ec4765fc","unresolved":false,"context_lines":[{"line_number":16630,"context_line":"        backend.disks[\u0027disk.swap\u0027].cache.assert_called_once_with("},{"line_number":16631,"context_line":"            fetch_func\u003dmock.ANY, filename\u003d\u0027swap_%i\u0027 % expected,"},{"line_number":16632,"context_line":"            size\u003dexpected * units.Mi, context\u003dself.context, swap_mb\u003dexpected,"},{"line_number":16633,"context_line":"            bootable\u003dFalse)"},{"line_number":16634,"context_line":""},{"line_number":16635,"context_line":"    @mock.patch.object(nova.virt.libvirt.imagebackend.Image, \u0027cache\u0027)"},{"line_number":16636,"context_line":"    def test_create_vz_container_with_swap(self, mock_cache):"}],"source_content_type":"text/x-python","patch_set":2,"id":"456925fe_2863fd79","line":16633,"in_reply_to":"53a6aba2_6629a8cc","updated":"2024-09-12 00:51:04.000000000","message":"Acknowledged","commit_id":"858ab0536de4cd2233bc9c37b933b8aa4116b482"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3c7efa3866254e886322e867491e868a8a31f4b","unresolved":true,"context_lines":[{"line_number":16715,"context_line":"        backend.disks[\u0027disk.eph0\u0027].cache.assert_called_once_with("},{"line_number":16716,"context_line":"            fetch_func\u003dmock.ANY, context\u003dself.context,"},{"line_number":16717,"context_line":"            filename\u003dfilename, size\u003d100 * units.Gi, ephemeral_size\u003dmock.ANY,"},{"line_number":16718,"context_line":"            specified_fs\u003dNone, bootable\u003dFalse)"},{"line_number":16719,"context_line":""},{"line_number":16720,"context_line":"    def test_create_image_resize_snap_backend(self):"},{"line_number":16721,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f50fa2d0_d1832ac4","line":16718,"updated":"2024-09-10 19:03:50.000000000","message":"and ephmeral disk code path","commit_id":"858ab0536de4cd2233bc9c37b933b8aa4116b482"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"164d69083bb17bf816d0f57667949208ec4765fc","unresolved":false,"context_lines":[{"line_number":16715,"context_line":"        backend.disks[\u0027disk.eph0\u0027].cache.assert_called_once_with("},{"line_number":16716,"context_line":"            fetch_func\u003dmock.ANY, context\u003dself.context,"},{"line_number":16717,"context_line":"            filename\u003dfilename, size\u003d100 * units.Gi, ephemeral_size\u003dmock.ANY,"},{"line_number":16718,"context_line":"            specified_fs\u003dNone, bootable\u003dFalse)"},{"line_number":16719,"context_line":""},{"line_number":16720,"context_line":"    def test_create_image_resize_snap_backend(self):"},{"line_number":16721,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d25853f2_f441fa73","line":16718,"in_reply_to":"f50fa2d0_d1832ac4","updated":"2024-09-12 00:51:04.000000000","message":"Acknowledged","commit_id":"858ab0536de4cd2233bc9c37b933b8aa4116b482"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"696f97d7d663f2c6a729eb9eaf6e411d2897fd9a","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        # downloaded the image."},{"line_number":688,"context_line":"        # NOTE(sean-k-mooney) If the base image is not bootable,"},{"line_number":689,"context_line":"        # it was created by nova as a swap or ephemeral disk so"},{"line_number":690,"context_line":"        # we don\u0027t need to check it"},{"line_number":691,"context_line":"        if not CONF.workarounds.disable_deep_image_inspection and bootable:"},{"line_number":692,"context_line":"            inspector \u003d format_inspector.detect_file_format(base)"},{"line_number":693,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"541b423f_d508e296","line":690,"updated":"2024-09-11 13:36:45.000000000","message":"that could be a risky assumption but I\u0027m fine having it for now until we have the new oslo version","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"164d69083bb17bf816d0f57667949208ec4765fc","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        # downloaded the image."},{"line_number":688,"context_line":"        # NOTE(sean-k-mooney) If the base image is not bootable,"},{"line_number":689,"context_line":"        # it was created by nova as a swap or ephemeral disk so"},{"line_number":690,"context_line":"        # we don\u0027t need to check it"},{"line_number":691,"context_line":"        if not CONF.workarounds.disable_deep_image_inspection and bootable:"},{"line_number":692,"context_line":"            inspector \u003d format_inspector.detect_file_format(base)"},{"line_number":693,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bb4e794e_f5aa3274","line":690,"in_reply_to":"541b423f_d508e296","updated":"2024-09-12 00:51:04.000000000","message":"it\u0027s not an assumption, the only places where bootable was set to false\nand where safe is now set to true are for cases where nova creates the file without user input for ephemeral disk and swap disks so we know those are always safe.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b03b265512a4b2fea3a9e5383a78b58ea32ff48","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        # downloaded the image."},{"line_number":688,"context_line":"        # NOTE(sean-k-mooney) If the base image is not bootable,"},{"line_number":689,"context_line":"        # it was created by nova as a swap or ephemeral disk so"},{"line_number":690,"context_line":"        # we don\u0027t need to check it"},{"line_number":691,"context_line":"        if not CONF.workarounds.disable_deep_image_inspection and bootable:"},{"line_number":692,"context_line":"            inspector \u003d format_inspector.detect_file_format(base)"},{"line_number":693,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"f28e7994_07fb46a9","line":690,"in_reply_to":"bb4e794e_f5aa3274","updated":"2024-09-12 16:38:14.000000000","message":"Yep.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b03b265512a4b2fea3a9e5383a78b58ea32ff48","unresolved":true,"context_lines":[{"line_number":276,"context_line":"        :fetch_func: Function that creates the base image"},{"line_number":277,"context_line":"                     Should accept `target` argument."},{"line_number":278,"context_line":"        :filename: Name of the file in the image directory"},{"line_number":279,"context_line":"        :size: Size of created image in bytes (optional)"},{"line_number":280,"context_line":"        \"\"\""},{"line_number":281,"context_line":"        base_dir \u003d os.path.join(CONF.instances_path,"},{"line_number":282,"context_line":"                                CONF.image_cache.subdirectory_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6295cc67_b22301f5","line":279,"updated":"2024-09-12 16:38:14.000000000","message":"docstring update?","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b31fa18c4cb1412cda28713cbcdfe7867d06a01f","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        # before we inspect it for other attributes. We do this each time"},{"line_number":160,"context_line":"        # because additional safety checks could have been added since we"},{"line_number":161,"context_line":"        # downloaded the image."},{"line_number":162,"context_line":"        # Note(sean-k-mooney): We only need to perform the safety check for"},{"line_number":163,"context_line":"        # the backing file if the image is bootable. backing files created"},{"line_number":164,"context_line":"        # for ephemeral disks are not bootable so we can skip the safety check"},{"line_number":165,"context_line":"        # as those are created by nova and are tursted."}],"source_content_type":"text/x-python","patch_set":4,"id":"b23bd5c4_9df6c0e7","line":162,"updated":"2024-09-11 14:16:35.000000000","message":"This might be misleading, as the safety check has nothing to do with actual bootable-ness. True, since you named the flag that, we only need to run the check if the `bootable` argument is `True`, but the naming of that combined with the first sentence of this explanation would probably lead someone to draw the wrong conclusion about when and why we need to do this.\n\nIMHO, the reason we don\u0027t need to run it on the ones we generate is because ... they\u0027re generated. I.e. they\u0027re trusted implicitly because we created them out of thin air. So `generated`, `trusted`, `safe`, `internal`, etc would be better words to use I think.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b03b265512a4b2fea3a9e5383a78b58ea32ff48","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        # before we inspect it for other attributes. We do this each time"},{"line_number":160,"context_line":"        # because additional safety checks could have been added since we"},{"line_number":161,"context_line":"        # downloaded the image."},{"line_number":162,"context_line":"        # Note(sean-k-mooney): We only need to perform the safety check for"},{"line_number":163,"context_line":"        # the backing file if the image is bootable. backing files created"},{"line_number":164,"context_line":"        # for ephemeral disks are not bootable so we can skip the safety check"},{"line_number":165,"context_line":"        # as those are created by nova and are tursted."}],"source_content_type":"text/x-python","patch_set":4,"id":"eb0133c4_1de02ee1","line":162,"in_reply_to":"0741e536_aa29a3a4","updated":"2024-09-12 16:38:14.000000000","message":"Acknowledged","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2cca5f2b191f876360b24e8552e2369e06212714","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        # before we inspect it for other attributes. We do this each time"},{"line_number":160,"context_line":"        # because additional safety checks could have been added since we"},{"line_number":161,"context_line":"        # downloaded the image."},{"line_number":162,"context_line":"        # Note(sean-k-mooney): We only need to perform the safety check for"},{"line_number":163,"context_line":"        # the backing file if the image is bootable. backing files created"},{"line_number":164,"context_line":"        # for ephemeral disks are not bootable so we can skip the safety check"},{"line_number":165,"context_line":"        # as those are created by nova and are tursted."}],"source_content_type":"text/x-python","patch_set":4,"id":"d10387d5_35947e2d","line":162,"in_reply_to":"3b0d6f3e_a6fcb1f7","updated":"2024-09-11 15:24:14.000000000","message":"Yep `safe` sounds good to me.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8e9adc9f58690e5c086dce79ecbda42d6fb4ede","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        # before we inspect it for other attributes. We do this each time"},{"line_number":160,"context_line":"        # because additional safety checks could have been added since we"},{"line_number":161,"context_line":"        # downloaded the image."},{"line_number":162,"context_line":"        # Note(sean-k-mooney): We only need to perform the safety check for"},{"line_number":163,"context_line":"        # the backing file if the image is bootable. backing files created"},{"line_number":164,"context_line":"        # for ephemeral disks are not bootable so we can skip the safety check"},{"line_number":165,"context_line":"        # as those are created by nova and are tursted."}],"source_content_type":"text/x-python","patch_set":4,"id":"3b0d6f3e_a6fcb1f7","line":162,"in_reply_to":"b23bd5c4_9df6c0e7","updated":"2024-09-11 14:55:15.000000000","message":"ah you have suggestions here\n\nsafe sound ok to me\n\nim less in clidned ot say trusted to avoid trust boot or tursted comptue implicatons\n\ni dont really have a read on internal vs generated.\n\n\nis there one name you would prefer.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46ae6925a89e22d8bf2c9c4a71de56bcbd187d11","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        # before we inspect it for other attributes. We do this each time"},{"line_number":160,"context_line":"        # because additional safety checks could have been added since we"},{"line_number":161,"context_line":"        # downloaded the image."},{"line_number":162,"context_line":"        # Note(sean-k-mooney): We only need to perform the safety check for"},{"line_number":163,"context_line":"        # the backing file if the image is bootable. backing files created"},{"line_number":164,"context_line":"        # for ephemeral disks are not bootable so we can skip the safety check"},{"line_number":165,"context_line":"        # as those are created by nova and are tursted."}],"source_content_type":"text/x-python","patch_set":4,"id":"0741e536_aa29a3a4","line":162,"in_reply_to":"d10387d5_35947e2d","updated":"2024-09-11 18:50:41.000000000","message":"i should have gone with unsafe :) i got all the way here after replacing all the usage of botable and realised that i neeed to go back and flip all the defaults  form True to False :) ill do that and update the tests to reflect that.\n\nhopefully i will have new version ready for review in the next 30 mins or so once i run the tests locally.\n\ni think i have just about finished all the inverting logic changes.","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"f04588bbdf18b675fb45900d373930f7a7d07279","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        # Note(sean-k-mooney): We only need to perform the safety check for"},{"line_number":163,"context_line":"        # the backing file if the image is bootable. backing files created"},{"line_number":164,"context_line":"        # for ephemeral disks are not bootable so we can skip the safety check"},{"line_number":165,"context_line":"        # as those are created by nova and are tursted."},{"line_number":166,"context_line":"        if not CONF.workarounds.disable_deep_image_inspection and bootable:"},{"line_number":167,"context_line":"            inspector \u003d format_inspector.detect_file_format(backing_file)"},{"line_number":168,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"58c3355b_ba0b8f1b","line":165,"range":{"start_line":165,"start_character":47,"end_line":165,"end_character":54},"updated":"2024-09-11 07:36:20.000000000","message":"s/tursted/trusted/","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46ae6925a89e22d8bf2c9c4a71de56bcbd187d11","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # Note(sean-k-mooney): We only need to perform the safety check for"},{"line_number":163,"context_line":"        # the backing file if the image is bootable. backing files created"},{"line_number":164,"context_line":"        # for ephemeral disks are not bootable so we can skip the safety check"},{"line_number":165,"context_line":"        # as those are created by nova and are tursted."},{"line_number":166,"context_line":"        if not CONF.workarounds.disable_deep_image_inspection and bootable:"},{"line_number":167,"context_line":"            inspector \u003d format_inspector.detect_file_format(backing_file)"},{"line_number":168,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"f19b3621_ae6b7aea","line":165,"range":{"start_line":165,"start_character":47,"end_line":165,"end_character":54},"in_reply_to":"58c3355b_ba0b8f1b","updated":"2024-09-11 18:50:41.000000000","message":"Acknowledged","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"696f97d7d663f2c6a729eb9eaf6e411d2897fd9a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        # the backing file if the image is bootable. backing files created"},{"line_number":164,"context_line":"        # for ephemeral disks are not bootable so we can skip the safety check"},{"line_number":165,"context_line":"        # as those are created by nova and are tursted."},{"line_number":166,"context_line":"        if not CONF.workarounds.disable_deep_image_inspection and bootable:"},{"line_number":167,"context_line":"            inspector \u003d format_inspector.detect_file_format(backing_file)"},{"line_number":168,"context_line":"            try:"},{"line_number":169,"context_line":"                inspector.safety_check()"}],"source_content_type":"text/x-python","patch_set":4,"id":"6193edff_1ca33d99","line":166,"updated":"2024-09-11 13:36:45.000000000","message":"same concern here but I\u0027m fine for 2024.2","commit_id":"36b86bdcf6cf40bb9064ec237f8becd0ecece07a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b03b265512a4b2fea3a9e5383a78b58ea32ff48","unresolved":true,"context_lines":[{"line_number":148,"context_line":"    :param backing_file: (Optional) Backing file to use."},{"line_number":149,"context_line":"    :param encryption: (Optional) Dict detailing various encryption attributes"},{"line_number":150,"context_line":"        such as the format and passphrase."},{"line_number":151,"context_line":"    :param safe: If True, the image is know to be safe."},{"line_number":152,"context_line":"    \"\"\""},{"line_number":153,"context_line":"    cmd \u003d ["},{"line_number":154,"context_line":"        \u0027env\u0027, \u0027LC_ALL\u003dC\u0027, \u0027LANG\u003dC\u0027, \u0027qemu-img\u0027, \u0027create\u0027, \u0027-f\u0027, disk_format"}],"source_content_type":"text/x-python","patch_set":5,"id":"bd3baffb_a4735099","line":151,"range":{"start_line":151,"start_character":39,"end_line":151,"end_character":43},"updated":"2024-09-12 16:38:14.000000000","message":"known\n\nBut also, this is actually \"the backing image is known to be safe\" right? Not critical to land for rc1 but we should probably try to get that corrected here.","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b03b265512a4b2fea3a9e5383a78b58ea32ff48","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        # because additional safety checks could have been added since we"},{"line_number":161,"context_line":"        # downloaded the image."},{"line_number":162,"context_line":"        # Note(sean-k-mooney): We only need to perform the safety check for"},{"line_number":163,"context_line":"        # the backing file if the image is not created by nova for swap or"},{"line_number":164,"context_line":"        # ephemeral disks."},{"line_number":165,"context_line":"        if not CONF.workarounds.disable_deep_image_inspection and not safe:"},{"line_number":166,"context_line":"            inspector \u003d format_inspector.detect_file_format(backing_file)"}],"source_content_type":"text/x-python","patch_set":5,"id":"d013330a_eee64b0d","line":163,"range":{"start_line":163,"start_character":30,"end_line":163,"end_character":39},"updated":"2024-09-12 16:38:14.000000000","message":"to be clear, this should be \"it (the backing file)\" not the image being created here (which is always created by nova)","commit_id":"8de15e9a276dc4261dd0656e26ca5a917825f441"}]}