)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"70833b5964d9e0c9e993ea0eeb7ccefccde11ede","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d354afe_de6fca73","updated":"2024-09-12 16:22:44.000000000","message":"couple of small things inline but the reproduce make sense to me.","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"115313d2490132e59480907a1bab69e6fc071fbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c2ab5da_08c5c628","updated":"2024-09-12 17:00:39.000000000","message":"ill push a new version shortly once i have the fix patch working \n\nin the mean time i have filed a bug to capture this\n\nhttps://bugs.launchpad.net/nova/+bug/2080556","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e12e92a06b8bda8078c6cb55ddd926e5e254978a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7005636d_4e084058","updated":"2024-09-12 13:03:13.000000000","message":"we need to wait for CI","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41fa8d1c2ad15d9f2c6bb9c203bb8fa17feae202","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7add5982_2b166b28","updated":"2024-09-19 05:11:54.000000000","message":"recheck\nsomething wrong with the cpu configuration but it has to be intermittent as the live-migration job run OK in the gate queue\n```\nSep 18 20:15:45.757072 np0038550844 nova-compute[85045]: ERROR nova.compute.manager nova.exception.Invalid: Invalid \u0027[compute] cpu_shared_set\u0027 config: one or more of the configured CPUs is not online. Online cpuset(s): [0, 1, 2, 3], configured cpuset(s): [0, 1, 2, 3, 4, 5]\n```","commit_id":"521db4a4353ac884252270cba226034e01062781"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ccf9c026736ebcc9b113994478b0b2a49a111dd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a109567d_a4e2a13c","updated":"2024-09-17 16:02:14.000000000","message":"recheck osc 7.1.1 bumped to uc","commit_id":"521db4a4353ac884252270cba226034e01062781"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cc961b9387139f19181036554bb0206e126dc9a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"226f4876_5c963a63","updated":"2024-09-18 17:40:00.000000000","message":"recheck osc pin landed in uc","commit_id":"521db4a4353ac884252270cba226034e01062781"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2086b7557ddc3fe45e6150581562a9ed05d1563f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e63347e8_b4cd4248","updated":"2024-09-19 08:31:08.000000000","message":"recheck storage issues in the ceph job","commit_id":"521db4a4353ac884252270cba226034e01062781"}],"nova/objects/instance_numa.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"70833b5964d9e0c9e993ea0eeb7ccefccde11ede","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        # unpinned CPUs only, with pinned CPUs tracked via \u0027pcpuset\u0027 instead."},{"line_number":59,"context_line":"        # For a backward compatibility, move the \u0027dedicated\u0027 instance CPU list"},{"line_number":60,"context_line":"        # from \u0027pcpuset\u0027 to \u0027cpuset\u0027."},{"line_number":61,"context_line":"        if target_version \u003c (1, 5):"},{"line_number":62,"context_line":"            if (primitive[\u0027cpu_policy\u0027] \u003d\u003d"},{"line_number":63,"context_line":"                    obj_fields.CPUAllocationPolicy.DEDICATED):"},{"line_number":64,"context_line":"                primitive[\u0027cpuset\u0027] \u003d primitive[\u0027pcpuset\u0027]"},{"line_number":65,"context_line":"            primitive.pop(\u0027pcpuset\u0027, None)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if target_version \u003c (1, 4):"},{"line_number":68,"context_line":"            primitive.pop(\u0027cpuset_reserved\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cba7f3ce_59c4b1a9","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":42},"updated":"2024-09-12 16:22:44.000000000","message":"I suggest to log a warning here as this might be the source of the VMs with wrong DB content that has no pcpuset defined in the table.","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1fe16dfbd78356c03f2ee70edf5b5de8d9e47c0f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # unpinned CPUs only, with pinned CPUs tracked via \u0027pcpuset\u0027 instead."},{"line_number":59,"context_line":"        # For a backward compatibility, move the \u0027dedicated\u0027 instance CPU list"},{"line_number":60,"context_line":"        # from \u0027pcpuset\u0027 to \u0027cpuset\u0027."},{"line_number":61,"context_line":"        if target_version \u003c (1, 5):"},{"line_number":62,"context_line":"            if (primitive[\u0027cpu_policy\u0027] \u003d\u003d"},{"line_number":63,"context_line":"                    obj_fields.CPUAllocationPolicy.DEDICATED):"},{"line_number":64,"context_line":"                primitive[\u0027cpuset\u0027] \u003d primitive[\u0027pcpuset\u0027]"},{"line_number":65,"context_line":"            primitive.pop(\u0027pcpuset\u0027, None)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if target_version \u003c (1, 4):"},{"line_number":68,"context_line":"            primitive.pop(\u0027cpuset_reserved\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c725c123_29ce9f75","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":42},"in_reply_to":"ba3e54ee_83379e5c","updated":"2024-09-13 10:27:50.000000000","message":"Done here https://review.opendev.org/c/openstack/nova/+/929187/1/nova/objects/instance_numa.py#69","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a389e7978fa9b4fe315b5a30973dc0e3980f6e32","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # unpinned CPUs only, with pinned CPUs tracked via \u0027pcpuset\u0027 instead."},{"line_number":59,"context_line":"        # For a backward compatibility, move the \u0027dedicated\u0027 instance CPU list"},{"line_number":60,"context_line":"        # from \u0027pcpuset\u0027 to \u0027cpuset\u0027."},{"line_number":61,"context_line":"        if target_version \u003c (1, 5):"},{"line_number":62,"context_line":"            if (primitive[\u0027cpu_policy\u0027] \u003d\u003d"},{"line_number":63,"context_line":"                    obj_fields.CPUAllocationPolicy.DEDICATED):"},{"line_number":64,"context_line":"                primitive[\u0027cpuset\u0027] \u003d primitive[\u0027pcpuset\u0027]"},{"line_number":65,"context_line":"            primitive.pop(\u0027pcpuset\u0027, None)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if target_version \u003c (1, 4):"},{"line_number":68,"context_line":"            primitive.pop(\u0027cpuset_reserved\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a66ba3c_c3342353","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":42},"in_reply_to":"ba3e54ee_83379e5c","updated":"2024-09-13 07:55:32.000000000","message":"There was ideas that the back leveling happened due to a conductor running old version of the code. But maybe that was another bug where the pcpuset was not filled with the cpuset for pinned instances.\n\nAnyhow this is not a big deal. I\u0027m OK with the patch either way.","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"115313d2490132e59480907a1bab69e6fc071fbb","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        # unpinned CPUs only, with pinned CPUs tracked via \u0027pcpuset\u0027 instead."},{"line_number":59,"context_line":"        # For a backward compatibility, move the \u0027dedicated\u0027 instance CPU list"},{"line_number":60,"context_line":"        # from \u0027pcpuset\u0027 to \u0027cpuset\u0027."},{"line_number":61,"context_line":"        if target_version \u003c (1, 5):"},{"line_number":62,"context_line":"            if (primitive[\u0027cpu_policy\u0027] \u003d\u003d"},{"line_number":63,"context_line":"                    obj_fields.CPUAllocationPolicy.DEDICATED):"},{"line_number":64,"context_line":"                primitive[\u0027cpuset\u0027] \u003d primitive[\u0027pcpuset\u0027]"},{"line_number":65,"context_line":"            primitive.pop(\u0027pcpuset\u0027, None)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if target_version \u003c (1, 4):"},{"line_number":68,"context_line":"            primitive.pop(\u0027cpuset_reserved\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3e54ee_83379e5c","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":42},"in_reply_to":"cba7f3ce_59c4b1a9","updated":"2024-09-12 17:00:39.000000000","message":"so the source as I understand it is that we didn\u0027t have a migration path before for floating instances with a numa topology.\n\nso these were just v1.4 numa topologies that were in the db when we add the field in 1.5\n\nI can add a warning but we should not be back levelling to \u003c1.5 since Victoria however I\u0027ll add one just in case. ill put that in the actual fix patch","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e12e92a06b8bda8078c6cb55ddd926e5e254978a","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                # to an empty set here"},{"line_number":199,"context_line":"                # if not \u0027pcpuset\u0027 in cell:"},{"line_number":200,"context_line":"                #     cell.pcpuset \u003d set()"},{"line_number":201,"context_line":"                #     update_db \u003d True"},{"line_number":202,"context_line":"                continue"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            cell.pcpuset \u003d cell.cpuset"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c7cbac7_3ecdf84f","line":201,"updated":"2024-09-12 13:03:13.000000000","message":"right, that\u0027s what\u0027s missing in case of an upgrade","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"182cad276cc1f4279e90f4f15261da8656cb7c27","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                # to an empty set here"},{"line_number":199,"context_line":"                # if not \u0027pcpuset\u0027 in cell:"},{"line_number":200,"context_line":"                #     cell.pcpuset \u003d set()"},{"line_number":201,"context_line":"                #     update_db \u003d True"},{"line_number":202,"context_line":"                continue"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            cell.pcpuset \u003d cell.cpuset"}],"source_content_type":"text/x-python","patch_set":1,"id":"bcd8f018_11162946","line":201,"in_reply_to":"024697a3_faab6507","updated":"2024-09-12 19:41:45.000000000","message":"note ill just do this in the actual fix patch.","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"70833b5964d9e0c9e993ea0eeb7ccefccde11ede","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                # to an empty set here"},{"line_number":199,"context_line":"                # if not \u0027pcpuset\u0027 in cell:"},{"line_number":200,"context_line":"                #     cell.pcpuset \u003d set()"},{"line_number":201,"context_line":"                #     update_db \u003d True"},{"line_number":202,"context_line":"                continue"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            cell.pcpuset \u003d cell.cpuset"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfea16fb_063d839f","line":201,"in_reply_to":"2c7cbac7_3ecdf84f","updated":"2024-09-12 16:22:44.000000000","message":"probably I structure the code like:\n```\nif cpu_policy \u003d\u003d dedicated:\n    # do what we do today\nelse:\n    # add the new logic for initing pcpuset\n```","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1fe16dfbd78356c03f2ee70edf5b5de8d9e47c0f","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                # to an empty set here"},{"line_number":199,"context_line":"                # if not \u0027pcpuset\u0027 in cell:"},{"line_number":200,"context_line":"                #     cell.pcpuset \u003d set()"},{"line_number":201,"context_line":"                #     update_db \u003d True"},{"line_number":202,"context_line":"                continue"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            cell.pcpuset \u003d cell.cpuset"}],"source_content_type":"text/x-python","patch_set":1,"id":"a53135bd_a756627c","line":201,"in_reply_to":"bcd8f018_11162946","updated":"2024-09-13 10:27:50.000000000","message":"Done https://review.opendev.org/c/openstack/nova/+/929187/1/nova/objects/instance_numa.py#204","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a389e7978fa9b4fe315b5a30973dc0e3980f6e32","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                # to an empty set here"},{"line_number":199,"context_line":"                # if not \u0027pcpuset\u0027 in cell:"},{"line_number":200,"context_line":"                #     cell.pcpuset \u003d set()"},{"line_number":201,"context_line":"                #     update_db \u003d True"},{"line_number":202,"context_line":"                continue"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            cell.pcpuset \u003d cell.cpuset"}],"source_content_type":"text/x-python","patch_set":1,"id":"12feb387_1f91040e","line":201,"in_reply_to":"bcd8f018_11162946","updated":"2024-09-13 07:55:32.000000000","message":"sure.","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"115313d2490132e59480907a1bab69e6fc071fbb","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                # to an empty set here"},{"line_number":199,"context_line":"                # if not \u0027pcpuset\u0027 in cell:"},{"line_number":200,"context_line":"                #     cell.pcpuset \u003d set()"},{"line_number":201,"context_line":"                #     update_db \u003d True"},{"line_number":202,"context_line":"                continue"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            cell.pcpuset \u003d cell.cpuset"}],"source_content_type":"text/x-python","patch_set":1,"id":"024697a3_faab6507","line":201,"in_reply_to":"dfea16fb_063d839f","updated":"2024-09-12 17:00:39.000000000","message":"ya i was wondering if i should invert the condtion checking ill do this refactor.","commit_id":"7b4bb7b21c3d52552c83b8d5fa3f1e55e6d7e0e3"}]}