)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"61920777b378494e98880a163cb027da3dc8cdc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4dc0fae_95c38379","updated":"2024-09-13 07:54:49.000000000","message":"I have a nit and the question but nothing serious.","commit_id":"c52aa2f1d37b3e0b3d0c40f17b5d98a2eaaabbec"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d71b5023899b18884a20cc6ff68a167eabfc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"09da724c_83042522","updated":"2024-09-13 10:29:09.000000000","message":"this need a recheck once the osc issue is resleoved but ill respin for the nit whic will reuntings anyway so not recheckign for now.","commit_id":"c52aa2f1d37b3e0b3d0c40f17b5d98a2eaaabbec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a4c3c240ed68adc58416463868eba7f00447a4b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ef2f58b_130538a4","updated":"2024-09-16 07:27:42.000000000","message":"recheck","commit_id":"2a870323c3d44d2056b326c184c435a484513532"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9330952112861edea92034698a66e91d38442f6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"afa999fb_56adca1a","updated":"2024-09-17 16:01:59.000000000","message":"recheck osc 7.1.1 bumped to u-c","commit_id":"2a870323c3d44d2056b326c184c435a484513532"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"522310d39b8cc0f3f88710840b62057f4a38146e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4281e8f8_53c670c2","updated":"2024-09-19 08:01:06.000000000","message":"recheck osc pinned to 6.x","commit_id":"2a870323c3d44d2056b326c184c435a484513532"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aaca1aac55c8270cd7c8114116535a595c6879b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"218316e8_3baadb3e","updated":"2024-09-16 10:03:34.000000000","message":"still fails with:\n```\n+ /opt/stack/nova/roles/run-evacuate-hook/files/test_negative_evacuate.sh:evacuate_and_wait_for_error:19 :   openstack --os-compute-api-version 2.67 server evacuate --host np0038513271 evacuate-test\ncompute version 2.67 is not in supported versions: 2, 2.1\nProxy.evacuate_server() got an unexpected keyword argument \u0027password\u0027\n```\neven though the client patch was merged.","commit_id":"2a870323c3d44d2056b326c184c435a484513532"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b5198b2531bc5a4a6388156f9f4fae787f1e154f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f0bd5670_9c8ef425","in_reply_to":"218316e8_3baadb3e","updated":"2024-09-16 11:50:02.000000000","message":"ya we need a release.\n\ntalking to stephen compute version 2.67 is not in supported versions: 2, 2.1 is likely a readheaing and an olde message that should be removed form the client.\n\n\nProxy.evacuate_server() got an unexpected keyword argument \u0027password\u0027\n\nis the issue and since that is still happening that indecates teh job does not have the clinet as a requried project hence lib_from_git is not actully pulling in the expected version.\n\ni have not confirmed that yet but that our working theory\n\nhttps://review.opendev.org/c/openstack/releases/+/929454 shoudl reoslve the issue once merged","commit_id":"2a870323c3d44d2056b326c184c435a484513532"}],"nova/objects/instance_numa.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"61920777b378494e98880a163cb027da3dc8cdc2","unresolved":true,"context_lines":[{"line_number":70,"context_line":"                f\u0027Downgrading InstanceNUMACell to version {target_version} \u0027"},{"line_number":71,"context_line":"                f\u0027may cause the loss of pinned CPUs if mixing different \u0027"},{"line_number":72,"context_line":"                f\u0027verisons of nova on different hosts. This should not \u0027"},{"line_number":73,"context_line":"                f\u0027happen on any supported after Victoria.\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if target_version \u003c (1, 4):"},{"line_number":76,"context_line":"            primitive.pop(\u0027cpuset_reserved\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"49848d59_f260f627","line":73,"updated":"2024-09-13 07:54:49.000000000","message":"nit: on any supported version after Victoria","commit_id":"c52aa2f1d37b3e0b3d0c40f17b5d98a2eaaabbec"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d71b5023899b18884a20cc6ff68a167eabfc7","unresolved":true,"context_lines":[{"line_number":70,"context_line":"                f\u0027Downgrading InstanceNUMACell to version {target_version} \u0027"},{"line_number":71,"context_line":"                f\u0027may cause the loss of pinned CPUs if mixing different \u0027"},{"line_number":72,"context_line":"                f\u0027verisons of nova on different hosts. This should not \u0027"},{"line_number":73,"context_line":"                f\u0027happen on any supported after Victoria.\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if target_version \u003c (1, 4):"},{"line_number":76,"context_line":"            primitive.pop(\u0027cpuset_reserved\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c61032fa_e1b439e2","line":73,"in_reply_to":"49848d59_f260f627","updated":"2024-09-13 10:29:09.000000000","message":"ah yep i can fix this.","commit_id":"c52aa2f1d37b3e0b3d0c40f17b5d98a2eaaabbec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"60cb57f082e6cc3281784bd1a0c5c227d779b706","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                f\u0027Downgrading InstanceNUMACell to version {target_version} \u0027"},{"line_number":71,"context_line":"                f\u0027may cause the loss of pinned CPUs if mixing different \u0027"},{"line_number":72,"context_line":"                f\u0027verisons of nova on different hosts. This should not \u0027"},{"line_number":73,"context_line":"                f\u0027happen on any supported after Victoria.\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if target_version \u003c (1, 4):"},{"line_number":76,"context_line":"            primitive.pop(\u0027cpuset_reserved\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6d085794_3415f0fb","line":73,"in_reply_to":"c61032fa_e1b439e2","updated":"2024-09-16 07:26:59.000000000","message":"Acknowledged","commit_id":"c52aa2f1d37b3e0b3d0c40f17b5d98a2eaaabbec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"61920777b378494e98880a163cb027da3dc8cdc2","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                cell.cpuset \u003d set()"},{"line_number":207,"context_line":"                update_db \u003d True"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                if \u0027pcpuset\u0027 not in cell:"},{"line_number":210,"context_line":"                    cell.pcpuset \u003d set()"},{"line_number":211,"context_line":"                    update_db \u003d True"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d84f559f_0f1506fe","line":209,"updated":"2024-09-13 07:54:49.000000000","message":"why we guard it? Is it to preserver mixed instances with both shared and pinned CPUs? If so then I would check for the cpu_policy instead as a guard. I know that we saw this issue appearing when pcpuset was not in the json blob in the DB. But I can imagine a similar failure mode when the field was there but the value would be json null.","commit_id":"c52aa2f1d37b3e0b3d0c40f17b5d98a2eaaabbec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"60cb57f082e6cc3281784bd1a0c5c227d779b706","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                cell.cpuset \u003d set()"},{"line_number":207,"context_line":"                update_db \u003d True"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                if \u0027pcpuset\u0027 not in cell:"},{"line_number":210,"context_line":"                    cell.pcpuset \u003d set()"},{"line_number":211,"context_line":"                    update_db \u003d True"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"00801cab_1728b15b","line":209,"in_reply_to":"03700176_877d4fab","updated":"2024-09-16 07:26:59.000000000","message":"yeah make sense. I guess this is safer this way.","commit_id":"c52aa2f1d37b3e0b3d0c40f17b5d98a2eaaabbec"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1a0a1968094b4e07da8f44a25e7cc8497d256a2f","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                cell.cpuset \u003d set()"},{"line_number":207,"context_line":"                update_db \u003d True"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                if \u0027pcpuset\u0027 not in cell:"},{"line_number":210,"context_line":"                    cell.pcpuset \u003d set()"},{"line_number":211,"context_line":"                    update_db \u003d True"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"03700176_877d4fab","line":209,"in_reply_to":"d84f559f_0f1506fe","updated":"2024-09-13 10:25:45.000000000","message":"the way this function is invoked today its called on already upgrade objects\n\nso if the pcpusset is there we do not wnat to modify it.\n\nif the object has already been upgraded and pcpuset is present we do not want to update it again in the db, that the main reason for this guard to only update the db if we change the object.","commit_id":"c52aa2f1d37b3e0b3d0c40f17b5d98a2eaaabbec"}]}