)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e1052152735dca7de21134743f537094054c36fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06112b94_ba9c9ed3","updated":"2024-09-16 12:11:19.000000000","message":"This feels scary to me to be carried upstream while most of us are not using nix. Could nix allows these files to be sourced outside of the source tree?","commit_id":"f02f46a20c31512de37abdaf9a3018aa6220aa2b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5ad221a47c9c5119e85b167b7e059a2b706700de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"666ef8d1_0b515084","in_reply_to":"06112b94_ba9c9ed3","updated":"2024-09-16 12:36:46.000000000","message":"yep i can keep this in a diffent git repo.\n\ni was mostly experimenting with this as a way of providing a quick, repoducable dev env but i have not had much luck getting complicaiton form source working so im proably going to just pause that experiment. until i have more time.\n\n\ni may expore other approches like providign a dockerfile or similar.\n\nbasically i wanted to see if i could provide a way to not depend on what your host os is to eaislly run all our tests.\n\nthis works but not as well as i woudl like so i dont think im going to prusue this in tree untill i have a better feel for this and how useful it is out of tree.","commit_id":"f02f46a20c31512de37abdaf9a3018aa6220aa2b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cf308c5c69458e566d22f68178ed3db5cbf4bf22","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8fe1dda4_c56282f5","in_reply_to":"666ef8d1_0b515084","updated":"2024-09-16 12:48:10.000000000","message":"by the way the way this works is you clone nova\ncd to it and run ```nix develop``` and your dropped into a shell with all the deps ready.\n\ntox has also recentlly ish added a devenv command\n\nhttps://tox.wiki/en/legacy/example/devenv.html\n\nits not quite the same in that you need to ensure you have python installed your self but its similar.\n\nas i said in my last comment i also want to exploure contaienr such as the devcontiaaner \"standard\"\n\n\nthat might be better for new contibnutors using vscode for example\n\neffectivly i wanted to provide a way for new contibutors and old to very quickly get a reasonabel envionment to work on nova bugs (anything doable with tox really) \n\n\ni have never used nix flakes before so this was also jsut a learning exersise for me to see what they look like.\n\ni think im going to pivot to a devcontaienr as my next experiment add see what that looks like.\n\ni currently use either a devstack vm or a https://distrobox.it/ container to create older dev envs as needed but that a much higher learnign curve for someone new.\n\nnix flakes because they end up compileing the python in this speciric case ended up being slower then i was hoping for so while it works its not delivering on the ux i hopped for.","commit_id":"f02f46a20c31512de37abdaf9a3018aa6220aa2b"}],"flake.nix":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"27a8c232f72a4d2ede6c05c6886ab174ff4952da","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        default \u003d mkPythonShell pkgs pkgs.python312;"},{"line_number":72,"context_line":"        # pillow does not compile properly on 3.12"},{"line_number":73,"context_line":"        # due to missing headers for jpeg. so the docs"},{"line_number":74,"context_line":"        # target does not work when a wheel can\u0027t be pulled"},{"line_number":75,"context_line":"        python312 \u003d mkPythonShell pkgs pkgs.python312;"},{"line_number":76,"context_line":"        python311 \u003d mkPythonShell pkgs pkgs.python311;"},{"line_number":77,"context_line":"        python310 \u003d mkPythonShell pkgs pkgs.python310;"}],"source_content_type":"text/x-nix","patch_set":5,"id":"a554029d_6216fd2d","line":74,"updated":"2024-09-15 12:33:07.000000000","message":"so this will actully be fixed when the change to uc is merged to allow pillow 10.4.0\n\nhttps://review.opendev.org/c/openstack/requirements/+/927102","commit_id":"f02f46a20c31512de37abdaf9a3018aa6220aa2b"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"27a8c232f72a4d2ede6c05c6886ab174ff4952da","unresolved":true,"context_lines":[{"line_number":53,"context_line":"  PYTHONOPTIMIZE"},{"line_number":54,"context_line":"  # there is also secret magic in subunit-trace which lets you run in a fail only"},{"line_number":55,"context_line":"  # mode. To do this define the TRACE_FAILONLY environmental variable."},{"line_number":56,"context_line":"  TRACE_FAILONLY"},{"line_number":57,"context_line":"commands \u003d"},{"line_number":58,"context_line":"  stestr run {posargs}"},{"line_number":59,"context_line":"  env TEST_OSPROFILER\u003d1 stestr run --combine --no-discover \u0027nova.tests.unit.test_profiler\u0027"}],"source_content_type":"text/x-properties","patch_set":5,"id":"a2b7f14e_18cb74c4","line":56,"updated":"2024-09-15 12:33:07.000000000","message":"we lost TRACE_FAILONLY at some point so im restoring it and fixed the indentation while im here.","commit_id":"f02f46a20c31512de37abdaf9a3018aa6220aa2b"}]}