)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0acb9808a4c2fb36be2aab14d8ca42d1eb754963","unresolved":true,"context_lines":[{"line_number":38,"context_line":"active). However, in the meantime we need to be truthful about the"},{"line_number":39,"context_line":"lie we\u0027re making, by correctly identifying the format of the zero-"},{"line_number":40,"context_line":"length data we\u0027re not uploading."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Change-Id: I6a6184da3b73506261c61005b6984c69cdc7fb98"},{"line_number":43,"context_line":"1: https://github.com/openstack/nova/commit/c3476b5ca7ab5237d3cb8a84fcb7a3292237b764"},{"line_number":44,"context_line":"2: https://bugs.launchpad.net/nova/+bug/1034730"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9c5af17b_f3070be3","line":41,"updated":"2024-09-27 21:39:01.000000000","message":"This says \"Fix $thing\" but there\u0027s no Closes-Bug here, so it\u0027s a bit confusing. Is something actively currently broken or is this a preemptive change to prevent future breakage? I\u0027m guessing it\u0027s the latter.","commit_id":"27c9cc1744021e46f30ed60761b4e903b9091d48"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6c87e713867b294f61b0a5ecbc458f31c97210b7","unresolved":true,"context_lines":[{"line_number":38,"context_line":"active). However, in the meantime we need to be truthful about the"},{"line_number":39,"context_line":"lie we\u0027re making, by correctly identifying the format of the zero-"},{"line_number":40,"context_line":"length data we\u0027re not uploading."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Change-Id: I6a6184da3b73506261c61005b6984c69cdc7fb98"},{"line_number":43,"context_line":"1: https://github.com/openstack/nova/commit/c3476b5ca7ab5237d3cb8a84fcb7a3292237b764"},{"line_number":44,"context_line":"2: https://bugs.launchpad.net/nova/+bug/1034730"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f3266aa1_46d5167e","line":41,"in_reply_to":"69c26f14_12b7cd9e","updated":"2024-09-27 22:42:11.000000000","message":"Yeah, I wasn\u0027t sure if this fix meant that volume-backed snapshot is currently broken and we lack Tempest testing of it. But then I thought it\u0027s unlikely we don\u0027t have Tempest testing of volume-backed snapshot, so it\u0027s probably not currently broken. \"Now, with glance moving to image format safety\" gives the hint that in the future this wrong format sending will become a hard fail for volume-backed snapshots.\n\nIf something isn\u0027t currently broken or failing or prevented from working, then I don\u0027t think filing a bug is necessary.","commit_id":"27c9cc1744021e46f30ed60761b4e903b9091d48"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1eb7cb1f6a10fcb27275b4c71c0abc724dcdf16c","unresolved":true,"context_lines":[{"line_number":38,"context_line":"active). However, in the meantime we need to be truthful about the"},{"line_number":39,"context_line":"lie we\u0027re making, by correctly identifying the format of the zero-"},{"line_number":40,"context_line":"length data we\u0027re not uploading."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Change-Id: I6a6184da3b73506261c61005b6984c69cdc7fb98"},{"line_number":43,"context_line":"1: https://github.com/openstack/nova/commit/c3476b5ca7ab5237d3cb8a84fcb7a3292237b764"},{"line_number":44,"context_line":"2: https://bugs.launchpad.net/nova/+bug/1034730"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"69c26f14_12b7cd9e","line":41,"in_reply_to":"9c5af17b_f3070be3","updated":"2024-09-27 21:58:49.000000000","message":"Well, I think it\u0027s wrong by definition because we\u0027re uploading non-qcow2 data and saying it\u0027s qcow2. Glance is not currently complaining, but it causes the stream format inspector to complain. I found this because I\u0027m working on this:\n\nhttps://review.opendev.org/c/openstack/glance-specs/+/925111\n\nWhere glance stops being a pushover about the content you give it. So I could file a bug where I explain why it\u0027s wrong and why it might matter in the future if you want. However, maybe I could just add something to the commit message (and change the git topic to match the glance implementation) about it being needed for that effort?","commit_id":"27c9cc1744021e46f30ed60761b4e903b9091d48"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6b326f5d311ed48face72e09969b7d10a963f81a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix image format error on vol-backed snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Long ago, it was decided that we should create an empty image in"},{"line_number":10,"context_line":"glance for snapshots of volume-backed instances[1]. I\u0027m not really sure"},{"line_number":11,"context_line":"why that is, since it doesn\u0027t seem to be a useful construct to do"},{"line_number":12,"context_line":"anything with (like a normal snapshot, which can be used to boot)."},{"line_number":13,"context_line":"It was so long ago that it was not documented well[2].  However, when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba90c8f4_d6a28767","line":10,"updated":"2024-10-01 17:01:13.000000000","message":"I should add that it was done this way to fix a very old and irrelevant behavior in n-cpu where we were calling qemu-img and needed a uuid, which we didn\u0027t have unless/until we created a glance image in order to have one. We don\u0027t even snapshot with `qemu-img snapshot` anymore and I think the right thing to have done back then is not even call that code in the BFV case. Now, for BFV, we don\u0027t even do the snapshotting on the compute node at all, so it\u0027s even less relevant today.","commit_id":"e28f90866b08285de088aabdde1c71bb0e1d6418"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"09fbd87bc0677c8bbfc3c53ab47bdf8c852bc690","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68b92bd7_54960082","updated":"2024-09-27 19:48:37.000000000","message":"recheck doesn\u0027t look related","commit_id":"27c9cc1744021e46f30ed60761b4e903b9091d48"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f66b68b23e4ccf6cf602f906f06b3e653b64ee33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc996527_00b6ef8b","updated":"2024-09-30 19:01:11.000000000","message":"Looks good to me. We will need this when Glance stops accepting image uploads that do not match the image format claimed in the metadata.","commit_id":"e28f90866b08285de088aabdde1c71bb0e1d6418"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"40439e04a2c73c0f31ffa0c85e5ffae0ae96060e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6444c4e4_607c0899","updated":"2024-10-08 16:49:50.000000000","message":"Thanks, I got more understanding from the discussion we had in the nova meeting today and I definitely agree with your point : a 0-byte upload should always be raw, but long-term we should even remove that.","commit_id":"e28f90866b08285de088aabdde1c71bb0e1d6418"}]}