)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b280c2976105c21b2dd61d17a9da18eade808abf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53f6de0f_26a237ef","updated":"2024-10-07 00:43:47.000000000","message":"recheck post failure","commit_id":"335b12107faed922c0fa2fd03e7efc2b8e934057"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4d296370e1f155eb56df191c7433a204dafc4b6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f0e62d2e_98d484eb","updated":"2024-10-15 17:01:31.000000000","message":"recheck irrelevant server creation failure...","commit_id":"204c064e8bb6604f81c9364635eb34d853153a25"}],"nova/compute/utils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8e2a0970345e92e0dd2c396d7fe54be9cf40952e","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"    :returns: list of Strings of ip addresses"},{"line_number":1042,"context_line":"    \"\"\""},{"line_number":1043,"context_line":"    addresses \u003d []"},{"line_number":1044,"context_line":"    for interface, ifaddresses in psutil.net_if_addrs().items():"},{"line_number":1045,"context_line":"        for ifaddress in ifaddresses:"},{"line_number":1046,"context_line":"            if ifaddress.family not in (socket.AF_INET, socket.AF_INET6):"},{"line_number":1047,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"e2ed19bd_964ef623","line":1044,"range":{"start_line":1044,"start_character":41,"end_line":1044,"end_character":53},"updated":"2024-10-15 13:44:47.000000000","message":"OK It turned out this specific interface is also supported in Windows OS then we should not require removing Windows OS really.","commit_id":"37168367c5fc1690d8c31917994a8e1d723ac5ec"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9b28f161d01a53915ae4fbdcd944ba94828c243c","unresolved":true,"context_lines":[{"line_number":1053,"context_line":"            if ifaddress.family \u003d\u003d socket.AF_INET6:"},{"line_number":1054,"context_line":"                addr \u003d addr.split(\u0027%\u0027)[0]"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"            addresses.append(addr)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    return addresses"},{"line_number":1059,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bd30b0af_1b412008","line":1056,"updated":"2024-11-14 20:43:25.000000000","message":"i guess this is fine\n\nthis si not one of the funtions that was moved to oslo.utils is it?\n\ni spoke to stephen at somepoint about movign this there sicne there are other services that do the same.","commit_id":"37168367c5fc1690d8c31917994a8e1d723ac5ec"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"810c29b0b5163822966060f478f9a5eeb44af556","unresolved":true,"context_lines":[{"line_number":1053,"context_line":"            if ifaddress.family \u003d\u003d socket.AF_INET6:"},{"line_number":1054,"context_line":"                addr \u003d addr.split(\u0027%\u0027)[0]"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"            addresses.append(addr)"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    return addresses"},{"line_number":1059,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ce7101ee_909f8ee5","line":1056,"in_reply_to":"bd30b0af_1b412008","updated":"2024-11-15 01:49:10.000000000","message":"We don\u0027t yet have the equivalent function in oslo.utils. All we currently have returns only the first IP. I\u0027ve checked the other projects but none currently maintains the logic to get all available IPs.\n\nThe only thing we can use from netutils is the method to trim IPv6 address scope but it introduces redundant ip version check so I\u0027ll leave it out of the scope of this change, now.","commit_id":"37168367c5fc1690d8c31917994a8e1d723ac5ec"}],"nova/tests/fixtures/nova.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bef10735ff3751b97c43642a8fcbacaf7ec8e25f","unresolved":true,"context_lines":[{"line_number":1716,"context_line":"        ("},{"line_number":1717,"context_line":"            \u0027psutil.net_if_addrs\u0027,"},{"line_number":1718,"context_line":"            \u0027tests should not be inspecting real interfaces on the test node\u0027,"},{"line_number":1719,"context_line":"        ),"},{"line_number":1720,"context_line":"        ("},{"line_number":1721,"context_line":"            \u0027os.uname\u0027,"},{"line_number":1722,"context_line":"            \u0027tests should not be inspecting host information on the test node\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b32b402a_c343bb99","line":1719,"updated":"2024-11-20 14:39:39.000000000","message":"+1 for adding that to the poison fixture","commit_id":"37168367c5fc1690d8c31917994a8e1d723ac5ec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"52cbf46a4af0c7cee724529b9dc56200a097f270","unresolved":true,"context_lines":[{"line_number":1664,"context_line":"            service_description.ServiceDescription, \u0027_make_proxy\u0027,"},{"line_number":1665,"context_line":"            fake_make_proxy))"},{"line_number":1666,"context_line":"        self.useFixture(fixtures.MockPatchObject("},{"line_number":1667,"context_line":"            _utils, \u0027localhost_supports_ipv6\u0027, return_value\u003dFalse))"},{"line_number":1668,"context_line":""},{"line_number":1669,"context_line":""},{"line_number":1670,"context_line":"class HostNameWeigher(weights.BaseHostWeigher):"}],"source_content_type":"text/x-python","patch_set":8,"id":"f1fecd62_5651e438","line":1667,"updated":"2025-02-14 11:12:42.000000000","message":"uhh that is ugly that we need to reach into the internals of the sdk. But the commit message explains it. The poison below is hit by the sdk\u0027s code. We definitely don\u0027t want our testing to depend on the sdk reading some host level config. So mocking this is necessary. If we encounter a lot of these later then we should consider changing the poison to a fake instead. But it is good now as is.","commit_id":"46435daf5c18af61f8dfaa19859ba863408f5d33"}],"nova/tests/unit/compute/test_utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bef10735ff3751b97c43642a8fcbacaf7ec8e25f","unresolved":true,"context_lines":[{"line_number":1156,"context_line":"                          self._test_event_reporter_graceful_exit, error)"},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":"    @mock.patch(\u0027netifaces.interfaces\u0027)"},{"line_number":1159,"context_line":"    def test_get_machine_ips_value_error(self, mock_interfaces):"},{"line_number":1160,"context_line":"        # Tests that the utility method does not explode if netifaces raises"},{"line_number":1161,"context_line":"        # a ValueError."},{"line_number":1162,"context_line":"        iface \u003d mock.sentinel"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d7d9ce3_3aaa9037","side":"PARENT","line":1159,"range":{"start_line":1159,"start_character":0,"end_line":1159,"end_character":2},"updated":"2024-11-20 14:39:39.000000000","message":"so we discussed the removal of this a littel on irc.\n\nThis was the only test coverign this function which mean that there was an existign test coverage gap for the ipv6 scope striping code.\n\ngiven this it is technially a latent issue im leaning towards sayign that we shoudl not block on this but adding new test coverage in a followup woudl be welcome.","commit_id":"754014b7b2a612620f85d6073adf6b71b20f7347"}]}