)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2f0cb1a6f36c3e7d2a30ba5dd08554f6f6fa9b29","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-15 13:45:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove Windows OS Support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since Hyper-V driver was removed, we don\u0027t expect any use case where"},{"line_number":10,"context_line":"nova should be deployed in Windows OS. This scenario is no longer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f0065d1c_bfa30fb1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":25},"updated":"2024-10-15 17:04:37.000000000","message":"As Windows support was already removed in 2024.1, we can change this line as \u0027Cleanup for the windows support removals\u0027","commit_id":"d46aae11cbd2f572c7e49b7745528aaf11f34ac0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1031b255be0d5b07c5ad4ae650fa06bc2dc6c163","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-15 13:45:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove Windows OS Support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since Hyper-V driver was removed, we don\u0027t expect any use case where"},{"line_number":10,"context_line":"nova should be deployed in Windows OS. This scenario is no longer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2ccc18ca_0ee254ca","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":25},"in_reply_to":"813cfbd5_bafc07c4","updated":"2024-10-15 17:09:27.000000000","message":"Done","commit_id":"d46aae11cbd2f572c7e49b7745528aaf11f34ac0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"520341246f3ec276fab7b2fef0db2796905c1934","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-15 13:45:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove Windows OS Support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since Hyper-V driver was removed, we don\u0027t expect any use case where"},{"line_number":10,"context_line":"nova should be deployed in Windows OS. This scenario is no longer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"813cfbd5_bafc07c4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":25},"in_reply_to":"f0065d1c_bfa30fb1","updated":"2024-10-15 17:07:26.000000000","message":"IIUC hyper-v driver was removed but it was not declared at that time that nova can no longer run in Windows OS. But I\u0027m ok to adjust the wordings if this sounds confusing.","commit_id":"d46aae11cbd2f572c7e49b7745528aaf11f34ac0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2f0cb1a6f36c3e7d2a30ba5dd08554f6f6fa9b29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"700db8dd_2d2011a2","updated":"2024-10-15 17:04:37.000000000","message":"cleanup lgtm but not sure we need releasenotes here as that can be confusing.","commit_id":"d46aae11cbd2f572c7e49b7745528aaf11f34ac0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d88c4034af30dd23928564994f3f35b7099e0db5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d5d83f0f_cfa534bb","updated":"2024-10-15 17:16:05.000000000","message":"thanks. lgtm.","commit_id":"72e60b5a28520849ba9f1e508c2d55379faf4b3f"}],"nova/monkey_patch.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"23d935280cb9d57e4a4ce86fb4d0c3a04eb40dc8","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    elif os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":48,"context_line":"        # for nova-compute running on Windows(Hyper-v)"},{"line_number":49,"context_line":"        # pipes don\u0027t support non-blocking I/O"},{"line_number":50,"context_line":"        eventlet.monkey_patch(os\u003dFalse)"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        eventlet.monkey_patch()"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b68d7d7b_306cc04c","side":"PARENT","line":50,"updated":"2024-11-14 20:41:09.000000000","message":"+1 i removed this in my eventlet removal poc too as part of droping the debugger so im fine with proceeding with this seperatatly as part of the widnows removal cleanup","commit_id":"37076155e6248ec6824ffbe4e26ffcd44994cd70"}],"nova/tests/fixtures/nova.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"23d935280cb9d57e4a4ce86fb4d0c3a04eb40dc8","unresolved":true,"context_lines":[{"line_number":1094,"context_line":"            # The libvirt driver uses modules that are not available"},{"line_number":1095,"context_line":"            # on Windows."},{"line_number":1096,"context_line":"            if os.name !\u003d \u0027nt\u0027:"},{"line_number":1097,"context_line":"                raise"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    def _poison_libvirt_driver(self):"},{"line_number":1100,"context_line":"        # The nova libvirt driver starts an event thread which only"}],"source_content_type":"text/x-python","patch_set":5,"id":"137b7afe_c8ab2e79","side":"PARENT","line":1097,"updated":"2024-11-14 20:41:09.000000000","message":"hum i guess that is ok\n\nthis is slightly diffent then the monkeypatch change as this is purly for testign but im ok to drop this too.","commit_id":"37076155e6248ec6824ffbe4e26ffcd44994cd70"}],"nova/tests/unit/virt/disk/test_inject.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"23d935280cb9d57e4a4ce86fb4d0c3a04eb40dc8","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        self.assertFalse(diskapi.inject_data("},{"line_number":59,"context_line":"            imgmodel.LocalFileImage(\"/some/file\", imgmodel.FORMAT_RAW),"},{"line_number":60,"context_line":"            admin_password\u003d\"p\"))"},{"line_number":61,"context_line":"        os.name \u003d os_name"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.assertFalse(diskapi.inject_data("},{"line_number":64,"context_line":"            imgmodel.LocalFileImage(\"/some/fail/file\", imgmodel.FORMAT_RAW),"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b04f504_e02ea7fb","side":"PARENT","line":61,"updated":"2024-11-14 20:41:09.000000000","message":"ok so this was testing password injection on a Windows and presumably hyperv host.\n\ni guess this si ok too.","commit_id":"37076155e6248ec6824ffbe4e26ffcd44994cd70"}],"nova/virt/disk/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"23d935280cb9d57e4a4ce86fb4d0c3a04eb40dc8","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import crypt"},{"line_number":27,"context_line":"import os"},{"line_number":28,"context_line":"import random"},{"line_number":29,"context_line":"import tempfile"}],"source_content_type":"text/x-python","patch_set":5,"id":"375bc820_61e4cea8","line":26,"updated":"2024-11-14 20:41:09.000000000","message":"so this dep will also have to be remvoed when we add py313 support but for now this is ok to pull out.","commit_id":"72e60b5a28520849ba9f1e508c2d55379faf4b3f"}],"releasenotes/notes/remove-windows-support-678ab5bb68896d43.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2f0cb1a6f36c3e7d2a30ba5dd08554f6f6fa9b29","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Running nova in Windows operating systems is no longer supported."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5506ff14_6b2e4fce","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":69},"updated":"2024-10-15 17:04:37.000000000","message":"I do not think we need to have this release notes as it can create more confusion about windows was supported before this.  We already stopped windows support when we removed the hyper-V driver in 2024.1.","commit_id":"d46aae11cbd2f572c7e49b7745528aaf11f34ac0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1031b255be0d5b07c5ad4ae650fa06bc2dc6c163","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Running nova in Windows operating systems is no longer supported."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"86b5df1e_114b213c","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":69},"in_reply_to":"5506ff14_6b2e4fce","updated":"2024-10-15 17:09:27.000000000","message":"Done","commit_id":"d46aae11cbd2f572c7e49b7745528aaf11f34ac0"}]}