)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"16a1198a353f45bcc8ae63721eff057444898aac","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            LOG.debug(\"Hypervisor: no assignable PCI devices\")"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _report_final_resource_view(self, resources):"},{"line_number":427,"context_line":"        \"\"\"Report final calculate of free memory, disk, CPUs, and PCI devices,"},{"line_number":428,"context_line":"        including instance calculations and in-progress resource claims. These"},{"line_number":429,"context_line":"        values will be exposed via the compute node table to the scheduler."},{"line_number":430,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_def1afce","line":427,"updated":"2014-05-12 11:26:26.000000000","message":"I think this method description needs updating now as well?","commit_id":"2fe1b3a8af67f164557ac376223de92e236b9656"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"16a1198a353f45bcc8ae63721eff057444898aac","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"},{"line_number":438,"context_line":"        if vcpus:"},{"line_number":439,"context_line":"            LOG.audit(_(\"Total usable vcpus: %(tcpu)s, used vcpus: %(ucpu)s\"),"},{"line_number":440,"context_line":"                        {\u0027tcpu\u0027: vcpus, \u0027ucpu\u0027: resources[\u0027vcpus_used\u0027]})"},{"line_number":441,"context_line":"        else:"},{"line_number":442,"context_line":"            LOG.audit(_(\"Free VCPU information unavailable\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_feecabf5","line":439,"updated":"2014-05-12 11:26:26.000000000","message":"I think you\u0027re hitting the max 80 character pep8 limit here","commit_id":"2fe1b3a8af67f164557ac376223de92e236b9656"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6eda212747066c22760171ac057cc33a0bfc35d2","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        including instance calculations and in-progress resource claims. These"},{"line_number":427,"context_line":"        values will be exposed via the compute node table to the scheduler."},{"line_number":428,"context_line":"        \"\"\""},{"line_number":429,"context_line":"        LOG.audit(_(\"Free ram (MB): %s\") % resources[\u0027free_ram_mb\u0027])"},{"line_number":430,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_4bcdb05c","side":"PARENT","line":429,"updated":"2014-07-03 07:56:17.000000000","message":"Why are you removing it ? Knowing overcommitment status in logs is good IMHO.\nIf you consider that you miss some info, add it but I don\u0027t think it\u0027s good removing something.\n\nAlso, there is possibly some DocImpact here for operators. Maybe this change would have required a spec...","commit_id":"1addb632bea3c0b974ea10deb5f939247f732fe4"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"5b86c2d6afc7e5ffeead215b689a71846f2716d1","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        including instance calculations and in-progress resource claims. These"},{"line_number":427,"context_line":"        values will be exposed via the compute node table to the scheduler."},{"line_number":428,"context_line":"        \"\"\""},{"line_number":429,"context_line":"        LOG.audit(_(\"Free ram (MB): %s\") % resources[\u0027free_ram_mb\u0027])"},{"line_number":430,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_6eae0287","side":"PARENT","line":429,"in_reply_to":"baada198_4bcdb05c","updated":"2014-07-03 08:20:52.000000000","message":"ok, thanks \nlet me think about it \nand could you please let me know any criteria that we need a bp or not? Thanks a lot","commit_id":"1addb632bea3c0b974ea10deb5f939247f732fe4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0f6001240d28ea6a72250575d2d4d0166cdaf30b","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        including instance calculations and in-progress resource claims. These"},{"line_number":427,"context_line":"        values will be exposed via the compute node table to the scheduler."},{"line_number":428,"context_line":"        \"\"\""},{"line_number":429,"context_line":"        LOG.audit(_(\"Free ram (MB): %s\") % resources[\u0027free_ram_mb\u0027])"},{"line_number":430,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_a419198a","side":"PARENT","line":429,"in_reply_to":"baada198_6eae0287","updated":"2014-07-03 09:29:15.000000000","message":"There is no specific rule of thumb for creating a spec. That said, we can consider a spec if the change is impacting operators, hence my proposal.\n\nI saw you opened a thread for that, it\u0027s worth a try to update it by giving a status, nope ?","commit_id":"1addb632bea3c0b974ea10deb5f939247f732fe4"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c1b695b4d590639d898de4b85934988f162b7e0b","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        including instance calculations and in-progress resource claims. These"},{"line_number":427,"context_line":"        values will be exposed via the compute node table to the scheduler."},{"line_number":428,"context_line":"        \"\"\""},{"line_number":429,"context_line":"        LOG.audit(_(\"Free ram (MB): %s\") % resources[\u0027free_ram_mb\u0027])"},{"line_number":430,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_968f9222","side":"PARENT","line":429,"in_reply_to":"baada198_a419198a","updated":"2014-07-28 04:27:10.000000000","message":"I did send mail again but no response\nso I will re-submit this patch and get more opinion\n\nthanks a lot for your comments","commit_id":"1addb632bea3c0b974ea10deb5f939247f732fe4"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"7f55f8dec651ae7f822619052c574cbc38255d15","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                    {\u0027pram\u0027: resources[\u0027memory_mb\u0027],"},{"line_number":433,"context_line":"                     \u0027vram\u0027: resources[\u0027memory_mb_used\u0027]})"},{"line_number":434,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"},{"line_number":437,"context_line":"        if vcpus:"},{"line_number":438,"context_line":"            LOG.audit(_(\"Total usable vcpus: %(tcpu)s, used vcpus: %(ucpu)s\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_40101400","line":435,"updated":"2014-07-24 21:15:17.000000000","message":"Overcommitment is possible with hard disk space as well. Could you express this as well? That being said, I like the general direction of this patch as the current  message makes it seem like the tracking is innacurate.","commit_id":"158e86185bdb8367a2bdc850c61fe6b76d10ae18"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c1b695b4d590639d898de4b85934988f162b7e0b","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                    {\u0027pram\u0027: resources[\u0027memory_mb\u0027],"},{"line_number":433,"context_line":"                     \u0027vram\u0027: resources[\u0027memory_mb_used\u0027]})"},{"line_number":434,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"},{"line_number":437,"context_line":"        if vcpus:"},{"line_number":438,"context_line":"            LOG.audit(_(\"Total usable vcpus: %(tcpu)s, used vcpus: %(ucpu)s\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_d6958a32","line":435,"in_reply_to":"baada198_40101400","updated":"2014-07-28 04:27:10.000000000","message":"I think it can be a candidate but I guess another patch will be better\n\nI plan to focus on memory/cpu first ,thanks for suggestions","commit_id":"158e86185bdb8367a2bdc850c61fe6b76d10ae18"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"419d7f9877d72d1034eb86bcc04f6a84ddce1ff6","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        LOG.audit(_(\"Total physical ram (MB): %(pram)s, \""},{"line_number":431,"context_line":"                    \"used overcommitted virtual ram (MB): %(vram)s\"),"},{"line_number":432,"context_line":"                    {\u0027pram\u0027: resources[\u0027memory_mb\u0027],"},{"line_number":433,"context_line":"                     \u0027vram\u0027: resources[\u0027memory_mb_used\u0027]})"},{"line_number":434,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0c1855cc","line":433,"updated":"2014-07-30 21:15:44.000000000","message":"I think this is more confusing than the current message. For example, if you have 1024 MB of physical ram, but only 256 in use, the audit log will say\n\n\"Total physical RAM (MB): 1024, used overcommited virtual ram (MB): 256\"\n\nThis makes it seem like there\u0027s 256 MB of overcommited memory when in fact there\u0027s actually 768 free. There\u0027s no overcommitment happening. I propose that the log should be\n\n\"Total physical RAM (MB): %(pram)s, total requested virtual RAM (MB): %(vram), total overcommitted RAM %(oram)\"\n\nWhere oram is \u003e\u003d 0 when pram \u003e\u003d vram, otherwise oram \u003d vram - pram","commit_id":"a8b220d7a41acff25646c8e3674035ac7060e184"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"111abd2c10bec7655f513a1afd87c140f2648477","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        LOG.audit(_(\"Total physical ram (MB): %(pram)s, \""},{"line_number":431,"context_line":"                    \"used overcommitted virtual ram (MB): %(vram)s\"),"},{"line_number":432,"context_line":"                    {\u0027pram\u0027: resources[\u0027memory_mb\u0027],"},{"line_number":433,"context_line":"                     \u0027vram\u0027: resources[\u0027memory_mb_used\u0027]})"},{"line_number":434,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ba72c60f","line":433,"in_reply_to":"baada198_04cba5a4","updated":"2014-08-04 03:06:39.000000000","message":"I feel we don\u0027t need to tell overcommitted ram because we tell the physical mem and virtual mem, so they can calculate the overcommitted memory and , \nvirtual mem/physical mem rate is something that operator should pay attention, I think current log is fine ...\n\nthoughts? thanks a lot","commit_id":"a8b220d7a41acff25646c8e3674035ac7060e184"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"adc09ebf89f8e6e0df35f0220cfb7585ab329fac","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        LOG.audit(_(\"Total physical ram (MB): %(pram)s, \""},{"line_number":431,"context_line":"                    \"used overcommitted virtual ram (MB): %(vram)s\"),"},{"line_number":432,"context_line":"                    {\u0027pram\u0027: resources[\u0027memory_mb\u0027],"},{"line_number":433,"context_line":"                     \u0027vram\u0027: resources[\u0027memory_mb_used\u0027]})"},{"line_number":434,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_04cba5a4","line":433,"in_reply_to":"baada198_0c1855cc","updated":"2014-07-31 18:36:55.000000000","message":"I apologize, I mean that oram should be 0 when pram \u003e\u003d vram","commit_id":"a8b220d7a41acff25646c8e3674035ac7060e184"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"32835154355673c9646d45f828488d80932afa93","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        LOG.audit(_(\"Total physical ram (MB): %(pram)s, \""},{"line_number":431,"context_line":"                    \"used overcommitted virtual ram (MB): %(vram)s\"),"},{"line_number":432,"context_line":"                    {\u0027pram\u0027: resources[\u0027memory_mb\u0027],"},{"line_number":433,"context_line":"                     \u0027vram\u0027: resources[\u0027memory_mb_used\u0027]})"},{"line_number":434,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_333ecd29","line":433,"in_reply_to":"baada198_ba72c60f","updated":"2014-08-04 14:13:13.000000000","message":"That is very true. I would suggest then that it should just be \"used\" rather than \"used overcomitted\". Always printing \"overcommitted\" may confuse the user.","commit_id":"a8b220d7a41acff25646c8e3674035ac7060e184"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"16e33654e4315a0c6f5589391037bed915579091","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        values will be exposed via the compute node table to the scheduler."},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        LOG.audit(_(\"Total physical ram (MB): %(pram)s, \""},{"line_number":432,"context_line":"                    \"total virtual ram (MB): %(vram)s\"),"},{"line_number":433,"context_line":"                    {\u0027pram\u0027: resources[\u0027memory_mb\u0027],"},{"line_number":434,"context_line":"                     \u0027vram\u0027: resources[\u0027memory_mb_used\u0027]})"},{"line_number":435,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_f5aef62d","line":432,"updated":"2014-08-04 16:12:45.000000000","message":"Taking comments from patchset #5, I would vote for \n\"Total allocated virtual RAM (MB): %(vram)s\"","commit_id":"ff64dbb401da0da2fdf97ae4a1df62e7711a3dae"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a13c0ea35b6f6e2b2b61161e727c48be2b73961a","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        values will be exposed via the compute node table to the scheduler."},{"line_number":430,"context_line":"        \"\"\""},{"line_number":431,"context_line":"        LOG.audit(_(\"Total physical ram (MB): %(pram)s, \""},{"line_number":432,"context_line":"                    \"total virtual ram (MB): %(vram)s\"),"},{"line_number":433,"context_line":"                    {\u0027pram\u0027: resources[\u0027memory_mb\u0027],"},{"line_number":434,"context_line":"                     \u0027vram\u0027: resources[\u0027memory_mb_used\u0027]})"},{"line_number":435,"context_line":"        LOG.audit(_(\"Free disk (GB): %s\") % resources[\u0027free_disk_gb\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_53f08865","line":432,"in_reply_to":"baada198_f5aef62d","updated":"2014-08-05 03:43:38.000000000","message":"make sense to me ,thanks","commit_id":"ff64dbb401da0da2fdf97ae4a1df62e7711a3dae"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"16e33654e4315a0c6f5589391037bed915579091","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"},{"line_number":438,"context_line":"        if vcpus:"},{"line_number":439,"context_line":"            LOG.audit(_(\"Total usable vcpus: %(tcpu)s, \""},{"line_number":440,"context_line":"                        \"used overcommitted vcpus: %(ucpu)s\"),"},{"line_number":441,"context_line":"                        {\u0027tcpu\u0027: vcpus, \u0027ucpu\u0027: resources[\u0027vcpus_used\u0027]})"},{"line_number":442,"context_line":"        else:"},{"line_number":443,"context_line":"            LOG.audit(_(\"Free VCPU information unavailable\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_b53f1ede","line":440,"updated":"2014-08-04 16:12:45.000000000","message":"Ditto L432 :\n\"Total allocated VCPUs: %(acpu)s","commit_id":"ff64dbb401da0da2fdf97ae4a1df62e7711a3dae"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a13c0ea35b6f6e2b2b61161e727c48be2b73961a","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        vcpus \u003d resources[\u0027vcpus\u0027]"},{"line_number":438,"context_line":"        if vcpus:"},{"line_number":439,"context_line":"            LOG.audit(_(\"Total usable vcpus: %(tcpu)s, \""},{"line_number":440,"context_line":"                        \"used overcommitted vcpus: %(ucpu)s\"),"},{"line_number":441,"context_line":"                        {\u0027tcpu\u0027: vcpus, \u0027ucpu\u0027: resources[\u0027vcpus_used\u0027]})"},{"line_number":442,"context_line":"        else:"},{"line_number":443,"context_line":"            LOG.audit(_(\"Free VCPU information unavailable\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_73e3cc9f","line":440,"in_reply_to":"baada198_b53f1ede","updated":"2014-08-05 03:43:38.000000000","message":"Done","commit_id":"ff64dbb401da0da2fdf97ae4a1df62e7711a3dae"}]}