)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0638c1471cdf061a998fda2f7ba999bf9b9ca962","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"880cc087_1aa409d6","updated":"2024-10-22 08:07:13.000000000","message":"Thank you for pushing this up, this has saved me doing that. My head still gets a bit confused around the functional tests, I had not seen that VGPU base, otherwise I would have push this up already.\n\nApparently there are some other related patches too, but they haven\u0027t been shared yet.\n\nI like this, so +1, but I think those release note nits should probably get fixed up.","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"533358900b50956fc3848fd2f3bedb46753a591d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"277ab163_693d6406","updated":"2025-02-26 08:21:05.000000000","message":"Thanks for the fix","commit_id":"9db3eba8133f4f643bc4a748460a97434fa91f78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4e3a60b82cc4cdf43ce029b16f16f6f1d6d32d18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc75dd25_388d2b1e","updated":"2024-10-22 12:33:58.000000000","message":"thanks. Still looks OK","commit_id":"9db3eba8133f4f643bc4a748460a97434fa91f78"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0638c1471cdf061a998fda2f7ba999bf9b9ca962","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    def get_device_by_alias(self, devalias, devtype\u003dNone,"},{"line_number":417,"context_line":"                            from_persistent_config\u003dFalse):"},{"line_number":418,"context_line":"        for dev in self.get_all_devices(devtype):"},{"line_number":419,"context_line":"            if hasattr(dev, \u0027alias\u0027) and dev.alias \u003d\u003d devalias:"},{"line_number":420,"context_line":"                return dev"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def get_all_devices("}],"source_content_type":"text/x-python","patch_set":1,"id":"2a5c7f8b_503a77b1","line":419,"updated":"2024-10-22 08:07:13.000000000","message":"Ah, neat idea to fix it the other way around.","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"}],"releasenotes/notes/bug-2074219-937d6404c1cbb04c.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"97a6071bd3ba164d9134844daa3b619ffa4105c9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    During the Caracal cycle the libvirt driver was enhanced to support using"},{"line_number":5,"context_line":"    device aliases to detach devices from a domain."},{"line_number":6,"context_line":"    I1dfe4ad3df81bc810835af9b09cfc6c06e9a5388"},{"line_number":7,"context_line":"    This intoduced a regression for instance with vgpus."},{"line_number":8,"context_line":"    A prior bugfix https://bugs.launchpad.net/nova/+bug/1942345"},{"line_number":9,"context_line":"    addressed the symptom without correcting the underlying problem."},{"line_number":10,"context_line":"    A related bug for mdev devices was later reported."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"99c834c5_ac702751","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":18},"updated":"2024-10-22 07:56:02.000000000","message":"nit: introduced","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e44875f6e24ffcb03c143524a83f2d66e9a62e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    During the Caracal cycle the libvirt driver was enhanced to support using"},{"line_number":5,"context_line":"    device aliases to detach devices from a domain."},{"line_number":6,"context_line":"    I1dfe4ad3df81bc810835af9b09cfc6c06e9a5388"},{"line_number":7,"context_line":"    This intoduced a regression for instance with vgpus."},{"line_number":8,"context_line":"    A prior bugfix https://bugs.launchpad.net/nova/+bug/1942345"},{"line_number":9,"context_line":"    addressed the symptom without correcting the underlying problem."},{"line_number":10,"context_line":"    A related bug for mdev devices was later reported."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a153c509_3c87612a","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":18},"in_reply_to":"99c834c5_ac702751","updated":"2024-10-22 16:54:30.000000000","message":"Done","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"97a6071bd3ba164d9134844daa3b619ffa4105c9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    A related bug for mdev devices was later reported."},{"line_number":11,"context_line":"    https://bugs.launchpad.net/nova/+bug/2074219"},{"line_number":12,"context_line":"    When this feature was added nova introduced a helper method"},{"line_number":13,"context_line":"    To get device via the alais because the libvirt api does not provide one"},{"line_number":14,"context_line":"    natively. That helper function assumed all devices would have an alias"},{"line_number":15,"context_line":"    attribute. That assumption was not valid and had now been corrected."},{"line_number":16,"context_line":"    As a result detaching a volume from an instance with vgpus should now"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"87de49be_3f9a6978","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":6},"updated":"2024-10-22 07:56:02.000000000","message":"nit: to","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"97a6071bd3ba164d9134844daa3b619ffa4105c9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    A related bug for mdev devices was later reported."},{"line_number":11,"context_line":"    https://bugs.launchpad.net/nova/+bug/2074219"},{"line_number":12,"context_line":"    When this feature was added nova introduced a helper method"},{"line_number":13,"context_line":"    To get device via the alais because the libvirt api does not provide one"},{"line_number":14,"context_line":"    natively. That helper function assumed all devices would have an alias"},{"line_number":15,"context_line":"    attribute. That assumption was not valid and had now been corrected."},{"line_number":16,"context_line":"    As a result detaching a volume from an instance with vgpus should now"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6c01e167_f6dd0e45","line":13,"range":{"start_line":13,"start_character":26,"end_line":13,"end_character":31},"updated":"2024-10-22 07:56:02.000000000","message":"nit:alias","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e44875f6e24ffcb03c143524a83f2d66e9a62e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    A related bug for mdev devices was later reported."},{"line_number":11,"context_line":"    https://bugs.launchpad.net/nova/+bug/2074219"},{"line_number":12,"context_line":"    When this feature was added nova introduced a helper method"},{"line_number":13,"context_line":"    To get device via the alais because the libvirt api does not provide one"},{"line_number":14,"context_line":"    natively. That helper function assumed all devices would have an alias"},{"line_number":15,"context_line":"    attribute. That assumption was not valid and had now been corrected."},{"line_number":16,"context_line":"    As a result detaching a volume from an instance with vgpus should now"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c39141f0_04fd573f","line":13,"range":{"start_line":13,"start_character":26,"end_line":13,"end_character":31},"in_reply_to":"6c01e167_f6dd0e45","updated":"2024-10-22 16:54:30.000000000","message":"Done","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e44875f6e24ffcb03c143524a83f2d66e9a62e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    A related bug for mdev devices was later reported."},{"line_number":11,"context_line":"    https://bugs.launchpad.net/nova/+bug/2074219"},{"line_number":12,"context_line":"    When this feature was added nova introduced a helper method"},{"line_number":13,"context_line":"    To get device via the alais because the libvirt api does not provide one"},{"line_number":14,"context_line":"    natively. That helper function assumed all devices would have an alias"},{"line_number":15,"context_line":"    attribute. That assumption was not valid and had now been corrected."},{"line_number":16,"context_line":"    As a result detaching a volume from an instance with vgpus should now"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"109b4555_f314ab30","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":6},"in_reply_to":"87de49be_3f9a6978","updated":"2024-10-22 16:54:30.000000000","message":"Done","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"97a6071bd3ba164d9134844daa3b619ffa4105c9","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    natively. That helper function assumed all devices would have an alias"},{"line_number":15,"context_line":"    attribute. That assumption was not valid and had now been corrected."},{"line_number":16,"context_line":"    As a result detaching a volume from an instance with vgpus should now"},{"line_number":17,"context_line":"    be possible and this class of bug should nonger happen."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f6584445_b27d70a2","line":17,"range":{"start_line":17,"start_character":45,"end_line":17,"end_character":51},"updated":"2024-10-22 07:56:02.000000000","message":"nit: no longer","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3e44875f6e24ffcb03c143524a83f2d66e9a62e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    natively. That helper function assumed all devices would have an alias"},{"line_number":15,"context_line":"    attribute. That assumption was not valid and had now been corrected."},{"line_number":16,"context_line":"    As a result detaching a volume from an instance with vgpus should now"},{"line_number":17,"context_line":"    be possible and this class of bug should nonger happen."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"93726653_ffbdd726","line":17,"range":{"start_line":17,"start_character":45,"end_line":17,"end_character":51},"in_reply_to":"f6584445_b27d70a2","updated":"2024-10-22 16:54:30.000000000","message":"Done","commit_id":"bf9d6495534c883d25162b32487ea4a9619f655e"}]}