)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f86de1a3eebb6078765966ea0283fb6903b3a19c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Mina ShahsavanPour \u003cm.shahsavanpour@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-24 17:13:03 +0330"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova-api: Prevent os-resetState API action on instances in disallowed VM states."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1913016"},{"line_number":10,"context_line":"Change-Id: I322302375392bffd9f8001282deb14a91b34349c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c7c0b8a0_0a2e437f","line":7,"updated":"2024-11-12 14:21:34.000000000","message":"reset state is explcitly and admin only escape hatch for updating the database\nwhen a instance is in an invlaid sate.\n\nfiltering it kind of defeats the reason for the api to exist.","commit_id":"cc191b82908560e10f6f505762c7986f5f051ad4"}],"nova/api/openstack/compute/admin_actions.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7ba19f0e412427358f5385bcb5d40da82c8eaaea","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        disallowed_states \u003d ["},{"line_number":85,"context_line":"            state.lower()"},{"line_number":86,"context_line":"            for state in CONF.disallowed_reset_states"},{"line_number":87,"context_line":"        ]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if instance.vm_state.lower() in disallowed_states:"}],"source_content_type":"text/x-python","patch_set":1,"id":"01cc6e18_24666e8d","line":86,"updated":"2024-11-12 13:27:52.000000000","message":"* This is what we call as a config driven API. In general nova tries to avoid config driven API implementations as that breaks cross cloud compatibility. \n\n* This is an API change so we need a discussion about the API design in a spec. https://docs.openstack.org/nova/latest/contributor/process.html#how-do-i-get-my-code-merged","commit_id":"cc191b82908560e10f6f505762c7986f5f051ad4"}],"nova/conf/service.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f86de1a3eebb6078765966ea0283fb6903b3a19c","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Provide a list of virtual machine states for which the os-resetState"},{"line_number":168,"context_line":"action will be disallowed. This helps prevent state resets for instances"},{"line_number":169,"context_line":"in specific states, such as \u0027shelved\u0027 or \u0027shelved_offloaded\u0027."},{"line_number":170,"context_line":"\"\"\"),"},{"line_number":171,"context_line":"]"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0321bc1f_cd6307bc","line":169,"updated":"2024-11-12 14:21:34.000000000","message":"its generaly unsafe to use reset state without alot of care in almost any move operation so while i get the intent, if we were to do this it shoudl not be a config option, we shoudl have a new api microversion for this behaivor.\n\nim not against that but as gibi noted this would be an api change and all api changes require a spec.\n\nthe current config-driven approach si kind of an interoperability issue.\nthe counter point ot this is this is an admin-only api so the admin coudl be reasonably expected to know what is set in this config for there cloud.\n\nin general, however, I\u0027m not a fan of this approach.","commit_id":"cc191b82908560e10f6f505762c7986f5f051ad4"}]}