)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"96c13fd70576de0a5986c539d6c11ef62a88815f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[eventlet] update nova tests for eventlet 0.37.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes one unit test less strict"},{"line_number":10,"context_line":"by asserting that waitall is called but not how often."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also avoid a scheduler restart in the"},{"line_number":13,"context_line":"cross cell functional tests by configuring the filters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"018d22a5_8be32ef2","line":10,"updated":"2024-10-24 23:40:48.000000000","message":"Do we know why the number of times it\u0027s called changed with the new eventlet? I\u0027m curious.","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e439d0a2dc242f8fe29a31b3dfe987babe13085b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[eventlet] update nova tests for eventlet 0.37.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes one unit test less strict"},{"line_number":10,"context_line":"by asserting that waitall is called but not how often."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also avoid a scheduler restart in the"},{"line_number":13,"context_line":"cross cell functional tests by configuring the filters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6efc8394_3e238f58","line":10,"in_reply_to":"018d22a5_8be32ef2","updated":"2024-10-24 23:56:03.000000000","message":"no its super odd.\n\nit went form 1 to 2 calls but i do not know why","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"405839eae7bcf032d030651c1702c64460a6e645","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[eventlet] update nova tests for eventlet 0.37.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes one unit test less strict"},{"line_number":10,"context_line":"by asserting that waitall is called but not how often."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also avoid a scheduler restart in the"},{"line_number":13,"context_line":"cross cell functional tests by configuring the filters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8dc153af_e4ef6a2e","line":10,"in_reply_to":"6efc8394_3e238f58","updated":"2024-12-10 13:31:38.000000000","message":"In general this commit message does not help understanding why things needs to be changed so it is hard for me to review if the given change is actually the correct one.","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a831d75e1e5d81f1d304f168d14d838d757ce14f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[eventlet] update nova tests for eventlet 0.37.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes one unit test less strict"},{"line_number":10,"context_line":"by asserting that waitall is called but not how often."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also avoid a scheduler restart in the"},{"line_number":13,"context_line":"cross cell functional tests by configuring the filters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c67f2dd4_af8701b8","line":10,"in_reply_to":"8dc153af_e4ef6a2e","updated":"2025-01-06 14:24:46.000000000","message":"this was quick attempet to unblock the new version fo evently \nhttps://review.opendev.org/c/openstack/requirements/+/933257\n\nbut while this allowed things to passed for me locally its still fils in the gate of that chagne so there is something else missing.\n\nim not acctivly working on this so we likely need someone ese to take this over or propose a diffent patch to supprot evently 0.37.0","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"43c7bd3c8b0b4cb7378e05787eedd1f31d2ca870","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[eventlet] update nova tests for eventlet 0.37.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes one unit test less strict"},{"line_number":10,"context_line":"by asserting that waitall is called but not how often."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also avoid a scheduler restart in the"},{"line_number":13,"context_line":"cross cell functional tests by configuring the filters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"07bb4426_748e9906","line":10,"in_reply_to":"c67f2dd4_af8701b8","updated":"2025-01-10 18:01:25.000000000","message":"The gate is now fixed https://review.opendev.org/c/openstack/requirements/+/933257\nThe problem was in the pipemutex implementation of oslo.log","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a831d75e1e5d81f1d304f168d14d838d757ce14f","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change also avoid a scheduler restart in the"},{"line_number":13,"context_line":"cross cell functional tests by configuring the filters"},{"line_number":14,"context_line":"in the class setUp function instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8f62200af67b0ee328637c45c0a0e77cc7018187"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f6d91b9_75457f2f","line":14,"updated":"2025-01-06 14:24:46.000000000","message":"this is why ^ i moved the aggreate filter.\n\nif we restart the schduler we get errror with the latest libirt release so i maoved it ot avoid the need for estart by ensuring the config was corrrect before it was started.\n\nwe coudl move where the schduelr is started in stead.","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f409784a18226931ccdd099210333c6a9a6acce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f4e2d4c_e0fe74ef","updated":"2024-12-06 08:57:23.000000000","message":"recheck logs expired and bump review","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0be049c4a2b8e938841e7b4335304d7309390e78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f54b39e_3312d766","updated":"2024-10-25 07:33:22.000000000","message":"testing with bumped eventlet in https://review.opendev.org/c/openstack/requirements/+/933257","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"339f41c3fbee579a33b2b850e269ae27c1e8c0c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"031fcbd7_630b1e11","updated":"2025-01-14 12:08:23.000000000","message":"single test case change works for me.","commit_id":"79798466583c9d0086289f086fb7068e7ad1d117"}],"nova/tests/functional/test_cross_cell_migrate.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a831d75e1e5d81f1d304f168d14d838d757ce14f","unresolved":true,"context_lines":[{"line_number":881,"context_line":"            self.flags(enabled_filters\u003denabled_filters,"},{"line_number":882,"context_line":"                       group\u003d\u0027filter_scheduler\u0027)"},{"line_number":883,"context_line":"            self.scheduler_service.stop()"},{"line_number":884,"context_line":"            self.scheduler_service \u003d self.start_service(\u0027scheduler\u0027)"},{"line_number":885,"context_line":"        # Now resize to the new flavor and it should go to host2 in cell2."},{"line_number":886,"context_line":"        self.admin_api.post_server_action("},{"line_number":887,"context_line":"            server[\u0027id\u0027], {\u0027resize\u0027: {\u0027flavorRef\u0027: new_flavor[\u0027id\u0027]}})"}],"source_content_type":"text/x-python","patch_set":1,"id":"4e5098ff_a0dee9f4","side":"PARENT","line":884,"updated":"2025-01-06 14:24:46.000000000","message":"and they way we stop and start the schduler here breaks with the new eventlet enabled by https://review.opendev.org/c/openstack/requirements/+/933257","commit_id":"796250fa0d325057868572f8a4bb29aacf1edcf6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"405839eae7bcf032d030651c1702c64460a6e645","unresolved":true,"context_lines":[{"line_number":70,"context_line":"            enabled_filters.append(\u0027AggregateInstanceExtraSpecsFilter\u0027)"},{"line_number":71,"context_line":"            self.flags(enabled_filters\u003denabled_filters,"},{"line_number":72,"context_line":"                       group\u003d\u0027filter_scheduler\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        super(TestMultiCellMigrate, self).setUp()"},{"line_number":75,"context_line":"        self.cinder \u003d self.useFixture(nova_fixtures.CinderFixture(self))"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6dcb028e_5fbe8897","line":73,"updated":"2024-12-10 13:31:38.000000000","message":"As this change now changing the pre-condition of around 1000 lines of other test cases I\u0027m bit afraid that it might create false positive test results in the future when something under test is changed covered by these unit test.\n\nSo I would rater no do this pre-condition change if I can. What is the reason we need to do this? The commit message only state what is changed but it does not explain why it is needed to change so I cannot assess if we really need this or not.\n\nIf we really need this then I would move the single test case with the different scheduler setup to a different test class to isolate this change to the single test case depending on it.","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a831d75e1e5d81f1d304f168d14d838d757ce14f","unresolved":true,"context_lines":[{"line_number":70,"context_line":"            enabled_filters.append(\u0027AggregateInstanceExtraSpecsFilter\u0027)"},{"line_number":71,"context_line":"            self.flags(enabled_filters\u003denabled_filters,"},{"line_number":72,"context_line":"                       group\u003d\u0027filter_scheduler\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        super(TestMultiCellMigrate, self).setUp()"},{"line_number":75,"context_line":"        self.cinder \u003d self.useFixture(nova_fixtures.CinderFixture(self))"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dc1d562b_92da6357","line":73,"in_reply_to":"6dcb028e_5fbe8897","updated":"2025-01-06 14:24:46.000000000","message":"see https://review.opendev.org/c/openstack/nova/+/933365/1//COMMIT_MSG#12\n\n\nhttps://review.opendev.org/c/openstack/nova/+/933365/1//COMMIT_MSG#12 is starting the schdluer.","commit_id":"09f670ca8e03ef1d271330415b3f22c9796c6634"}]}