)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7eced03651b6016ed2db2292bee53a9ec14666dd","unresolved":true,"context_lines":[{"line_number":26,"context_line":"evacuation based on the migration record. It will be correct even if the"},{"line_number":27,"context_line":"evacuation is still in progress or even if it is already finished."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Close-Bug: #2085975"},{"line_number":30,"context_line":"Change-Id: If5ad213649d68da995dad146f0a0c3cacc369309"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a3d9a55c_ed53df46","line":29,"updated":"2024-10-30 17:23:50.000000000","message":"nit:Closes-Bug\n\nI will respin this after CI votes.","commit_id":"065d8d13a952522f54d56f000901b2525c5be95b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"65bc18ef20e1ff5206f15691d3b34052663e00a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"evacuation based on the migration record. It will be correct even if the"},{"line_number":27,"context_line":"evacuation is still in progress or even if it is already finished."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Close-Bug: #2085975"},{"line_number":30,"context_line":"Change-Id: If5ad213649d68da995dad146f0a0c3cacc369309"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9d656b86_2b7e7fba","line":29,"in_reply_to":"a3d9a55c_ed53df46","updated":"2024-11-04 10:02:05.000000000","message":"Done","commit_id":"065d8d13a952522f54d56f000901b2525c5be95b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4df3179b4522c22f80a5c1f559742e5b7d78400b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0cc5580e_69394516","updated":"2024-11-05 13:53:51.000000000","message":"we may want a fixes release note for this as operators might be interested to learn about this.\n\nwith that said i dont think we need to respin for that so if you happen to respin for a merge conflict or other feedback consier if you think a release note adds value or not.\n\noverall i think this make sense and im ok with the level of test coverage so +2","commit_id":"2c76fd3bafc90b23ed9d9e6a7f84919082dc0076"}],"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4df3179b4522c22f80a5c1f559742e5b7d78400b","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                                                           instance)"},{"line_number":829,"context_line":"                evac \u003d evacuations[instance.uuid]"},{"line_number":830,"context_line":"                destroy_disks \u003d not (self._is_instance_storage_shared("},{"line_number":831,"context_line":"                    context, instance, host\u003devac.dest_compute))"},{"line_number":832,"context_line":"            except exception.InstanceNotFound:"},{"line_number":833,"context_line":"                network_info \u003d network_model.NetworkInfo()"},{"line_number":834,"context_line":"                bdi \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"1d60bfd7_c94e3cf8","line":831,"updated":"2024-11-05 13:53:51.000000000","message":"+1","commit_id":"2c76fd3bafc90b23ed9d9e6a7f84919082dc0076"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b10f2d13ed8d4c280910fdfcff627044dd2fb21","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                                                           instance)"},{"line_number":829,"context_line":"                evac \u003d evacuations[instance.uuid]"},{"line_number":830,"context_line":"                destroy_disks \u003d not (self._is_instance_storage_shared("},{"line_number":831,"context_line":"                    context, instance, host\u003devac.dest_compute))"},{"line_number":832,"context_line":"            except exception.InstanceNotFound:"},{"line_number":833,"context_line":"                network_info \u003d network_model.NetworkInfo()"},{"line_number":834,"context_line":"                bdi \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"72637979_5d510bb0","line":831,"in_reply_to":"1d60bfd7_c94e3cf8","updated":"2024-11-06 16:19:27.000000000","message":"I was thinking this was still a race between creating the migration and the actual instance on the other side, which might cause this to fail briefly if we got \"lucky\". However, reminding myself of how this works, we *do* check to see if \"this instance is shared\", however that will work regardless of if the instance is actually present on either because we\u0027re just doing the sentinel check. So, this should be good.\n\nBut, note for later that this sort of thing would likely need to change in a multibackend case where we\u0027d need to do more to decide \"would the instance be on $backend, and is $backend shared\".","commit_id":"2c76fd3bafc90b23ed9d9e6a7f84919082dc0076"}],"nova/tests/functional/regressions/test_bug_2085975.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4df3179b4522c22f80a5c1f559742e5b7d78400b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        contd.set()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        self.assertIsNone(rpc_exception)"},{"line_number":131,"context_line":"        self.assertEqual(\u0027compute2\u0027, rpc_target_host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3709609_5d9a99ba","line":131,"updated":"2024-11-05 13:53:51.000000000","message":"i didnt run this for quite as long but also looks stable\n\n{0} nova.tests.functional.regressions.test_bug_2085975.TestComputeStartupInProgressEvacuation.test_compute_startup_evacuation_in_progress [4.646813s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 30 tests in 415.5370 sec.\n - Passed: 30\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 140.4901 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (30 tests) \u003d\u003e 0:06:55.536956","commit_id":"2c76fd3bafc90b23ed9d9e6a7f84919082dc0076"}]}