)]}'
{"nova/conductor/api.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"1cbdeba081b438c22fffed832ac6e0e71ed7c149","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            try:"},{"line_number":295,"context_line":"                self.base_rpcapi.ping(context, \u00271.21 GigaWatts\u0027,"},{"line_number":296,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":297,"context_line":"                if has_timedout:"},{"line_number":298,"context_line":"                    LOG.warning(_(\u0027nova-conductor connection \u0027"},{"line_number":299,"context_line":"                                  \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_9fdf8268","line":297,"updated":"2014-05-20 11:04:42.000000000","message":"I feel like this isn\u0027t needed","commit_id":"fa6853583ffe0e2362f631b20d9bfaa49f8fed8f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0a4490d07d1c67ba7859da16888f6363e560e809","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            try:"},{"line_number":295,"context_line":"                self.base_rpcapi.ping(context, \u00271.21 GigaWatts\u0027,"},{"line_number":296,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":297,"context_line":"                if has_timedout:"},{"line_number":298,"context_line":"                    LOG.warning(_(\u0027nova-conductor connection \u0027"},{"line_number":299,"context_line":"                                  \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ef169ba6","line":297,"in_reply_to":"7adec928_9fdf8268","updated":"2014-06-03 05:48:42.000000000","message":"It\u0027s only needed to inform that the WARNING \"Timed-out waiting ...\" is non-fatal.  However, as mentioned I\u0027ll take a different approach where that message is changed to illustrate it is non-fatal","commit_id":"fa6853583ffe0e2362f631b20d9bfaa49f8fed8f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"1cbdeba081b438c22fffed832ac6e0e71ed7c149","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                                  \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"},{"line_number":301,"context_line":"            except messaging.MessagingTimeout:"},{"line_number":302,"context_line":"                has_timedout \u003d True"},{"line_number":303,"context_line":"                LOG.warning(_(\u0027Timed out waiting for nova-conductor. \u0027"},{"line_number":304,"context_line":"                                \u0027Is it running? Or did this service start \u0027"},{"line_number":305,"context_line":"                                \u0027before nova-conductor?\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_bf6fde90","line":302,"updated":"2014-05-20 11:04:42.000000000","message":"How about this instead, in the except do:\n\nif attempt !\u003d 0 and (attempt % 10) \u003d\u003d 0:\n    LOG.warning(_(\u0027......................... %dth attempt\u0027 % attempt)\n\nThis would let us go through 10 attempts first before we raise an issue, which I think is good enough.","commit_id":"fa6853583ffe0e2362f631b20d9bfaa49f8fed8f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0a4490d07d1c67ba7859da16888f6363e560e809","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                                  \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"},{"line_number":301,"context_line":"            except messaging.MessagingTimeout:"},{"line_number":302,"context_line":"                has_timedout \u003d True"},{"line_number":303,"context_line":"                LOG.warning(_(\u0027Timed out waiting for nova-conductor. \u0027"},{"line_number":304,"context_line":"                                \u0027Is it running? Or did this service start \u0027"},{"line_number":305,"context_line":"                                \u0027before nova-conductor?\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_af4573b4","line":302,"in_reply_to":"7adec928_89dd88e2","updated":"2014-06-03 05:48:42.000000000","message":"I feel like this overcomplicates things.  What I will do is modify the warning message to make it clear that it is retrying the connection.  As it reads right now, it looks like a fatal error","commit_id":"fa6853583ffe0e2362f631b20d9bfaa49f8fed8f"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"525b9f0b30e0c8cbd4221df78b4f4b41c2618b70","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                                  \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"},{"line_number":301,"context_line":"            except messaging.MessagingTimeout:"},{"line_number":302,"context_line":"                has_timedout \u003d True"},{"line_number":303,"context_line":"                LOG.warning(_(\u0027Timed out waiting for nova-conductor. \u0027"},{"line_number":304,"context_line":"                                \u0027Is it running? Or did this service start \u0027"},{"line_number":305,"context_line":"                                \u0027before nova-conductor?\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_89dd88e2","line":302,"in_reply_to":"7adec928_bf6fde90","updated":"2014-05-20 15:18:02.000000000","message":"attempt is never going to be 0 as it gets incremented early on\nsuggest:\n\nif (attempt-1) % 10 \u003d\u003d 0:\n\n\nThis will fire a warning on the first and then every 10th failure","commit_id":"fa6853583ffe0e2362f631b20d9bfaa49f8fed8f"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"4f33565760ff2ae7e329e11d075e16414ae52977","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            try:"},{"line_number":296,"context_line":"                self.base_rpcapi.ping(context, \u00271.21 GigaWatts\u0027,"},{"line_number":297,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":298,"context_line":"                LOG.info(_(\u0027nova-conductor connection \u0027"},{"line_number":299,"context_line":"                           \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"},{"line_number":301,"context_line":"            except messaging.MessagingTimeout:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_5fb72b3a","line":298,"updated":"2014-06-03 13:53:19.000000000","message":"At best these should be .debug and I question logging every single connection attempt and success.  This would seem to clutter the logs terribly which is already a problem.","commit_id":"441cb2fb9c0bd781f095438f8243811bb7af81ac"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"aa2de2efe583dd689990f5ce13282675b9c45bf6","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            try:"},{"line_number":296,"context_line":"                self.base_rpcapi.ping(context, \u00271.21 GigaWatts\u0027,"},{"line_number":297,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":298,"context_line":"                LOG.info(_(\u0027nova-conductor connection \u0027"},{"line_number":299,"context_line":"                           \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"},{"line_number":301,"context_line":"            except messaging.MessagingTimeout:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_d7668429","line":298,"in_reply_to":"1ae5cdf2_07b1b046","updated":"2014-06-05 01:22:20.000000000","message":"\u003e I\u0027m good with the log.warn message\n\nCan we agree on one thing : if we warn that we couldn\u0027t establish the connection, we need some corresponding message when it comes up.\n\nOtherwise to someone who hasn\u0027t read through this code it\u0027s unclear what has gone on; if it\u0027s a persistent error that needs investigation or if things are actually working.\n\nSo that returns to my prior review which, if the warning was shown, outputted a partner message saying the connection was up.  I feel that showing the message modulo various counts etc is all a bit arbitrary and unnecessary complication","commit_id":"441cb2fb9c0bd781f095438f8243811bb7af81ac"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"b2385186f2a46d35bac9a5763f226b01fab48a39","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            try:"},{"line_number":296,"context_line":"                self.base_rpcapi.ping(context, \u00271.21 GigaWatts\u0027,"},{"line_number":297,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":298,"context_line":"                LOG.info(_(\u0027nova-conductor connection \u0027"},{"line_number":299,"context_line":"                           \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"},{"line_number":301,"context_line":"            except messaging.MessagingTimeout:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_07b1b046","line":298,"in_reply_to":"1ae5cdf2_43dd91df","updated":"2014-06-04 15:00:19.000000000","message":"I wouldn\u0027t make the assumption that this only runs once at startup.  It\u0027s been fixed now, but we noticed that LocalAPI objects were being created every time run_instance calls were made in the scheduler.  This was addressed on May 8th, but it was like that for several months.  Nothing prevents us from doing this (regardless of whether it\u0027s a good thing or not).\n\nSorry for the confusion, this is specific to log.info of the attempt and connection establishment.  I\u0027m good with the log.warn message.  My preference is to not have any message on successful connection.  If you feel strongly there is a need.  I think it should be one message saying the connection was established and it should be at the debug level.","commit_id":"441cb2fb9c0bd781f095438f8243811bb7af81ac"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6afe2d47d0f46aec812de25a1b8d0d339c07b283","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            try:"},{"line_number":296,"context_line":"                self.base_rpcapi.ping(context, \u00271.21 GigaWatts\u0027,"},{"line_number":297,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":298,"context_line":"                LOG.info(_(\u0027nova-conductor connection \u0027"},{"line_number":299,"context_line":"                           \u0027established successfully\u0027))"},{"line_number":300,"context_line":"                break"},{"line_number":301,"context_line":"            except messaging.MessagingTimeout:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_43dd91df","line":298,"in_reply_to":"1ae5cdf2_5fb72b3a","updated":"2014-06-03 19:16:06.000000000","message":"This only runs once at startup?  And this msg will only appear once when the connection happens; in other cases the ping will raise an exception and we get the warning as already happens.\n\nWould you rather no INFO messages and just the WARNING message?  or something else to happen to notify of failure to connect?","commit_id":"441cb2fb9c0bd781f095438f8243811bb7af81ac"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d2997c407014337a24bda122be2f70c4b5358458","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":300,"context_line":"                if has_timedout:"},{"line_number":301,"context_line":"                    LOG.warning(_(\u0027nova-conductor connection \u0027"},{"line_number":302,"context_line":"                                  \u0027established successfully\u0027))"},{"line_number":303,"context_line":"                break"},{"line_number":304,"context_line":"            except messaging.MessagingTimeout:"},{"line_number":305,"context_line":"                has_timedout \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_5da613af","line":302,"updated":"2014-06-05 02:50:12.000000000","message":"only feel \na little bit confusing here with a \u0027warning\u0027\nand established successfully\n\nusually warning means it can lead to potential issue...\nbut it won\u0027t be true here","commit_id":"898d7179e073490853dd1233777d8ed4b7b6ca3e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3f886b2bb0c94b0a76e32e75764dbbe51137d311","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":300,"context_line":"                if has_timedout:"},{"line_number":301,"context_line":"                    LOG.warning(_(\u0027nova-conductor connection \u0027"},{"line_number":302,"context_line":"                                  \u0027established successfully\u0027))"},{"line_number":303,"context_line":"                break"},{"line_number":304,"context_line":"            except messaging.MessagingTimeout:"},{"line_number":305,"context_line":"                has_timedout \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_98e429ad","line":302,"in_reply_to":"1ae5cdf2_5da613af","updated":"2014-06-05 04:11:24.000000000","message":"It\u0027s to match the level of the other warning...","commit_id":"898d7179e073490853dd1233777d8ed4b7b6ca3e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"273da227b2e3e6f3864a1e6645e21402cceac13c","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                                      timeout\u003dtimeout)"},{"line_number":300,"context_line":"                if has_timedout:"},{"line_number":301,"context_line":"                    LOG.warning(_(\u0027nova-conductor connection \u0027"},{"line_number":302,"context_line":"                                  \u0027established successfully\u0027))"},{"line_number":303,"context_line":"                break"},{"line_number":304,"context_line":"            except messaging.MessagingTimeout:"},{"line_number":305,"context_line":"                has_timedout \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_115f3376","line":302,"in_reply_to":"1ae5cdf2_98e429ad","updated":"2014-06-26 21:27:02.000000000","message":"It should be info. It\u0027s not a warning that the right thing happened.","commit_id":"898d7179e073490853dd1233777d8ed4b7b6ca3e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"002e7e38de1e1004218df53e687e0f20166d16c3","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                break"},{"line_number":304,"context_line":"            except messaging.MessagingTimeout:"},{"line_number":305,"context_line":"                has_timedout \u003d True"},{"line_number":306,"context_line":"                LOG.warning(_(\u0027Timed out waiting for nova-conductor.  \u0027"},{"line_number":307,"context_line":"                              \u0027Is it running? Or did this service start \u0027"},{"line_number":308,"context_line":"                              \u0027before nova-conductor?  \u0027"},{"line_number":309,"context_line":"                              \u0027Reattempting establishment of \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_f27aae86","line":306,"updated":"2014-06-05 01:33:38.000000000","message":"PS. I feel this is a necessary warning. Even in the early_timeout it\u0027s still sitting around stalled for 10-seconds, which is a very long time to say nothing","commit_id":"898d7179e073490853dd1233777d8ed4b7b6ca3e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"273da227b2e3e6f3864a1e6645e21402cceac13c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                break"},{"line_number":304,"context_line":"            except messaging.MessagingTimeout:"},{"line_number":305,"context_line":"                has_timedout \u003d True"},{"line_number":306,"context_line":"                LOG.warning(_(\u0027Timed out waiting for nova-conductor.  \u0027"},{"line_number":307,"context_line":"                              \u0027Is it running? Or did this service start \u0027"},{"line_number":308,"context_line":"                              \u0027before nova-conductor?  \u0027"},{"line_number":309,"context_line":"                              \u0027Reattempting establishment of \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_11bbb375","line":306,"in_reply_to":"1ae5cdf2_f27aae86","updated":"2014-06-26 21:27:02.000000000","message":"Something still doesn\u0027t seem right, because in this patch, we get a Timedout warning, then 17ms later the connect. Which probably means the timedout isn\u0027t working like we think.\n\nhttp://logs.openstack.org/75/93375/4/check/check-tempest-dsvm-full/8fb24f8/logs/screen-n-cpu.txt.gz","commit_id":"898d7179e073490853dd1233777d8ed4b7b6ca3e"}]}
