)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bf6241ea17985d5be6880f83d9ab61bcb89163a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Improve heal_instance_info_cache periodic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change removes the slightly different behavior between value 0 and"},{"line_number":10,"context_line":"value \u003c 0. Now in both case the periodic task will never be started."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also this change clarifies the doc of the config option about when to"},{"line_number":13,"context_line":"safe to turn this periodic off."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e2a37018_fb2486af","line":10,"updated":"2024-11-21 12:44:46.000000000","message":"+1","commit_id":"1d43a6116721456ee6cd582240267b14bd350ec3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a4e4ace8c05077c925ef544e03dc8abdb23b07ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05f713f1_07d4b20a","updated":"2025-01-15 22:16:17.000000000","message":"Looks OK to me","commit_id":"1d43a6116721456ee6cd582240267b14bd350ec3"}],"nova/conf/compute.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bf6241ea17985d5be6880f83d9ab61bcb89163a","unresolved":true,"context_lines":[{"line_number":1085,"context_line":"  to be synchronized manually."},{"line_number":1086,"context_line":"\"\"\"),"},{"line_number":1087,"context_line":"    cfg.IntOpt(\u0027heal_instance_info_cache_interval\u0027,"},{"line_number":1088,"context_line":"        default\u003d60,"},{"line_number":1089,"context_line":"        help\u003d\"\"\""},{"line_number":1090,"context_line":"Interval between instance network information cache updates."},{"line_number":1091,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b621d92d_8280ecff","line":1088,"range":{"start_line":1088,"start_character":16,"end_line":1088,"end_character":18},"updated":"2024-11-21 12:44:46.000000000","message":"ok let keep this focused on the text changes\n\nwe can tweak this in a follow up.\n\ni think setting this to -1 would make sense\ngiven that is correct for intree neutron backends.\n\nim also wondering if in the future a -2 or simialr value\ncould represnet fully disabling nova\u0027s cache.\n\ni don\u0027t want to derail the docs patch with this however.","commit_id":"1d43a6116721456ee6cd582240267b14bd350ec3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"987812cf25ace0c98a5e5acd2e6289454078d4d7","unresolved":true,"context_lines":[{"line_number":1085,"context_line":"  to be synchronized manually."},{"line_number":1086,"context_line":"\"\"\"),"},{"line_number":1087,"context_line":"    cfg.IntOpt(\u0027heal_instance_info_cache_interval\u0027,"},{"line_number":1088,"context_line":"        default\u003d60,"},{"line_number":1089,"context_line":"        help\u003d\"\"\""},{"line_number":1090,"context_line":"Interval between instance network information cache updates."},{"line_number":1091,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c906dd30_6591125b","line":1088,"range":{"start_line":1088,"start_character":16,"end_line":1088,"end_character":18},"in_reply_to":"8bf534b6_6b76b648","updated":"2024-12-10 10:36:37.000000000","message":"so my issue with that is i want to recommend we use -1 to disable\n\ni dont really want us to use 0 for that.\n\nhats because the use to behave differently although Gibi fixed that in this change as well. no 0 and -1 but behave liek -1 did so its less of an issue but i woudl have previously told peopld to use -1","commit_id":"1d43a6116721456ee6cd582240267b14bd350ec3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"da9834d2a4f73cd87a6bf68575ae83c4fa0d128c","unresolved":true,"context_lines":[{"line_number":1085,"context_line":"  to be synchronized manually."},{"line_number":1086,"context_line":"\"\"\"),"},{"line_number":1087,"context_line":"    cfg.IntOpt(\u0027heal_instance_info_cache_interval\u0027,"},{"line_number":1088,"context_line":"        default\u003d60,"},{"line_number":1089,"context_line":"        help\u003d\"\"\""},{"line_number":1090,"context_line":"Interval between instance network information cache updates."},{"line_number":1091,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8bf534b6_6b76b648","line":1088,"range":{"start_line":1088,"start_character":16,"end_line":1088,"end_character":18},"in_reply_to":"b621d92d_8280ecff","updated":"2024-12-10 07:51:55.000000000","message":"Agree. That is said I would have added in this change a warning for any values \u003c 0 to let us have in future the possibility to use them.\n\n0 \u003d disable\npositive value \u003d activated\nnegative value \u003d disable with a warning that indicates only 0 or positive value","commit_id":"1d43a6116721456ee6cd582240267b14bd350ec3"}]}