)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"7cb4f88fbe7f6ef9a9e35e48adc9e05060c44837","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch missing Glance image attrs with None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Glance is known to drop values from its respons if they don\u0027t resolve to true."},{"line_number":10,"context_line":" Previously in I67b7dd16a94fe60d873c012f6bd246ab24500d5a the None catch was"},{"line_number":11,"context_line":" removed as this WILL cause a call to glance for missing value and"},{"line_number":12,"context_line":" optimizations where made to attempt to pre-catch values can be missing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7adec928_a2748836","line":9,"updated":"2014-05-16 01:40:19.000000000","message":"respons -\u003e response","commit_id":"459541441af050cbf2c53dd68d1c4661f8040ae9"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"7cb4f88fbe7f6ef9a9e35e48adc9e05060c44837","unresolved":false,"context_lines":[{"line_number":11,"context_line":" removed as this WILL cause a call to glance for missing value and"},{"line_number":12,"context_line":" optimizations where made to attempt to pre-catch values can be missing"},{"line_number":13,"context_line":" in expected ways. However there are still situations that can\u0027t be optimized."},{"line_number":14,"context_line":" Notably this can occur with name, deleted, and checksum."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug #1308058"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7adec928_c2719445","line":14,"updated":"2014-05-16 01:40:19.000000000","message":"Most of the lines above are prefixed with a space...","commit_id":"459541441af050cbf2c53dd68d1c4661f8040ae9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"366c6fe2b5bcc137bcabbfaaf74f7493ebd915e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catch missing Glance image attrs with None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Glance is known to drop values from its respons if they don\u0027t resolve to true."},{"line_number":10,"context_line":" Previously in I67b7dd16a94fe60d873c012f6bd246ab24500d5a the None catch was"},{"line_number":11,"context_line":" removed as this WILL cause a call to glance for missing value and"},{"line_number":12,"context_line":" optimizations where made to attempt to pre-catch values can be missing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_b3cf0a57","line":9,"updated":"2014-05-20 19:55:31.000000000","message":"nit: s/respons/response/","commit_id":"9d1ef181d04e7ca8d5500f7c8c50aa4ff34702bb"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"366c6fe2b5bcc137bcabbfaaf74f7493ebd915e5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Glance is known to drop values from its respons if they don\u0027t resolve to true."},{"line_number":10,"context_line":" Previously in I67b7dd16a94fe60d873c012f6bd246ab24500d5a the None catch was"},{"line_number":11,"context_line":" removed as this WILL cause a call to glance for missing value and"},{"line_number":12,"context_line":" optimizations where made to attempt to pre-catch values can be missing"},{"line_number":13,"context_line":" in expected ways. However there are still situations that can\u0027t be optimized."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":" Notably this can occur with disk_format, container_format, name, deleted,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7adec928_53088691","line":12,"updated":"2014-05-20 19:55:31.000000000","message":"nit: s/pre-catch values can/pre-cache values that can/","commit_id":"9d1ef181d04e7ca8d5500f7c8c50aa4ff34702bb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a625a46cd87daa1b5865d04c47fc5b2071b3d59d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Glance is known to drop values from its response if they don\u0027t resolve to true."},{"line_number":10,"context_line":" Previously in I67b7dd16a94fe60d873c012f6bd246ab24500d5a the None catch was"},{"line_number":11,"context_line":" removed as this WILL cause a call to glance for missing value and"},{"line_number":12,"context_line":" optimizations where made to attempt to pre-cache values that can be missing"},{"line_number":13,"context_line":" in expected ways. However there are still situations that can\u0027t be optimized."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Notably this can occur with disk_format, container_format, name, deleted,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7adec928_80050fc4","line":12,"updated":"2014-05-22 16:15:15.000000000","message":"s/where/were/","commit_id":"ef3f158a5aa1988be8ab2f295252373f3ee85809"}],"nova/image/glance.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"e7e31ec0297c2f810233c688cca529ccc98d5cd0","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            output[attr] \u003d None"},{"line_number":529,"context_line":"        else:"},{"line_number":530,"context_line":"            # NOTE(xarses):Anything that is caught with the default value will result in a"},{"line_number":531,"context_line":"            # will result in the a additional lookup to glance for said attr."},{"line_number":532,"context_line":"            # Notable attributes that could have this issue:"},{"line_number":533,"context_line":"            # name, deleted, checksum"},{"line_number":534,"context_line":"            output[attr] \u003d getattr(image, attr, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_e9675e4b","line":531,"updated":"2014-05-15 16:37:24.000000000","message":"\u0027will result in\u0027 is duplicated and \u0027the\u0027 seems like it\u0027s not needed","commit_id":"459541441af050cbf2c53dd68d1c4661f8040ae9"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d546a046b5d7163c1713af367e66eb99553b7d5c","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            output[attr] \u003d None"},{"line_number":529,"context_line":"        else:"},{"line_number":530,"context_line":"            # NOTE(xarses):Anything that is caught with the default value will result in a"},{"line_number":531,"context_line":"            # will result in the a additional lookup to glance for said attr."},{"line_number":532,"context_line":"            # Notable attributes that could have this issue:"},{"line_number":533,"context_line":"            # name, deleted, checksum"},{"line_number":534,"context_line":"            output[attr] \u003d getattr(image, attr, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_c4dfe70b","line":531,"in_reply_to":"7adec928_e9675e4b","updated":"2014-05-15 17:57:29.000000000","message":"Done","commit_id":"459541441af050cbf2c53dd68d1c4661f8040ae9"},{"author":{"_account_id":9847,"name":"ricky.bo","email":"boh.ricky@gmail.com","username":"boh.ricky"},"change_message_id":"cbff36567115cee14958d46ea223981a0ca5c070","unresolved":false,"context_lines":[{"line_number":530,"context_line":"            # NOTE(xarses):Anything that is caught with the default value will result in a"},{"line_number":531,"context_line":"            # will result in the a additional lookup to glance for said attr."},{"line_number":532,"context_line":"            # Notable attributes that could have this issue:"},{"line_number":533,"context_line":"            # name, deleted, checksum"},{"line_number":534,"context_line":"            output[attr] \u003d getattr(image, attr, None)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    output[\u0027properties\u0027] \u003d getattr(image, \u0027properties\u0027, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_89d97a24","line":533,"updated":"2014-05-15 16:29:20.000000000","message":"I think disk_format/container_format has this issue too.\nI read your commit log, maybe we really need to add a unit test to avoid the same thing occurs again in the future.","commit_id":"459541441af050cbf2c53dd68d1c4661f8040ae9"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d546a046b5d7163c1713af367e66eb99553b7d5c","unresolved":false,"context_lines":[{"line_number":530,"context_line":"            # NOTE(xarses):Anything that is caught with the default value will result in a"},{"line_number":531,"context_line":"            # will result in the a additional lookup to glance for said attr."},{"line_number":532,"context_line":"            # Notable attributes that could have this issue:"},{"line_number":533,"context_line":"            # name, deleted, checksum"},{"line_number":534,"context_line":"            output[attr] \u003d getattr(image, attr, None)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    output[\u0027properties\u0027] \u003d getattr(image, \u0027properties\u0027, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_e4e4e3e2","line":533,"in_reply_to":"7adec928_89d97a24","updated":"2014-05-15 17:57:29.000000000","message":"Done","commit_id":"459541441af050cbf2c53dd68d1c4661f8040ae9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e481b5e36d0b480005198adcbc721673fbbf68b4","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        elif attr \u003d\u003d \u0027checksum\u0027 and output[\u0027status\u0027] !\u003d \u0027active\u0027:"},{"line_number":528,"context_line":"            output[attr] \u003d None"},{"line_number":529,"context_line":"        else:"},{"line_number":530,"context_line":"            #NOTE(xarses): Anything that is caught with the default value"},{"line_number":531,"context_line":"            # will result in a additional lookup to glance for said attr."},{"line_number":532,"context_line":"            # Notable attributes that could have this issue:"},{"line_number":533,"context_line":"            # disk_format, container_format, name, deleted, checksum"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_5d9230a0","line":530,"updated":"2014-05-21 20:22:08.000000000","message":"I could have sworn we had a pep8 check that said there needed to be a space between # and NOTE.","commit_id":"9d1ef181d04e7ca8d5500f7c8c50aa4ff34702bb"}],"nova/tests/image/test_glance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e481b5e36d0b480005198adcbc721673fbbf68b4","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        This fakes the image class and is missing attribute as the client can"},{"line_number":460,"context_line":"        return if they\u0027re not set in the database. Regression test for bug"},{"line_number":461,"context_line":"        #1308058."},{"line_number":462,"context_line":"        \"\"\""},{"line_number":463,"context_line":"        class MyFakeGlanceImage(glance_stubs.FakeImage):"},{"line_number":464,"context_line":"            def __init__(self, metadata):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_9dbaf808","line":461,"updated":"2014-05-21 20:22:08.000000000","message":"We don\u0027t need the bug number in the code, it\u0027s in the commit message and we can find that through git history and blame if needed.","commit_id":"9d1ef181d04e7ca8d5500f7c8c50aa4ff34702bb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e481b5e36d0b480005198adcbc721673fbbf68b4","unresolved":false,"context_lines":[{"line_number":494,"context_line":"            \u0027properties\u0027: {},"},{"line_number":495,"context_line":"            \u0027owner\u0027: None,"},{"line_number":496,"context_line":"        }"},{"line_number":497,"context_line":"        self.assertEqual(actual, expected)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"def _create_failing_glance_client(info):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7adec928_1d46e823","line":497,"updated":"2014-05-21 20:22:08.000000000","message":"nit: swap args since the params are (expected, observed).","commit_id":"9d1ef181d04e7ca8d5500f7c8c50aa4ff34702bb"}]}