)]}'
{"nova/network/manager.py":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a8c024ec6ea60145d5f049ca3bb6cdfb262ada2c","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"        if \u0027enable_dhcp\u0027 not in kwargs:"},{"line_number":1041,"context_line":"            kwargs[\u0027enable_dhcp\u0027] \u003d True"},{"line_number":1042,"context_line":"        if \u0027share_address\u0027 not in kwargs:"},{"line_number":1043,"context_line":"            kwargs[\u0027share_address\u0027] \u003d CONF.share_dhcp_address"},{"line_number":1044,"context_line":"        for name in arg_names:"},{"line_number":1045,"context_line":"            kwargs[name] \u003d locals()[name]"},{"line_number":1046,"context_line":"        self._convert_int_args(kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_222f18a3","line":1043,"updated":"2014-05-27 14:17:40.000000000","message":"Will kwargs.setdefault([key_value], [desired default]) work here instead of the multiple \"if\"\u0027s","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"b32aa2add103a3ed897d659ed6120e935f1bb770","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"        if \u0027enable_dhcp\u0027 not in kwargs:"},{"line_number":1041,"context_line":"            kwargs[\u0027enable_dhcp\u0027] \u003d True"},{"line_number":1042,"context_line":"        if \u0027share_address\u0027 not in kwargs:"},{"line_number":1043,"context_line":"            kwargs[\u0027share_address\u0027] \u003d CONF.share_dhcp_address"},{"line_number":1044,"context_line":"        for name in arg_names:"},{"line_number":1045,"context_line":"            kwargs[name] \u003d locals()[name]"},{"line_number":1046,"context_line":"        self._convert_int_args(kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_5a69608a","line":1043,"in_reply_to":"3ae8d1ca_222f18a3","updated":"2014-05-27 19:03:53.000000000","message":"sure, will change.","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a8c024ec6ea60145d5f049ca3bb6cdfb262ada2c","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"            net.dns2 \u003d dns2"},{"line_number":1190,"context_line":"            net.mtu \u003d mtu"},{"line_number":1191,"context_line":"            net.enable_dhcp \u003d enable_dhcp"},{"line_number":1192,"context_line":"            net.share_address \u003d share_address"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"            net.project_id \u003d kwargs.get(\u0027project_id\u0027)"},{"line_number":1195,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_7d52a114","line":1192,"updated":"2014-05-27 14:17:40.000000000","message":"A question more than a comment. Will \"None\" values ever be valid for these fields? If not, is placing \"None\" values in the arg list valid?","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"b32aa2add103a3ed897d659ed6120e935f1bb770","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"            net.dns2 \u003d dns2"},{"line_number":1190,"context_line":"            net.mtu \u003d mtu"},{"line_number":1191,"context_line":"            net.enable_dhcp \u003d enable_dhcp"},{"line_number":1192,"context_line":"            net.share_address \u003d share_address"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"            net.project_id \u003d kwargs.get(\u0027project_id\u0027)"},{"line_number":1195,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_006f6ac6","line":1192,"in_reply_to":"3ae8d1ca_7d52a114","updated":"2014-05-27 19:03:53.000000000","message":"None is valid for mtu it means don\u0027t mess with it. None for the other two is a little tricky. None will cause an error for the other two fields. ValueError: Field `enable_dhcp\u0027 cannot be None","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"33be398312649f86e0df040bba34923bb95c053c","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"                net.netmask \u003d str(subnet_v4.netmask)"},{"line_number":1205,"context_line":"                net.gateway \u003d gateway or str(subnet_v4[1])"},{"line_number":1206,"context_line":"                net.broadcast \u003d str(subnet_v4.broadcast)"},{"line_number":1207,"context_line":"                net.dhcp_start \u003d str(subnet_v4[2])"},{"line_number":1208,"context_line":"                if not dhcp_server:"},{"line_number":1209,"context_line":"                    dhcp_server \u003d net.gateway"},{"line_number":1210,"context_line":"                if net.dhcp_start \u003d\u003d dhcp_server:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_a6559fc7","line":1207,"updated":"2014-05-23 18:22:52.000000000","message":"Might make this more readable to put a code comment in here... maybe something like this?\n\n # If DHCP is enabled for the subnet, we place\n # the DHCP server at the start of the subnet, immediately\n # after the gateway. We also adjust the list of addresses\n # supplied to the _create_fixed_ips() function that are\n # marked as reserved and not for use by tenant VMs","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"b32aa2add103a3ed897d659ed6120e935f1bb770","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"                net.netmask \u003d str(subnet_v4.netmask)"},{"line_number":1205,"context_line":"                net.gateway \u003d gateway or str(subnet_v4[1])"},{"line_number":1206,"context_line":"                net.broadcast \u003d str(subnet_v4.broadcast)"},{"line_number":1207,"context_line":"                net.dhcp_start \u003d str(subnet_v4[2])"},{"line_number":1208,"context_line":"                if not dhcp_server:"},{"line_number":1209,"context_line":"                    dhcp_server \u003d net.gateway"},{"line_number":1210,"context_line":"                if net.dhcp_start \u003d\u003d dhcp_server:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_3ab9f42e","line":1207,"in_reply_to":"7adec928_a6559fc7","updated":"2014-05-27 19:03:53.000000000","message":"Will do.","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a8c024ec6ea60145d5f049ca3bb6cdfb262ada2c","unresolved":false,"context_lines":[{"line_number":1287,"context_line":"        bottom_reserved \u003d self._bottom_reserved_ips"},{"line_number":1288,"context_line":"        top_reserved \u003d self._top_reserved_ips"},{"line_number":1289,"context_line":"        if extra_reserved \u003d\u003d None:"},{"line_number":1290,"context_line":"            extra_reserved \u003d []"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"        if not fixed_cidr:"},{"line_number":1293,"context_line":"            fixed_cidr \u003d netaddr.IPNetwork(network[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_dd6735e9","line":1290,"updated":"2014-05-27 14:17:40.000000000","message":"Is it valid to simply make the default value for extra_reserved in the argument list an empty list instead of None? I guess one could make the argument that bad things would then happen if someone passed in \"extra_reserved\u003dNone\"","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8edaa00abf0900cab6ee3c0754abd83fa469e133","unresolved":false,"context_lines":[{"line_number":1287,"context_line":"        bottom_reserved \u003d self._bottom_reserved_ips"},{"line_number":1288,"context_line":"        top_reserved \u003d self._top_reserved_ips"},{"line_number":1289,"context_line":"        if extra_reserved \u003d\u003d None:"},{"line_number":1290,"context_line":"            extra_reserved \u003d []"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"        if not fixed_cidr:"},{"line_number":1293,"context_line":"            fixed_cidr \u003d netaddr.IPNetwork(network[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_834b8458","line":1290,"in_reply_to":"3ae8d1ca_5a5fa00e","updated":"2014-05-27 19:34:59.000000000","message":"Wooohahhah. Yeah, that would suck. I missed the \"execution at definition\" semantics, but it makes sense.","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"b32aa2add103a3ed897d659ed6120e935f1bb770","unresolved":false,"context_lines":[{"line_number":1287,"context_line":"        bottom_reserved \u003d self._bottom_reserved_ips"},{"line_number":1288,"context_line":"        top_reserved \u003d self._top_reserved_ips"},{"line_number":1289,"context_line":"        if extra_reserved \u003d\u003d None:"},{"line_number":1290,"context_line":"            extra_reserved \u003d []"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"        if not fixed_cidr:"},{"line_number":1293,"context_line":"            fixed_cidr \u003d netaddr.IPNetwork(network[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_5a5fa00e","line":1290,"in_reply_to":"3ae8d1ca_dd6735e9","updated":"2014-05-27 19:03:53.000000000","message":"Never put a list or a dict as a default value in python:\n\nhttp://effbot.org/zone/default-values.htm","commit_id":"d4af0baa71ee9c80538a0a8334868f8f71ef8865"}]}