)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5c2f3c86672a3dd48769fe86c7eecfdcf6dcf8df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0d895267_7de3f524","updated":"2025-01-29 17:34:29.000000000","message":"recheck timeout","commit_id":"c697c6d55f70fca02fc69190860b12bdde3b5185"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"6f503d02ceb1e6c1fde4a49b21c7cd477f89df22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1398aa4f_75fe6d3e","updated":"2025-06-06 14:10:48.000000000","message":"I have checked against the openstack public api doc and it matches.\nSo this patch looks good to me.","commit_id":"2b3eb6b01593d5a26f3cdea95b2b4f29352597e4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c2cbd8442651fae4e9a7a80d1b7c00133b95ad38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"17ed9b7b_7cc50f42","updated":"2025-06-09 22:35:16.000000000","message":"lgtm","commit_id":"2b3eb6b01593d5a26f3cdea95b2b4f29352597e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37a7e95d677e91bb16519b918ef8663b2f831769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bf879de0_3c02fec4","updated":"2025-06-06 10:39:41.000000000","message":"recheck timeout","commit_id":"2b3eb6b01593d5a26f3cdea95b2b4f29352597e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32251fb4d20cdd2833d022eb4fd39ff7f8b709c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cef69851_060edad7","updated":"2025-05-19 13:02:31.000000000","message":"recheck unrelated failure","commit_id":"2b3eb6b01593d5a26f3cdea95b2b4f29352597e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b641d7ff80369a3781f45523a31f8c1c96ed8db3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"10123bd2_506b3aea","updated":"2025-05-26 15:07:46.000000000","message":"recheck unrelated volume timeouts","commit_id":"2b3eb6b01593d5a26f3cdea95b2b4f29352597e4"}],"nova/api/openstack/compute/schemas/ips.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4ea40489b17fa2c6e97fab1c265b4baa8dd784fa","unresolved":true,"context_lines":[{"line_number":35,"context_line":"                {\u0027format\u0027: \u0027ipv4\u0027},"},{"line_number":36,"context_line":"                {\u0027format\u0027: \u0027ipv6\u0027},"},{"line_number":37,"context_line":"            ],"},{"line_number":38,"context_line":"        },"},{"line_number":39,"context_line":"        \u0027version\u0027: {"},{"line_number":40,"context_line":"            \u0027enum\u0027: [4, 6],"},{"line_number":41,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":9,"id":"4df7d013_f5db74c1","line":38,"updated":"2025-06-24 14:04:38.000000000","message":"this is slightly stricter then our current api ref states\n\nhttps://docs.openstack.org/api-ref/compute/#id146\n\nbut i belive it is mroe correct so +1","commit_id":"2b3eb6b01593d5a26f3cdea95b2b4f29352597e4"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"6f503d02ceb1e6c1fde4a49b21c7cd477f89df22","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027patternProperties\u0027: {"},{"line_number":53,"context_line":"                # TODO(stephenfin): Surely there are some limitations on"},{"line_number":54,"context_line":"                # network names?"},{"line_number":55,"context_line":"                \u0027^.+$\u0027: {"},{"line_number":56,"context_line":"                    \u0027type\u0027: \u0027array\u0027,"},{"line_number":57,"context_line":"                    \u0027items\u0027: copy.deepcopy(_ip_address),"},{"line_number":58,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":9,"id":"fbf8d7f7_1e873fef","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":21},"updated":"2025-06-06 14:10:48.000000000","message":"I think that\u0027s ok. At least it checks something is defined.","commit_id":"2b3eb6b01593d5a26f3cdea95b2b4f29352597e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4ea40489b17fa2c6e97fab1c265b4baa8dd784fa","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027patternProperties\u0027: {"},{"line_number":53,"context_line":"                # TODO(stephenfin): Surely there are some limitations on"},{"line_number":54,"context_line":"                # network names?"},{"line_number":55,"context_line":"                \u0027^.+$\u0027: {"},{"line_number":56,"context_line":"                    \u0027type\u0027: \u0027array\u0027,"},{"line_number":57,"context_line":"                    \u0027items\u0027: copy.deepcopy(_ip_address),"},{"line_number":58,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":9,"id":"66339831_35464adf","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":21},"in_reply_to":"fbf8d7f7_1e873fef","updated":"2025-06-24 14:04:38.000000000","message":"There probably are but those are defined by neutron, and I don\u0027t really want to tightly couple our scemem too closely to theirs.\n\nso non-empty is a good start\n\ni know they are alphanumeric but i am not sure about Unicode or special characters or make lengths so for now I\u0027m fine with this\n\nthis is validating the \"network_label\" correct which is actully the neturon nerwork name.\n\nLooking at our network model objects we just treat the lable as a opaque string that is sthen storead in a json blob.\n\nhttps://github.com/openstack/nova/blob/31b9c8ed58efa283979e32128344df5e7cb29941/nova/network/model.py#L362\n\nwe thend to prefer to use the uuid not the lable in most code path.\n\nperhaps we should consider changing this to the network uuid in a future microverison. \n\nthat would be a generally useful change IMO.","commit_id":"2b3eb6b01593d5a26f3cdea95b2b4f29352597e4"}]}