)]}'
{"id":"openstack%2Fnova~937840","triplet_id":"openstack%2Fnova~master~I38c0e984af6c2b2354d1a5151b93174ba5d1c9e8","project":"openstack/nova","branch":"master","topic":"bug/2091147","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2024-12-30 04:37:10.000000000","reason":"Removed by \u003cGERRIT_ACCOUNT_37469\u003e by clicking the attention icon","reason_account":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"}},"37469":{"account":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"last_update":"2024-12-17 08:54:01.000000000","reason":"\u003cGERRIT_ACCOUNT_37469\u003e replied on the change","reason_account":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"}}},"hashtags":[],"change_id":"I38c0e984af6c2b2354d1a5151b93174ba5d1c9e8","subject":"Improve instance shutdown logic for graceful shutdown","status":"NEW","created":"2024-12-17 06:36:34.000000000","updated":"2024-12-30 04:37:10.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5326b6ccbd7772b3a6103ed78c72ff911728259a","_number":937840,"virtual_id_number":937840,"owner":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2024-12-17 11:03:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-17 07:19:40.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-12-17 08:13:42.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2024-12-17 08:40:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a1eec6ad00c8854bb02db5fb79a57da333318dc2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"date":"2024-12-17 06:36:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58a0f01a80873fb10d2ba28e4c0a319f0ba0d3c8","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-12-17 07:19:40.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-937840-j7k8p/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"8effb3490047f029ab51e230fa381cbd679af3d8","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2024-12-17 08:13:42.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2c7a4e0b0278aeb43218d2cec6d6f0b2e4f328a3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-17 08:40:40.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/df864a2e157c4070beb7d342c8389c68\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/0016ff6ade2a466ba1677ed97f500ceb : SUCCESS in 56m 17s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/999cf55d8c924ef8ba85d40d708bf24f : SUCCESS in 1h 39m 39s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/9d48a2e4261d44d18341650ff6f68798 : SUCCESS in 52m 24s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/85d4f70003024e53a6064217c61f1e2b : SUCCESS in 27m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ca1bef81c9ab431eb74e7a686bb256ce : FAILURE in 5m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/72f62f9ed8e842539bc4968e2c51d963 : SUCCESS in 13m 33s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/525a3eac9c86449385d2008c5c81d21d : SUCCESS in 9m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ebd7d6622bad473195871c1fbfbb8253 : SUCCESS in 9m 36s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bb6c62a7b8c44a47a1074e6ded25b79e : SUCCESS in 28m 01s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/2515ddee76ad45209c819b1e527d3b7c : SUCCESS in 1h 06m 16s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/7723ff4a0ddb40b793edbf00899a722b : SUCCESS in 1h 34m 31s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/255314847aa1453c98d9530a37e0cd25 : SUCCESS in 53m 43s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/27f2f6343219480e82cdd75f9ee260c8 : SUCCESS in 53m 34s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/5fc6f7321d9844138fe6ea6b9e5c6d46 : SUCCESS in 53m 08s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/17dd7350c3224d87b13761618062585e : SUCCESS in 1h 40m 40s\n- nova-next https://zuul.opendev.org/t/openstack/build/4ade4a7310314876a7bbc15eaee3b0f9 : SUCCESS in 2h 01m 33s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/f765a0332786445094739d2a24d74434 : SUCCESS in 44m 49s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/11dd2687e1fd4b6a9bc481c66836f9a3 : SUCCESS in 5m 00s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/109af31eb0af47af9a3e4533bfe9f2e7 : SUCCESS in 26m 12s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/a9cdd255bab84e28843f4cb9ef63d5a3 : SUCCESS in 27m 20s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/9b89b0df01544910a954b86f58061953 : SUCCESS in 35m 35s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/bc58c56df75b491185ad7e843765958c : SUCCESS in 1h 50m 55s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/a3874e98ad364c57a0c0e3dd56610951 : SUCCESS in 1h 41m 46s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/eba9c09a8aa3403db1d68d35c7aa6b29 : SUCCESS in 1h 16m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/087800e447ef4c8cafa04eda55b79329 : SUCCESS in 53m 13s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/b28e8411d06948c0838b3ccca7482051 : SUCCESS in 22m 56s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/af9b04d854e3482d82dab38ecfe0f455 : SUCCESS in 19m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"23ebadd2cd79f8590016c498e5f424fa3d38657b","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-17 08:43:21.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7ecca1b82b594442a9d8f18d16eb34e0\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/6c5e2a1f79f240d7b1cde2d04ec5d67a : FAILURE in 38m 20s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/4e2991d940ba4c33a7eb53029d9e792a : SUCCESS in 33m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"eaa51bae65b680da00b2dde46bfbe043eb7267df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"date":"2024-12-17 08:51:21.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"e3651c59afb130f7d61d6962f1b2fcbe79e80ce7","author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"date":"2024-12-17 08:54:01.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a7d33f7b511118e27a75dda738f64f27b82b6125","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2024-12-17 09:29:55.000000000","message":"Patch Set 2:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-937840-bzvvx/index.html\u003e","accounts_in_message":[],"_revision_number":2},{"id":"c24af420118c68afc4f2c94533d14708c4d87f44","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-17 10:00:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/208ecd78a1e8402a838d147128db4714\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/473ed3e1766d4629a6f31e10b21aa5be : FAILURE in 55m 34s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/e6eda4d295a14fdab6ea80bb84f258d5 : SUCCESS in 41m 22s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f0ed4ee6ee7049cb62b3cb5678f94cf3fc3ee2e0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-17 11:03:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e516299e89fd49049ad414f9ff555fe8\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/edbb2776fdfd4d659a2f662694b9be48 : SUCCESS in 48m 35s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/bdc7b839665b4a73b24a29b8b602fd9f : SUCCESS in 1h 39m 06s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/dda80ae4e3d24fbd92023d1619a9cef9 : SUCCESS in 1h 11m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/99223bc4b5b4437da6dc84d194a330a3 : SUCCESS in 22m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bfb6d1adc9bf4743aabcff24977e1198 : SUCCESS in 7m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0c447d5abba644daa578ffd3161bd202 : SUCCESS in 11m 49s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/0346859969944a99b9004835a96c0c6c : SUCCESS in 12m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/104db0aef9f342a0b9b8a428763cbed2 : SUCCESS in 8m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d050aa1448274e579dc600f0a628b3a8 : SUCCESS in 32m 16s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/fde75503cd474b49b547f14cc928a035 : SUCCESS in 1h 05m 31s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/4e51968375c8430cb1957495a2be6592 : SUCCESS in 1h 41m 52s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/d559c7b38e824eaf9c6e1c6d11cfb9ca : SUCCESS in 44m 55s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/58b696a7735a4446bfdd259648ae632f : SUCCESS in 1h 00m 14s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/96992b3d9d3f4c6ba7ea306087e2a40d : SUCCESS in 1h 07m 25s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/f439d2544cfd46b68c9822c5867fb8fe : SUCCESS in 2h 01m 11s\n- nova-next https://zuul.opendev.org/t/openstack/build/e5349f568ae347709fc434448577042f : SUCCESS in 1h 58m 23s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/7fe6272d48ac42488679bda20c9954f4 : SUCCESS in 1h 01m 20s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/f0ed5d534e5c44c3aa3ef4197e0f05d0 : SUCCESS in 5m 10s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/6f94f67a1c4646cd98d5321d49084ec5 : SUCCESS in 22m 28s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/bc4e1aa912394c4bbad28c3f6155554b : SUCCESS in 25m 41s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/1e3618824f1141db9be886427dd95a33 : SUCCESS in 30m 30s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/3f29fddbd1f24de7a0185f3f1d03045f : SUCCESS in 1h 52m 21s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/0b547ddd90014bb7bd4551f2c8566ea7 : SUCCESS in 1h 50m 02s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a253fef0fdf24fc199da8d0ca5b594ca : SUCCESS in 1h 21m 19s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9b13f8bdeb1c43aca92827fcbd707fd9 : SUCCESS in 44m 37s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/dcbb777ff6474a9997af1026bd1edff7 : SUCCESS in 32m 54s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/49800686e4b54a199849cf35f5cef5f4 : SUCCESS in 33m 13s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ce27c6710dccf19ac6849f2bbe90d01978354a9a","revisions":{"88fe9889e8938dfb2b3e6f6c219522debd2e4fcb":{"kind":"REWORK","_number":1,"created":"2024-12-17 06:36:34.000000000","uploader":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"ref":"refs/changes/40/937840/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/40/937840/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/937840/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/937840/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/937840/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/40/937840/1"}}},"commit":{"parents":[{"commit":"3c038645dbd2bac9b53a2e15c3fa938dd0b204b9","subject":"Merge \"Refactor test_server_shares: Mock in Base Class and trait verification\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3c038645dbd2bac9b53a2e15c3fa938dd0b204b9"}]}],"author":{"name":"donghunkimzack","email":"bigheadzacky@gmail.com","date":"2024-12-17 06:32:19.000000000","tz":540},"committer":{"name":"donghunkimzack","email":"bigheadzacky@gmail.com","date":"2024-12-17 06:33:34.000000000","tz":540},"subject":"Improve instance shutdown logic for graceful shutdown","message":"Improve instance shutdown logic for graceful shutdown\n\nNova\u0027s instance shutdown logic prematurely interpreted the \u0027in shutdown\u0027\nstate as \u0027shutdown successful\u0027, interfering with the graceful shutdown\nprocess. This caused issues especially for VMs using PCI passthrough,\ninstances with large memory (TB scale), or in scenarios where OS startup\nwas not complete before a stop request.\n\n- Add domain ID check to verify complete shut off before initiating destroy\n- Ensure proper clean shutdown in various scenarios\n- Improve robustness of shutdown process across different configurations\n\nThis fix addresses scenarios where the shutdown process may take longer\nthan expected, ensuring a more reliable and consistent shutdown behavior.\n\nCloses-Bug: #2091147\nChange-Id: I38c0e984af6c2b2354d1a5151b93174ba5d1c9e8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/88fe9889e8938dfb2b3e6f6c219522debd2e4fcb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/88fe9889e8938dfb2b3e6f6c219522debd2e4fcb"}]},"branch":"refs/heads/master"},"ce27c6710dccf19ac6849f2bbe90d01978354a9a":{"kind":"REWORK","_number":2,"created":"2024-12-17 08:51:21.000000000","uploader":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"ref":"refs/changes/40/937840/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/40/937840/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/937840/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/937840/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/937840/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/40/937840/2"}}},"commit":{"parents":[{"commit":"3c038645dbd2bac9b53a2e15c3fa938dd0b204b9","subject":"Merge \"Refactor test_server_shares: Mock in Base Class and trait verification\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3c038645dbd2bac9b53a2e15c3fa938dd0b204b9"}]}],"author":{"name":"donghunkimzack","email":"bigheadzacky@gmail.com","date":"2024-12-17 06:32:19.000000000","tz":540},"committer":{"name":"donghunkimzack","email":"bigheadzacky@gmail.com","date":"2024-12-17 08:48:09.000000000","tz":540},"subject":"Improve instance shutdown logic for graceful shutdown","message":"Improve instance shutdown logic for graceful shutdown\n\nNova\u0027s instance shutdown logic prematurely interpreted the \u0027in shutdown\u0027\nstate as \u0027shutdown successful\u0027, interfering with the graceful shutdown\nprocess. This caused issues especially for VMs using PCI passthrough,\ninstances with large memory (TB scale), or in scenarios where OS startup\nwas not complete before a stop request.\n\n- Add domain ID check to verify complete shut off before initiating destroy\n- Ensure proper clean shutdown in various scenarios\n- Improve robustness of shutdown process across different configurations\n\nThis fix addresses scenarios where the shutdown process may take longer\nthan expected, ensuring a more reliable and consistent shutdown behavior.\n\nCloses-Bug: #2091147\nChange-Id: I38c0e984af6c2b2354d1a5151b93174ba5d1c9e8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ce27c6710dccf19ac6849f2bbe90d01978354a9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ce27c6710dccf19ac6849f2bbe90d01978354a9a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}