)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47480da7b8ad6230926649fab4f33309c446e8c9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle ephemeral root disk in evacuation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If \"preserve_epehemeral\" is True in evacuation,"},{"line_number":10,"context_line":"destination hypervisor checks ability"},{"line_number":11,"context_line":"to preserve epehemeral root disk."},{"line_number":12,"context_line":"Ephemeral root disk can be preserved:"},{"line_number":13,"context_line":"1) destination hypervisor can reach instance disk"},{"line_number":14,"context_line":"2) image backend is shared"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"e0721dba_71946158","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":33},"updated":"2025-03-27 08:34:12.000000000","message":"preserve_epehemeral is currently only supported for ironic and it is exlcity for the behavior of the addtiona ephermal disk not the root disk.\n\nit would not be correct to use this to alter the behavior of how the root disk is managed.","commit_id":"0d6e425ee9c96a55f937552b293fde7ca9c622d9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47480da7b8ad6230926649fab4f33309c446e8c9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"If \"preserve_epehemeral\" is True in evacuation,"},{"line_number":10,"context_line":"destination hypervisor checks ability"},{"line_number":11,"context_line":"to preserve epehemeral root disk."},{"line_number":12,"context_line":"Ephemeral root disk can be preserved:"},{"line_number":13,"context_line":"1) destination hypervisor can reach instance disk"},{"line_number":14,"context_line":"2) image backend is shared"},{"line_number":15,"context_line":"3) instance is volume-backed"},{"line_number":16,"context_line":"If root disk cannot be preserved,"},{"line_number":17,"context_line":"then evacuation fails."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"35860e93_918a31b4","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":28},"updated":"2025-03-27 08:34:12.000000000","message":"Ephemeral root disks are not a thing\n\nthere are 2 types of root disk, nova provisioned root disks and cinder provisioned root disks\n\nfor nova provisioned disks, they are preserved today if you use images_type\u003drbd or if you use raw/qcow/flat with /var/lib/nova/instances on nfs\n\n\nevacuate is only allowed at the api if the source compute node is down and the admin has manually verified that the vm is not running.\n\nthe recommend way to do that is to ensure the souce node is powered off as not doing that can cause issues in neutron or risk the poteial for data currption fi th e vm is actully still running on the souce and it has data volumes or is on shared storage.","commit_id":"0d6e425ee9c96a55f937552b293fde7ca9c622d9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aa35e1d2e7b1976c30da7d0d3286f72c8941056f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c8c40ea_9c19b512","updated":"2025-01-17 18:40:41.000000000","message":"prodcuduly all api changes need an appvoed spec.\n\nso this is not a bug, its  a new feature proposal and we are apt the specfreeze deadlien for this cycle.","commit_id":"5651f59b14b91001ddd665c7ac5f82850817959e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c13e6ab67f8a221720d459c320a3431d937e186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22e33b52_fdc02d88","updated":"2025-01-17 18:47:33.000000000","message":"adding procedural -2 since this would require a spec and we are passed the spec freeze for this cycle.\n\nthis could be discussed for 2025.2 however i don\u0027t think this is inline with how we would like evacuate to work.\n\n\nit can be discussed but to see what other think but its definitely not a bugfix.","commit_id":"ae4c2dd1c2ac6f35b38ac5ebe7c6c91e7119179e"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"a3a3c479de22785f261fd3e24802dfb1849f4a45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74b4f758_a94a8fff","updated":"2025-01-18 19:05:05.000000000","message":"recheck","commit_id":"f38f99b5e168fe50f9b7d974357a6bc90e4e4cdc"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"bf6320d502a069d39b491f2fa357efb994c650f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6c2440bf_6bab96c9","updated":"2025-03-27 07:44:02.000000000","message":"recheck","commit_id":"0d6e425ee9c96a55f937552b293fde7ca9c622d9"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"fc0799892a7dc75c1ac13ab2231273ef1ccc6286","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"81538f7c_d02f6b73","updated":"2025-03-26 13:07:48.000000000","message":"recheck","commit_id":"0d6e425ee9c96a55f937552b293fde7ca9c622d9"}],"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47480da7b8ad6230926649fab4f33309c446e8c9","unresolved":true,"context_lines":[{"line_number":3848,"context_line":""},{"line_number":3849,"context_line":"        if evacuate:"},{"line_number":3850,"context_line":"            LOG.info(\"Evacuating instance\", instance\u003dinstance)"},{"line_number":3851,"context_line":"            self._fail_if_preserve_ephemeral_root_disk("},{"line_number":3852,"context_line":"                instance, context, migration, preserve_ephemeral)"},{"line_number":3853,"context_line":"            preserve_ephemeral \u003d False"},{"line_number":3854,"context_line":"        else:"},{"line_number":3855,"context_line":"            LOG.info(\"Rebuilding instance\", instance\u003dinstance)"},{"line_number":3856,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2f2d1fc9_6760ef57","line":3853,"range":{"start_line":3851,"start_character":10,"end_line":3853,"end_character":38},"updated":"2025-03-27 08:34:12.000000000","message":"as noted in the commit its incorrect to use the preserve_ephemeral api paramter to make any desigion about the root disk.\n\npreserve_ephemeral was intoduced for ironic to decide if addtiona non root disk should be wiped when doing a rebuild.\n\nevacuate is built on top of rebuild which is why that parmater is aviable.\n\npreserve_ephemeral is expclitly referint to the addtional ephemral disks\nrelated to the Ephemeral Disk GB section of the flavor and is not related to the root disk.\n\nhttps://docs.openstack.org/nova/latest/user/flavors.html#overview","commit_id":"0d6e425ee9c96a55f937552b293fde7ca9c622d9"}]}