)]}'
{"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"383bbce6a41780112a5b2f382b581b545ef73de9","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"        return"},{"line_number":2095,"context_line":""},{"line_number":2096,"context_line":"    # Check if we have siblings. If so, coalesce will not take place."},{"line_number":2097,"context_line":"    if _count_sibling_vhds(session, vdi_ref, sr_ref) \u003e 1:"},{"line_number":2098,"context_line":"        return"},{"line_number":2099,"context_line":""},{"line_number":2100,"context_line":"    max_attempts \u003d CONF.xenserver.vhd_coalesce_max_attempts"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_b6e8957d","line":2097,"updated":"2014-05-22 17:30:02.000000000","message":"Minor nitpick here because this seems a bit unintuitive.  I would expect if siblings \u003e\u003d 1 it would return here.  But this seems to imply, and the code above seems to backup, that this counts the current vdi as a sibling.  If so it might be better off named count_children_of_parent or something more explicit.","commit_id":"c8e0bb33a66059578aa691dce03d5f9c8ade841b"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"a3ef209d8c7a5edd361cc0fcb17dbcedf2d69af3","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"        return"},{"line_number":2095,"context_line":""},{"line_number":2096,"context_line":"    # Check if we have siblings. If so, coalesce will not take place."},{"line_number":2097,"context_line":"    if _count_sibling_vhds(session, vdi_ref, sr_ref) \u003e 1:"},{"line_number":2098,"context_line":"        return"},{"line_number":2099,"context_line":""},{"line_number":2100,"context_line":"    max_attempts \u003d CONF.xenserver.vhd_coalesce_max_attempts"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_70e7dfe4","line":2097,"in_reply_to":"7adec928_b6e8957d","updated":"2014-05-23 08:47:36.000000000","message":"Done","commit_id":"c8e0bb33a66059578aa691dce03d5f9c8ade841b"}]}