)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94ad0c8d54d1d43f32d7add8c9560ec31181d570","unresolved":true,"context_lines":[{"line_number":10,"context_line":"associated with a server. This change extends existing Nova\u0027s"},{"line_number":11,"context_line":"API to allow users to retrieve this information when it is available."},{"line_number":12,"context_line":"It adds a new API microversion to support returning the associated"},{"line_number":13,"context_line":"scheduler_hints in both ``GET /servers/{server_id}`` and"},{"line_number":14,"context_line":"``GET /servers/detail`` responses."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint show-scheduler-hints-in-server-details"},{"line_number":17,"context_line":"Change-Id: If0070cfbc218e0515bf3b58fc8c5067ae22c7072"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"babd7bb6_6727e29e","line":14,"range":{"start_line":13,"start_character":24,"end_line":14,"end_character":34},"updated":"2025-02-26 19:58:13.000000000","message":"basically it change four API response, GET, GET detail, rebuild, and, update server - https://review.opendev.org/c/openstack/nova/+/938604/12/nova/api/openstack/compute/views/servers.py#256","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6f8fada2e6b0f0905b4a16d24eb0a6c0e1e5b1db","unresolved":false,"context_lines":[{"line_number":10,"context_line":"associated with a server. This change extends existing Nova\u0027s"},{"line_number":11,"context_line":"API to allow users to retrieve this information when it is available."},{"line_number":12,"context_line":"It adds a new API microversion to support returning the associated"},{"line_number":13,"context_line":"scheduler_hints in both ``GET /servers/{server_id}`` and"},{"line_number":14,"context_line":"``GET /servers/detail`` responses."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint show-scheduler-hints-in-server-details"},{"line_number":17,"context_line":"Change-Id: If0070cfbc218e0515bf3b58fc8c5067ae22c7072"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"e131f89c_fbbc3b56","line":14,"range":{"start_line":13,"start_character":24,"end_line":14,"end_character":34},"in_reply_to":"59e213eb_1ad6e99d","updated":"2025-02-27 18:17:18.000000000","message":"Done.\n\nFixing microversion 2.96 and 2.98 in\n\nhttps://review.opendev.org/c/openstack/nova/+/942875\nhttps://review.opendev.org/c/openstack/nova/+/942878","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"635dbf273e94cbd5f59c10a109bdaeb590fcd841","unresolved":true,"context_lines":[{"line_number":10,"context_line":"associated with a server. This change extends existing Nova\u0027s"},{"line_number":11,"context_line":"API to allow users to retrieve this information when it is available."},{"line_number":12,"context_line":"It adds a new API microversion to support returning the associated"},{"line_number":13,"context_line":"scheduler_hints in both ``GET /servers/{server_id}`` and"},{"line_number":14,"context_line":"``GET /servers/detail`` responses."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint show-scheduler-hints-in-server-details"},{"line_number":17,"context_line":"Change-Id: If0070cfbc218e0515bf3b58fc8c5067ae22c7072"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"59e213eb_1ad6e99d","line":14,"range":{"start_line":13,"start_character":24,"end_line":14,"end_character":34},"in_reply_to":"babd7bb6_6727e29e","updated":"2025-02-26 22:30:58.000000000","message":"ya we missed that for 2,98 and i think 2.96 thanks for calling that out.\n\nfixing the docs and testing of those is out of scope for this change but we proably should do that as a follow up.","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bdaebe8394df3472b6618d07ea5db40b3f373723","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a0e65e2d_092f31a6","updated":"2025-01-29 07:58:54.000000000","message":"Just skimmed the patch. As the rebuild response is changed\n* we need that to be added to the sample tests\n* we need to mention that in the documentation","commit_id":"b83ab1cbe26ac02165c05bb5ae49077ef80596cd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c456647b648b47854a0e047070e07c1f774a9cba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f86ea6e0_7a166df5","updated":"2025-01-16 12:49:47.000000000","message":"That looks good, I just feel like some tests are missings. Currently you just satisfy the API part.\n\nYou can perhaps add tests in:\ntests/functional/tests_servers and assert the output\ntests/units/api/openstack to validate the usage of the new microversion\nYou may also want to assert behavior in unit/compute","commit_id":"b83ab1cbe26ac02165c05bb5ae49077ef80596cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"645179bf4bcd60a47491db624bb4bbc2bea32d50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ce5ccfb2_aa7e8a5a","updated":"2025-01-22 12:36:23.000000000","message":"ill try and get back to this before the end of the week.","commit_id":"b83ab1cbe26ac02165c05bb5ae49077ef80596cd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"d5629d88cd40dd38ad087f84d63eecaebeae1caa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"002bd6de_f3d83d66","updated":"2025-01-15 11:16:41.000000000","message":"recheck\n\none job failed with ssh timemout to a server, doesn\u0027t seems related [1]\n\n[1] https://9c7ec08fe4ed42af1038-c18294dabc353549d102a4106e3e5c6a.ssl.cf5.rackcdn.com/938604/5/check/nova-multi-cell/48f514a/testr_results.html","commit_id":"b83ab1cbe26ac02165c05bb5ae49077ef80596cd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"85bc85c62705325b7ae0fd689d58dc81b530e7f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d907d2ef_f3387733","updated":"2025-01-31 21:34:37.000000000","message":"thank you @gibi and @sahid for your reviews, I added a few more test cases","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a595ff341df0c89bc2be52c3131d7400a47e56c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1567218b_7d0ab367","updated":"2025-02-04 17:53:59.000000000","message":"ty for your reviews","commit_id":"e0ecc0d753ec52680876464e4d7b32eb10f449d8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18d9a2aa76fae459b4a83f421045dba9438fa0b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"db0050f5_f87f4bb2","updated":"2025-02-25 03:42:36.000000000","message":"spice direct has now merged so this will need to be updated to 2.100","commit_id":"3e0e21717c179227c1a7bcf3ae158cf22f4d3319"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a826937d_0a41b503","updated":"2025-02-26 17:39:09.000000000","message":"Thank you for your review sean!","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ad462cf7_0b6a9704","updated":"2025-02-26 16:40:50.000000000","message":"i think this is pretty close.\n\n-1 is because i think the data type is wrong in the api ref.","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25ceb11ebb3795c3ff359af666ffbe8d10c2c6a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"03bfe983_7e8cce32","updated":"2025-02-26 18:02:55.000000000","message":"this is closer some minor nits in the example","commit_id":"0a978a0f17ff6bf9bb4039207244c4365a2068d7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94ad0c8d54d1d43f32d7add8c9560ec31181d570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c605d265_84d43876","updated":"2025-02-26 19:58:13.000000000","message":"we need to mention about update server API also which is also get updated in this change.","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"afe33eb680c7f3cea23144626700017fd5fbba9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a115e009_029b325f","updated":"2025-02-26 18:23:23.000000000","message":"within the limits of my experience with api changes i think this is more or less good at this point pending ci.\n\nso hopefully mel or gmann can take a look and see what i missed.","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"635dbf273e94cbd5f59c10a109bdaeb590fcd841","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d94db440_4f5a1c07","in_reply_to":"c605d265_84d43876","updated":"2025-02-26 22:30:58.000000000","message":"i guess it does because we use the samem respocne as show.\n\nwe didnt document this for 2.98 or 2.96 when we added the image properties or add the pinned az as far as im aware.\n\nIm not disagreeing, just pointing out we have not been consitent with the last few microversions it covering update.","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1d4b1ead011fee1ae62452aec53cd24a282367b2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"97faaa99_81dd3ff6","in_reply_to":"d94db440_4f5a1c07","updated":"2025-02-26 23:44:07.000000000","message":"ok, I have not checked those old microversion but we should keep these 4 APIs response consistent (as we fixed in 2.74). All these 4 APis response are controlled by the views/servers.py so actually we are changing 4 APIs together.","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4f40a806eb825865077565777e5c2fb94d833881","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1b68796c_190ee74b","updated":"2025-02-27 18:34:01.000000000","message":"From etherpad it is not clear to me which Tuesday is deadline https://etherpad.opendev.org/p/nova-2025.1-status#L103\n\nI asked bauzas in IRC and accordingly sean or I can +W here.","commit_id":"2db8af71dd67779295c8d128d4197eba98ed3dae"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"56786c14bf19a293a37b8efe3903154d0fb4332f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"127d4004_717381eb","updated":"2025-02-27 00:30:03.000000000","message":"recheck\n\nmultinode grenade failed on resize_volume_backed_server test, with a ssh timeout, doesn\u0027t look related to this change. Trying again.","commit_id":"2db8af71dd67779295c8d128d4197eba98ed3dae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6f8fada2e6b0f0905b4a16d24eb0a6c0e1e5b1db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8cd5a544_9d0337f2","updated":"2025-02-27 18:17:18.000000000","message":"thanks for updates. lgtm now. Tempest tests verify the response schema for all changed APIs - https://review.opendev.org/c/openstack/tempest/+/939375/4 and test is passing \n- https://zuul.opendev.org/t/openstack/build/80031baee6354207aa883ec6cd499698/log/job-output.txt#24217\n\nI am holding this to approve in case there si something we need for FFE or so.","commit_id":"2db8af71dd67779295c8d128d4197eba98ed3dae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"59973813348894a181f4f652258e8ed3210cfff5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7de65cbf_48864a30","in_reply_to":"1b68796c_190ee74b","updated":"2025-02-27 18:39:30.000000000","message":"Sean confirmed it on IRC about today is feature freeze so it is good to go","commit_id":"2db8af71dd67779295c8d128d4197eba98ed3dae"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[{"line_number":5560,"context_line":"    documentation to know what is available for scheduler hints."},{"line_number":5561,"context_line":"  in: body"},{"line_number":5562,"context_line":"  required: false"},{"line_number":5563,"context_line":"  type: object"},{"line_number":5564,"context_line":"os:scheduler_hints_build_near_host_ip:"},{"line_number":5565,"context_line":"  description: |"},{"line_number":5566,"context_line":"    Schedule the server on a host in the network specified with this parameter"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e9baaf0b_28d47c9b","line":5563,"updated":"2025-02-26 16:40:50.000000000","message":"here its defiend as an object but i am not sure we want to duplciate it","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25ceb11ebb3795c3ff359af666ffbe8d10c2c6a1","unresolved":false,"context_lines":[{"line_number":5560,"context_line":"    documentation to know what is available for scheduler hints."},{"line_number":5561,"context_line":"  in: body"},{"line_number":5562,"context_line":"  required: false"},{"line_number":5563,"context_line":"  type: object"},{"line_number":5564,"context_line":"os:scheduler_hints_build_near_host_ip:"},{"line_number":5565,"context_line":"  description: |"},{"line_number":5566,"context_line":"    Schedule the server on a host in the network specified with this parameter"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f8243ff8_5bc10a75","line":5563,"in_reply_to":"55b99c1c_3f2f692f","updated":"2025-02-26 18:02:55.000000000","message":"Acknowledged","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":true,"context_lines":[{"line_number":5560,"context_line":"    documentation to know what is available for scheduler hints."},{"line_number":5561,"context_line":"  in: body"},{"line_number":5562,"context_line":"  required: false"},{"line_number":5563,"context_line":"  type: object"},{"line_number":5564,"context_line":"os:scheduler_hints_build_near_host_ip:"},{"line_number":5565,"context_line":"  description: |"},{"line_number":5566,"context_line":"    Schedule the server on a host in the network specified with this parameter"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"55b99c1c_3f2f692f","line":5563,"in_reply_to":"e9baaf0b_28d47c9b","updated":"2025-02-26 17:39:09.000000000","message":"yeah, I decided to create another one because this description was built for server creation. Not sure if makes sense the response too.","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[{"line_number":6132,"context_line":"    The dictionary of hints sent to the scheduler during server"},{"line_number":6133,"context_line":"    creation time."},{"line_number":6134,"context_line":"  in: body"},{"line_number":6135,"context_line":"  required: true"},{"line_number":6136,"context_line":"  type: array"},{"line_number":6137,"context_line":"  min_version: 2.100"},{"line_number":6138,"context_line":"secgroup_default_rule_id:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"28c4e5c3_7b2386ca","line":6135,"updated":"2025-02-26 16:40:50.000000000","message":"So this means that as of 2.100 this will always be present\nwhich I guess means it will be an empty dict if the instance has no hints.","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":true,"context_lines":[{"line_number":6132,"context_line":"    The dictionary of hints sent to the scheduler during server"},{"line_number":6133,"context_line":"    creation time."},{"line_number":6134,"context_line":"  in: body"},{"line_number":6135,"context_line":"  required: true"},{"line_number":6136,"context_line":"  type: array"},{"line_number":6137,"context_line":"  min_version: 2.100"},{"line_number":6138,"context_line":"secgroup_default_rule_id:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"97f245bd_024cac92","line":6135,"in_reply_to":"28c4e5c3_7b2386ca","updated":"2025-02-26 17:39:09.000000000","message":"correct, it will return an empty dict","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09b57dbd8d1d7fdb30a1b23f41323ecd06ce49d5","unresolved":false,"context_lines":[{"line_number":6132,"context_line":"    The dictionary of hints sent to the scheduler during server"},{"line_number":6133,"context_line":"    creation time."},{"line_number":6134,"context_line":"  in: body"},{"line_number":6135,"context_line":"  required: true"},{"line_number":6136,"context_line":"  type: array"},{"line_number":6137,"context_line":"  min_version: 2.100"},{"line_number":6138,"context_line":"secgroup_default_rule_id:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"830554dd_12679e1e","line":6135,"in_reply_to":"97f245bd_024cac92","updated":"2025-02-26 17:59:08.000000000","message":"Acknowledged","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[{"line_number":6133,"context_line":"    creation time."},{"line_number":6134,"context_line":"  in: body"},{"line_number":6135,"context_line":"  required: true"},{"line_number":6136,"context_line":"  type: array"},{"line_number":6137,"context_line":"  min_version: 2.100"},{"line_number":6138,"context_line":"secgroup_default_rule_id:"},{"line_number":6139,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"11128c16_49f9578e","line":6136,"range":{"start_line":6136,"start_character":8,"end_line":6136,"end_character":13},"updated":"2025-02-26 16:40:50.000000000","message":"however this should then be\n\n\"type: dict\"\n\nso will this be an array or a dict\n\nwe shoudl make the description consistent with the data type","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"65ee219f578efa3671ff75f0cfb60328497b2cd6","unresolved":true,"context_lines":[{"line_number":6133,"context_line":"    creation time."},{"line_number":6134,"context_line":"  in: body"},{"line_number":6135,"context_line":"  required: true"},{"line_number":6136,"context_line":"  type: array"},{"line_number":6137,"context_line":"  min_version: 2.100"},{"line_number":6138,"context_line":"secgroup_default_rule_id:"},{"line_number":6139,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4b3b1ff2_94e193bc","line":6136,"range":{"start_line":6136,"start_character":8,"end_line":6136,"end_character":13},"in_reply_to":"11128c16_49f9578e","updated":"2025-02-26 16:51:42.000000000","message":"chatting to @stephenfin@redhat.com it seam that either `type: dict` or `type: object` will work here but object woudl be prefered.","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":true,"context_lines":[{"line_number":6133,"context_line":"    creation time."},{"line_number":6134,"context_line":"  in: body"},{"line_number":6135,"context_line":"  required: true"},{"line_number":6136,"context_line":"  type: array"},{"line_number":6137,"context_line":"  min_version: 2.100"},{"line_number":6138,"context_line":"secgroup_default_rule_id:"},{"line_number":6139,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6ea9743f_2047a823","line":6136,"range":{"start_line":6136,"start_character":8,"end_line":6136,"end_character":13},"in_reply_to":"4b3b1ff2_94e193bc","updated":"2025-02-26 17:39:09.000000000","message":"ack, updating in the next PS, thanks!","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25ceb11ebb3795c3ff359af666ffbe8d10c2c6a1","unresolved":false,"context_lines":[{"line_number":6133,"context_line":"    creation time."},{"line_number":6134,"context_line":"  in: body"},{"line_number":6135,"context_line":"  required: true"},{"line_number":6136,"context_line":"  type: array"},{"line_number":6137,"context_line":"  min_version: 2.100"},{"line_number":6138,"context_line":"secgroup_default_rule_id:"},{"line_number":6139,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"59398765_b39a4ad8","line":6136,"range":{"start_line":6136,"start_character":8,"end_line":6136,"end_character":13},"in_reply_to":"6ea9743f_2047a823","updated":"2025-02-26 18:02:55.000000000","message":"Done","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"}],"doc/api_samples/servers/v2.100/server-action-rebuild-resp.json":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        \"os-extended-volumes:volumes_attached\": [],"},{"line_number":76,"context_line":"        \"progress\": 0,"},{"line_number":77,"context_line":"        \"pinned_availability_zone\": \"us-west\","},{"line_number":78,"context_line":"        \"scheduler_hints\": {},"},{"line_number":79,"context_line":"        \"security_groups\": ["},{"line_number":80,"context_line":"            {"},{"line_number":81,"context_line":"                \"name\": \"default\""}],"source_content_type":"application/json","patch_set":10,"id":"beb49950_12f849fe","line":78,"updated":"2025-02-26 16:40:50.000000000","message":"here its expressed as a a json object which maps to a dict or object so i think that the type is just incorrect in the api ref.","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        \"os-extended-volumes:volumes_attached\": [],"},{"line_number":76,"context_line":"        \"progress\": 0,"},{"line_number":77,"context_line":"        \"pinned_availability_zone\": \"us-west\","},{"line_number":78,"context_line":"        \"scheduler_hints\": {},"},{"line_number":79,"context_line":"        \"security_groups\": ["},{"line_number":80,"context_line":"            {"},{"line_number":81,"context_line":"                \"name\": \"default\""}],"source_content_type":"application/json","patch_set":10,"id":"d9c1dca0_d6a49f8d","line":78,"in_reply_to":"beb49950_12f849fe","updated":"2025-02-26 17:39:09.000000000","message":"ack, updating to object.","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09b57dbd8d1d7fdb30a1b23f41323ecd06ce49d5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \"os-extended-volumes:volumes_attached\": [],"},{"line_number":76,"context_line":"        \"progress\": 0,"},{"line_number":77,"context_line":"        \"pinned_availability_zone\": \"us-west\","},{"line_number":78,"context_line":"        \"scheduler_hints\": {},"},{"line_number":79,"context_line":"        \"security_groups\": ["},{"line_number":80,"context_line":"            {"},{"line_number":81,"context_line":"                \"name\": \"default\""}],"source_content_type":"application/json","patch_set":10,"id":"d7b695c0_b8be9a77","line":78,"in_reply_to":"d9c1dca0_d6a49f8d","updated":"2025-02-26 17:59:08.000000000","message":"Done","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"}],"doc/api_samples/servers/v2.100/server-get-resp.json":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09b57dbd8d1d7fdb30a1b23f41323ecd06ce49d5","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        \"progress\": 0,"},{"line_number":80,"context_line":"        \"scheduler_hints\": {"},{"line_number":81,"context_line":"            \"same_host\": ["},{"line_number":82,"context_line":"                \"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\""},{"line_number":83,"context_line":"            ]"},{"line_number":84,"context_line":"        },"},{"line_number":85,"context_line":"        \"security_groups\": ["}],"source_content_type":"application/json","patch_set":11,"id":"ef050bc7_945bc1d4","line":82,"updated":"2025-02-26 17:59:08.000000000","message":"we chatted on irc this woud lideealy be \"48e6a9f6-30af-47e0-bc04-acaed113bb4e\"\n\nor an actul uuid","commit_id":"0a978a0f17ff6bf9bb4039207244c4365a2068d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"afe33eb680c7f3cea23144626700017fd5fbba9b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"progress\": 0,"},{"line_number":80,"context_line":"        \"scheduler_hints\": {"},{"line_number":81,"context_line":"            \"same_host\": ["},{"line_number":82,"context_line":"                \"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\""},{"line_number":83,"context_line":"            ]"},{"line_number":84,"context_line":"        },"},{"line_number":85,"context_line":"        \"security_groups\": ["}],"source_content_type":"application/json","patch_set":11,"id":"6ef0a588_62c975d9","line":82,"in_reply_to":"ef050bc7_945bc1d4","updated":"2025-02-26 18:23:23.000000000","message":"Done","commit_id":"0a978a0f17ff6bf9bb4039207244c4365a2068d7"}],"doc/api_samples/servers/v2.100/servers-details-resp.json":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[{"line_number":78,"context_line":"            \"OS-SRV-USG:terminated_at\": null,"},{"line_number":79,"context_line":"            \"pinned_availability_zone\": \"us-west\","},{"line_number":80,"context_line":"            \"progress\": 0,"},{"line_number":81,"context_line":"            \"scheduler_hints\": {},"},{"line_number":82,"context_line":"            \"security_groups\": ["},{"line_number":83,"context_line":"                {"},{"line_number":84,"context_line":"                    \"name\": \"default\""}],"source_content_type":"application/json","patch_set":10,"id":"68257b1c_e9a576d1","line":81,"updated":"2025-02-26 16:40:50.000000000","message":"it would be nice to actually show and example of schduler hint in the responce\nin the docs rather then just empty.","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":true,"context_lines":[{"line_number":78,"context_line":"            \"OS-SRV-USG:terminated_at\": null,"},{"line_number":79,"context_line":"            \"pinned_availability_zone\": \"us-west\","},{"line_number":80,"context_line":"            \"progress\": 0,"},{"line_number":81,"context_line":"            \"scheduler_hints\": {},"},{"line_number":82,"context_line":"            \"security_groups\": ["},{"line_number":83,"context_line":"                {"},{"line_number":84,"context_line":"                    \"name\": \"default\""}],"source_content_type":"application/json","patch_set":10,"id":"980c2c78_3aa8487f","line":81,"in_reply_to":"68257b1c_e9a576d1","updated":"2025-02-26 17:39:09.000000000","message":"I have it working now with a example, going to propose it.","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25ceb11ebb3795c3ff359af666ffbe8d10c2c6a1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \"OS-SRV-USG:terminated_at\": null,"},{"line_number":79,"context_line":"            \"pinned_availability_zone\": \"us-west\","},{"line_number":80,"context_line":"            \"progress\": 0,"},{"line_number":81,"context_line":"            \"scheduler_hints\": {},"},{"line_number":82,"context_line":"            \"security_groups\": ["},{"line_number":83,"context_line":"                {"},{"line_number":84,"context_line":"                    \"name\": \"default\""}],"source_content_type":"application/json","patch_set":10,"id":"b3a34db4_a1bb8d60","line":81,"in_reply_to":"980c2c78_3aa8487f","updated":"2025-02-26 18:02:55.000000000","message":"Acknowledged","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25ceb11ebb3795c3ff359af666ffbe8d10c2c6a1","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            \"progress\": 0,"},{"line_number":81,"context_line":"            \"scheduler_hints\": {"},{"line_number":82,"context_line":"                \"same_host\": ["},{"line_number":83,"context_line":"                    \"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\""},{"line_number":84,"context_line":"                ]"},{"line_number":85,"context_line":"            },"},{"line_number":86,"context_line":"            \"security_groups\": ["}],"source_content_type":"application/json","patch_set":11,"id":"1cd0f160_34c2d3f1","line":83,"updated":"2025-02-26 18:02:55.000000000","message":"same comment here","commit_id":"0a978a0f17ff6bf9bb4039207244c4365a2068d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"afe33eb680c7f3cea23144626700017fd5fbba9b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \"progress\": 0,"},{"line_number":81,"context_line":"            \"scheduler_hints\": {"},{"line_number":82,"context_line":"                \"same_host\": ["},{"line_number":83,"context_line":"                    \"[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\""},{"line_number":84,"context_line":"                ]"},{"line_number":85,"context_line":"            },"},{"line_number":86,"context_line":"            \"security_groups\": ["}],"source_content_type":"application/json","patch_set":11,"id":"9f9c504c_ee548f6d","line":83,"in_reply_to":"1cd0f160_34c2d3f1","updated":"2025-02-26 18:23:23.000000000","message":"Done","commit_id":"0a978a0f17ff6bf9bb4039207244c4365a2068d7"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[{"line_number":271,"context_line":"    * 2.99 - Add the spice-direct console type to the spice console protocol."},{"line_number":272,"context_line":"    * 2.100 - Add support for returning associated scheduler_hints in"},{"line_number":273,"context_line":"             ``GET /servers/{server_id}`` and ``GET /servers/detail``"},{"line_number":274,"context_line":"             responses."},{"line_number":275,"context_line":"\"\"\""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":10,"id":"f7e2cdfe_ad35a722","line":274,"updated":"2025-02-26 16:40:50.000000000","message":"nit: and rebuild","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    * 2.99 - Add the spice-direct console type to the spice console protocol."},{"line_number":272,"context_line":"    * 2.100 - Add support for returning associated scheduler_hints in"},{"line_number":273,"context_line":"             ``GET /servers/{server_id}`` and ``GET /servers/detail``"},{"line_number":274,"context_line":"             responses."},{"line_number":275,"context_line":"\"\"\""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":10,"id":"cc21da4e_ac877b10","line":274,"in_reply_to":"f7e2cdfe_ad35a722","updated":"2025-02-26 17:39:09.000000000","message":"Done","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[{"line_number":1295,"context_line":"-----------------------------------------------------"},{"line_number":1296,"context_line":""},{"line_number":1297,"context_line":"The ``GET /servers/{server_id}`` and ``GET /servers/detail`` responses now include the"},{"line_number":1298,"context_line":"scheduler hints provided during server creation."},{"line_number":1299,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"807817cd_0b5f1504","line":1298,"updated":"2025-02-26 16:40:50.000000000","message":"nit: and rebuild","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"-----------------------------------------------------"},{"line_number":1296,"context_line":""},{"line_number":1297,"context_line":"The ``GET /servers/{server_id}`` and ``GET /servers/detail`` responses now include the"},{"line_number":1298,"context_line":"scheduler hints provided during server creation."},{"line_number":1299,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"8e021e86_d9ff09d9","line":1298,"in_reply_to":"807817cd_0b5f1504","updated":"2025-02-26 17:39:09.000000000","message":"Done","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ac19b018ed66eabfb9b7c3c3f4afdf3be0d4b9b2","unresolved":true,"context_lines":[{"line_number":1189,"context_line":"        schema.rebuild_response_v275, \u00272.75\u0027, \u00272.95\u0027)"},{"line_number":1190,"context_line":"    @validation.response_body_schema("},{"line_number":1191,"context_line":"        schema.rebuild_response_v296, \u00272.96\u0027, \u00272.97\u0027)"},{"line_number":1192,"context_line":"    @validation.response_body_schema("},{"line_number":1193,"context_line":"        schema.rebuild_response_v298, \u00272.98\u0027)"},{"line_number":1194,"context_line":"    def _action_rebuild(self, req, id, body):"},{"line_number":1195,"context_line":"        \"\"\"Rebuild an instance with the given attributes.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9651e390_95dd4372","line":1192,"updated":"2025-01-14 19:40:03.000000000","message":"for now, this is the only place that already has response schema validation and is affected by the scheduler_hints addition in GET /server response.\nPlease see more discussions about validating (or not) the scheduler_hints schema in: https://review.opendev.org/c/openstack/nova-specs/+/936140","commit_id":"ed734f17684a151fbfcd379f6406c97bcc11e930"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18d9a2aa76fae459b4a83f421045dba9438fa0b9","unresolved":true,"context_lines":[{"line_number":1189,"context_line":"        schema.rebuild_response_v275, \u00272.75\u0027, \u00272.95\u0027)"},{"line_number":1190,"context_line":"    @validation.response_body_schema("},{"line_number":1191,"context_line":"        schema.rebuild_response_v296, \u00272.96\u0027, \u00272.97\u0027)"},{"line_number":1192,"context_line":"    @validation.response_body_schema("},{"line_number":1193,"context_line":"        schema.rebuild_response_v298, \u00272.98\u0027)"},{"line_number":1194,"context_line":"    def _action_rebuild(self, req, id, body):"},{"line_number":1195,"context_line":"        \"\"\"Rebuild an instance with the given attributes.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"e756b315_bd4cd184","line":1192,"in_reply_to":"9651e390_95dd4372","updated":"2025-02-25 03:42:36.000000000","message":"ya stephen has not written the server show/detail list verions yet so this is out of scope fo this chagne to adress.","commit_id":"ed734f17684a151fbfcd379f6406c97bcc11e930"}],"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"edc5d142e3f27514eef346c563a9d5c29242657c","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        elif req_spec is not None:"},{"line_number":227,"context_line":"            pinned_az \u003d req_spec.availability_zone"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            pinned_az \u003d \u0027\u0027"},{"line_number":230,"context_line":"        return pinned_az"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _get_req_spec_obj(self, context, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"01b1ec29_a80db314","line":229,"updated":"2025-02-03 01:50:15.000000000","message":"One more small point. This if-block changes response body value type basing on instance situation.\n\n- instance with pinned_az info: AZ string\n- instance without pinned_az but request_spec exists: `null` (None)\n- request_spec doesn\u0027t exist: `\u0027\u0027` (empty string)","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e210d54d04335b0a63244e69e9c7b422c0f1b7c8","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        elif req_spec is not None:"},{"line_number":227,"context_line":"            pinned_az \u003d req_spec.availability_zone"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            pinned_az \u003d \u0027\u0027"},{"line_number":230,"context_line":"        return pinned_az"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _get_req_spec_obj(self, context, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"770f230e_5df615f0","line":229,"in_reply_to":"01b1ec29_a80db314","updated":"2025-02-03 13:54:13.000000000","message":"if provided_az is None and req_spec is not None, it will get the availability from the req_spec.availability_zone as in previous implemented way.\nthe difference here is that the db request is outside this method.","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a595ff341df0c89bc2be52c3131d7400a47e56c9","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        elif req_spec is not None:"},{"line_number":227,"context_line":"            pinned_az \u003d req_spec.availability_zone"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            pinned_az \u003d \u0027\u0027"},{"line_number":230,"context_line":"        return pinned_az"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _get_req_spec_obj(self, context, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"8d21a0fb_00fa9f25","line":229,"in_reply_to":"082133ff_2425c246","updated":"2025-02-04 17:53:59.000000000","message":"reworked the code to not touch pinned_az parts, and also following the same idea from [1] and removed the usage of `defaultdict`.\n\n[1] https://review.opendev.org/c/openstack/nova/+/939658","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d565a12b8426cf4d5a17f7fd380c114d7663d8ec","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        elif req_spec is not None:"},{"line_number":227,"context_line":"            pinned_az \u003d req_spec.availability_zone"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            pinned_az \u003d \u0027\u0027"},{"line_number":230,"context_line":"        return pinned_az"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _get_req_spec_obj(self, context, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"cddc0f78_3c1f1251","line":229,"in_reply_to":"770f230e_5df615f0","updated":"2025-02-04 00:02:37.000000000","message":"there is a diffent patch changing _get_pinned_az as part of a bug fix.\n\nthis change should not be modifyint this function.","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"afe33eb680c7f3cea23144626700017fd5fbba9b","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        elif req_spec is not None:"},{"line_number":227,"context_line":"            pinned_az \u003d req_spec.availability_zone"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            pinned_az \u003d \u0027\u0027"},{"line_number":230,"context_line":"        return pinned_az"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _get_req_spec_obj(self, context, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"21c6adca_1d398c18","line":229,"in_reply_to":"8d21a0fb_00fa9f25","updated":"2025-02-26 18:23:23.000000000","message":"Acknowledged","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2d422488900367edbd777d3bb4d24d4897eebb60","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        elif req_spec is not None:"},{"line_number":227,"context_line":"            pinned_az \u003d req_spec.availability_zone"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            pinned_az \u003d \u0027\u0027"},{"line_number":230,"context_line":"        return pinned_az"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _get_req_spec_obj(self, context, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"082133ff_2425c246","line":229,"in_reply_to":"aa9c93b5_53782109","updated":"2025-02-04 11:30:49.000000000","message":"yes, I was trying to avoid 2 db calls here to get the req_spec obj, that\u0027s why it was changed, but I can change the code to not touch this part, and avoid conflict","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95aebe95d3c5d7196a8a965c7745d2dcacd75e4b","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        elif req_spec is not None:"},{"line_number":227,"context_line":"            pinned_az \u003d req_spec.availability_zone"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            pinned_az \u003d \u0027\u0027"},{"line_number":230,"context_line":"        return pinned_az"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _get_req_spec_obj(self, context, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"aa9c93b5_53782109","line":229,"in_reply_to":"cddc0f78_3c1f1251","updated":"2025-02-04 00:04:28.000000000","message":"https://review.opendev.org/c/openstack/nova/+/939658\n\nwe will want to backprot ^ to adress the issue on older releases.\n\nwe cannot back this patch as it makeing other api chagnes so this pacth cshoudl avoid alterign the behvior fo _get_pinned_az","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"5d3f3c5a9c2f9fda1fe6695b3450c33e9b9a28ea","unresolved":true,"context_lines":[{"line_number":243,"context_line":"             show_keypair\u003dTrue, show_srv_usg\u003dTrue, show_sec_grp\u003dTrue,"},{"line_number":244,"context_line":"             show_extended_status\u003dTrue, show_extended_volumes\u003dTrue,"},{"line_number":245,"context_line":"             bdms\u003dNone, cell_down_support\u003dFalse, show_server_groups\u003dFalse,"},{"line_number":246,"context_line":"             show_user_data\u003dTrue, provided_az\u003dNone, req_spec\u003dNone):"},{"line_number":247,"context_line":"        \"\"\"Detailed view of a single instance.\"\"\""},{"line_number":248,"context_line":"        if show_extra_specs is None:"},{"line_number":249,"context_line":"            # detail will pre-calculate this for us. If we\u0027re doing show,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d2f3dde7_f444e291","line":246,"updated":"2025-02-02 08:50:57.000000000","message":"This is minor question, but is it required to pass both `provided_az` and `req_spec`?  IIUC, source of the `provided_az` is request_spec so it can be merged to one method argument, `req_spec`.","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"afe33eb680c7f3cea23144626700017fd5fbba9b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"             show_keypair\u003dTrue, show_srv_usg\u003dTrue, show_sec_grp\u003dTrue,"},{"line_number":244,"context_line":"             show_extended_status\u003dTrue, show_extended_volumes\u003dTrue,"},{"line_number":245,"context_line":"             bdms\u003dNone, cell_down_support\u003dFalse, show_server_groups\u003dFalse,"},{"line_number":246,"context_line":"             show_user_data\u003dTrue, provided_az\u003dNone, req_spec\u003dNone):"},{"line_number":247,"context_line":"        \"\"\"Detailed view of a single instance.\"\"\""},{"line_number":248,"context_line":"        if show_extra_specs is None:"},{"line_number":249,"context_line":"            # detail will pre-calculate this for us. If we\u0027re doing show,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f496177_f6bc9476","line":246,"in_reply_to":"adcaa735_7e41da17","updated":"2025-02-26 18:23:23.000000000","message":"Acknowledged","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e210d54d04335b0a63244e69e9c7b422c0f1b7c8","unresolved":true,"context_lines":[{"line_number":243,"context_line":"             show_keypair\u003dTrue, show_srv_usg\u003dTrue, show_sec_grp\u003dTrue,"},{"line_number":244,"context_line":"             show_extended_status\u003dTrue, show_extended_volumes\u003dTrue,"},{"line_number":245,"context_line":"             bdms\u003dNone, cell_down_support\u003dFalse, show_server_groups\u003dFalse,"},{"line_number":246,"context_line":"             show_user_data\u003dTrue, provided_az\u003dNone, req_spec\u003dNone):"},{"line_number":247,"context_line":"        \"\"\"Detailed view of a single instance.\"\"\""},{"line_number":248,"context_line":"        if show_extra_specs is None:"},{"line_number":249,"context_line":"            # detail will pre-calculate this for us. If we\u0027re doing show,"}],"source_content_type":"text/x-python","patch_set":6,"id":"adcaa735_7e41da17","line":246,"in_reply_to":"d2f3dde7_f444e291","updated":"2025-02-03 13:54:13.000000000","message":"they could be merged, but it would change code in more places. Instead, this change is adding the req_spec as optional parameter, which defaults to None, which make easier to integrate in the existing code.\nBut I am open to more opinions on that, tks for raising that point.","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"5d3f3c5a9c2f9fda1fe6695b3450c33e9b9a28ea","unresolved":true,"context_lines":[{"line_number":540,"context_line":"                    context, instance_uuids)"},{"line_number":541,"context_line":"            azs_dict \u003d {req.instance_uuid: req.availability_zone"},{"line_number":542,"context_line":"                              for req in req_specs}"},{"line_number":543,"context_line":"            req_specs_dict \u003d {req.instance_uuid: req for req in req_specs}"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        server_list \u003d [func(request, server,"},{"line_number":546,"context_line":"                            show_extra_specs\u003dshow_extra_specs,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0ec9bbad_9a4a5763","line":543,"updated":"2025-02-02 08:50:57.000000000","message":"This line replaces the `req_specs_dict` collection.defaultdict with dict object. If no request_spec object instance exists at least one instance, the `_list_view` raises `KeyError` exception and it causes 500 Internal Server Error at L552.\n\nOne typical use case of no request_spec situation is one request exceeds Quota limit and the instance gets ERROR.\n\n```\nreq_spec\u003dreq_specs_dict[server.uuid])[\"server\"]\n^^^^\nThis line raises the KeyError if no request_spec object is there because it\u0027s dict object.\n```","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e210d54d04335b0a63244e69e9c7b422c0f1b7c8","unresolved":true,"context_lines":[{"line_number":540,"context_line":"                    context, instance_uuids)"},{"line_number":541,"context_line":"            azs_dict \u003d {req.instance_uuid: req.availability_zone"},{"line_number":542,"context_line":"                              for req in req_specs}"},{"line_number":543,"context_line":"            req_specs_dict \u003d {req.instance_uuid: req for req in req_specs}"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        server_list \u003d [func(request, server,"},{"line_number":546,"context_line":"                            show_extra_specs\u003dshow_extra_specs,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4b39be50_ee39e7e7","line":543,"in_reply_to":"0ec9bbad_9a4a5763","updated":"2025-02-03 13:54:13.000000000","message":"This is not going to happen, because the `req_specs_dict` is a `collections.defaultdict` with default factory set to None. Meaning that if the key does not exists, it will return a \u0027None\u0027 value [1].\n\n[1] https://docs.python.org/3/library/collections.html#collections.defaultdict","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a595ff341df0c89bc2be52c3131d7400a47e56c9","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                    context, instance_uuids)"},{"line_number":541,"context_line":"            azs_dict \u003d {req.instance_uuid: req.availability_zone"},{"line_number":542,"context_line":"                              for req in req_specs}"},{"line_number":543,"context_line":"            req_specs_dict \u003d {req.instance_uuid: req for req in req_specs}"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        server_list \u003d [func(request, server,"},{"line_number":546,"context_line":"                            show_extra_specs\u003dshow_extra_specs,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d2097be2_9a8624a1","line":543,"in_reply_to":"4b39be50_ee39e7e7","updated":"2025-02-04 17:53:59.000000000","message":"The code is now changed to not use `defaultdict` to be in sync with [1] which should also merge as per Sean\u0027s comments.\nNow I see that the issue is really on re-defining the var with a regular dict. Thanks for raising this issue here.\n\n[1] https://review.opendev.org/c/openstack/nova/+/939658","commit_id":"1aecbe0a03c49570bdee4e283a059e3c7e047bf2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0c2689a59c9e823e44f5382e9c29cf5849b4c8ca","unresolved":true,"context_lines":[{"line_number":563,"context_line":"                 show_sec_grp\u003dshow_sec_grp, bdms\u003dbdms,"},{"line_number":564,"context_line":"                 cell_down_support\u003dcell_down_support,"},{"line_number":565,"context_line":"                 provided_az\u003dreq_specs_dict[server.uuid],"},{"line_number":566,"context_line":"                 provided_sched_hints\u003dsched_hints_dict.get(server.uuid, False)"},{"line_number":567,"context_line":"                 )[\"server\"]"},{"line_number":568,"context_line":"            for server in servers"},{"line_number":569,"context_line":"            # Filter out the fake marker instance created by the"}],"source_content_type":"text/x-python","patch_set":10,"id":"96ddae71_9cfa8595","line":566,"range":{"start_line":566,"start_character":72,"end_line":566,"end_character":77},"updated":"2025-02-26 16:40:50.000000000","message":"Using false as a sentinel for not set is not a good pattern to follow.\nHere you can use None or follow the sentinel object pattern.\n\nsee the chagnes in https://review.opendev.org/c/openstack/nova/+/939658/7/nova/api/openstack/compute/views/servers.py","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"faeb828f748fe534f1cfb7aad300483262fb8c2c","unresolved":true,"context_lines":[{"line_number":563,"context_line":"                 show_sec_grp\u003dshow_sec_grp, bdms\u003dbdms,"},{"line_number":564,"context_line":"                 cell_down_support\u003dcell_down_support,"},{"line_number":565,"context_line":"                 provided_az\u003dreq_specs_dict[server.uuid],"},{"line_number":566,"context_line":"                 provided_sched_hints\u003dsched_hints_dict.get(server.uuid, False)"},{"line_number":567,"context_line":"                 )[\"server\"]"},{"line_number":568,"context_line":"            for server in servers"},{"line_number":569,"context_line":"            # Filter out the fake marker instance created by the"}],"source_content_type":"text/x-python","patch_set":10,"id":"a264b129_cb95c9a6","line":566,"range":{"start_line":566,"start_character":72,"end_line":566,"end_character":77},"in_reply_to":"96ddae71_9cfa8595","updated":"2025-02-26 17:39:09.000000000","message":"ack, going to fix it. thanks","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25ceb11ebb3795c3ff359af666ffbe8d10c2c6a1","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                 show_sec_grp\u003dshow_sec_grp, bdms\u003dbdms,"},{"line_number":564,"context_line":"                 cell_down_support\u003dcell_down_support,"},{"line_number":565,"context_line":"                 provided_az\u003dreq_specs_dict[server.uuid],"},{"line_number":566,"context_line":"                 provided_sched_hints\u003dsched_hints_dict.get(server.uuid, False)"},{"line_number":567,"context_line":"                 )[\"server\"]"},{"line_number":568,"context_line":"            for server in servers"},{"line_number":569,"context_line":"            # Filter out the fake marker instance created by the"}],"source_content_type":"text/x-python","patch_set":10,"id":"1344087f_db77b838","line":566,"range":{"start_line":566,"start_character":72,"end_line":566,"end_character":77},"in_reply_to":"a264b129_cb95c9a6","updated":"2025-02-26 18:02:55.000000000","message":"Done","commit_id":"87fc69db54820a23bd9e1a6325ebc98c656a8ad1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25ceb11ebb3795c3ff359af666ffbe8d10c2c6a1","unresolved":true,"context_lines":[{"line_number":240,"context_line":"    def _get_scheduler_hints(self, context, instance, provided_sched_hints):"},{"line_number":241,"context_line":"        if provided_sched_hints is SCHED_HINTS_NOT_IN_REQUEST_SPEC:"},{"line_number":242,"context_line":"            # Case where it was pre fetched, but not specified"},{"line_number":243,"context_line":"            sched_hints \u003d None"},{"line_number":244,"context_line":"        elif provided_sched_hints is not None:"},{"line_number":245,"context_line":"            sched_hints \u003d provided_sched_hints"},{"line_number":246,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"46e58655_72ac62d1","line":243,"range":{"start_line":243,"start_character":26,"end_line":243,"end_character":30},"updated":"2025-02-26 18:02:55.000000000","message":"should we be returning {} here","commit_id":"0a978a0f17ff6bf9bb4039207244c4365a2068d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25ceb11ebb3795c3ff359af666ffbe8d10c2c6a1","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                        context, instance.uuid)"},{"line_number":251,"context_line":"                sched_hints \u003d req_spec.scheduler_hints"},{"line_number":252,"context_line":"            except exception.RequestSpecNotFound:"},{"line_number":253,"context_line":"                sched_hints \u003d {}"},{"line_number":254,"context_line":"        return sched_hints"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def show(self, request, instance, extend_address\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":11,"id":"c247e319_9589715d","line":253,"updated":"2025-02-26 18:02:55.000000000","message":"to align to this.","commit_id":"0a978a0f17ff6bf9bb4039207244c4365a2068d7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94ad0c8d54d1d43f32d7add8c9560ec31181d570","unresolved":true,"context_lines":[{"line_number":253,"context_line":"                sched_hints \u003d {}"},{"line_number":254,"context_line":"        return sched_hints"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def show(self, request, instance, extend_address\u003dTrue,"},{"line_number":257,"context_line":"             show_extra_specs\u003dNone, show_AZ\u003dTrue, show_config_drive\u003dTrue,"},{"line_number":258,"context_line":"             show_extended_attr\u003dNone, show_host_status\u003dNone,"},{"line_number":259,"context_line":"             show_keypair\u003dTrue, show_srv_usg\u003dTrue, show_sec_grp\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ac132b55_8e4990c3","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":58},"updated":"2025-02-26 19:58:13.000000000","message":"just to note, along with GET and rebuild, this change also also return the sch hint in update server API also\n\n- https://github.com/openstack/nova/blob/8f57fa7359d57e186fc6b75424b4900dc63c564f/nova/api/openstack/compute/servers.py#L962\n\nWhich is correct things as we need to keep GET, GET detail, rebuild, and PUT server APIS response consistent. We fixed it in past with microversion 2.74[1] but we should update the documentation/release notes/tests also for that.\n\n[1] https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id68","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6f8fada2e6b0f0905b4a16d24eb0a6c0e1e5b1db","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                sched_hints \u003d {}"},{"line_number":254,"context_line":"        return sched_hints"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def show(self, request, instance, extend_address\u003dTrue,"},{"line_number":257,"context_line":"             show_extra_specs\u003dNone, show_AZ\u003dTrue, show_config_drive\u003dTrue,"},{"line_number":258,"context_line":"             show_extended_attr\u003dNone, show_host_status\u003dNone,"},{"line_number":259,"context_line":"             show_keypair\u003dTrue, show_srv_usg\u003dTrue, show_sec_grp\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":12,"id":"98e9754d_5063ea11","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":58},"in_reply_to":"ac132b55_8e4990c3","updated":"2025-02-27 18:17:18.000000000","message":"Done","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"}],"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94ad0c8d54d1d43f32d7add8c9560ec31181d570","unresolved":true,"context_lines":[{"line_number":662,"context_line":"        )"},{"line_number":663,"context_line":"        subs \u003d params.copy()"},{"line_number":664,"context_line":"        del subs[\u0027uuid\u0027]"},{"line_number":665,"context_line":"        self._verify_response(\u0027server-action-rebuild-resp\u0027, subs, resp, 202)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"class ServersUpdateSampleJsonTest(ServersSampleBase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"52f69b6f_3eab5685","line":665,"range":{"start_line":665,"start_character":75,"end_line":665,"end_character":76},"updated":"2025-02-26 19:58:13.000000000","message":"As this API change update the PUT server API also (please see my comment in views/servers.py file[1]), we should add the update server test also and accordingly we will have update server API updated documentation in api-ref too.\n\n[1] https://review.opendev.org/c/openstack/nova/+/938604/12/nova/api/openstack/compute/views/servers.py#256","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"635dbf273e94cbd5f59c10a109bdaeb590fcd841","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        )"},{"line_number":663,"context_line":"        subs \u003d params.copy()"},{"line_number":664,"context_line":"        del subs[\u0027uuid\u0027]"},{"line_number":665,"context_line":"        self._verify_response(\u0027server-action-rebuild-resp\u0027, subs, resp, 202)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"class ServersUpdateSampleJsonTest(ServersSampleBase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"262f8081_732cfd4f","line":665,"range":{"start_line":665,"start_character":75,"end_line":665,"end_character":76},"in_reply_to":"52f69b6f_3eab5685","updated":"2025-02-26 22:30:58.000000000","message":"Done","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"}],"releasenotes/notes/bp-show-sched-hints-server-details-22bc15d5ea81e43a.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94ad0c8d54d1d43f32d7add8c9560ec31181d570","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new microversion has been added that allows users to retrieve"},{"line_number":5,"context_line":"    server\u0027s associated scheduler hints in ``GET /servers/{server_id}``"},{"line_number":6,"context_line":"    and ``GET /servers/detail`` responses."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9901c66e_1441575c","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":33},"updated":"2025-02-26 19:58:13.000000000","message":"This change return the sch hint in rebuild as well as PUT server API response (comment in views/servers.py [1]) also\n\n ... ``GET /servers/{server_id}``\n    and ``GET /servers/detail``, ``PUT /servers/{server_id}``, and ``POST /servers/{server_id}/action {rebuild}`` responses.\n    \n[1] https://review.opendev.org/c/openstack/nova/+/938604/12/nova/api/openstack/compute/views/servers.py#256","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6f8fada2e6b0f0905b4a16d24eb0a6c0e1e5b1db","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new microversion has been added that allows users to retrieve"},{"line_number":5,"context_line":"    server\u0027s associated scheduler hints in ``GET /servers/{server_id}``"},{"line_number":6,"context_line":"    and ``GET /servers/detail`` responses."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e9531aa8_dea37780","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":33},"in_reply_to":"53825f77_a4a532a7","updated":"2025-02-27 18:17:18.000000000","message":"Done","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"635dbf273e94cbd5f59c10a109bdaeb590fcd841","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new microversion has been added that allows users to retrieve"},{"line_number":5,"context_line":"    server\u0027s associated scheduler hints in ``GET /servers/{server_id}``"},{"line_number":6,"context_line":"    and ``GET /servers/detail`` responses."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"53825f77_a4a532a7","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":33},"in_reply_to":"9901c66e_1441575c","updated":"2025-02-26 22:30:58.000000000","message":"ya that makes sense\n\nthis api change is intentionally not trying to allow you to you to modify the scheduler_hints but your right the responce should be consitent.\n\nwe are missing test covergve for 2.96 and 2.98 for updated in tempest.","commit_id":"2efb30fa0d63280fc8a1123e5fa0a33a3c3d7d7e"}]}