)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"a3b80148ec2041a7d96295173f5a3efcf73a9a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25d3b75a_d06ac271","updated":"2025-01-20 09:39:38.000000000","message":"LGTM, thanks for the work","commit_id":"103af5f98b5d23455cc4fd40eef69502dd42f602"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"884ca4d70e8b66f043ca198fbb02283333e6dfd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c4327eba_d900c7f8","updated":"2025-01-21 18:34:09.000000000","message":"by the way there is quite a lot of prior art in this area\n\n9 years ago we made the monitors loaable via stevedore plugins\nhttps://review.opendev.org/c/openstack/nova/+/196182\n\nbefore and after that we rejected adding \npower monitoring https://review.opendev.org/c/openstack/nova/+/64404\ncpu frequency https://review.opendev.org/c/openstack/nova/+/197829\nmeory bandwith https://review.opendev.org/q/topic:%22bp/memory-bw%22\n\nwe even partly merged numa metrics \nhttps://review.opendev.org/c/openstack/nova/+/198972\nalthough the actul collection was never merged\n\nhttps://review.opendev.org/c/openstack/nova/+/270344\n\nwe still techincally have the stevador entry point\n\nhttps://github.com/openstack/nova/blob/master/setup.cfg#L74-L75\n\nhowver we do not offcialy supprot/test that interface anymore.\n\nit does howver still exist https://github.com/openstack/nova/blob/master/nova/compute/monitors/__init__.py","commit_id":"103af5f98b5d23455cc4fd40eef69502dd42f602"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43b016e4d41ee37c2113d96ce0ef03334ac79762","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"17c01006_617cd20d","updated":"2025-01-21 17:02:36.000000000","message":"per https://docs.openstack.org/nova/latest/contributor/policies.html#metrics-gathering the monitor interface is exiplcity frozen and not currently extensible.\n\nas such this ned a details discussion before proceedign and likely a spec.\n\nwe breifly dicussed this at the team meeting today and suggested this woudl be a good topic ot dicussin in more detail at the next ptg.\n\n\ncelimetor has a per comptue node agent that can collect this information directly without needign nova to be modified. so the fact that the ceilometer comptue agent still existis is a reason to not add this to nova.\n\nthe only valid reason for nova to do this is to proved the information to the nova scheduler so that it can make more informed decsiions via the metrics weigher.","commit_id":"103af5f98b5d23455cc4fd40eef69502dd42f602"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fca36b273031814a785c389d107aedf22508027f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"95d097ad_b25045e8","in_reply_to":"17c01006_617cd20d","updated":"2025-01-21 17:33:21.000000000","message":"it looks liek the supprot in ceilometer was removed in \n\n\nhttps://github.com/openstack/ceilometer/commit/a28cef7036edc2ecb0f60b5d27a97735482e7f98\n\nbut i do have the full context fo that removal beyond the commit which says it was removed because of the removal of its use in trileo.\n\nmy inclination is to say the sysfs based implmation that is beign propsoed here coul be addded to https://github.com/openstack/ceilometer/tree/master/ceilometer/compute/pollsters\n\nto provided host memroy metrics however im not sure how the ceilometer folks woudl feel about that.","commit_id":"103af5f98b5d23455cc4fd40eef69502dd42f602"}]}