)]}'
{"id":"openstack%2Fnova~939158","triplet_id":"openstack%2Fnova~stable%2F2024.2~I4e423bac26990fc3538e840990294b178c30e374","project":"openstack/nova","branch":"stable/2024.2","topic":"proxy-libvirt-calls-stable/2024.2","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2025-01-14 20:04:11.000000000","reason":"\u003cGERRIT_ACCOUNT_4690\u003e replied on the change","reason_account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"}}},"hashtags":[],"change_id":"I4e423bac26990fc3538e840990294b178c30e374","subject":"libvirt: Wrap un-proxied listDevices() and listAllDevices()","status":"ABANDONED","created":"2025-01-13 19:38:03.000000000","updated":"2025-01-15 06:54:22.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":932669,"cherry_pick_of_patch_set":3,"meta_rev_id":"09d9c36cf80e970cddf5200d4ac0519764660e12","_number":939158,"virtual_id_number":939158,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:check","value":1,"date":"2025-01-13 21:48:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"disliked":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":-1,"date":"2025-01-14 17:20:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2025-01-14 14:55:01.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":-1,"date":"2025-01-14 20:04:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"date":"2025-01-14 14:55:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-13 21:25:17.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-01-13 21:48:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-14 14:55:01.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2025-01-14 17:20:34.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2025-01-15 06:54:22.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"}],"messages":[{"id":"6a1e59ff8ac3ab17d2edee1ebcdcc35f173ac886","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-01-13 19:38:03.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"854cfece143be1924d9f8006dccb27e5ced4e874","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-01-13 21:25:17.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-939158-27mf9/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"d553f4306871f654e1ee4640960f1e78269c1e84","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-13 21:48:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e51cc5c4775b4e15bcb3a722158bcf99\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/12ac891beb3e46ab94282492b1df8feb : SUCCESS in 1h 02m 08s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/062a69e0978b489eb6c58b9d4ee9cbc9 : SUCCESS in 1h 43m 53s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/56a6bd0772ac43afb7cc85853141f312 : SUCCESS in 48m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7c9fdb3ed246434591a51a98e7752927 : SUCCESS in 20m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/25510753700c4b80a7c6753fc849523b : SUCCESS in 7m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/395b7bf580d0479c8c4690d91f4db7b0 : SUCCESS in 12m 58s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ea6a45e0e1104029907ca4e5b28454d6 : SUCCESS in 10m 34s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/30761af42632449f88f3938722637d0e : SUCCESS in 12m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b24c75db6d7d4bbb98ceb8f7ecc399c3 : SUCCESS in 8m 29s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/4775c4b884dc434fb6f587012b42f920 : SUCCESS in 42m 41s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/1ee2e1a08db54560abc67d2312ce333b : SUCCESS in 1h 19m 20s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/158cc7dac7474ff9adf09ba4dbaf2759 : SUCCESS in 57m 05s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/8999cf18bcf241f98e7f7e300c2b507a : SUCCESS in 5m 14s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/3eba86358ebb4e0c976eed3e173b85a3 : SUCCESS in 25m 40s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/35bd1c341ec34448a77f92eebc8cf2ab : SUCCESS in 27m 49s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/7c26a40d6b784cd1aae3e74abdafab0d : SUCCESS in 31m 14s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/1c18505f8ce84f5c80d2f21a5ea2ca1f : SUCCESS in 1h 58m 09s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/c673e6b135e046b4a67b13561db1893b : SUCCESS in 1h 59m 57s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a73b56a9c56649b084deebeb19c20265 : SUCCESS in 1h 28m 17s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2a2360bd512446d3aaa235afa29b7504 : SUCCESS in 1h 04m 17s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/9f55e22ff9aa490693ab6494fa2389c3 : SUCCESS in 30m 05s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/cdf51e99da994db39d84fea639561eda : SUCCESS in 34m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e392a4645f90f18ac82d05c5b19a7d720063bfc8","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-13 21:55:03.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/621a328ebd1b47da8e7cba1326396aa1\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/8ca7725f94344a92893af944c7de79b5 : FAILURE in 44m 16s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/6661dc57d22741c8b162c17bf1a1c88d : FAILURE in 32m 23s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"501a710b54795e46a5914613f2dad4f2a0e55896","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-01-14 14:55:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6f17439d06742a1915f4852af3e2b5582ab2ff69","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-01-14 14:55:11.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"f00bd1120ee0284274e0b09f51b069237a8fc66c","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-01-14 17:20:34.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"22e97670f0ae240ff196803a09726fc5809a1094","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-01-14 20:04:11.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"49e4bc69aa69e837aed9c6fc7b594ab497f5e127","tag":"autogenerated:gerrit:abandon","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-01-14 20:14:38.000000000","message":"Abandoned\n\nThis needs to be redone on master","accounts_in_message":[],"_revision_number":1},{"id":"09d9c36cf80e970cddf5200d4ac0519764660e12","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-01-15 06:54:22.000000000","message":"Patch Set 1:\n\nBuild succeeded. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bdb66c067546b625217466d19647c1b0e8bf91e6","revisions":{"bdb66c067546b625217466d19647c1b0e8bf91e6":{"kind":"REWORK","_number":1,"created":"2025-01-13 19:38:03.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/58/939158/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/939158/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/939158/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/939158/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/939158/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/939158/1"}}},"commit":{"parents":[{"commit":"89c07d735319801b192ddc1db0d6a8ce7abea2fc","subject":"Route shared storage RPC to evac dest at startup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/89c07d735319801b192ddc1db0d6a8ce7abea2fc"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2024-10-18 02:54:02.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-01-13 19:38:03.000000000","tz":0},"subject":"libvirt: Wrap un-proxied listDevices() and listAllDevices()","message":"libvirt: Wrap un-proxied listDevices() and listAllDevices()\n\nThis is similar to change I668643c836d46a25df46d4c99a973af5e50a39db\nwhere the objects returned in a list from a libvirt call were not\ntpool.Proxy wrapped. Because the objects are not wrapped, calling\nmethods on them such as listCaps() can block all other greenthreads\nand can cause nova-compute to freeze for hours in certain scenarios.\n\nThis adds the same wrapping to libvirt calls which return lists of\nvirNodeDevice.\n\nCloses-Bug: #2091033\n\nChange-Id: I4e423bac26990fc3538e840990294b178c30e374\n(cherry picked from commit 0fccb365ddea10b9d6d082c3d95dba24b7fec435)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bdb66c067546b625217466d19647c1b0e8bf91e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bdb66c067546b625217466d19647c1b0e8bf91e6"}]},"branch":"refs/heads/stable/2024.2"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{}}}]}