)]}'
{"id":"openstack%2Fnova~939162","triplet_id":"openstack%2Fnova~stable%2F2024.1~I4e423bac26990fc3538e840990294b178c30e374","project":"openstack/nova","branch":"stable/2024.1","topic":"proxy-libvirt-calls-stable/2024.2-stable/2024.1","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2025-01-14 20:14:49.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4e423bac26990fc3538e840990294b178c30e374","subject":"libvirt: Wrap un-proxied listDevices() and listAllDevices()","status":"ABANDONED","created":"2025-01-13 20:33:17.000000000","updated":"2025-01-15 07:00:07.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":939158,"cherry_pick_of_patch_set":1,"meta_rev_id":"d4565cfd5878e1226c1e6f526800eb18cdd4dfc0","_number":939162,"virtual_id_number":939162,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:check","value":1,"date":"2025-01-13 22:17:16.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2025-01-14 14:58:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-13 22:17:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-14 00:02:10.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-01-14 14:58:50.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2025-01-15 07:00:07.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"}],"messages":[{"id":"f8093d4a314c33f7eb7e75902b2153b672d6ee5c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-01-13 20:33:17.000000000","message":"Patch Set 1: Cherry Picked from branch stable/2024.2.","accounts_in_message":[],"_revision_number":1},{"id":"0dfa76b3c5aae3f8cb462ed62ae5ce48fd78e270","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-13 22:17:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/34728071ca574819925ef7cf72fff5da\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/783c7d000d714b6bacfc0ffbbc8b14fe : SUCCESS in 58m 56s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/9715f1e122a241a59c9b8f070cc99bc7 : SUCCESS in 1h 18m 46s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/920fe1e03e644cdcbf3228f6f64a1c1c : SUCCESS in 1h 05m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5ee0b278861d4e4c8341c78be80513ad : SUCCESS in 21m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5fdb62d62a72434181964129dafb52ec : SUCCESS in 7m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/336062b01b66444080b506cb726b9b6d : SUCCESS in 13m 51s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/361bf8356f9e46fa9e5cebbef2965e3f : SUCCESS in 11m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7583a225efe54f33b09eeb4898ebae44 : SUCCESS in 9m 11s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b4b25b43326c436692976e4d205d3de5 : SUCCESS in 44m 59s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/302520efd5314c90afb8a7fe9229973b : SUCCESS in 1h 42m 36s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/b93bc5d895284a2396f262a91065100f : SUCCESS in 1h 05m 22s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/421860d1c5a4414a96d382cc61841c4c : FAILURE in 4m 46s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/ef5b185da8d041a7b76af06d67e100c4 : SUCCESS in 29m 38s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/2d77c8030c0148f5b4817733df6814e5 : SUCCESS in 23m 40s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/b0ed177a9cdb478b843d02982ea04105 : SUCCESS in 29m 52s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/69c1abb06ae54070803622f27491cd0f : SUCCESS in 1h 37m 28s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/8bed08fae7b6476e90154992408b9551 : SUCCESS in 1h 12m 55s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/9a82c6027ecd4cf38e8e6f5e2876fbe7 : SUCCESS in 1h 18m 43s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/655d53aec1444dce8320faf2f3bcf420 : SUCCESS in 1h 04m 44s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/ea86889c1db943dc808a8d78b921c634 : SUCCESS in 34m 40s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/a4968a65f88b4f0e954c0c3a83b0e623 : SUCCESS in 37m 56s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c69f4893761750a2603b5cb8e351e2bc22bb7a01","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-13 22:26:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7bad0d9c414e44e18e45742b16898772\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/476b85f4a7254da9918ab56244beaa2f : FAILURE in 40m 57s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/d4cf81baaed24cb48dd023b6c2ff13b3 : FAILURE in 35m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e3966a676d80a8d21dee5f9aed6e4e065a2a1428","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-01-14 00:02:10.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-939162-4wptb/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"b912ce929febf42c37ab05b5137c73b70e8f074c","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-01-14 14:58:50.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"75adcea67ae0d2f18eaf7c1880ac4a440b93e4b5","tag":"autogenerated:gerrit:abandon","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-01-14 20:14:49.000000000","message":"Abandoned\n\nThis needs to be redone on master","accounts_in_message":[],"_revision_number":1},{"id":"d4565cfd5878e1226c1e6f526800eb18cdd4dfc0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-01-15 07:00:07.000000000","message":"Patch Set 1:\n\nBuild succeeded. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5ce0f731d2c6dc83e71fc0068ad637dadf914ce2","revisions":{"5ce0f731d2c6dc83e71fc0068ad637dadf914ce2":{"kind":"REWORK","_number":1,"created":"2025-01-13 20:33:17.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/62/939162/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/939162/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/939162/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/939162/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/939162/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/939162/1"}}},"commit":{"parents":[{"commit":"8555afb07d39dfad81e39c4a90b371598acaa8ca","subject":"Merge \"Handle neutron-client conflict\" into stable/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8555afb07d39dfad81e39c4a90b371598acaa8ca"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2024-10-18 02:54:02.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-01-13 20:33:17.000000000","tz":0},"subject":"libvirt: Wrap un-proxied listDevices() and listAllDevices()","message":"libvirt: Wrap un-proxied listDevices() and listAllDevices()\n\nThis is similar to change I668643c836d46a25df46d4c99a973af5e50a39db\nwhere the objects returned in a list from a libvirt call were not\ntpool.Proxy wrapped. Because the objects are not wrapped, calling\nmethods on them such as listCaps() can block all other greenthreads\nand can cause nova-compute to freeze for hours in certain scenarios.\n\nThis adds the same wrapping to libvirt calls which return lists of\nvirNodeDevice.\n\nCloses-Bug: #2091033\n\nChange-Id: I4e423bac26990fc3538e840990294b178c30e374\n(cherry picked from commit 0fccb365ddea10b9d6d082c3d95dba24b7fec435)\n(cherry picked from commit bdb66c067546b625217466d19647c1b0e8bf91e6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5ce0f731d2c6dc83e71fc0068ad637dadf914ce2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5ce0f731d2c6dc83e71fc0068ad637dadf914ce2"}]},"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}