)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"3f2056e7685cb5fe0fd19c71218a3c02ea6f159a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix parameter order in add_instance_info_to_node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Corrected the parameter order in `add_instance_info_to_node`, resolving issue https://bugs.launchpad.net/nova/+bug/2092570"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1e7458a70a65f65f4da66d98d8fde6c031e3315e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c6de0528_2584fdde","line":10,"updated":"2025-01-20 14:03:57.000000000","message":"Please add `Closes-Bug: #2092570` line here, which links this commit to the bug report.","commit_id":"9b9f40e13f89ded77498a28be3aba89f010a6219"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"11d746763989d8f4ea9a4f23b4e5a22fd5f9bc35","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix parameter order in add_instance_info_to_node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Corrected the parameter order in `add_instance_info_to_node`, resolving issue https://bugs.launchpad.net/nova/+bug/2092570"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1e7458a70a65f65f4da66d98d8fde6c031e3315e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"74959cba_26bb89e8","line":10,"in_reply_to":"c6de0528_2584fdde","updated":"2025-01-22 05:47:05.000000000","message":"Acknowledged","commit_id":"9b9f40e13f89ded77498a28be3aba89f010a6219"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"3f2056e7685cb5fe0fd19c71218a3c02ea6f159a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a6af90d1_2742c578","updated":"2025-01-20 14:03:57.000000000","message":"The code looks good to me.\n\nSmall cosmetic comment.","commit_id":"9b9f40e13f89ded77498a28be3aba89f010a6219"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"9fd14bbc414dafe3eabc0f4333a5360e0e6de17a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c4e9e30c_0c747276","updated":"2025-01-21 01:08:24.000000000","message":"Thank you for the update. I did a small update for the commit cmessage.","commit_id":"5dd00536deef4f256ca13680130098064e7ea38e"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"11d746763989d8f4ea9a4f23b4e5a22fd5f9bc35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b0aef2d1_a4388b3e","updated":"2025-01-22 05:47:05.000000000","message":"I have completed the required changes and believe this is now ready for merge. Any feedback or approval would be greatly appreciated.","commit_id":"4c2c7647f10a741dfa39698b51bae5c085bc6a45"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eb3b37151853451ad55ed3c2b7751efc4afae1a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3fffc221_59d6b896","updated":"2025-01-29 15:06:57.000000000","message":"This looks correct. I do wonder if we want to release note and a link to the commit that broke things here, but either way, this looks like an important fix, so lets get that in.","commit_id":"4c2c7647f10a741dfa39698b51bae5c085bc6a45"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4a8b3a9e4b43e92b2d0f480f076568845c699ca9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"91fdf700_53d6e075","updated":"2025-01-29 22:32:50.000000000","message":"This looks correct. I won\u0027t +W for now bc I\u0027m not 100% sure if a release note is desired. Feel free to +W either way","commit_id":"4c2c7647f10a741dfa39698b51bae5c085bc6a45"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45b16a369dc2345efd194a913e49403fecf5ce95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"288185dc_7838153c","updated":"2025-02-06 12:30:07.000000000","message":"note, in generally you shoudl not + code review your own patch.\nthe only exception to that is if someone else is back porting your patch.","commit_id":"d5e595a2fdab03ab2f0ee4653a63bd2b68a734f8"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"e6d162a15ff8fc028d5afb449d7c3b385303130b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a193a7ea_c8607cf0","in_reply_to":"288185dc_7838153c","updated":"2025-02-06 13:34:55.000000000","message":"This bug has been affecting the users for some time. The frequent updates and vote were intended to ensure continued progress toward a resolution. Apologies for any unconventional actions; future contributions will adhere to community standards.","commit_id":"d5e595a2fdab03ab2f0ee4653a63bd2b68a734f8"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"1f0551c0a78f00bf2af3908922c00d77f00bb411","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4456f32a_40e744ce","updated":"2025-03-04 01:08:47.000000000","message":"Does anyone have anything to add?","commit_id":"a4580335682d2abd58e9cfc441a27d1e65e29d0c"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"590a1329951f2dc0bad13bba942c08311e021023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a17a8b38_024179fd","updated":"2025-02-18 01:02:59.000000000","message":"Ping for review—any thoughts or suggestions?","commit_id":"a4580335682d2abd58e9cfc441a27d1e65e29d0c"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"17dd90cd5cae01c80f3a2035170d628e07923751","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"20330ad7_86a7a5dd","updated":"2025-02-10 01:10:25.000000000","message":"recheck nova-next","commit_id":"a4580335682d2abd58e9cfc441a27d1e65e29d0c"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"e2acb125da2a34fedd7f88b52adb02229a556b99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2e6ff72d_33e769ce","updated":"2025-02-07 01:16:00.000000000","message":"recheck nova-next","commit_id":"a4580335682d2abd58e9cfc441a27d1e65e29d0c"},{"author":{"_account_id":37743,"name":"JackyChang","display_name":"JackyChang","email":"ya2648130@gmail.com","username":"jackychang"},"change_message_id":"551cd421f5723b11a2be2aa10eb480dd54686ed1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c6dc1c88_6ff42079","updated":"2025-03-10 01:22:05.000000000","message":"we\u0027ve be affected by this too. hope this can be fix soon.","commit_id":"a4580335682d2abd58e9cfc441a27d1e65e29d0c"},{"author":{"_account_id":37740,"name":"Quan-Yu, LAI","display_name":"NestorLAI","email":"nestor.lai.1994@gmail.com","username":"nestorlai"},"change_message_id":"fd8e7cac30f622132a8db19066228486d7fc03fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cd62299f_e4e878d3","updated":"2025-02-20 06:08:26.000000000","message":"would love to see this fixed","commit_id":"a4580335682d2abd58e9cfc441a27d1e65e29d0c"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a694da52a7de04b870113bdadc7560a537d2fc4a","unresolved":true,"context_lines":[{"line_number":1749,"context_line":"        node \u003d self._get_node(node_id)"},{"line_number":1750,"context_line":""},{"line_number":1751,"context_line":"        metadata \u003d self.get_instance_driver_metadata(instance, network_info)"},{"line_number":1752,"context_line":"        self._add_instance_info_to_node(node, instance, image_meta,"},{"line_number":1753,"context_line":"                                        instance.flavor, metadata,"},{"line_number":1754,"context_line":"                                        preserve_ephemeral)"},{"line_number":1755,"context_line":""},{"line_number":1756,"context_line":"        # Config drive"},{"line_number":1757,"context_line":"        configdrive_value \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"fddc72c6_92abecd2","line":1754,"range":{"start_line":1752,"start_character":0,"end_line":1754,"end_character":59},"updated":"2025-01-21 01:11:11.000000000","message":"https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L409-L411\n\nthe fucntion signiture is \n```\ndef _add_instance_info_to_node(self, node, instance, image_meta, flavor,\n                                   metadata, preserve_ephemeral\u003dNone,\n                                   block_device_info\u003dNone):\n```                                   \nso yes flavor and metadata are swaped and preserve_ephemeral is not a postional argument so it shoudl not be passed as on\n\ncan up update it to \n```suggestion\n        self._add_instance_info_to_node(\n            node, instance, image_meta, instance.flavor, metadata,\n            preserve_ephemeral\u003dpreserve_ephemeral)\n```","commit_id":"c1ec595eeb9d75cd687484a98a6daa0e12304634"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"11d746763989d8f4ea9a4f23b4e5a22fd5f9bc35","unresolved":false,"context_lines":[{"line_number":1749,"context_line":"        node \u003d self._get_node(node_id)"},{"line_number":1750,"context_line":""},{"line_number":1751,"context_line":"        metadata \u003d self.get_instance_driver_metadata(instance, network_info)"},{"line_number":1752,"context_line":"        self._add_instance_info_to_node(node, instance, image_meta,"},{"line_number":1753,"context_line":"                                        instance.flavor, metadata,"},{"line_number":1754,"context_line":"                                        preserve_ephemeral)"},{"line_number":1755,"context_line":""},{"line_number":1756,"context_line":"        # Config drive"},{"line_number":1757,"context_line":"        configdrive_value \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"839f768a_f3846dcb","line":1754,"range":{"start_line":1752,"start_character":0,"end_line":1754,"end_character":59},"in_reply_to":"fddc72c6_92abecd2","updated":"2025-01-22 05:47:05.000000000","message":"Acknowledged","commit_id":"c1ec595eeb9d75cd687484a98a6daa0e12304634"}],"releasenotes/notes/bug-2092570-fix-parameter-order-in-add_instance_info_to_node.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45b16a369dc2345efd194a913e49403fecf5ce95","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    This bug was introduced by `commit 93b90d2b"},{"line_number":6,"context_line":"    \u003chttps://review.opendev.org/c/openstack/nova/+/923910\u003e`__."},{"line_number":7,"context_line":"    See `bug 2092570"},{"line_number":8,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/2092570\u003e`__ for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ea06ba78_c6c48a7d","line":8,"updated":"2025-02-06 12:30:07.000000000","message":"i guess we now have a release note but release notes should explaine why\nthe fix is imporant without requiring the reader to click though any links.\n\nso this does not actully do that.\n\nif other are ok with it i wount block on this but this is not a useful release note.\n\nit shoudl explain in 1 to 2 sentences what was broken before and now works.","commit_id":"d5e595a2fdab03ab2f0ee4653a63bd2b68a734f8"},{"author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"change_message_id":"590a1329951f2dc0bad13bba942c08311e021023","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    This bug was introduced by `commit 93b90d2b"},{"line_number":6,"context_line":"    \u003chttps://review.opendev.org/c/openstack/nova/+/923910\u003e`__."},{"line_number":7,"context_line":"    See `bug 2092570"},{"line_number":8,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/2092570\u003e`__ for details."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d0d134e9_300324c6","line":8,"in_reply_to":"ea06ba78_c6c48a7d","updated":"2025-02-18 01:02:59.000000000","message":"Done","commit_id":"d5e595a2fdab03ab2f0ee4653a63bd2b68a734f8"}]}