)]}'
{"nova/tests/functional/regressions/test_bug_2095391.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5938f7cc6d13379cca5ddfd889ef6f9bff4fd146","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # NOTE(auniyal): create_swap at imagebackend did not get called"},{"line_number":79,"context_line":"        # during finish_resize"},{"line_number":80,"context_line":"        self.imagebackend.mock_create_swap.assert_not_called()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        host2 \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":83,"context_line":"        self.assertNotEqual(host1, host2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"53cb6461_81dd784b","line":80,"range":{"start_line":80,"start_character":43,"end_line":80,"end_character":60},"updated":"2025-02-19 04:32:51.000000000","message":"after fix also not getting called.\n\nthis is unrealted to autospec fail shown in functional test","commit_id":"fbfd0c3296f448c48254940bd2ff96281683e4a8"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d954d57877494105586275b46ae49b632a561951","unresolved":true,"context_lines":[{"line_number":23940,"context_line":""},{"line_number":23941,"context_line":"            # Concatenate all parts written by `write()`"},{"line_number":23942,"context_line":"            written_disks \u003d \u0027\u0027.join(call[0][0]"},{"line_number":23943,"context_line":"                                   for call in fp.write.call_args_list)"},{"line_number":23944,"context_line":"            self.assertEqual(written_disks, expected_disks)"},{"line_number":23945,"context_line":""},{"line_number":23946,"context_line":"    def test_wait_for_running(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1baac107_3cf6d543","line":23943,"updated":"2025-02-18 04:40:53.000000000","message":"write was making 9 different calls instead of single to write whole file, so joined all to verify final written data","commit_id":"f4fda8e41a2d9073d64c32d34f17fbd35b72f92b"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3e71d44e4926a9cb6952f832d0c32b02b59b9e6","unresolved":true,"context_lines":[{"line_number":12252,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":12253,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":12254,"context_line":"                if fname \u003d\u003d \u0027disk.swap\u0027:"},{"line_number":12255,"context_line":"                    # (auniyal) as we are ignoring disk.swap for copy"},{"line_number":12256,"context_line":"                    # we should also remove it from disk.info. because that\u0027s"},{"line_number":12257,"context_line":"                    # what used by image imagebackend to create new disks."},{"line_number":12258,"context_line":"                    # will have new disk.swap created if new-flavor has it."},{"line_number":12259,"context_line":"                    self._remove_swap(src_disk_info_path, instance)"},{"line_number":12260,"context_line":"                    continue"},{"line_number":12261,"context_line":""},{"line_number":12262,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"}],"source_content_type":"text/x-python","patch_set":1,"id":"22601843_2c0081f6","line":12259,"range":{"start_line":12255,"start_character":0,"end_line":12259,"end_character":67},"updated":"2025-01-21 15:09:35.000000000","message":"As far as I know the bug fixed here is https://bugs.launchpad.net/nova/+bug/2095391. The bug report says the instance dir is on shared storage (NFS). And that during the cold migration the VM fails to start on the destination compute as the swap disk is not found. \n* So there was a spaw disk on the source node before the instance was migrated\n* the directory is shared with the dest node\n* the VM fails to start on dest as the swap disk is not found.\n\nSo before we jump to how to trigger re-creation of the swap disk, I\u0027m wondering how that swap disk got deleted from the shared instance dir in the first place?","commit_id":"e4a31e5996436c803e4a9d5ad72c56a6f9429479"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"b2ecb9b7b75692b0f54bb1617fe9fe7399ce4021","unresolved":true,"context_lines":[{"line_number":12252,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":12253,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":12254,"context_line":"                if fname \u003d\u003d \u0027disk.swap\u0027:"},{"line_number":12255,"context_line":"                    # (auniyal) as we are ignoring disk.swap for copy"},{"line_number":12256,"context_line":"                    # we should also remove it from disk.info. because that\u0027s"},{"line_number":12257,"context_line":"                    # what used by image imagebackend to create new disks."},{"line_number":12258,"context_line":"                    # will have new disk.swap created if new-flavor has it."},{"line_number":12259,"context_line":"                    self._remove_swap(src_disk_info_path, instance)"},{"line_number":12260,"context_line":"                    continue"},{"line_number":12261,"context_line":""},{"line_number":12262,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"}],"source_content_type":"text/x-python","patch_set":1,"id":"b7e6dc2a_d6f03852","line":12259,"range":{"start_line":12255,"start_character":0,"end_line":12259,"end_character":67},"in_reply_to":"22601843_2c0081f6","updated":"2025-01-21 15:40:13.000000000","message":"\u003e the bug fixed here is https://bugs.launchpad.net/nova/+bug/2095391.\n\nyes, will update commit msg in next respin.\n\nactually, swap.disk does not get delete, we just rename the instance directory, with postfix _resize (instances/\u003cthe_id\u003e_resize), at L12229.\nand except disk.swap copy all other disks (because as commented L12249-12253)\n\n\nso initially I felt, if we know the storage is shared, we should just skip coping disks, but seems something which might break other process.","commit_id":"e4a31e5996436c803e4a9d5ad72c56a6f9429479"}]}