)]}'
{"id":"openstack%2Fnova~939728","triplet_id":"openstack%2Fnova~unmaintained%2Fvictoria~I11fb5d3ada7f27b39c183157ea73c8b72b4e672e","project":"openstack/nova","branch":"unmaintained/victoria","topic":"bug/1815989","attention_set":{},"removed_from_attention_set":{"17685":{"account":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"last_update":"2025-01-22 10:08:37.000000000","reason":"\u003cGERRIT_ACCOUNT_17685\u003e replied on the change","reason_account":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},"15554":{"account":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"last_update":"2025-12-19 14:00:56.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I11fb5d3ada7f27b39c183157ea73c8b72b4e672e","subject":"libvirt: Delegate OVS plug to os-vif","status":"ABANDONED","created":"2025-01-21 15:48:09.000000000","updated":"2025-12-19 14:00:56.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b590a6cf43ea3d1134c4de96b8a55469a617e8fb","_number":939728,"virtual_id_number":939728,"owner":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2025-01-21 17:29:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"disliked":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2025-04-10 12:42:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":1,"date":"2025-01-23 01:38:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},{"value":-1,"date":"2025-01-22 10:08:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"REVIEWER":[{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-21 15:48:09.000000000","updated_by":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"CC"},{"updated":"2025-01-21 15:51:29.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2025-01-21 17:29:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-22 08:21:42.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"state":"CC"},{"updated":"2025-01-22 08:21:46.000000000","updated_by":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"reviewer":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"state":"REVIEWER"},{"updated":"2025-01-23 01:38:11.000000000","updated_by":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"reviewer":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"state":"REVIEWER"}],"messages":[{"id":"b6316767a8b918136d2c66d896a962cc1f177801","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"date":"2025-01-21 15:48:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"267667f51c4d678dc8dca9f8f099df3860372169","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-21 17:29:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/430a7364b7b54498bc0e42c60e757b55\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/3bae287837e942199947535ed75672da : SUCCESS in 1h 23m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/871322fe5f624e20b8020a354d85d650 : SUCCESS in 15m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/80ea73869c9541b9a7a5dfb1546df929 : SUCCESS in 15m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/42daf855f87149a9b98fdf099b6cecef : SUCCESS in 20m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/14e92115c62a43998c51df141b5d446e : SUCCESS in 12m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09313a4141c54354befeb4fd0447f22c : SUCCESS in 16m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1f84f5d3ecff4bcf88dcb659e074e37e : SUCCESS in 28m 18s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ea74b686776f48dd8cd68d3d28d4e5f2 : FAILURE in 25m 20s (non-voting)\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/6a9041bb0f3d4f25854cef39746c9f2d : SUCCESS in 50m 29s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/15b9a4e5c1ca493db41f71f5e7db68eb : SUCCESS in 28m 48s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/1e50e635994b4f7a9dc77c76fb2086b2 : FAILURE in 58m 04s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/0f98b290d6a449ccab074d99e2bb83a3 : SUCCESS in 1h 07m 03s\n- nova-next https://zuul.opendev.org/t/openstack/build/4ba7c4fb04184cba920a85f47bbe7621 : SUCCESS in 1h 28m 00s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/b8946236617545158aa674db3dfb5a13 : FAILURE in 5m 44s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2d47e9b96662446fb5e06bf9f7dae96e : SUCCESS in 19m 41s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/fa8adf4e91b347629a52b6b5ef03f023 : SUCCESS in 1h 20m 25s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2513991a269145928140414018b89436 : SUCCESS in 52m 01s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/fe9878f8f0fa462ba2dd8401a875e800 : FAILURE in 34m 35s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/66f8c1fcd180449f84b92f5bee9efac3 : FAILURE in 27m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6cf86c9ac1670cbfc0b5bb1f0910e594cf9b6ce6","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2025-01-22 08:21:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"606820444da9e137085735fddaf65966396aeb8e","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2025-01-22 08:21:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d78edbcb96a82312fd0dee9b05c0750d0c2d63d2","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-01-22 10:08:37.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"799a19f4c050cc067509705e472300edd967c98b","author":{"_account_id":37620,"name":"suiong ng","display_name":"Suiong Ng","email":"YoungN@supermicro.com","username":"suiong_ng"},"date":"2025-01-23 01:38:11.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"86e824a6a9729a74a166651633dfb1c5db16c39f","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2025-04-10 12:42:15.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"b590a6cf43ea3d1134c4de96b8a55469a617e8fb","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-12-19 14:00:56.000000000","message":"Abandoned\n\nunmaintained/victoria branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8afe92dd7ee5dd9f75b35a40bcb67f09f419f63d","revisions":{"8afe92dd7ee5dd9f75b35a40bcb67f09f419f63d":{"kind":"REWORK","_number":1,"created":"2025-01-21 15:48:09.000000000","uploader":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"ref":"refs/changes/28/939728/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/28/939728/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/939728/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/939728/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/28/939728/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/28/939728/1"}}},"commit":{"parents":[{"commit":"864525d38e9f23ff3d4265f1c2cda5d570eb0175","subject":"Do not untrack resources of a server being unshelved","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/864525d38e9f23ff3d4265f1c2cda5d570eb0175"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-04-30 11:51:35.000000000","tz":60},"committer":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2025-01-21 15:46:52.000000000","tz":60},"subject":"libvirt: Delegate OVS plug to os-vif","message":"libvirt: Delegate OVS plug to os-vif\n\nos-vif 1.15.0 added the ability to create an OVS port during plugging\nby specifying the \u0027create_port\u0027 attribute in the \u0027port_profile\u0027 field.\nBy delegating port creation to os-vif, we can rely on it\u0027s \u0027isolate_vif\u0027\nconfig option [1] that will temporarily configure the VLAN to 4095\n(0xfff), which is reserved for implementation use [2] and is used by\nneutron to as a dead VLAN [3]. By doing this, we ensure VIFs are plugged\nsecurely, preventing guests from accessing other tenants\u0027 networks\nbefore the neutron OVS agent can wire up the port.\n\nThis change requires a little dance as part of the live migration flow.\nSince we can\u0027t be certain the destination host has a version of os-vif\nthat supports this feature, we need to use a sentinel to indicate when\nit does. Typically we would do so with a field in\n\u0027LibvirtLiveMigrateData\u0027, such as the \u0027src_supports_numa_live_migration\u0027\nand \u0027dst_supports_numa_live_migration\u0027 fields used to indicate support\nfor NUMA-aware live migration. However, doing this prevents us\nbackporting this important fix since o.vo changes are not backportable.\nInstead, we (somewhat evilly) rely on the free-form nature of the\n\u0027VIFMigrateData.profile_json\u0027 string field, which stores JSON blobs and\nis included in \u0027LibvirtLiveMigrateData\u0027 via the \u0027vifs\u0027 attribute, to\ntransport this sentinel. This is a hack but is necessary to work around\nthe lack of a free-form \"capabilities\" style dict that would allow us do\nbackportable fixes to live migration features.\n\nNote that this change has the knock on effect of modifying the XML\ngenerated for OVS ports: when hybrid plug is false will now be of type\n\u0027ethernet\u0027 rather than \u0027bridge\u0027 as before. This explains the larger than\nexpected test damage but should not affect users.\n\nConflicts:\n  nova/tests/unit/virt/libvirt/fakelibvirt.py\n  nova/tests/unit/virt/libvirt/test_driver.py\n  nova/tests/unit/virt/libvirt/test_vif.py\n  nova/virt/libvirt/driver.py\n\nChanges:\n  nova/tests/unit/virt/libvirt/test_driver.py\n\nNOTE(stephenfin): Conflicts in the fake libvirt fixture are due to the\nabsence of I7f2b6330decb92e2838aa7cee47fb228f00f47da (\"Replace blind\nretry with libvirt event waiting in detach\"), which significantly beefed\nup this fixture. We use the beefed up version here since it works and is\narguably more correct that what we had previously. The conflicts in the\nother files are trivial conflicts caused by the removal of \u0027six\u0027 imports\nin changes I779bd1446dc1f070fa5100ccccda7881fa508d79 (\"Remove\nsix.text_type (2/2)\") and I23bb9e539d08f5c6202909054c2dd49b6c7a7a0e\n(\"Remove six.text_type (1/2)\") on stable/wallaby. The additional change\nis a trivial addition of a mock to two tests that no longer existed on\nstable/wallaby due to change I952f36fe201aad37297c7630ed562b579c90f64a\n(\"libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION\").\n\n[1] https://opendev.org/openstack/os-vif/src/tag/2.4.0/vif_plug_ovs/ovs.py#L90-L93\n[2] https://en.wikipedia.org/wiki/IEEE_802.1Q#Frame_format\n[3] https://answers.launchpad.net/neutron/+question/231806\n\nChange-Id: I11fb5d3ada7f27b39c183157ea73c8b72b4e672e\nDepends-On: Id12486b3127ab4ac8ad9ef2b3641da1b79a25a50\nCloses-Bug: #1734320\nCloses-Bug: #1815989\n(cherry picked from commit a62dd42c0dbb6b2ab128e558e127d76962738446)\n(cherry picked from commit d16ded1f5bbfa27d96c36978c6cedd0c050ab106)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8afe92dd7ee5dd9f75b35a40bcb67f09f419f63d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8afe92dd7ee5dd9f75b35a40bcb67f09f419f63d"}]},"branch":"refs/heads/unmaintained/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}