)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2722729d90180a691c8488753ffc932cd9f9c9d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1564ca1e_6d76436e","updated":"2025-07-30 11:02:44.000000000","message":"the blueprint for this need to be approved in an nova irc meeting.\n\nwhile you do not have to atteend in person it does need to be added ot the adjged and review by the core team and appoved as a blueprint before the code can be merged.\n\n\non the code ise you shoudl have a release note for this feature.\ni agree it shoudl be disabled by default.\ni think we shoudl also have more testing.\n\nim undecided if enabling this in one of the tempest jobs (nova-next) would be enough additional coverage or if we shoudl have functional test coverage to ensure it properly decrement the value in the db over time.\n\nin the functional tests we can manually execute the perodics to trigger there sideefects. i feel like a funcitonal test would be a good addtion i just dont know if we have an existing one you can use as a refence to create it.\n\ni.e. one that is already teting the behvior of the failed build weigher but i suspect we do.\n\nthe over all change looks ok but as i noted inline im not sure this need to be a seperate perodic. i would liek to see with others think.\n\n-1 is partly for the comment above and inline and partly because the blueprint is not approved.\n\ntechnically that shoudl be a procedual -2  however i don think that is required at this time.\n\nwe are currently past the bluepint approvale deadlien for 2025.2 so this will have to be dicussed in the context of 2026.1","commit_id":"29f79e1b1f5a53284c0a71b699a1f9f1b0ee2a7a"},{"author":{"_account_id":35674,"name":"ChungWon Lee","display_name":"cw0306-lee","email":"cw0306.lee@samsung.com","username":"cw0306-lee"},"change_message_id":"cad235200d854a6f64a2c717aa0c03779ee74925","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31446dfe_59eb93fa","in_reply_to":"1564ca1e_6d76436e","updated":"2025-07-30 11:32:19.000000000","message":"Thank you for your opinion!\nThis was first time to try contributing on nova, and I got lost the procedure of contributing when I made this code. Thank you for your kind guide.\nI\u0027ll try to improve code as you said and write release note.\nShould I do something to add this on irc meeting agenda?","commit_id":"29f79e1b1f5a53284c0a71b699a1f9f1b0ee2a7a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b185990beded0859e493b0cd5caeb2199fce905c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4b09e64f_09b633e1","updated":"2026-05-26 19:04:26.000000000","message":"so before this moves forward this need test coverage, documention and a release note","commit_id":"93be10753ca3c62ce3df101e5f2cfd8b40b60d78"},{"author":{"_account_id":35674,"name":"ChungWon Lee","display_name":"cw0306-lee","email":"cw0306.lee@samsung.com","username":"cw0306-lee"},"change_message_id":"be98121462fd6dc35862fd18d768b1e33f4c8b87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1695a0b5_d661ce11","in_reply_to":"4b09e64f_09b633e1","updated":"2026-05-27 07:44:18.000000000","message":"Thank you for comment, @seanmooney8202@yahoo.ie.\nBefore make test and release note, could it be okay to use Patchset 2 again like the comment given in the irc channel?","commit_id":"93be10753ca3c62ce3df101e5f2cfd8b40b60d78"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"d1aa904713e497acca2429416a64022255ec59cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e4625301_bf8d3841","updated":"2026-06-02 14:11:40.000000000","message":"run-Quobyte CI","commit_id":"eecbe749161cfe1296f159e2854770aea71794ed"}],"nova/conf/compute.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2722729d90180a691c8488753ffc932cd9f9c9d5","unresolved":true,"context_lines":[{"line_number":1287,"context_line":"* Any positive integer in seconds."},{"line_number":1288,"context_line":"\"\"\"),"},{"line_number":1289,"context_line":"    cfg.IntOpt(\u0027build_failed_reduce_interval\u0027,"},{"line_number":1290,"context_line":"        default\u003d0,"},{"line_number":1291,"context_line":"        help\u003d\"\"\""},{"line_number":1292,"context_line":"Interval for reducing build failures."},{"line_number":1293,"context_line":"This option specifies how often the reduce_host_failed_build"}],"source_content_type":"text/x-python","patch_set":2,"id":"29b1e77b_9fdc2cd4","line":1290,"updated":"2025-07-30 11:02:44.000000000","message":"i think it woul dbe better to have the defautl be -1\nand have 0 mean use the default perodic interval.\n\nthat would be more considtent.\n\nbut im also not sure this shoudl be a seperate preodic.\n\nim more include to say it whoudl be part of the update_aviable_resouces perodic and just have a boolean config option ot enable or disabel the the decrement.","commit_id":"29f79e1b1f5a53284c0a71b699a1f9f1b0ee2a7a"}]}
