)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"61b30c8f604ec348609c15528a52c973e260fba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c1d61e4a_5044afe6","updated":"2025-01-24 14:37:12.000000000","message":"recheck timeout","commit_id":"14e275fa68658c51b41b057b6a4b714fd6cf566a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2cdd1a4e538606bcc8754d6b192db34629b7c6cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d694ebd4_93b4c0f2","updated":"2025-01-29 17:33:35.000000000","message":"recheck timeout","commit_id":"c359ab75c3dddd79e17181e2c9b09bf82962adf3"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"f5fafcf01455976c0615433082f02790da3bf888","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7043931d_cc64d044","updated":"2025-06-10 13:47:22.000000000","message":"Based on the follow up patch everything looks good to me.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc528a1ff252a79137919f02f35aab5efbaf19ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"35668ff8_90bc8c30","updated":"2025-06-10 09:49:05.000000000","message":"Issues addressed in follow-up https://review.opendev.org/c/openstack/nova/+/952213","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0bb14d04_a13425a0","updated":"2025-06-06 15:25:28.000000000","message":"It seems there are some discrepancies compared to the API doc.\nAlthough most of these API are deprecated, it could be good to align with the doc.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4dc1ff24a973e2f0f9f39a9427d5fc9a6bddb93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6ef533b8_7aeb98d5","updated":"2025-06-10 21:32:50.000000000","message":"lgtm, thanks","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8008481c22d7239d59e70a87cba96dbf98126fa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"406db6e5_eb3a3d44","updated":"2025-06-09 22:49:03.000000000","message":"overall ok but -1 for the rdp response schema","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ef8ad8016004bea9aec95544be1d4fd7d4fdc7d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"080aa679_ee86cf05","updated":"2025-06-24 18:13:12.000000000","message":"recheck","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29961c8006b55e2acabffad51d176646835aa581","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"624d84f1_2aee2e65","updated":"2025-06-24 14:14:26.000000000","message":"there are som nit inline but let fix the rdp valued for protocl adn type in a follow up change","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"}],"nova/api/openstack/compute/schemas/remote_consoles.py":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":true,"context_lines":[{"line_number":22,"context_line":"            \u0027properties\u0027: {"},{"line_number":23,"context_line":"                \u0027type\u0027: {"},{"line_number":24,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":25,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027],"},{"line_number":26,"context_line":"                },"},{"line_number":27,"context_line":"            },"},{"line_number":28,"context_line":"            \u0027required\u0027: [\u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"d4215c0c_35c24f7a","line":25,"range":{"start_line":25,"start_character":39,"end_line":25,"end_character":45},"updated":"2025-06-06 15:25:28.000000000","message":"From the doc the only value seeems novnc.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"270520242551b5ca9f47b0cfd8c10773810bbdff","unresolved":true,"context_lines":[{"line_number":22,"context_line":"            \u0027properties\u0027: {"},{"line_number":23,"context_line":"                \u0027type\u0027: {"},{"line_number":24,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":25,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027],"},{"line_number":26,"context_line":"                },"},{"line_number":27,"context_line":"            },"},{"line_number":28,"context_line":"            \u0027required\u0027: [\u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"fc34199a_4293fa51","line":25,"range":{"start_line":25,"start_character":39,"end_line":25,"end_character":45},"in_reply_to":"d4215c0c_35c24f7a","updated":"2025-06-09 13:49:07.000000000","message":"It is now, and that\u0027s okay for docs. However, for schema validation, I think we need to support legacy clients that can pass other values. We previously supported `xvpvnc`. This was removed in I2f7f2379d0cd54e4d0a91008ddb44858cfc5a4cf.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29961c8006b55e2acabffad51d176646835aa581","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            \u0027properties\u0027: {"},{"line_number":23,"context_line":"                \u0027type\u0027: {"},{"line_number":24,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":25,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027],"},{"line_number":26,"context_line":"                },"},{"line_number":27,"context_line":"            },"},{"line_number":28,"context_line":"            \u0027required\u0027: [\u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"5620a786_2964be3c","line":25,"range":{"start_line":25,"start_character":39,"end_line":25,"end_character":45},"in_reply_to":"fc34199a_4293fa51","updated":"2025-06-24 14:14:26.000000000","message":"Acknowledged","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                },"},{"line_number":88,"context_line":"                \u0027type\u0027: {"},{"line_number":89,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":90,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027serial\u0027],"},{"line_number":91,"context_line":"                },"},{"line_number":92,"context_line":"            },"},{"line_number":93,"context_line":"            \u0027required\u0027: [\u0027protocol\u0027, \u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"f333ab64_81c92668","line":90,"range":{"start_line":90,"start_character":39,"end_line":90,"end_character":45},"updated":"2025-06-06 15:25:28.000000000","message":"This values seems not possible","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"270520242551b5ca9f47b0cfd8c10773810bbdff","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                },"},{"line_number":88,"context_line":"                \u0027type\u0027: {"},{"line_number":89,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":90,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027serial\u0027],"},{"line_number":91,"context_line":"                },"},{"line_number":92,"context_line":"            },"},{"line_number":93,"context_line":"            \u0027required\u0027: [\u0027protocol\u0027, \u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"a0caba16_9084f202","line":90,"range":{"start_line":90,"start_character":39,"end_line":90,"end_character":45},"in_reply_to":"f333ab64_81c92668","updated":"2025-06-09 13:49:07.000000000","message":"as above","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                },"},{"line_number":111,"context_line":"                \u0027type\u0027: {"},{"line_number":112,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":113,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027serial\u0027,"},{"line_number":114,"context_line":"                             \u0027webmks\u0027],"},{"line_number":115,"context_line":"                },"},{"line_number":116,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":6,"id":"801a035e_a0a9c3e4","line":113,"range":{"start_line":113,"start_character":39,"end_line":113,"end_character":45},"updated":"2025-06-06 15:25:28.000000000","message":"ditto","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"270520242551b5ca9f47b0cfd8c10773810bbdff","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                },"},{"line_number":111,"context_line":"                \u0027type\u0027: {"},{"line_number":112,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":113,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027serial\u0027,"},{"line_number":114,"context_line":"                             \u0027webmks\u0027],"},{"line_number":115,"context_line":"                },"},{"line_number":116,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":6,"id":"6d9b6a9a_a69697c8","line":113,"range":{"start_line":113,"start_character":39,"end_line":113,"end_character":45},"in_reply_to":"801a035e_a0a9c3e4","updated":"2025-06-09 13:49:07.000000000","message":"as above","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                },"},{"line_number":135,"context_line":"                \u0027type\u0027: {"},{"line_number":136,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":137,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027spice-direct\u0027,"},{"line_number":138,"context_line":"                             \u0027serial\u0027, \u0027webmks\u0027],"},{"line_number":139,"context_line":"                },"},{"line_number":140,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":6,"id":"ec4841bb_187b2725","line":137,"range":{"start_line":137,"start_character":39,"end_line":137,"end_character":45},"updated":"2025-06-06 15:25:28.000000000","message":"ditto","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"270520242551b5ca9f47b0cfd8c10773810bbdff","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                },"},{"line_number":135,"context_line":"                \u0027type\u0027: {"},{"line_number":136,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":137,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027spice-direct\u0027,"},{"line_number":138,"context_line":"                             \u0027serial\u0027, \u0027webmks\u0027],"},{"line_number":139,"context_line":"                },"},{"line_number":140,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":6,"id":"d8bdb8d0_7c3a6905","line":137,"range":{"start_line":137,"start_character":39,"end_line":137,"end_character":45},"in_reply_to":"ec4841bb_187b2725","updated":"2025-06-09 13:49:07.000000000","message":"as above","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            \u0027properties\u0027: {"},{"line_number":155,"context_line":"                \u0027type\u0027: {"},{"line_number":156,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":157,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027],"},{"line_number":158,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":159,"context_line":"                },"},{"line_number":160,"context_line":"                \u0027url\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"c8eb1a65_0cfc71e1","line":157,"range":{"start_line":157,"start_character":39,"end_line":157,"end_character":45},"updated":"2025-06-06 15:25:28.000000000","message":"seems to be only novnc","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29961c8006b55e2acabffad51d176646835aa581","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            \u0027properties\u0027: {"},{"line_number":155,"context_line":"                \u0027type\u0027: {"},{"line_number":156,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":157,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027],"},{"line_number":158,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":159,"context_line":"                },"},{"line_number":160,"context_line":"                \u0027url\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"35dc1f76_52a19d88","line":157,"range":{"start_line":157,"start_character":39,"end_line":157,"end_character":45},"in_reply_to":"c8eb1a65_0cfc71e1","updated":"2025-06-24 14:14:26.000000000","message":"Acknowledged","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"4779266f_6989a141","line":206,"range":{"start_line":206,"start_character":30,"end_line":206,"end_character":33},"updated":"2025-06-06 15:25:28.000000000","message":"From the doc it seems to be: rdp-html5","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"270520242551b5ca9f47b0cfd8c10773810bbdff","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"f30541f3_ee527b06","line":206,"range":{"start_line":206,"start_character":30,"end_line":206,"end_character":33},"in_reply_to":"4779266f_6989a141","updated":"2025-06-09 13:49:07.000000000","message":"Good catch. Will fix.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7107842970d8dd950597dfe3b818538325cea74b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"636dce56_5624aac0","line":206,"range":{"start_line":206,"start_character":30,"end_line":206,"end_character":33},"in_reply_to":"b6e0f4fc_ec1cb716","updated":"2025-06-24 15:20:12.000000000","message":"Yeah, sorry, I\u0027ve done this here https://review.opendev.org/c/openstack/nova/+/952213/","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29961c8006b55e2acabffad51d176646835aa581","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"b6e0f4fc_ec1cb716","line":206,"range":{"start_line":206,"start_character":30,"end_line":206,"end_character":33},"in_reply_to":"f30541f3_ee527b06","updated":"2025-06-24 14:14:26.000000000","message":"the api refe documented the protocl as rdp \nhttps://github.com/openstack/nova/blob/15bd66dc9082b85b1f275ff8f6936059ff977a4e/api-ref/source/servers-remote-consoles.inc?plain\u003d1#L20\n\nand type as `rdp-html5`\n\nso rene is correct but given support for this has been deleted for some time and we are not going to backport this im fine with fixing this in a followup.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8008481c22d7239d59e70a87cba96dbf98126fa5","unresolved":true,"context_lines":[{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":196,"context_line":"}"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"get_rdp_console_response \u003d {"},{"line_number":199,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":200,"context_line":"    \u0027properties\u0027: {"},{"line_number":201,"context_line":"        \u0027console\u0027: {"},{"line_number":202,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"},{"line_number":210,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":211,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":212,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":213,"context_line":"                },"},{"line_number":214,"context_line":"            },"},{"line_number":215,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":216,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":217,"context_line":"        },"},{"line_number":218,"context_line":"    },"},{"line_number":219,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":220,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":221,"context_line":"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"get_serial_console_response \u003d {"},{"line_number":224,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"02d786aa_8d883500","line":221,"range":{"start_line":197,"start_character":0,"end_line":221,"end_character":1},"updated":"2025-06-09 22:49:03.000000000","message":"as this API is 400 always, we do not need response schema right? or empty schema like request schema.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9faf3b1281f8072d6247bea4471cc9f9c185fd6c","unresolved":true,"context_lines":[{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":196,"context_line":"}"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"get_rdp_console_response \u003d {"},{"line_number":199,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":200,"context_line":"    \u0027properties\u0027: {"},{"line_number":201,"context_line":"        \u0027console\u0027: {"},{"line_number":202,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"},{"line_number":210,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":211,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":212,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":213,"context_line":"                },"},{"line_number":214,"context_line":"            },"},{"line_number":215,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":216,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":217,"context_line":"        },"},{"line_number":218,"context_line":"    },"},{"line_number":219,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":220,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":221,"context_line":"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"get_serial_console_response \u003d {"},{"line_number":224,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f09b631b_3d0c8e13","line":221,"range":{"start_line":197,"start_character":0,"end_line":221,"end_character":1},"in_reply_to":"02d786aa_8d883500","updated":"2025-06-10 09:39:45.000000000","message":"Uggla has a similar comment and [my response is the same](https://review.opendev.org/c/openstack/nova/+/940114/comment/d4215c0c_35c24f7a/): because this value was supported in the past, and because our schemas and docs are unversioned (we\u0027ll always generated them from `master`), IMO we need to provide schemas for all APIs, even removed ones. If we don\u0027t, our docs are incomplete and we won\u0027t be able to generate clients that work with older releases of OpenStack.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bad4043fa55358a8042d6579db3cfb2e088f042","unresolved":true,"context_lines":[{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":196,"context_line":"}"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"get_rdp_console_response \u003d {"},{"line_number":199,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":200,"context_line":"    \u0027properties\u0027: {"},{"line_number":201,"context_line":"        \u0027console\u0027: {"},{"line_number":202,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"},{"line_number":210,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":211,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":212,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":213,"context_line":"                },"},{"line_number":214,"context_line":"            },"},{"line_number":215,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":216,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":217,"context_line":"        },"},{"line_number":218,"context_line":"    },"},{"line_number":219,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":220,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":221,"context_line":"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"get_serial_console_response \u003d {"},{"line_number":224,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8cce4730_f465f534","line":221,"range":{"start_line":197,"start_character":0,"end_line":221,"end_character":1},"in_reply_to":"1a94c01f_e53b9a65","updated":"2025-06-10 16:44:55.000000000","message":"\u003e request is ok as user can request it becuase endpoint exist. But API always return 400 with error message and no response body. Having response schema even empty indicate that this API can return response.\n\nI\u0027ve responded on the follow-up also, but the API always returns HTTP 400 *if* you are using post-Caracal or pre-Caracal with another non-Hyper-V virt driver. This is not true if you are using the Hyper-V virt driver, however. As I said above, our docs and clients are unversioned so we need to document every supported version, even if it\u0027s done very loosely. In any case, this is effectively a noop since we will always raise an exception in these methods, which means these schemas will never be evaluated against response bodies (there are no response bodies). This exists purely for `os-api-ref` / `codegenerator` purposes.\n\n\u003e API gone for all the microversions are gone and we just need to indicate them \u0027GONE\u0027 without showing any request/response schema. If tool requires some response schema for always-error APIs then it should either skip them or expect error code also along with response schema.\n\nOur decorators don\u0027t required these schemas, but `os-api-ref` and `codegenerator` will.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4dc1ff24a973e2f0f9f39a9427d5fc9a6bddb93","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":196,"context_line":"}"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"get_rdp_console_response \u003d {"},{"line_number":199,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":200,"context_line":"    \u0027properties\u0027: {"},{"line_number":201,"context_line":"        \u0027console\u0027: {"},{"line_number":202,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"},{"line_number":210,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":211,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":212,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":213,"context_line":"                },"},{"line_number":214,"context_line":"            },"},{"line_number":215,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":216,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":217,"context_line":"        },"},{"line_number":218,"context_line":"    },"},{"line_number":219,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":220,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":221,"context_line":"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"get_serial_console_response \u003d {"},{"line_number":224,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b28ca89e_8461b145","line":221,"range":{"start_line":197,"start_character":0,"end_line":221,"end_character":1},"in_reply_to":"8cce4730_f465f534","updated":"2025-06-10 21:32:50.000000000","message":"Yeah, you are right. I think no harm to keep it and usage of pre-caracel is valid one. \n\nI am ok to keep it as it is (we do not need to empty it)","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a83beb7984b1a8ef75328fd7d31c883533c62273","unresolved":true,"context_lines":[{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":196,"context_line":"}"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"get_rdp_console_response \u003d {"},{"line_number":199,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":200,"context_line":"    \u0027properties\u0027: {"},{"line_number":201,"context_line":"        \u0027console\u0027: {"},{"line_number":202,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"},{"line_number":210,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":211,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":212,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":213,"context_line":"                },"},{"line_number":214,"context_line":"            },"},{"line_number":215,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":216,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":217,"context_line":"        },"},{"line_number":218,"context_line":"    },"},{"line_number":219,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":220,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":221,"context_line":"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"get_serial_console_response \u003d {"},{"line_number":224,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a94c01f_e53b9a65","line":221,"range":{"start_line":197,"start_character":0,"end_line":221,"end_character":1},"in_reply_to":"e4dc1dd4_ad5d7b7b","updated":"2025-06-10 16:02:58.000000000","message":"request is ok as user can request it becuase endpoint exist. But API always return 400 with error message and no response body. Having response schema even empty indicate that this API can return response.\n\nAPI gone for all the microversions are gone and we just need to indicate them \u0027GONE\u0027 without showing any request/response schema. If tool requires some response schema for always-error APIs then it should either skip them or expect error code also along with response schema.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fbe46336b0dfc0e8f4fdeeb7091c1acc570ae4e0","unresolved":true,"context_lines":[{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":196,"context_line":"}"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"get_rdp_console_response \u003d {"},{"line_number":199,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":200,"context_line":"    \u0027properties\u0027: {"},{"line_number":201,"context_line":"        \u0027console\u0027: {"},{"line_number":202,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":203,"context_line":"            \u0027properties\u0027: {"},{"line_number":204,"context_line":"                \u0027type\u0027: {"},{"line_number":205,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":206,"context_line":"                    \u0027const\u0027: \u0027rdp\u0027,"},{"line_number":207,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":208,"context_line":"                },"},{"line_number":209,"context_line":"                \u0027url\u0027: {"},{"line_number":210,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":211,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":212,"context_line":"                    \u0027description\u0027: \u0027\u0027,"},{"line_number":213,"context_line":"                },"},{"line_number":214,"context_line":"            },"},{"line_number":215,"context_line":"            \u0027required\u0027: [\u0027type\u0027, \u0027url\u0027],"},{"line_number":216,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":217,"context_line":"        },"},{"line_number":218,"context_line":"    },"},{"line_number":219,"context_line":"    \u0027required\u0027: [\u0027console\u0027],"},{"line_number":220,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":221,"context_line":"}"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"get_serial_console_response \u003d {"},{"line_number":224,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"e4dc1dd4_ad5d7b7b","line":221,"range":{"start_line":197,"start_character":0,"end_line":221,"end_character":1},"in_reply_to":"f09b631b_3d0c8e13","updated":"2025-06-10 09:44:58.000000000","message":"...then again, I\u0027ve left the schema empty for request. Hmm, what do we do?","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29961c8006b55e2acabffad51d176646835aa581","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            \u0027properties\u0027: {"},{"line_number":254,"context_line":"                \u0027protocol\u0027: {"},{"line_number":255,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":256,"context_line":"                    \u0027enum\u0027: [\u0027vnc\u0027, \u0027spice\u0027, \u0027serial\u0027],"},{"line_number":257,"context_line":"                },"},{"line_number":258,"context_line":"                \u0027type\u0027: {"},{"line_number":259,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d2f03f64_715aebe0","line":256,"updated":"2025-06-24 14:14:26.000000000","message":"this used to have rdp","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7107842970d8dd950597dfe3b818538325cea74b","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            \u0027properties\u0027: {"},{"line_number":254,"context_line":"                \u0027protocol\u0027: {"},{"line_number":255,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":256,"context_line":"                    \u0027enum\u0027: [\u0027vnc\u0027, \u0027spice\u0027, \u0027serial\u0027],"},{"line_number":257,"context_line":"                },"},{"line_number":258,"context_line":"                \u0027type\u0027: {"},{"line_number":259,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"85fd9b25_5af04f98","line":256,"in_reply_to":"d2f03f64_715aebe0","updated":"2025-06-24 15:20:12.000000000","message":"https://review.opendev.org/c/openstack/nova/+/952213/","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":true,"context_lines":[{"line_number":257,"context_line":"                },"},{"line_number":258,"context_line":"                \u0027type\u0027: {"},{"line_number":259,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":260,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027serial\u0027],"},{"line_number":261,"context_line":"                },"},{"line_number":262,"context_line":"                \u0027url\u0027: {"},{"line_number":263,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d98cd8e_c5b7a68b","line":260,"range":{"start_line":260,"start_character":39,"end_line":260,"end_character":45},"updated":"2025-06-06 15:25:28.000000000","message":"This one seems not define in the api doc","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7107842970d8dd950597dfe3b818538325cea74b","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                },"},{"line_number":258,"context_line":"                \u0027type\u0027: {"},{"line_number":259,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":260,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027serial\u0027],"},{"line_number":261,"context_line":"                },"},{"line_number":262,"context_line":"                \u0027url\u0027: {"},{"line_number":263,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c4a75980_e5708e3a","line":260,"range":{"start_line":260,"start_character":39,"end_line":260,"end_character":45},"in_reply_to":"1f9d8bae_25e87ab0","updated":"2025-06-24 15:20:12.000000000","message":"https://review.opendev.org/c/openstack/nova/+/952213/","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"270520242551b5ca9f47b0cfd8c10773810bbdff","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                },"},{"line_number":258,"context_line":"                \u0027type\u0027: {"},{"line_number":259,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":260,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027serial\u0027],"},{"line_number":261,"context_line":"                },"},{"line_number":262,"context_line":"                \u0027url\u0027: {"},{"line_number":263,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8b81d12a_d044111f","line":260,"range":{"start_line":260,"start_character":39,"end_line":260,"end_character":45},"in_reply_to":"2d98cd8e_c5b7a68b","updated":"2025-06-09 13:49:07.000000000","message":"As above.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29961c8006b55e2acabffad51d176646835aa581","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                },"},{"line_number":258,"context_line":"                \u0027type\u0027: {"},{"line_number":259,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":260,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027spice-html5\u0027, \u0027serial\u0027],"},{"line_number":261,"context_line":"                },"},{"line_number":262,"context_line":"                \u0027url\u0027: {"},{"line_number":263,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f9d8bae_25e87ab0","line":260,"range":{"start_line":260,"start_character":39,"end_line":260,"end_character":45},"in_reply_to":"8b81d12a_d044111f","updated":"2025-06-24 14:14:26.000000000","message":"and rdp-html5","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a0bb9b93d5081435922f35e4ed7459dee3c3171e","unresolved":true,"context_lines":[{"line_number":264,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":265,"context_line":"                },"},{"line_number":266,"context_line":"            },"},{"line_number":267,"context_line":"            \u0027required\u0027: [\u0027protocol\u0027, \u0027type\u0027],"},{"line_number":268,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":269,"context_line":"        },"},{"line_number":270,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"a98ef8a8_0ebac9f4","line":267,"range":{"start_line":267,"start_character":43,"end_line":267,"end_character":44},"updated":"2025-06-09 22:56:20.000000000","message":"\u0027url\u0027 also mandatory field\n https://github.com/openstack/nova/blob/21943b55215d3716284d387365dd1f035494da74/nova/api/openstack/compute/remote_consoles.py#L160","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4dc1ff24a973e2f0f9f39a9427d5fc9a6bddb93","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    \u0027format\u0027: \u0027uri\u0027,"},{"line_number":265,"context_line":"                },"},{"line_number":266,"context_line":"            },"},{"line_number":267,"context_line":"            \u0027required\u0027: [\u0027protocol\u0027, \u0027type\u0027],"},{"line_number":268,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":269,"context_line":"        },"},{"line_number":270,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"cd99e2e5_39ab7608","line":267,"range":{"start_line":267,"start_character":43,"end_line":267,"end_character":44},"in_reply_to":"a98ef8a8_0ebac9f4","updated":"2025-06-10 21:32:50.000000000","message":"I commented it in followup.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"3165db65588fc72a3396e4f89fe4658fde8cdb33","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":273,"context_line":"}"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"create_response_v28 \u003d copy.deepcopy(create_response)"},{"line_number":276,"context_line":"create_response_v28[\u0027properties\u0027][\u0027remote_console\u0027][\u0027properties\u0027]["},{"line_number":277,"context_line":"    \u0027protocol\u0027"},{"line_number":278,"context_line":"][\u0027enum\u0027].append(\u0027mks\u0027)"},{"line_number":279,"context_line":"create_response_v28[\u0027properties\u0027][\u0027remote_console\u0027][\u0027properties\u0027]["},{"line_number":280,"context_line":"    \u0027type\u0027"},{"line_number":281,"context_line":"][\u0027enum\u0027].append(\u0027webmks\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"create_response_v299 \u003d copy.deepcopy(create_response_v28)"},{"line_number":284,"context_line":"create_response_v299[\u0027properties\u0027][\u0027remote_console\u0027][\u0027properties\u0027]["},{"line_number":285,"context_line":"    \u0027type\u0027"},{"line_number":286,"context_line":"][\u0027enum\u0027].append(\u0027spice-direct\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ecf886b_2a751f47","line":286,"range":{"start_line":275,"start_character":0,"end_line":286,"end_character":32},"updated":"2025-06-06 15:25:28.000000000","message":"Note to myself: ok we append based on the api version.","commit_id":"485ee768d6206911e5a80a6e936fce0b7b0840bf"}]}