)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ced3770ea1c84069ca98383b75032373b8cb91e7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"by the commit[1]. And the libvirt behavior change causes"},{"line_number":12,"context_line":"VM boot failure with some Neutron plugin. For example,"},{"line_number":13,"context_line":"the calico plugin uses the vif_type is tap device and"},{"line_number":14,"context_line":"it fails to create tap device."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit adds managed\u003d\"no\" flag to the target device"},{"line_number":17,"context_line":"section in the xml domain file. The extra flag allows"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d5b5cea5_c2de2638","line":14,"updated":"2025-01-24 14:50:32.000000000","message":"https://libvirt.org/formatdomain.html#generic-ethernet-connection\ndoes not define a manged attribute for the ethernet type\n\nalthough it is defeind on the target element it would seam.\n\n```\nSince 5.7.0 Using managed\u003d\u0027no\u0027 with a pre-created tap device is useful because it permits a virtual machine managed by an unprivileged libvirtd to have emulated network devices based on tap devices.\n```\n\nour min version fo libvirt and qemu are new enough to not need a version check as all supported version support this element.\n\nMIN_LIBVIRT_VERSION \u003d (7, 0, 0)\nMIN_QEMU_VERSION \u003d (5, 2, 0)\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L221C1-L222C29","commit_id":"92230653358eb456d5c97d0051be03fdf237a081"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"1d5ac46371c67c41cb06accc67df6e3cfe178586","unresolved":true,"context_lines":[{"line_number":11,"context_line":"by the commit[1]. And the libvirt behavior change causes"},{"line_number":12,"context_line":"VM boot failure with some Neutron plugin. For example,"},{"line_number":13,"context_line":"the calico plugin uses the vif_type is tap device and"},{"line_number":14,"context_line":"it fails to create tap device."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit adds managed\u003d\"no\" flag to the target device"},{"line_number":17,"context_line":"section in the xml domain file. The extra flag allows"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dd348184_d58cee00","line":14,"in_reply_to":"d5b5cea5_c2de2638","updated":"2025-03-24 18:33:59.000000000","message":"I completely missed the MIN version definition. thanks.","commit_id":"92230653358eb456d5c97d0051be03fdf237a081"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"56152f7bedab34740dfca87e789b676964d0de3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62e8a08e_32816e72","updated":"2025-05-30 16:30:18.000000000","message":"Masahito-san I would just like to say thank you for identifying this problem and for proposing this fix. I am in the upstream Calico team, and we have just seen this problem for the first time after updating our testing to run on Ubuntu 24.04.","commit_id":"92230653358eb456d5c97d0051be03fdf237a081"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a1c6c8d34141a24404a87a6a0613e3bcec183168","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"94a14704_fc06cb7d","in_reply_to":"62e8a08e_32816e72","updated":"2025-05-30 16:56:06.000000000","message":"in the orgial bug reprot on irc \n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L427\n\nor rater in the funcitons that are used for backend that create the tap out of band\n\nlike calico and midone\n\nhttps://bugs.launchpad.net/nova/+bug/2033681\n\neffectivly that may be all backend that use vnic_type\u003dtap\n\n\nthe problem with the current patch is it does nto set it only in the targeted location where ist required\nit set managed\u003dno for all network interfaces by default in the base class\n\nso that wont work and we cant proceed with this revsion of the patch.\n\none of the concers i raised in another comment is there si no thirdparty or first party ci for calico so we dont really have a good way ot knwo if this will infact fix it\n\nsettign managed\u003dno shoudl work but longterm if calico is to contiue to be supproted it shoudl be tested.\n\nare there any calico neturon jobs that we could perhaps enable or is there a third party ci that the calico comuntiy runs to verify this continues to work?","commit_id":"92230653358eb456d5c97d0051be03fdf237a081"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ced3770ea1c84069ca98383b75032373b8cb91e7","unresolved":true,"context_lines":[{"line_number":1612,"context_line":"             \u003cmodel type\u003d\"virtio\"/\u003e"},{"line_number":1613,"context_line":"             \u003csource bridge\u003d\"br100\"/\u003e"},{"line_number":1614,"context_line":"             \u003cmtu size\u003d\"9000\"/\u003e"},{"line_number":1615,"context_line":"             \u003ctarget dev\u003d\"nicdc065497-3c\" managed\u003d\"no\"/\u003e"},{"line_number":1616,"context_line":"             \u003cbandwidth\u003e"},{"line_number":1617,"context_line":"              \u003cinbound average\u003d\"100\" peak\u003d\"200\" burst\u003d\"300\"/\u003e"},{"line_number":1618,"context_line":"              \u003coutbound average\u003d\"10\" peak\u003d\"20\" burst\u003d\"30\"/\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f3fad9c_9b6f839f","line":1615,"updated":"2025-01-24 14:50:32.000000000","message":"this is showign that you are braking backward compatiblity for other network backends.","commit_id":"92230653358eb456d5c97d0051be03fdf237a081"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ced3770ea1c84069ca98383b75032373b8cb91e7","unresolved":true,"context_lines":[{"line_number":1912,"context_line":"        self.device_addr \u003d None"},{"line_number":1913,"context_line":"        self.mtu \u003d None"},{"line_number":1914,"context_line":"        self.alias \u003d None"},{"line_number":1915,"context_line":"        self.managed \u003d \"no\""},{"line_number":1916,"context_line":""},{"line_number":1917,"context_line":"    def __eq__(self, other):"},{"line_number":1918,"context_line":"        if not isinstance(other, LibvirtConfigGuestInterface):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0e4862e_2cd9ddbe","line":1915,"updated":"2025-01-24 14:50:32.000000000","message":"we cant default this to no here\n\nthat will effect other inerface types. this willl need to default to None.\n\nhave you considered the general upgrade impact.\n\nif we have an instance without this change say runing on dalmatian we need to make sure you can live migrate it to an epoxy host.\n\nnow what i think will happen currently is the xml will not be modifed. however we need to ensrue that either the managed flag is not updated of the current domain or if it is updated we need to ensure that libvirt allows that.\n\nit would be bad if you could no longer live migrate instance created before this change after it was applied.\n\nwe do not have any tempest ci coverage of calico today.\n\nhave you tested live migrating between host with/without this patch?","commit_id":"92230653358eb456d5c97d0051be03fdf237a081"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"1d5ac46371c67c41cb06accc67df6e3cfe178586","unresolved":true,"context_lines":[{"line_number":1912,"context_line":"        self.device_addr \u003d None"},{"line_number":1913,"context_line":"        self.mtu \u003d None"},{"line_number":1914,"context_line":"        self.alias \u003d None"},{"line_number":1915,"context_line":"        self.managed \u003d \"no\""},{"line_number":1916,"context_line":""},{"line_number":1917,"context_line":"    def __eq__(self, other):"},{"line_number":1918,"context_line":"        if not isinstance(other, LibvirtConfigGuestInterface):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8cb6f34f_e8f4b06f","line":1915,"in_reply_to":"d0e4862e_2cd9ddbe","updated":"2025-03-24 18:33:59.000000000","message":"Thanks for the comment. we use same qemu, libvirt and nova version in our deployment so the fist commit code doesn\u0027t care the situation there are multiple version situation.\nLet me update the code as it\u0027s configurable.","commit_id":"92230653358eb456d5c97d0051be03fdf237a081"}]}