)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8116c85fe3296cf8433adc93878eba7f5c65fa05","unresolved":true,"context_lines":[{"line_number":10,"context_line":"connected in place data migration. If the cpu_policy is dedicated the"},{"line_number":11,"context_line":"content of the cpuset is moved to to the new pcpuset field during the"},{"line_number":12,"context_line":"load of the data from the DB and the ovo is persisted back to the DB."},{"line_number":13,"context_line":"However during this data migration the version of the ovo is not bumped"},{"line_number":14,"context_line":"to the latest, 1.6, version. Therefore the DB contains an inconsistent"},{"line_number":15,"context_line":"object as it has the new pcpuset field from 1.6 but the"},{"line_number":16,"context_line":"nova_object.version is still set to 1.4. It turned out that this can"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"44e71b6b_96b389a3","line":13,"range":{"start_line":13,"start_character":65,"end_line":13,"end_character":71},"updated":"2025-02-04 17:51:07.000000000","message":"Same comment here as the other patch. I think of \"bumping the version\" as a compile/development-time operation, and \"updating\" being the thing that happens at runtime. Still not critical, but just saying...","commit_id":"ae2f9bd573dc1923bdb2504f5a0ab7cf706109e8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8116c85fe3296cf8433adc93878eba7f5c65fa05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ae2db8ac_02ec0095","updated":"2025-02-04 17:51:07.000000000","message":"+1 for two-phase repro-then-fix :)","commit_id":"ae2f9bd573dc1923bdb2504f5a0ab7cf706109e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57d63f2c0bbfa3ac025ea1cedbfe425ea2a9e474","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"78ea1c5d_600623c2","updated":"2025-02-15 18:59:50.000000000","message":"before we +w this we shoudl proably also get \n\nhttps://review.opendev.org/c/openstack/nova/+/940953/6\n\nready to merged.\n\nideally the 3 of thse will merge together","commit_id":"ae2f9bd573dc1923bdb2504f5a0ab7cf706109e8"}],"nova/tests/unit/objects/test_instance_numa.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"08ea0f49ae7510b0946628bb0577e3ff15d656f5","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        # data is saved back to the DB it still has the old version 1.4, but"},{"line_number":451,"context_line":"        # also it has the new pcpuset field from version 1.6. This is bug"},{"line_number":452,"context_line":"        # https://bugs.launchpad.net/nova/+bug/2097359."},{"line_number":453,"context_line":"        self.assertEqual(\u00271.4\u0027, topo_loaded.cells[0].VERSION)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"class TestInstanceNUMATopology("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f9e7cb1_166c06e6","line":453,"updated":"2025-02-09 01:26:22.000000000","message":"ack","commit_id":"ae2f9bd573dc1923bdb2504f5a0ab7cf706109e8"}]}
