)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b8aa8711951994f7c11e778411e1c2dca7ee4845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b895041_498c0db8","updated":"2025-02-18 18:16:26.000000000","message":"im not sure i agree that we shoudl merge this test only change first.\n\nwe really shoudl only update this when the code change that requires it is done.","commit_id":"37b5d1d6fd401366b4245565e888470389c57f3f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"783b6d83dcdc715937f267eeb5c599cb0f02d314","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"69fdc365_89827083","in_reply_to":"8b895041_498c0db8","updated":"2025-02-18 18:44:11.000000000","message":"Main reason why I added manager role in unit tests before code change is that we can see *what all persmission manager role currently has (bcz manager role implies member, reader role)* VS *what permission will be changed when we add manager role in policy*. This is what we have done for RBAC phase-1 (adding reader role) also and that helped us to know actual impact of default change.\n\nI think that is useful to know the impact otherwise just adding manager role in policy change commit will not give us clear pic. Imagine if we do that then all these changes I am doing here will be added in the policy changes also which will make that change difficult to review/know actual impact.","commit_id":"37b5d1d6fd401366b4245565e888470389c57f3f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4ed0feb14fbcb81dd87965bc82cd1a9db536fe92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a42ce7f6_8493bbe9","updated":"2025-07-09 19:28:05.000000000","message":"doing this unit test change first still feels odd to me but i accpeted your logic before for the split so im not goign to revist that.\n\nthis looks ok over all","commit_id":"38f978d39a02ff6a350a7cb68949b230139a84a9"}],"nova/tests/unit/policies/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b8aa8711951994f7c11e778411e1c2dca7ee4845","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        # project scoped users"},{"line_number":99,"context_line":"        self.project_admin_context \u003d nova_context.RequestContext("},{"line_number":100,"context_line":"                user_id\u003d\"project_admin\", project_id\u003dself.project_id,"},{"line_number":101,"context_line":"                roles\u003d[\u0027admin\u0027, \u0027member\u0027, \u0027reader\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.project_manager_context \u003d nova_context.RequestContext("},{"line_number":104,"context_line":"                user_id\u003d\"project_manager\", project_id\u003dself.project_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"72a5dfc7_6d48e595","line":101,"range":{"start_line":101,"start_character":15,"end_line":101,"end_character":52},"updated":"2025-02-18 18:16:26.000000000","message":"isn\u0027t admin meant to imply manager.\nand manager implies member which implies reader so \nshould this not be updated too?","commit_id":"37b5d1d6fd401366b4245565e888470389c57f3f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa9ab80b305941ca097af37e532f6c0a69c6e870","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # project scoped users"},{"line_number":99,"context_line":"        self.project_admin_context \u003d nova_context.RequestContext("},{"line_number":100,"context_line":"                user_id\u003d\"project_admin\", project_id\u003dself.project_id,"},{"line_number":101,"context_line":"                roles\u003d[\u0027admin\u0027, \u0027member\u0027, \u0027reader\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.project_manager_context \u003d nova_context.RequestContext("},{"line_number":104,"context_line":"                user_id\u003d\"project_manager\", project_id\u003dself.project_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"54edffb2_772ffe53","line":101,"range":{"start_line":101,"start_character":15,"end_line":101,"end_character":52},"in_reply_to":"1fd4fb74_e4999ec5","updated":"2025-06-18 21:12:23.000000000","message":"Done","commit_id":"37b5d1d6fd401366b4245565e888470389c57f3f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"783b6d83dcdc715937f267eeb5c599cb0f02d314","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        # project scoped users"},{"line_number":99,"context_line":"        self.project_admin_context \u003d nova_context.RequestContext("},{"line_number":100,"context_line":"                user_id\u003d\"project_admin\", project_id\u003dself.project_id,"},{"line_number":101,"context_line":"                roles\u003d[\u0027admin\u0027, \u0027member\u0027, \u0027reader\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.project_manager_context \u003d nova_context.RequestContext("},{"line_number":104,"context_line":"                user_id\u003d\"project_manager\", project_id\u003dself.project_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fd4fb74_e4999ec5","line":101,"range":{"start_line":101,"start_character":15,"end_line":101,"end_character":52},"in_reply_to":"72a5dfc7_6d48e595","updated":"2025-02-18 18:44:11.000000000","message":"right, I need to add here.","commit_id":"37b5d1d6fd401366b4245565e888470389c57f3f"}]}