)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"58386e679bc4c74e282ebf30ea1a8056d6216f86","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Properly handle snatting for external gateways"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, snatting for netowrks with external gateways had to be"},{"line_number":10,"context_line":"handled by manually setting:"},{"line_number":11,"context_line":" * public_interface \u003d \u0027\u0027"},{"line_number":12,"context_line":" * force_snat_range \u003d snat_range"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7adec928_46ecdb8f","line":9,"updated":"2014-05-23 18:50:11.000000000","message":"s/netowrks/networks","commit_id":"6c961795ecef8cdae664550ca0cc6cd3aee814fc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"58386e679bc4c74e282ebf30ea1a8056d6216f86","unresolved":false,"context_lines":[{"line_number":14,"context_line":" * public_interface \u003d eth0"},{"line_number":15,"context_line":" * force_snat_range \u003d None or [\u00270.0.0.0/0\u0027]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In order to support both simultaneously, we calcualate whether the"},{"line_number":18,"context_line":"gateway is external, and use the force_snat_range and skip interface"},{"line_number":19,"context_line":"if it is an external gateway. Otherwise, we use the setting for public"},{"line_number":20,"context_line":"interface and 0.0.0.0/0. This allows external and internal gateways"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7adec928_c6f70b58","line":17,"updated":"2014-05-23 18:50:11.000000000","message":"s/calcualate/calculate","commit_id":"6c961795ecef8cdae664550ca0cc6cd3aee814fc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b114382dd27c5c18c47915958407d3717935260","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Properly handle snatting for external gateways"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, snatting for netowrks with external gateways had to be"},{"line_number":10,"context_line":"handled by manually setting:"},{"line_number":11,"context_line":" * public_interface \u003d \u0027\u0027"},{"line_number":12,"context_line":" * force_snat_range \u003d snat_range"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5adbc538_1f319eec","line":9,"updated":"2014-05-25 20:15:45.000000000","message":"s/netowrks/networks/ :)","commit_id":"38c067a664ab06f268737cfe5ac1ea4f5ab7fe5f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b114382dd27c5c18c47915958407d3717935260","unresolved":false,"context_lines":[{"line_number":14,"context_line":" * public_interface \u003d eth0"},{"line_number":15,"context_line":" * force_snat_range \u003d None or [\u00270.0.0.0/0\u0027]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In order to support both simultaneously, we calcualate whether the"},{"line_number":18,"context_line":"gateway is external, and use the force_snat_range and skip interface"},{"line_number":19,"context_line":"if it is an external gateway. Otherwise, we use the setting for public"},{"line_number":20,"context_line":"interface and 0.0.0.0/0. This allows external and internal gateways"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5adbc538_5f524614","line":17,"updated":"2014-05-25 20:15:45.000000000","message":"s/calcualate/calculate/","commit_id":"38c067a664ab06f268737cfe5ac1ea4f5ab7fe5f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"24836783784b716f3c5e6f0479f7750da4bf284b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Properly handle snatting for external gateways"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, snatting for netowrks with external gateways had to be"},{"line_number":10,"context_line":"handled by manually setting:"},{"line_number":11,"context_line":" * public_interface \u003d \u0027\u0027"},{"line_number":12,"context_line":" * force_snat_range \u003d snat_range"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_2220c8f6","line":9,"updated":"2014-06-09 21:54:07.000000000","message":"s/netowrks/networks/","commit_id":"1868d22397956d8ade504ec85588e381f32d1954"}],"nova/network/linux_net.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"58386e679bc4c74e282ebf30ea1a8056d6216f86","unresolved":false,"context_lines":[{"line_number":659,"context_line":"    iptables_manager.apply()"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"def add_snat_rule(ip_range, gateway_ext\u003dFalse):"},{"line_number":663,"context_line":"    if CONF.routing_source_ip:"},{"line_number":664,"context_line":"        if gateway_ext:"},{"line_number":665,"context_line":"            if CONF.force_snat_range:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_266eef01","line":662,"updated":"2014-05-23 18:50:11.000000000","message":"In the absense of any docstrings, and for code readability, I\u0027d prefer to see boolean parameters use an \"is_\" or \"has_\" prefix... Can we use \"is_ext\" here, instead of gateway_ext?","commit_id":"6c961795ecef8cdae664550ca0cc6cd3aee814fc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"58386e679bc4c74e282ebf30ea1a8056d6216f86","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        iptables_manager.apply()"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"def init_host(ip_range, gateway_ext\u003dFalse):"},{"line_number":681,"context_line":"    \"\"\"Basic networking setup goes here.\"\"\""},{"line_number":682,"context_line":"    # NOTE(devcamcar): Cloud public SNAT entries and the default"},{"line_number":683,"context_line":"    # SNAT rule for outbound traffic."}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_667717d5","line":680,"updated":"2014-05-23 18:50:11.000000000","message":"ditto...","commit_id":"6c961795ecef8cdae664550ca0cc6cd3aee814fc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b114382dd27c5c18c47915958407d3717935260","unresolved":false,"context_lines":[{"line_number":659,"context_line":"    iptables_manager.apply()"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"def add_snat_rule(ip_range, gateway_ext\u003dFalse):"},{"line_number":663,"context_line":"    if CONF.routing_source_ip:"},{"line_number":664,"context_line":"        if gateway_ext:"},{"line_number":665,"context_line":"            if CONF.force_snat_range:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5adbc538_9f5cce27","line":662,"updated":"2014-05-25 20:15:45.000000000","message":"In the absense of any docstrings, and for code readability, I\u0027d prefer to see boolean parameters use an \"is_\" or \"has_\" prefix... Can we use \"is_ext\" here, instead of gateway_ext?","commit_id":"38c067a664ab06f268737cfe5ac1ea4f5ab7fe5f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b114382dd27c5c18c47915958407d3717935260","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        iptables_manager.apply()"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"def init_host(ip_range, gateway_ext\u003dFalse):"},{"line_number":681,"context_line":"    \"\"\"Basic networking setup goes here.\"\"\""},{"line_number":682,"context_line":"    # NOTE(devcamcar): Cloud public SNAT entries and the default"},{"line_number":683,"context_line":"    # SNAT rule for outbound traffic."}],"source_content_type":"text/x-python","patch_set":8,"id":"5adbc538_bf40aa36","line":680,"updated":"2014-05-25 20:15:45.000000000","message":"ditto","commit_id":"38c067a664ab06f268737cfe5ac1ea4f5ab7fe5f"}]}