)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5cc99d158d9f14ffaf61fd0eac7711acf5fe91ce","unresolved":true,"context_lines":[{"line_number":13,"context_line":"[0] https://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #2091185"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I03cb85200cc362b8ec876bdb955e8c0bb41f2c6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"70abc351_06ac8a6a","line":16,"updated":"2025-02-15 21:07:53.000000000","message":"this is a new feature not bug.\n\nit shoudl be tacked with a bluprint and possibly a spec","commit_id":"b30b6562dc5cdf65add33a405c3ff2bd609593ad"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"84657fa784e660d25cab0110dca7b073897be6ff","unresolved":false,"context_lines":[{"line_number":13,"context_line":"[0] https://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #2091185"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I03cb85200cc362b8ec876bdb955e8c0bb41f2c6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"56b32267_511ea1e6","line":16,"in_reply_to":"70abc351_06ac8a6a","updated":"2025-02-16 11:53:15.000000000","message":"Acknowledged","commit_id":"b30b6562dc5cdf65add33a405c3ff2bd609593ad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed491d061f0cc1f87958d20420d3b3789a595b40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8c60c607_191c5cfa","updated":"2025-02-15 00:56:55.000000000","message":"recheck nova-grenade-multinode","commit_id":"e53579ea22be104e4c68f022197abad28f838b7c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5cc99d158d9f14ffaf61fd0eac7711acf5fe91ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ca0c8fa8_ecf1160f","updated":"2025-02-15 21:07:53.000000000","message":"this may be worth considering but if we were to do this we should likely have a spec that detail which version of could it support this feature and we shoudl perhaps have tempest test to validate it.\n\nin any case before this can proceed this need wider discussion as its a new feature not a bug.","commit_id":"b30b6562dc5cdf65add33a405c3ff2bd609593ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4acbf61f6dcd0fa107a18ca0dda816552dd03b95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e489109c_e74674c2","in_reply_to":"367b3d08_ec67eb1f","updated":"2025-02-17 00:37:58.000000000","message":"i have restored it.\n\nim not sure if the orginal propasl makes sense or not today\n\nit had not reached agreement 6 years ago on a desing and i dont know how close or far it was off the top of my head.\n\nit would be good to get neturon folks to reveiw that too.","commit_id":"b30b6562dc5cdf65add33a405c3ff2bd609593ad"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"84657fa784e660d25cab0110dca7b073897be6ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"367b3d08_ec67eb1f","in_reply_to":"ca0c8fa8_ecf1160f","updated":"2025-02-16 11:53:15.000000000","message":"I\u0027ve added such test https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/941355 and it passed on with this patch here https://review.opendev.org/c/openstack/neutron/+/941730.\n\nI\u0027ve start looking for a spec and it seems it was already created long time ago https://review.opendev.org/c/openstack/nova-specs/+/471815/8/specs/queens/approved/expose-vlan-trunking.rst#143 could you please restore that patch so I can push an update there?","commit_id":"b30b6562dc5cdf65add33a405c3ff2bd609593ad"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9bf657bc3f357a8f60b7bbebd3825e2992c5ed87","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ab2e6f64_64a59318","in_reply_to":"e489109c_e74674c2","updated":"2025-02-17 14:35:55.000000000","message":"Thanks, I\u0027ve checked the spec, it as raw without exact details on how its going to be implemented. The only thing related to Neutron so far I see was this bug https://bugs.launchpad.net/neutron/+bug/1705084 where they told that it should be implmented on nova side :-)","commit_id":"b30b6562dc5cdf65add33a405c3ff2bd609593ad"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"83abda78c6d6adfec082d530a7d09ca08eef8551","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8f23aac6_ec783221","updated":"2025-06-05 11:12:20.000000000","message":"It\u0027d be nice if the network_json sample here (https://docs.openstack.org/nova/latest/user/metadata.html#openstack-format-metadata) would cover a sample trunk and subport too. And maybe a sentence mentioning which nova version started supporting trunks.","commit_id":"97871f1e313752f7ac860c63a827524799e289b1"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a7872242adf0a13186ec59f9e910f2e88d659f4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c2b36263_399734d2","updated":"2025-02-21 23:30:31.000000000","message":"The spec talks about optional population of the trunk vifs in metadata.\nafict, this patch always populate the trunk vifs?","commit_id":"97871f1e313752f7ac860c63a827524799e289b1"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"dc9e17429d6348dd8fbc961f88cde8bdf018c549","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b3813b91_388f678a","updated":"2025-05-15 18:01:31.000000000","message":"fwiw, this patch plus the fix I noted has been deployed in production for a bit now by a different operator than what Vasyl is working on this for. So it would be great to see the momentum behind this not die out.","commit_id":"97871f1e313752f7ac860c63a827524799e289b1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"32df2a4cd1e4aa6211e3aa234a691286f849a785","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e98a6058_5704b314","updated":"2025-07-01 17:13:40.000000000","message":"recheck logs rotated","commit_id":"97871f1e313752f7ac860c63a827524799e289b1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c52400000c80e409795cfa4f1ee4974325a00560","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0ee0a65d_a3c95f07","in_reply_to":"c2b36263_399734d2","updated":"2025-02-22 12:17:36.000000000","message":"thanks for review Harald, correct this part is not yet implemented here.","commit_id":"97871f1e313752f7ac860c63a827524799e289b1"}],"nova/network/model.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"7bcead9f9d7f1a0e1174dc76ca1884f6ef9e83ef","unresolved":true,"context_lines":[{"line_number":521,"context_line":"    @classmethod"},{"line_number":522,"context_line":"    def hydrate(cls, vif):"},{"line_number":523,"context_line":"        vif \u003d cls(**vif)"},{"line_number":524,"context_line":"        vif[\u0027trunk_vifs\u0027] \u003d [VIF.hydrate(**trunk_vif) for trunk_vif"},{"line_number":525,"context_line":"                             in vif.get(\u0027trunk_vifs\u0027, [])]"},{"line_number":526,"context_line":"        vif[\u0027network\u0027] \u003d Network.hydrate(vif[\u0027network\u0027])"},{"line_number":527,"context_line":"        return vif"}],"source_content_type":"text/x-python","patch_set":12,"id":"8a18e2a1_9c891d37","line":524,"updated":"2025-02-20 21:27:16.000000000","message":"```suggestion\n        vif[\u0027trunk_vifs\u0027] \u003d [VIF.hydrate(trunk_vif) for trunk_vif\n```\n\nhttps://etherpad.opendev.org/p/nova-trunk-details-941227","commit_id":"97871f1e313752f7ac860c63a827524799e289b1"}],"nova/network/neutron.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"83abda78c6d6adfec082d530a7d09ca08eef8551","unresolved":true,"context_lines":[{"line_number":3461,"context_line":""},{"line_number":3462,"context_line":"    def _populate_trunk_info(self, vif, current_neutron_port, context, client):"},{"line_number":3463,"context_line":"        trunk_details \u003d current_neutron_port.get(\"trunk_details\", {})"},{"line_number":3464,"context_line":"        for subport in trunk_details.get(\"sub_ports\", []):"},{"line_number":3465,"context_line":"            port_id \u003d subport[\"port_id\"]"},{"line_number":3466,"context_line":"            port \u003d self._show_port(context, port_id,"},{"line_number":3467,"context_line":"                                   neutron_client\u003dclient)"},{"line_number":3468,"context_line":"            subport_network \u003d client.show_network("},{"line_number":3469,"context_line":"                port[\u0027network_id\u0027])[\u0027network\u0027]"},{"line_number":3470,"context_line":""},{"line_number":3471,"context_line":"            subport_vif \u003d self._build_vif_model("},{"line_number":3472,"context_line":"                    context, client, port, [subport_network],"},{"line_number":3473,"context_line":"                    [port_id])"}],"source_content_type":"text/x-python","patch_set":12,"id":"63966571_c550ce97","line":3470,"range":{"start_line":3464,"start_character":0,"end_line":3470,"end_character":1},"updated":"2025-06-05 11:12:20.000000000","message":"This may be premature optimization, but it is probably worth measuring how much time this for loop takes (some people use several hundred subports) and (depending on the result) using the bulk port/net get API.","commit_id":"97871f1e313752f7ac860c63a827524799e289b1"}],"nova/virt/netutils.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a7872242adf0a13186ec59f9e910f2e88d659f4d","unresolved":true,"context_lines":[{"line_number":262,"context_line":"    return ip_info"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"def _get_eth_link(vif, ifc_num, parent_vif\u003dNone):"},{"line_number":266,"context_line":"    \"\"\"Get a VIF or physical NIC representation."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    :param vif: Neutron VIF"}],"source_content_type":"text/x-python","patch_set":12,"id":"4cacf12a_2f50fdee","line":265,"range":{"start_line":265,"start_character":32,"end_line":265,"end_character":47},"updated":"2025-02-21 23:30:31.000000000","message":"nit: New parameter not in docstring.","commit_id":"97871f1e313752f7ac860c63a827524799e289b1"}],"releasenotes/notes/vlan-aware-network-data-9b9b5e8c0fd191ba.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ede55e55b6fdfc5e2cc852f8b980552d01284b87","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When deploing instance with trunks generate required"},{"line_number":5,"context_line":"    network_data for cloudinit."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"79aa0d9b_862c4a25","line":5,"updated":"2025-02-12 14:35:34.000000000","message":"When deploying an instance with a trunk port, generate required network_data for cloud-init.","commit_id":"f91d82abcdcbe59a4db2d0848bc621a2aaaf58a0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a05d95f52763191b45135cfe627bc70d7d769126","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When deploing instance with trunks generate required"},{"line_number":5,"context_line":"    network_data for cloudinit."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fbdb8db_43ca4d07","line":5,"in_reply_to":"79aa0d9b_862c4a25","updated":"2025-02-12 15:28:06.000000000","message":"Acknowledged, will fix when do another revision. Thanks for review Brian","commit_id":"f91d82abcdcbe59a4db2d0848bc621a2aaaf58a0"}]}