)]}'
{"id":"openstack%2Fnova~942334","triplet_id":"openstack%2Fnova~master~Ib5befdd3c13367daa208ff969f66cba693ae2c76","project":"openstack/nova","branch":"master","topic":"bug/2098892","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2025-02-24 23:25:54.000000000","reason":"Change was submitted"},"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2025-02-21 00:14:37.000000000","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change","reason_account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},"4393":{"account":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"last_update":"2025-02-24 23:25:54.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib5befdd3c13367daa208ff969f66cba693ae2c76","subject":"libvirt: Fix regression of listDevices() return type","status":"MERGED","created":"2025-02-20 04:27:09.000000000","updated":"2025-02-24 23:27:14.000000000","submitted":"2025-02-24 23:25:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":16,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"942334-bug/2098892","meta_rev_id":"dbea3c7561a6cfa4f67d6f3637b4b05e2c014303","_number":942334,"virtual_id_number":942334,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-02-24 23:25:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2025-02-21 00:14:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2025-02-24 18:13:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":2,"date":"2025-02-24 18:37:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-02-21 17:43:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":1,"date":"2025-02-24 18:37:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-20 04:59:19.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-02-20 06:22:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-02-20 07:03:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-20 07:08:43.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2025-02-20 11:50:19.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2025-02-21 17:43:14.000000000","updated_by":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"reviewer":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"state":"REVIEWER"},{"updated":"2025-02-24 18:13:05.000000000","updated_by":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"reviewer":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"state":"REVIEWER"},{"updated":"2025-02-24 18:32:06.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"CC"},{"updated":"2025-02-24 18:37:22.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"}],"messages":[{"id":"4f70ccc0f5939d317787e1854f0661c25456c698","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 04:27:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d5f2a8690721b327356c9595d8ccf57bab0ddf1f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 04:30:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a77642e5cd8fb92d1d198a52a55ec991a61ebeb2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 04:35:17.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"0deb368b439da781438d39a05614b6431c24cd10","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-20 04:59:19.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942334-rwx2c/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"5eb6644ffafeb89a1e1677115538971a3d68e9b7","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-20 05:24:45.000000000","message":"Patch Set 2:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942334-gbh4p/index.html\u003e","accounts_in_message":[],"_revision_number":2},{"id":"148bdb7b28957e19e516e4ca56eaedefe310e832","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-20 05:53:25.000000000","message":"Patch Set 3:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942334-jrjln/index.html\u003e","accounts_in_message":[],"_revision_number":3},{"id":"8ee3d4b8f11ee5704b822cf67dbf2faff3a04fde","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-20 06:22:07.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cde64d9eb0a240a092923dde7e18e91e\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/68ecebdfbb754d24b6d5c31a0864975d : TIMED_OUT in 1h 01m 01s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/ea430a6e3fe64ee0bdfab97880a30008 : RETRY_LIMIT Ansible setup timeout in 1m 05s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"07b9c8b170de039c6dfafb8e0d92f19f05c0b63f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-20 07:03:15.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/617a4266dc024c529845bd11f92a399c\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/8c7e0f14bef64233af3a2825acf51323 : SUCCESS in 1h 04m 06s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/37244184be0b477081e4703e943fbb43 : SUCCESS in 1h 49m 37s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/64860bc86f424ec4807ddcafa2c998f1 : SUCCESS in 37m 58s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ba35184176304814a323d923f12cb104 : SUCCESS in 24m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3725ef34314841a5a87cc5e6fd308237 : SUCCESS in 4m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ed0801687a9a4d7ba398608f74390a42 : SUCCESS in 10m 54s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/3307c0111a4749488d65c4a51963d902 : SUCCESS in 10m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ddee90ef6274544b9f711e8b327bdf4 : SUCCESS in 8m 41s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/82933d6b16764e87acf8849c96217b51 : SUCCESS in 1h 00m 08s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2b3c3d3477a145309977a3ffbbe454b8 : SUCCESS in 1h 27m 08s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ad738f45694343838733ab4de4ab92d9 : SUCCESS in 38m 23s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/2b78f9dd65d84949b7a9a52c15ffe60c : SUCCESS in 1h 02m 03s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/3e43efeda6234dddb2e136868606c800 : SUCCESS in 54m 56s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/e78a3a78ec3947208645c97944d6d558 : SUCCESS in 2h 21m 47s\n- nova-next https://zuul.opendev.org/t/openstack/build/46115a973a3c469a8a00b905a2540b77 : SUCCESS in 2h 15m 35s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/60fae11470ae461aafd46a36a2e8b42c : SUCCESS in 37m 48s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/cb98a6baefd7479da65c0185895687f0 : SUCCESS in 4m 59s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/0a960dc2b8c74d329735a0bcedb5e39b : SUCCESS in 26m 04s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/4729afb250354981a9b84874515a9c32 : SUCCESS in 28m 29s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/8a5f9a901d874d0d867d64c53eb08fd7 : SUCCESS in 25m 08s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/efcd888f2fc2498dad587ce03b2e5826 : SUCCESS in 1h 13m 56s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d51bdaa28b764fef85a1486a576bac09 : SUCCESS in 39m 20s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/fcb2bfb567f34d99bbf35cde88bdc459 : SUCCESS in 26m 22s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/4407ce4a44e7423ab8b65942c2e697b0 : SUCCESS in 35m 56s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"aa7a4856bc8b4fa76c6fd31ba44b8b4cf9f89566","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-02-20 07:08:43.000000000","message":"Patch Set 3:\n\nBuild FAILED. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":3},{"id":"97519414a59ed95f71649d938ff7c92663d057d4","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-02-20 11:50:19.000000000","message":"Patch Set 3: Code-Review+1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"983237bbc83042cd9d3070ba4facda59d94fd05f","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 18:06:36.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8a7c4557af40927930da5c8b6c25437478a771f3","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 18:07:28.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"cdc3a12f2f5e9872c283b03ef3f46827680f3106","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 21:33:39.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":4},{"id":"30995196d2eac18048bc44858a0262a123e997eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 21:40:04.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"5b957bd6e96c8344029d5526bb0d1e1318a797b0","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 21:42:52.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"46e7d4b2b71ede7278f20b665fca7bbe98411799","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-20 22:37:01.000000000","message":"Patch Set 4:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942334-gn8xf/index.html\u003e","accounts_in_message":[],"_revision_number":4},{"id":"03b4f581661ccda0e6daeb81dc67d7ed3fb43f54","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-20 22:50:13.000000000","message":"Patch Set 5:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f9560a234773468db321616aeaf3b0a3\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/e22764db82f349739621ca9c3aa9063e : TIMED_OUT in 1h 01m 47s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/121149f261ca48bb86c9f0434fc2283d : RETRY_LIMIT Ansible setup timeout in 1m 06s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"b28812057db6f2c33922618406e117ce13f28797","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 22:51:18.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"d55017c87b4878eda5f1bc7f86797f5cb582fbc3","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-20 23:06:19.000000000","message":"Patch Set 5:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942334-m8s2h/index.html\u003e","accounts_in_message":[],"_revision_number":5},{"id":"ec7ce20a7bf13be6bbb484361c74babd8dad0060","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-20 23:50:42.000000000","message":"Patch Set 6:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/26c9a4ae77554ab4941b215ea483a755\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/c6e05675087741d295b4a16ce4d617b9 : FAILURE in 37m 43s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/6f07c608f5144f45831978adaa6796b9 : FAILURE in 57m 25s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"0c02819a957ec89f7d185deb1d20e86ad0b7aa59","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-21 00:04:24.000000000","message":"Patch Set 6:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942334-ztw8p/index.html\u003e","accounts_in_message":[],"_revision_number":6},{"id":"98f64b1eed05a97e9f6ae2bdf3c330c1ef8ff6dd","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-02-21 00:14:37.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"f7a540125148257dcd84ddecdb81c02680bcd785","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-21 00:46:07.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/5556a15ae8644cfea87040fc8a4bab64\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/5e28002d5dba4f248cf0f105117dd0db : SUCCESS in 55m 11s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/5c67cd51699d47a9bb34eaadf63742d3 : SUCCESS in 1h 51m 48s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/6d33fc29be9f4d1c807d5db457aa7c58 : SUCCESS in 50m 33s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b7334cdcceed491eb6d82402e4efac3e : FAILURE in 19m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8203550b22074bd8909fa1d0b3ef1ae5 : SUCCESS in 7m 44s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ac1d2641ff794278b8045fed00e43fa5 : SUCCESS in 13m 42s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/3ca0684e20eb482f879d1e336d89eb4d : SUCCESS in 13m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6196c1729dad4ff49aa905e380848560 : SUCCESS in 8m 58s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/cddd1fd7494247c9ae00844a9f9e7c55 : FAILURE in 1h 37m 04s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2554f4a55175465b957dc018b72b89f2 : SUCCESS in 1h 10m 03s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/e1aa3e7044e64d92912a18d016067bd8 : SUCCESS in 1h 04m 21s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/0964ab4e87084178844a0dfa8463e208 : SUCCESS in 1h 01m 14s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/e5a6cb0c8dbd4691b9090b00ec0cb425 : SUCCESS in 1h 14m 16s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/47da20d43f4d46789035aa6adeed5c17 : SUCCESS in 1h 29m 30s\n- nova-next https://zuul.opendev.org/t/openstack/build/2fbee1ae517040e487cd403f78894d30 : SUCCESS in 1h 29m 56s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/16fc1256d0ba42d1bf40cc08d4d1fd27 : SUCCESS in 50m 26s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/d13a218cfa6847989807df86ce77c60d : SUCCESS in 5m 11s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/8482408d479043af92a71e3be058aa13 : SUCCESS in 28m 11s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/410457ef6b0a40d89f55359d77af3fc7 : SUCCESS in 28m 31s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/cb8435a73f834fddbc517c03e441c205 : SUCCESS in 34m 13s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/187ee7a7d4c948538e2498a869f051b5 : SUCCESS in 1h 25m 34s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/95fb871ad09e442a83c5c8dbb3d681cb : SUCCESS in 34m 16s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/2fd5872316d347c7ac6860d2560c765e : SUCCESS in 31m 20s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/68132dc0558443a2b49135146c0ac879 : SUCCESS in 39m 07s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"1cd0291df3d8a2898dea38f80147b6f74dab46b4","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-21 01:08:48.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"14e97b52273f4c863f89a0452b49c5f7d9f61154","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-21 01:34:21.000000000","message":"Patch Set 6:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942334-sw8v6/index.html\u003e","accounts_in_message":[],"_revision_number":6},{"id":"0e2918f03c44da7d2dd518a17dcd5137d1550a81","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-21 02:14:54.000000000","message":"Patch Set 6:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c1fd4aaedcca42c0934934fcb6d83150\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/4bbdc29233884656bdc4c71d511e19c5 : FAILURE in 56m 16s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/21b3e2aa1a49463082110f34924a53cf : TIMED_OUT in 1h 01m 12s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"87b1a59b96c0c4b370953b97e614316a66ec5347","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-21 03:43:45.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8563168eb68c4b9f950455745891a644\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/a6014fcff8af45acb0ce4b7197afbce3 : SUCCESS in 39m 37s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/6d58852bcbed4d3bb284820d4ffdca82 : SUCCESS in 1h 38m 19s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/b405fd0ce2644fbf979a82ce52918628 : SUCCESS in 48m 42s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f3bd6eded3574f9ab32d2080b5a2a70c : SUCCESS in 16m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fe21639c486e4595859f37d78fc32f12 : SUCCESS in 6m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5ece266e30bb4b81b25890df7a6681c5 : SUCCESS in 11m 26s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/51775e509ce44a1bbee212d7d5d4b707 : SUCCESS in 11m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e93537c9018d43df8480a5f7ffccb352 : SUCCESS in 5m 54s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/526f76fcee7e406a9e4c36f223728d70 : SUCCESS in 49m 33s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/b7d57cfef3da4ae9b19527fb4ab2ebd0 : SUCCESS in 1h 34m 06s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/e828de635a244c2596f91e94e921e31b : SUCCESS in 30m 38s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/b3b215c77f394e439b18f411e326d5ee : SUCCESS in 44m 21s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/e1888cb96dde4b31836d9dd1262d7ad5 : SUCCESS in 1h 23m 32s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/6e07b0d5220c4794940fbf0331981efc : SUCCESS in 1h 24m 21s\n- nova-next https://zuul.opendev.org/t/openstack/build/83a64b0b17584fbc899d65691dbc99bb : SUCCESS in 2h 28m 10s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/bfe6182d2047479f8bf902ec93f8fb30 : SUCCESS in 35m 07s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/2a60bbc9bbaf492596efc2300adbeb5f : SUCCESS in 5m 13s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/6068e669b6034d7b85904d1ae6fdf63e : SUCCESS in 25m 43s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/a216f55296324c768187f454a9e8ecde : SUCCESS in 26m 51s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/2b3c16e305e04524b52cbd097ace52c9 : SUCCESS in 26m 00s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/7e4c34805f734221bee0292c30cfb499 : SUCCESS in 1h 29m 38s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/4dc0d29859424d55ad7d9c7b0dbcd794 : SUCCESS in 1h 02m 00s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/ca7d455402b94d09b498f0a2eb841f19 : SUCCESS in 32m 42s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/76f81bb7fd9249b7b1c8b6afdd63699a : SUCCESS in 42m 28s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"44234c3576f4282c5f0ae6cc06c516498f5d8fa9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-02-21 03:49:23.000000000","message":"Patch Set 6:\n\nBuild FAILED. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":6},{"id":"85582a22e7e31997d59acb427a47c2c2276119a0","author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"date":"2025-02-21 17:43:14.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"5606ae2385a39b22c32221fe74386d7354a76a42","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2025-02-24 18:13:05.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"6056270f02f533e5599c15cf552c80cafda4caad","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2025-02-24 18:32:06.000000000","message":"Patch Set 6:\n\n(3 comments)","accounts_in_message":[],"_revision_number":6},{"id":"6df6c9f434d951afe928977ad3ce242d65e71583","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2025-02-24 18:37:22.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"1030d9cb0bbd6b422330da0093b7b3656bfbfd7f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-24 18:38:26.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"480ad769b69adfc563df7784ba4136136a4105be","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-02-24 18:45:21.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"57d88c2a7b0063ce9b727ca1d73dc5f469a5bb68","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-24 23:25:54.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e40d5d3bb04d433383f993c30ea891f6\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/f5be85faf83a4f3cb1edfd90081db0cd : SUCCESS in 59m 40s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/139ca2b49a234fbf8d5748dc3a2d1335 : SUCCESS in 1h 52m 15s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3070e5d2313643439a07a89b18cd6e92 : SUCCESS in 1h 19m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/62857a75439a4e61afd0fd5f47dee5f5 : SUCCESS in 8m 53s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2441d069a3554d2fbca9b186c995f14e : SUCCESS in 12m 54s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/26c6970ef1be4a8e9d568be6f4db65de : SUCCESS in 13m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d8d963468534de7ae46974c867daf52 : SUCCESS in 8m 28s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/c1b1e44a084f4986a584cc74a1425b6a : SUCCESS in 56m 15s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/446f554158d544688348ee426fc5391d : SUCCESS in 23m 45s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/d49d72264c514c978aa3449af346b562 : SUCCESS in 27m 32s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/a5873cb6e18f4590bc6c47e6dd0fc35e : SUCCESS in 32m 52s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/0604e275f6304df182291ce30323256f : SUCCESS in 1h 11m 01s\n- nova-next https://zuul.opendev.org/t/openstack/build/daa99f8b206948c19cf8d89639b56a4e : SUCCESS in 2h 36m 22s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/611c5bb867374ab596173e5571b10fda : SUCCESS in 6m 11s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/951380356cd8419186c2ad0d67d0547f : SUCCESS in 1h 49m 36s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f08d1cfe4bb046098064e4760e99ce86 : SUCCESS in 1h 22m 39s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/fccf76ca670e47aba4258f175be23b6e : SUCCESS in 46m 56s","accounts_in_message":[],"_revision_number":6},{"id":"597fec77b5f155c63f21206793a5a074feca74b6","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-24 23:25:54.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":6},{"id":"dbea3c7561a6cfa4f67d6f3637b4b05e2c014303","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-24 23:27:14.000000000","message":"Patch Set 6:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b0e4f6a6ed2049afbdd043be337d8cd5\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bd06bfdb98e24268aa708bc621f10e5d : SUCCESS in 57s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"2c07aa06458a2e70d79f8b3c68960bdccd11ab57","revisions":{"f741d0eb2807da552b3113bd89eb330649379c93":{"kind":"REWORK","_number":1,"created":"2025-02-20 04:27:09.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/34/942334/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/942334/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/942334/1"}}},"commit":{"parents":[{"commit":"ae87118f98cefda5dc485c7fd0b1322ca1a1ba30","subject":"Merge \"Add unit test coverage of get_machine_ips\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ae87118f98cefda5dc485c7fd0b1322ca1a1ba30"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:09:44.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:25:22.000000000","tz":0},"subject":"libvirt: Fix regression of listDevices() return type","message":"libvirt: Fix regression of listDevices() return type\n\nThis a partial revert of change\nI60d6f04d374e9ede5895a43b7a75e955b0fea3c5 which added tpool.Proxy\nwrapping to the listDevices() and listAllDevices() methods.\n\nThe regression was caught during downstream testing with vGPUs and the\nupdate_available_resource() periodic task was failing with:\n\n  TypeError: virNodeDeviceLookupByName() argument 2 must be str or\n    None, not Proxy\n\nIt turns out that while the listAllDevices() method returns a list of\nvirNodeDevice objects [1], the listDevices() method returns a list of\nstring names [2] and is generated from the corresponding function in C\n[3].\n\nThe error was not caught by unit or functional testing because those\ntest environments intentionally do not import the libvirt Python\nmodule -- so mocked code in the LibvirtFixture runs instead.\n\nThis reverts the change that caused the regression and adds checking in\nthe LibvirtFixture to help prevent future mistakes and also updates\npotentially confusing docstrings.\n\nCloses-Bug: #2098892\n\n[1] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-virConnect.py#L520-L524\n[2] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-api.xml#L448-L453\n[3] https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeListDevices\n\nChange-Id: Ib5befdd3c13367daa208ff969f66cba693ae2c76\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f741d0eb2807da552b3113bd89eb330649379c93"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f741d0eb2807da552b3113bd89eb330649379c93"}]},"branch":"refs/heads/master"},"e76f1cbae16f561b72bd776f2def2fc11123f361":{"kind":"REWORK","_number":2,"created":"2025-02-20 04:30:56.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/34/942334/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/942334/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/942334/2"}}},"commit":{"parents":[{"commit":"ae87118f98cefda5dc485c7fd0b1322ca1a1ba30","subject":"Merge \"Add unit test coverage of get_machine_ips\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ae87118f98cefda5dc485c7fd0b1322ca1a1ba30"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:09:44.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:30:23.000000000","tz":0},"subject":"libvirt: Fix regression of listDevices() return type","message":"libvirt: Fix regression of listDevices() return type\n\nThis a partial revert of change\nI60d6f04d374e9ede5895a43b7a75e955b0fea3c5 which added tpool.Proxy\nwrapping to the listDevices() and listAllDevices() methods.\n\nThe regression was caught during downstream testing with vGPUs and the\nupdate_available_resource() periodic task was failing with:\n\n  TypeError: virNodeDeviceLookupByName() argument 2 must be str or\n    None, not Proxy\n\nIt turns out that while the listAllDevices() method returns a list of\nvirNodeDevice objects [1], the listDevices() method returns a list of\nstring names [2] and is generated from the corresponding function in C\n[3].\n\nThe error was not caught by unit or functional testing because those\ntest environments intentionally do not import the libvirt Python\nmodule -- so mocked code in the LibvirtFixture runs instead.\n\nThis reverts the change that caused the regression and adds checking in\nthe LibvirtFixture to help prevent future mistakes and also updates\npotentially confusing docstrings.\n\nCloses-Bug: #2098892\n\n[1] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-virConnect.py#L520-L524\n[2] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-api.xml#L448-L453\n[3] https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeListDevices\n\nChange-Id: Ib5befdd3c13367daa208ff969f66cba693ae2c76\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e76f1cbae16f561b72bd776f2def2fc11123f361"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e76f1cbae16f561b72bd776f2def2fc11123f361"}]},"branch":"refs/heads/master"},"7db63c9e9c5cc606b015d89ed8866cfec8d650da":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-02-20 04:35:17.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/34/942334/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/942334/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/942334/3"}}},"commit":{"parents":[{"commit":"ae87118f98cefda5dc485c7fd0b1322ca1a1ba30","subject":"Merge \"Add unit test coverage of get_machine_ips\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ae87118f98cefda5dc485c7fd0b1322ca1a1ba30"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:09:44.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:32:20.000000000","tz":0},"subject":"libvirt: Fix regression of listDevices() return type","message":"libvirt: Fix regression of listDevices() return type\n\nThis a partial revert of change\nI60d6f04d374e9ede5895a43b7a75e955b0fea3c5 which added tpool.Proxy\nwrapping to the listDevices() and listAllDevices() methods.\n\nThe regression was caught during downstream testing with vGPUs and the\nupdate_available_resource() periodic task was failing with:\n\n  TypeError: virNodeDeviceLookupByName() argument 2 must be str or\n    None, not Proxy\n\nIt turns out that while the listAllDevices() method returns a list of\nvirNodeDevice objects [1], the listDevices() method returns a list of\nstring names [2] and is generated from the corresponding function in C\n[3].\n\nThe error was not caught by unit or functional testing because those\ntest environments intentionally do not import the libvirt Python\nmodule -- so mocked code in the LibvirtFixture runs instead. Also, the\nupdate_available_resource() method has a \u0027except Exception:\u0027 at the end\nwhich logs an error but does not re-raise. So it would not cause a\nfunctional test to fail.\n\nThis reverts the change that caused the regression, adds checking in\nthe LibvirtFixture to help prevent future mistakes, updates potentially\nconfusing docstrings, and adds a keyword arg to the test\n_run_periodics() method to specify whether it should raise an exception\nif an error is logged.\n\nCloses-Bug: #2098892\n\n[1] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-virConnect.py#L520-L524\n[2] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-api.xml#L448-L453\n[3] https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeListDevices\n\nChange-Id: Ib5befdd3c13367daa208ff969f66cba693ae2c76\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7db63c9e9c5cc606b015d89ed8866cfec8d650da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7db63c9e9c5cc606b015d89ed8866cfec8d650da"}]},"branch":"refs/heads/master"},"ed8b984033c758fd6f9e3168382a0d7d063d283f":{"kind":"REWORK","_number":4,"created":"2025-02-20 21:33:39.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/34/942334/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/942334/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/942334/4"}}},"commit":{"parents":[{"commit":"281b91baba47d623dc8c5a07387eaa1bde6f0ec8","subject":"Reproducer for bug 2098892","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/281b91baba47d623dc8c5a07387eaa1bde6f0ec8"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:09:44.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 21:31:25.000000000","tz":0},"subject":"libvirt: Fix regression of listDevices() return type","message":"libvirt: Fix regression of listDevices() return type\n\nThis a partial revert of change\nI60d6f04d374e9ede5895a43b7a75e955b0fea3c5 which added tpool.Proxy\nwrapping to the listDevices() and listAllDevices() methods.\n\nThe regression was caught during downstream testing with vGPUs and the\nupdate_available_resource() periodic task was failing with:\n\n  TypeError: virNodeDeviceLookupByName() argument 2 must be str or\n    None, not Proxy\n\nIt turns out that while the listAllDevices() method returns a list of\nvirNodeDevice objects [1], the listDevices() method returns a list of\nstring names [2] and is generated from the corresponding function in C\n[3].\n\nThe error was not caught by unit or functional testing because those\ntest environments intentionally do not import the libvirt Python\nmodule -- so mocked code in the LibvirtFixture runs instead. Also, the\nupdate_available_resource() method has a \u0027except Exception:\u0027 at the end\nwhich logs an error but does not re-raise. So it would not cause a\nfunctional test to fail.\n\nThis reverts the change that caused the regression, updates potentially\nconfusing docstrings, and adds type annotations to the methods that use\nlistDevices().\n\nCloses-Bug: #2098892\n\n[1] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-virConnect.py#L520-L524\n[2] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-api.xml#L448-L453\n[3] https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeListDevices\n\nChange-Id: Ib5befdd3c13367daa208ff969f66cba693ae2c76\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ed8b984033c758fd6f9e3168382a0d7d063d283f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ed8b984033c758fd6f9e3168382a0d7d063d283f"}]},"branch":"refs/heads/master"},"c7f7f14c6e6063695e1f551a672dc8b46d25343a":{"kind":"REWORK","_number":5,"created":"2025-02-20 21:40:04.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/34/942334/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/942334/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/942334/5"}}},"commit":{"parents":[{"commit":"281b91baba47d623dc8c5a07387eaa1bde6f0ec8","subject":"Reproducer for bug 2098892","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/281b91baba47d623dc8c5a07387eaa1bde6f0ec8"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:09:44.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 21:39:53.000000000","tz":0},"subject":"libvirt: Fix regression of listDevices() return type","message":"libvirt: Fix regression of listDevices() return type\n\nThis a partial revert of change\nI60d6f04d374e9ede5895a43b7a75e955b0fea3c5 which added tpool.Proxy\nwrapping to the listDevices() and listAllDevices() methods.\n\nThe regression was caught during downstream testing with vGPUs and the\nupdate_available_resource() periodic task was failing with:\n\n  TypeError: virNodeDeviceLookupByName() argument 2 must be str or\n    None, not Proxy\n\nIt turns out that while the listAllDevices() method returns a list of\nvirNodeDevice objects [1], the listDevices() method returns a list of\nstring names [2] and is generated from the corresponding function in C\n[3].\n\nThe error was not caught by unit or functional testing because those\ntest environments intentionally do not import the libvirt Python\nmodule -- so mocked code in the LibvirtFixture runs instead. Also, the\nupdate_available_resource() method has a \u0027except Exception:\u0027 at the end\nwhich logs an error but does not re-raise. So it would not cause a\nfunctional test to fail.\n\nThis reverts the change that caused the regression, updates potentially\nconfusing docstrings, and adds type annotations to the methods that use\nlistDevices().\n\nCloses-Bug: #2098892\n\n[1] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-virConnect.py#L520-L524\n[2] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-api.xml#L448-L453\n[3] https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeListDevices\n\nChange-Id: Ib5befdd3c13367daa208ff969f66cba693ae2c76\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c7f7f14c6e6063695e1f551a672dc8b46d25343a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c7f7f14c6e6063695e1f551a672dc8b46d25343a"}]},"branch":"refs/heads/master"},"2c07aa06458a2e70d79f8b3c68960bdccd11ab57":{"kind":"REWORK","_number":6,"created":"2025-02-20 22:51:18.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/34/942334/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/942334/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/942334/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/942334/6"}}},"commit":{"parents":[{"commit":"3cf6667c503a5c27c85c2129e4495cf8bf53d66c","subject":"Reproducer for bug 2098892","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3cf6667c503a5c27c85c2129e4495cf8bf53d66c"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 04:09:44.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 22:42:16.000000000","tz":0},"subject":"libvirt: Fix regression of listDevices() return type","message":"libvirt: Fix regression of listDevices() return type\n\nThis a partial revert of change\nI60d6f04d374e9ede5895a43b7a75e955b0fea3c5 which added tpool.Proxy\nwrapping to the listDevices() and listAllDevices() methods.\n\nThe regression was caught during downstream testing with vGPUs and the\nupdate_available_resource() periodic task was failing with:\n\n  TypeError: virNodeDeviceLookupByName() argument 2 must be str or\n    None, not Proxy\n\nIt turns out that while the listAllDevices() method returns a list of\nvirNodeDevice objects [1], the listDevices() method returns a list of\nstring names [2] and is generated from the corresponding function in C\n[3].\n\nThe error was not caught by unit or functional testing because those\ntest environments intentionally do not import the libvirt Python\nmodule -- so mocked code in the LibvirtFixture runs instead. Also, the\nupdate_available_resource() method has a \u0027except Exception:\u0027 at the end\nwhich logs an error but does not re-raise. So it would not cause a\nfunctional test to fail.\n\nThis reverts the change that caused the regression, updates potentially\nconfusing docstrings, adds type annotations to the methods that use\nlistDevices(), and moves the nodeDeviceLookupByName type checking into\nthe LibvirtFixture.\n\nCloses-Bug: #2098892\n\n[1] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-virConnect.py#L520-L524\n[2] https://github.com/libvirt/libvirt-python/blob/408815a/libvirt-override-api.xml#L448-L453\n[3] https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeListDevices\n\nChange-Id: Ib5befdd3c13367daa208ff969f66cba693ae2c76\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2c07aa06458a2e70d79f8b3c68960bdccd11ab57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2c07aa06458a2e70d79f8b3c68960bdccd11ab57"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}