)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9b888352097b670e36eaa575eece37f9e4337f00","unresolved":true,"context_lines":[{"line_number":10,"context_line":"doesn\u0027t contain a `bits` attribute. Our"},{"line_number":11,"context_line":"`LibvirtConfigCPUMaxPhysAddr.parse_dom()` assumed `bits` was always set"},{"line_number":12,"context_line":"and the tests only tested parsing the XML for the `emulate` mode."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic16561dfb38612ac46c2148f2847006f6890940e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0aafb759_2caa8b77","line":13,"updated":"2025-02-20 17:59:11.000000000","message":"Does this issue cause any bug or problem? If so, it would be good to file a bug and add `Closes-Bug: #NNNNNN` here.","commit_id":"f6c716668f93aaf572335014c0989da2b8050e0d"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"baf052426d3bf50f1a7f6924387fd5e5395a6164","unresolved":false,"context_lines":[{"line_number":10,"context_line":"doesn\u0027t contain a `bits` attribute. Our"},{"line_number":11,"context_line":"`LibvirtConfigCPUMaxPhysAddr.parse_dom()` assumed `bits` was always set"},{"line_number":12,"context_line":"and the tests only tested parsing the XML for the `emulate` mode."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic16561dfb38612ac46c2148f2847006f6890940e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fdf249c9_f5be28b3","line":13,"in_reply_to":"0aafb759_2caa8b77","updated":"2025-02-21 07:42:19.000000000","message":"Yes, it does. It prohibits us from spawning VMs with the mode set to `passthrough`.","commit_id":"f6c716668f93aaf572335014c0989da2b8050e0d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"232d03f87336e5a5e99b6475336a45b58669705e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"34ea908e_e060af64","updated":"2025-02-27 09:21:48.000000000","message":"fix make sense, the included unit test needs a bit of cleanup","commit_id":"7cacff2ed85f526c4eedaff283f426a5d8414672"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5a772c3128ad4d63a2d5a005476d87acdc66307d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"98e02ec9_40206591","updated":"2025-02-27 09:55:37.000000000","message":"looks good.","commit_id":"5f6ff008c3d8861831a9da6a58bdc207edadd8c5"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"481c59a621c28ac3ca9e47ccb33fb5ca3867bdcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30a21a84_b68b1ad1","updated":"2025-03-10 07:53:35.000000000","message":"recheck SSH problems","commit_id":"5f6ff008c3d8861831a9da6a58bdc207edadd8c5"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"fc9048d52d20a6ed21b7ee384d2b819ddfe80d2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"513cee4a_48d5b3dd","updated":"2025-03-04 08:22:02.000000000","message":"recheck SSHTimeout","commit_id":"5f6ff008c3d8861831a9da6a58bdc207edadd8c5"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"0d6a0251bf1f2933522fd34deb6d64f8d95d5744","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34e9744c_255aeab5","updated":"2025-02-28 06:25:59.000000000","message":"recheck timeout","commit_id":"5f6ff008c3d8861831a9da6a58bdc207edadd8c5"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"f4c502c7b4b1959dcc482f6fda396da4c42142be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c7c3adbe_07a8bc05","updated":"2025-03-03 15:34:16.000000000","message":"recheck timeout","commit_id":"5f6ff008c3d8861831a9da6a58bdc207edadd8c5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d31e99007ab4cb22fab7460895c4b80e7e3c12ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a261b8e1_8c7018f3","updated":"2025-02-27 12:02:15.000000000","message":"ya ok i agree with this approch.\n\nthanks for the patch","commit_id":"5f6ff008c3d8861831a9da6a58bdc207edadd8c5"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"f12bea7b2ad6812397f57a4e9bb4e972be7cbb7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30a12260_dd4a479e","in_reply_to":"c7c3adbe_07a8bc05","updated":"2025-03-03 15:35:36.000000000","message":"looked at the wrong result. it\u0027s a failure. will see if it\u0027s related.","commit_id":"5f6ff008c3d8861831a9da6a58bdc207edadd8c5"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"232d03f87336e5a5e99b6475336a45b58669705e","unresolved":true,"context_lines":[{"line_number":564,"context_line":"        \"\"\"Passthrough mode has no \"bits\" attribute\"\"\""},{"line_number":565,"context_line":"        xml \u003d \"\"\""},{"line_number":566,"context_line":"            \u003ccpu\u003e"},{"line_number":567,"context_line":"              \u003cmaxphysaddr mode\u003d\u0027emulate\u0027/\u003e"},{"line_number":568,"context_line":"            \u003c/cpu\u003e"},{"line_number":569,"context_line":"        \"\"\""},{"line_number":570,"context_line":"        xmldoc \u003d etree.fromstring(xml)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f8450db_0452a805","line":567,"updated":"2025-02-27 09:21:48.000000000","message":"I guess you mean \"passthrough\" here?","commit_id":"7cacff2ed85f526c4eedaff283f426a5d8414672"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5a772c3128ad4d63a2d5a005476d87acdc66307d","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        \"\"\"Passthrough mode has no \"bits\" attribute\"\"\""},{"line_number":565,"context_line":"        xml \u003d \"\"\""},{"line_number":566,"context_line":"            \u003ccpu\u003e"},{"line_number":567,"context_line":"              \u003cmaxphysaddr mode\u003d\u0027emulate\u0027/\u003e"},{"line_number":568,"context_line":"            \u003c/cpu\u003e"},{"line_number":569,"context_line":"        \"\"\""},{"line_number":570,"context_line":"        xmldoc \u003d etree.fromstring(xml)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7f4fbc9_ae9dc5b9","line":567,"in_reply_to":"9f8450db_0452a805","updated":"2025-02-27 09:55:37.000000000","message":"Done","commit_id":"7cacff2ed85f526c4eedaff283f426a5d8414672"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"232d03f87336e5a5e99b6475336a45b58669705e","unresolved":true,"context_lines":[{"line_number":571,"context_line":"        obj \u003d config.LibvirtConfigCPU()"},{"line_number":572,"context_line":"        obj.parse_dom(xmldoc)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        self.assertEqual(\"emulate\", obj.maxphysaddr.mode)"},{"line_number":575,"context_line":"        self.assertIsNone(obj.maxphysaddr.bits)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"62a9bf82_b6e304d8","line":574,"updated":"2025-02-27 09:21:48.000000000","message":"ditto","commit_id":"7cacff2ed85f526c4eedaff283f426a5d8414672"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5a772c3128ad4d63a2d5a005476d87acdc66307d","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        obj \u003d config.LibvirtConfigCPU()"},{"line_number":572,"context_line":"        obj.parse_dom(xmldoc)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        self.assertEqual(\"emulate\", obj.maxphysaddr.mode)"},{"line_number":575,"context_line":"        self.assertIsNone(obj.maxphysaddr.bits)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b418d4d3_a99e85ac","line":574,"in_reply_to":"62a9bf82_b6e304d8","updated":"2025-02-27 09:55:37.000000000","message":"Done","commit_id":"7cacff2ed85f526c4eedaff283f426a5d8414672"}]}