)]}'
{"id":"openstack%2Fnova~942402","triplet_id":"openstack%2Fnova~master~I3a3dda57f2181b24bd6589ac7bb8160014ab2396","project":"openstack/nova","branch":"master","topic":"bug/2098892","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2025-02-24 21:25:48.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3a3dda57f2181b24bd6589ac7bb8160014ab2396","subject":"Reproducer for bug 2098892","status":"MERGED","created":"2025-02-20 21:33:39.000000000","updated":"2025-02-24 21:27:22.000000000","submitted":"2025-02-24 21:25:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"942402-bug/2098892","meta_rev_id":"9cf520109108b282a0b9fa2c63e4cfd217df36b7","_number":942402,"virtual_id_number":942402,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-02-24 21:25:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-02-24 18:37:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":2,"date":"2025-02-21 00:12:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-02-24 18:37:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-20 22:07:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-20 22:10:36.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-02-20 23:24:41.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2025-02-21 00:12:41.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2025-02-24 18:37:30.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"}],"messages":[{"id":"872b5d17214f0dd02485e9e165f8a51ce8e64dc2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 21:33:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"223a255f509740142ca3b93eace5c27cfb455b55","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-20 22:07:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/16436c9196c34f89a8fdce27cf218890\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ad916f1fe501436c85e6245daab5a8cc : SUCCESS in 20m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/80c23847d79447faa344cb0616d337d2 : SUCCESS in 7m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c5ee59a5ecb5481f8fd8fad7f2b5d613 : SUCCESS in 16m 53s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/c81a7752cdab4428afb723dad812c741 : SUCCESS in 14m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5da848619772434a971546e52152eabf : SUCCESS in 9m 50s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/8e2b334ef9714d93a7877a72d9ae2c7c : SUCCESS in 5m 27s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/db4fc97923db4de48e66706e679a0093 : FAILURE in 27m 35s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/d55c42802da34cc78451b0398c8cec75 : FAILURE in 31m 32s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/af4db980a0de444889db9527b4e722d3 : FAILURE in 27m 07s","accounts_in_message":[],"_revision_number":1},{"id":"eb42c56883d24b9281afcf3256d68d44cdfcb05f","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-20 22:10:36.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942402-jq7ht/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"a62494e0588574c7bc9385e4856a577a695e4baf","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-20 22:49:40.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0bb36940c1f24e5ebc99245f66017d5a\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/32f69c27119f408eb643caae8cca2b45 : TIMED_OUT in 1h 01m 07s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/9834ea9e834546a69cb6e12e103fedb0 : TIMED_OUT in 1h 01m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1f350f11e27c3374a36affa25d52eccece9a3b55","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2025-02-20 22:51:18.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"5da2594ec391a8458e9ce2850feff8eb302bd850","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-20 23:19:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bce83b476efd443489959af68301ee0f\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fb28ff7d18d043aea676fafbdfc055e2 : SUCCESS in 18m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/648ed09e57714695bc94af1051052f8b : SUCCESS in 7m 15s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9501ebab5afe41cf8d048bc4d7ce294c : SUCCESS in 12m 48s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/75360398a61d4abf8cba80968ce61f35 : SUCCESS in 13m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e9a1b36ef3fb4ff2b7673bbb28112bef : SUCCESS in 10m 47s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/af8d707157284b32af0af03ca1b69a3f : SUCCESS in 4m 44s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/26e2428840ba41a5bab2091ab22f23a2 : SUCCESS in 22m 08s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/fb28b9d1cd2b4e279439b7bfd9ced84c : SUCCESS in 26m 36s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/821ee018b8ce486cb450347d1300c198 : SUCCESS in 24m 31s","accounts_in_message":[],"_revision_number":2},{"id":"89bcf2ad85bf906696bc1617ee19f2368a5a6e02","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2025-02-20 23:24:41.000000000","message":"Patch Set 2:\n\nBuild FAILED. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":2},{"id":"08c6f929b791f5524f37d1786e2b9fa958f541bc","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-02-20 23:35:33.000000000","message":"Patch Set 2:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942402-4cvcb/index.html\u003e","accounts_in_message":[],"_revision_number":2},{"id":"a91b5259979922a5feec56f0dddc10c2c606f41e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-20 23:50:39.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d2c90fe1d154454cb6f7aa25a0d8c175\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/60d2a731f3e1422892c1707f573837fe : FAILURE in 37m 21s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/99ae51a7fc514d7883e4ab7f76fc198f : FAILURE in 57m 07s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4c6c961b211f744e0744502101481f331a15b875","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-02-21 00:12:41.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"50147000c42ccf38534d85566fe36abc3824f862","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2025-02-24 18:37:30.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"84f2dcf4e9bd9d22ab4c25a705484942934dceea","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-24 18:38:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c588246768a0f8ad3de661d22262336587dc1247","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-24 21:25:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ea46a19154894df3af847d23443e7785\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0ab50b09c454416d9bf2b9e16901c102 : SUCCESS in 9m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c5dc62311e694bf393958fe58fe2e00f : SUCCESS in 11m 50s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/6545ea9c46ee4bc7b39e9f087328c9a7 : SUCCESS in 16m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0dbdcf48f3fc4141a3dc3b33f1d26ca0 : SUCCESS in 11m 58s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d0b01eee5d5a46a9a98121da1a07f875 : SUCCESS in 27m 28s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/f8bf093df69c4903bd6b1e4b9ec549dd : SUCCESS in 25m 33s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/f00cfe4374b24f458172518e6e8a3843 : SUCCESS in 31m 31s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/8773cdf5bfda41d7bb51684e8bc10cb4 : SUCCESS in 3m 07s","accounts_in_message":[],"_revision_number":2},{"id":"6891876e920c0861d3989918a8a2aa82d755e1b6","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-24 21:25:48.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"9cf520109108b282a0b9fa2c63e4cfd217df36b7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-24 21:27:22.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/99f97d0fc64b40048ffe435bc3bffbe6\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c202c8caa9d5410ab99ba074173c90be : SUCCESS in 1m 16s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3cf6667c503a5c27c85c2129e4495cf8bf53d66c","revisions":{"281b91baba47d623dc8c5a07387eaa1bde6f0ec8":{"kind":"REWORK","_number":1,"created":"2025-02-20 21:33:39.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/02/942402/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/942402/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/942402/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/942402/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/942402/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/942402/1"}}},"commit":{"parents":[{"commit":"ae87118f98cefda5dc485c7fd0b1322ca1a1ba30","subject":"Merge \"Add unit test coverage of get_machine_ips\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ae87118f98cefda5dc485c7fd0b1322ca1a1ba30"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 20:44:04.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 21:28:38.000000000","tz":0},"subject":"Reproducer for bug 2098892","message":"Reproducer for bug 2098892\n\nChange I60d6f04d374e9ede5895a43b7a75e955b0fea3c5 added tpool.Proxy\nwrapping to the listDevices() and listAllDevices() methods but\nintroduced a regression for listDevices() that led to an error in\nupdate_available_resource():\n\n  TypeError: virNodeDeviceLookupByName() argument 2 must be str or\n    None, not Proxy\n\nThe error was not caught by unit or functional testing because those\ntest environments intentionally do not import the libvirt Python\nmodule -- so mocked code in the LibvirtFixture runs instead. Also, the\nupdate_available_resource() method has a \u0027except Exception:\u0027 at the end\nwhich logs an error but does not re-raise. So it would not cause a\nfunctional test to fail.\n\nThis adds a functional test to reproduce the bug, adds checking in\nthe LibvirtFixture to help prevent future mistakes, and adds a keyword\narg to the test _run_periodics() method to specify whether it should\nraise an exception if an error is logged.\n\nRelated-Bug: #2098892\n\nChange-Id: I3a3dda57f2181b24bd6589ac7bb8160014ab2396\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/281b91baba47d623dc8c5a07387eaa1bde6f0ec8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/281b91baba47d623dc8c5a07387eaa1bde6f0ec8"}]},"branch":"refs/heads/master"},"3cf6667c503a5c27c85c2129e4495cf8bf53d66c":{"kind":"REWORK","_number":2,"created":"2025-02-20 22:51:18.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/02/942402/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/942402/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/942402/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/942402/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/942402/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/942402/2"}}},"commit":{"parents":[{"commit":"ae87118f98cefda5dc485c7fd0b1322ca1a1ba30","subject":"Merge \"Add unit test coverage of get_machine_ips\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ae87118f98cefda5dc485c7fd0b1322ca1a1ba30"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 20:44:04.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2025-02-20 22:31:21.000000000","tz":0},"subject":"Reproducer for bug 2098892","message":"Reproducer for bug 2098892\n\nChange I60d6f04d374e9ede5895a43b7a75e955b0fea3c5 added tpool.Proxy\nwrapping to the listDevices() and listAllDevices() methods but\nintroduced a regression for listDevices() that led to an error in\nupdate_available_resource():\n\n  TypeError: virNodeDeviceLookupByName() argument 2 must be str or\n    None, not Proxy\n\nThe error was not caught by unit or functional testing because those\ntest environments intentionally do not import the libvirt Python\nmodule -- so mocked code in the LibvirtFixture runs instead. Also, the\nupdate_available_resource() method has a \u0027except Exception:\u0027 at the end\nwhich logs an error but does not re-raise. So it would not cause a\nfunctional test to fail.\n\nThis adds a functional test to reproduce the bug and adds a keyword arg\nto the test _run_periodics() method to specify whether it should raise\nan exception if an error is logged.\n\nRelated-Bug: #2098892\n\nChange-Id: I3a3dda57f2181b24bd6589ac7bb8160014ab2396\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3cf6667c503a5c27c85c2129e4495cf8bf53d66c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3cf6667c503a5c27c85c2129e4495cf8bf53d66c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}