)]}'
{"id":"openstack%2Fnova~942510","triplet_id":"openstack%2Fnova~master~I1639a2400f1614dd102caf7846f79c2f0513473d","project":"openstack/nova","branch":"master","hashtags":[],"change_id":"I1639a2400f1614dd102caf7846f79c2f0513473d","subject":"Consider using X-Forwarded-Proto only if initial validation fails","status":"NEW","created":"2025-02-22 13:50:17.000000000","updated":"2025-03-06 09:46:03.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"work_in_progress":true,"has_review_started":false,"meta_rev_id":"a92b34bc74c737868b96e32ac9d6dcc9fb357cb5","_number":942510,"virtual_id_number":942510,"owner":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2025-02-22 16:07:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}]},"pending_reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}]},"reviewer_updates":[{"updated":"2025-02-22 14:37:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-02-22 16:07:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-03-06 09:46:03.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"bdf4842c26b36e1b1b57a14192689d06abb0dead","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"date":"2025-02-22 13:50:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a3a8c4dd7fd80034c71897c52be7cfaa88f11e63","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-22 14:37:05.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/249726459de343ceaf395cde088435c0\n\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ca73d83d303148c7b44e1004cc3f03af : FAILURE in 36m 42s (non-voting)\n- openstack-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/523d4ba231da46a8bb674e88a03c5bb8 : FAILURE in 44m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"47e9d87a25df1751777c8de8398f8bfb292e9446","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-02-22 16:07:36.000000000","message":"Patch Set 1: Verified-1\n\n(7 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/65f2b75999cd47828e4adda8c48a661d\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/939a23cacb484198a246bf0f014f083b : SUCCESS in 35m 01s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/b295c577a1214cfc99966af94636236f : SUCCESS in 1h 40m 14s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/bfa2a7c27227410f9e54f0b599a58345 : SUCCESS in 1h 06m 33s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cb1f8236d8ed4941b167b5f44b767d92 : SUCCESS in 26m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/65df58ea933c4ccf9ca354f321233413 : FAILURE in 7m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/bf43e3d0328a47239289d9e805cf6d26 : SUCCESS in 13m 46s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/7f2e139802df44bdac790837e00fcf3e : SUCCESS in 13m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f50fc6dd456b415a8f81fba612923f73 : SUCCESS in 9m 36s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/42fcfe7d88b34800b3831614705540fa : FAILURE in 1h 19m 34s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/c7eb9790757041738f30cc447b7c3ec8 : SUCCESS in 2h 02m 30s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/c713d980d541455a8dca4a48749ca8a4 : SUCCESS in 57m 12s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/d2638f2aab06489f9c993d7b247290f4 : SUCCESS in 32m 13s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/e239424e642c40a8b2e9ab0fb70399a4 : SUCCESS in 1h 52m 55s\n- nova-next https://zuul.opendev.org/t/openstack/build/6c327efe20d74d6fa9114a2f6453991c : FAILURE in 1h 23m 28s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/46cfd54b53874a9dae54f9fe93ba0145 : SUCCESS in 34m 41s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/f0a35d47edba4cd98048889afbb72afc : SUCCESS in 4m 56s (non-voting)\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/0cce8885dc9b482eaa8ac5d1a5abc819 : SUCCESS in 20m 37s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/2be4f510045b432aab40ff4d6792dbc9 : SUCCESS in 22m 04s\n- nova-tox-functional-py312 https://zuul.opendev.org/t/openstack/build/e3f52d98ee04404cbbcd6990fa9a35f3 : SUCCESS in 24m 27s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/0bf333adbfc944b7a8314e552b7c9026 : SUCCESS in 59m 11s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/4a80375938ee443093d41fff6390ae20 : SUCCESS in 42m 06s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/9818e260e0724e5ebf67c6a2df263cb0 : SUCCESS in 20m 46s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/7a97233ebf7a43aaaf7fb4665b52cfd0 : SUCCESS in 22m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a92b34bc74c737868b96e32ac9d6dcc9fb357cb5","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-03-06 09:46:03.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-942510-6f5km/index.html\u003e","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"68f44b27f7c72db1fc7a494dc6ee5f84056b9c14","revisions":{"68f44b27f7c72db1fc7a494dc6ee5f84056b9c14":{"kind":"REWORK","_number":1,"created":"2025-02-22 13:50:17.000000000","uploader":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"ref":"refs/changes/10/942510/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/10/942510/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/942510/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/942510/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/942510/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/10/942510/1"}}},"commit":{"parents":[{"commit":"375d95565d594182c5472f710b3f7bd53f0746d4","subject":"Merge \"FUP for reno issues\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/375d95565d594182c5472f710b3f7bd53f0746d4"}]}],"author":{"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","date":"2025-02-22 13:42:17.000000000","tz":120},"committer":{"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","date":"2025-02-22 13:49:54.000000000","tz":120},"subject":"Consider using X-Forwarded-Proto only if initial validation fails","message":"Consider using X-Forwarded-Proto only if initial validation fails\n\nSome proxies like Traefik would put a value of \u0027ws\u0027/\u0027wss\u0027 in the\n\u0027X-Forwarded-Proto\u0027 field instead of modifying the \u0027Origin\u0027 field\nlike haproxy does.\n\nSo, consider using X-Forwarded-Proto for validating the connection\ninfo only if validating against the scheme in the \u0027Origin\u0027 header\nfails first.\n\nChange-Id: I1639a2400f1614dd102caf7846f79c2f0513473d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/68f44b27f7c72db1fc7a494dc6ee5f84056b9c14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/68f44b27f7c72db1fc7a494dc6ee5f84056b9c14"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}