)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"352ee6352f123658ac4d5add2bd3bef8e7a37a38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"046de28e_a214ea18","updated":"2025-02-27 13:02:55.000000000","message":"i can see this being useful so sure.","commit_id":"6a7c94e730e3f7f4b77cae3fd01dc5efbcfe3e18"}],"nova/compute/multi_cell_list.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b156818bb936d27af71a88a9c79f11f13ff3831","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            # we won\u0027t call into the implementation\u0027s comparison routines)"},{"line_number":105,"context_line":"            # wrapping the sentinel indicating timeout."},{"line_number":106,"context_line":"            LOG.warning(\u0027Timed out waiting for response from cell in query \u0027"},{"line_number":107,"context_line":"                        \u0027generator: %s\u0027, e)"},{"line_number":108,"context_line":"            yield RecordWrapper(ctx, None, context.did_not_respond_sentinel)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"8ad3c46b_c2ea9a84","line":107,"updated":"2025-02-27 13:05:13.000000000","message":"by the way i assume the logic is \n\ntimeout are an expect exception case so while we should warn operator because it might indicate a problem in there infra its not very alarming if it ocationally happens.","commit_id":"6a7c94e730e3f7f4b77cae3fd01dc5efbcfe3e18"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"5dc179b158e381f9a29a4cbb4c791544e7130bae","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            # we won\u0027t call into the implementation\u0027s comparison routines)"},{"line_number":105,"context_line":"            # wrapping the sentinel indicating timeout."},{"line_number":106,"context_line":"            LOG.warning(\u0027Timed out waiting for response from cell in query \u0027"},{"line_number":107,"context_line":"                        \u0027generator: %s\u0027, e)"},{"line_number":108,"context_line":"            yield RecordWrapper(ctx, None, context.did_not_respond_sentinel)"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"2fb9b74c_1a05aaaa","line":107,"in_reply_to":"8ad3c46b_c2ea9a84","updated":"2025-02-28 02:21:19.000000000","message":"Done","commit_id":"6a7c94e730e3f7f4b77cae3fd01dc5efbcfe3e18"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b156818bb936d27af71a88a9c79f11f13ff3831","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            # we won\u0027t call into the implementation\u0027s comparison routines)"},{"line_number":113,"context_line":"            # wrapping the exception object indicating failure."},{"line_number":114,"context_line":"            LOG.exception(\u0027Error gathering result from cell in query \u0027"},{"line_number":115,"context_line":"                          \u0027generator: %s\u0027, e)"},{"line_number":116,"context_line":"            yield RecordWrapper(ctx, None, e.__class__(e.args))"},{"line_number":117,"context_line":"            return"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"cb1b800e_9445699a","line":115,"updated":"2025-02-27 13:05:13.000000000","message":"where as any other excption is more problematic and we shoudl use \nLOG.exception which i belive uses the ERROR level to highlight that more clearly in the logs.","commit_id":"6a7c94e730e3f7f4b77cae3fd01dc5efbcfe3e18"},{"author":{"_account_id":35560,"name":"zhou zhong","display_name":"zhouzhong","email":"zhong.zhou@easystack.cn","username":"Mizar"},"change_message_id":"5dc179b158e381f9a29a4cbb4c791544e7130bae","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            # we won\u0027t call into the implementation\u0027s comparison routines)"},{"line_number":113,"context_line":"            # wrapping the exception object indicating failure."},{"line_number":114,"context_line":"            LOG.exception(\u0027Error gathering result from cell in query \u0027"},{"line_number":115,"context_line":"                          \u0027generator: %s\u0027, e)"},{"line_number":116,"context_line":"            yield RecordWrapper(ctx, None, e.__class__(e.args))"},{"line_number":117,"context_line":"            return"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c6447e7b_14629353","line":115,"in_reply_to":"cb1b800e_9445699a","updated":"2025-02-28 02:21:19.000000000","message":"Done","commit_id":"6a7c94e730e3f7f4b77cae3fd01dc5efbcfe3e18"}]}