)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7c6659b209f3bcbfb2d3924479a8246a940cd3eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e96a7375_14e5af9b","updated":"2025-03-26 12:31:55.000000000","message":"by the way neither bug refence which storage backedn is beign used or if the isntance i usign local sotrage, shared storage or boot form ovlume\n\nfor ceph we already have this workaround flag\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#workarounds.ensure_libvirt_rbd_instance_dir_cleanup\n\nif we were to add a new config option it would be in the workaroudn section also an d we would need to have detection code for share stroage (nfs) or an explcit warning n the config option text to never enable it if the isntnace state dir si on nfs.","commit_id":"c848bdc1d40e180babe3f53e85c4486f62acc93d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"ea41ab11f4485aff13eda26b0d68d27439592ac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a7fe417b_65b76da5","updated":"2025-03-17 12:45:58.000000000","message":"recheck","commit_id":"c848bdc1d40e180babe3f53e85c4486f62acc93d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"daa36b639823b0d4ce20e33e43c326df0567d1da","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fd626c69_38d30d27","in_reply_to":"e96a7375_14e5af9b","updated":"2025-03-26 13:24:28.000000000","message":"In our case it doesn\u0027t matter, please see reply above.","commit_id":"c848bdc1d40e180babe3f53e85c4486f62acc93d"}],"nova/conf/libvirt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e83da50717b477b83d8bf90deb1bb325aa5ea8c2","unresolved":true,"context_lines":[{"line_number":945,"context_line":"                help\u003d\"\"\""},{"line_number":946,"context_line":"If instance was evacuated from host, it\u0027s directory can remain on host."},{"line_number":947,"context_line":"In case the instance is gonna migrate to that host we should cleanup its"},{"line_number":948,"context_line":"remnants."},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"Possible values:"},{"line_number":951,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fc355e47_be2e32e7","line":948,"updated":"2025-03-26 12:27:17.000000000","message":"this is unsafe if your isntance state dir is on shared storage.\n\nbut behond that this is at most a workaorund for the underling bug.\n\nwe have code to clean up the instace data on comptue node start up after an instance ahs been evacuated form the host so if we are not doing that we should fix the that bug.","commit_id":"c848bdc1d40e180babe3f53e85c4486f62acc93d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"daa36b639823b0d4ce20e33e43c326df0567d1da","unresolved":true,"context_lines":[{"line_number":945,"context_line":"                help\u003d\"\"\""},{"line_number":946,"context_line":"If instance was evacuated from host, it\u0027s directory can remain on host."},{"line_number":947,"context_line":"In case the instance is gonna migrate to that host we should cleanup its"},{"line_number":948,"context_line":"remnants."},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"Possible values:"},{"line_number":951,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f6e3707a_1c13dd9e","line":948,"in_reply_to":"fc355e47_be2e32e7","updated":"2025-03-26 13:24:28.000000000","message":"We check whether an instance is on shared storage several lines before.\nInstance artefacts exist on target hypervisor and instance is not on shared storage.\nYes, there is cleaning function on compute service startup, but it has several issues:\n1) if evacution starts during cleanup, then instance artefacts will be deleted on next compute service startup.\n2) If evacuation has started recently, cleanup code sends request to new instance\u0027s host and always gets RPC timeout. Evacuation status becomes \"completed\", instance artefacts will never be removed.\n3) If evacuation fails, then cleanup code gets RPC timeout from new expected instance host. Instance artefacts will never be removed.","commit_id":"c848bdc1d40e180babe3f53e85c4486f62acc93d"}]}