)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fdfeefe08e183cbea25b7e908b5442a763bf3cf8","unresolved":true,"context_lines":[{"line_number":13,"context_line":"[pci]"},{"line_number":14,"context_line":"alias \u003d { \"name\": \"vf1\", \"product_id\":\"10ca\", \"vendor_id\":\"8086\", \"device_type\":\"type-VF\"}"},{"line_number":15,"context_line":"alias \u003d { \"name\": \"vf1\", \"product_id\":\"f000\", \"vendor_id\":\"8086\", \"device_type\":\"type-VF\"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This would mean the alias vf1 can be fulfilled from devices with product"},{"line_number":18,"context_line":"id 10ca OR f000. However this OR relationship cannot be encoded to a"},{"line_number":19,"context_line":"single Placement allocation query as Placement does not support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f42df708_f5ec2484","line":16,"updated":"2025-03-11 17:55:06.000000000","message":"that shoudl be a config error","commit_id":"08ee86505cc3aee9024e2fd67c68a6aae2ae967d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"780bfd1a1e3780f88b9d7dfdd0a25f6612bf2bd9","unresolved":true,"context_lines":[{"line_number":13,"context_line":"[pci]"},{"line_number":14,"context_line":"alias \u003d { \"name\": \"vf1\", \"product_id\":\"10ca\", \"vendor_id\":\"8086\", \"device_type\":\"type-VF\"}"},{"line_number":15,"context_line":"alias \u003d { \"name\": \"vf1\", \"product_id\":\"f000\", \"vendor_id\":\"8086\", \"device_type\":\"type-VF\"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This would mean the alias vf1 can be fulfilled from devices with product"},{"line_number":18,"context_line":"id 10ca OR f000. However this OR relationship cannot be encoded to a"},{"line_number":19,"context_line":"single Placement allocation query as Placement does not support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"331ffa00_93659720","line":16,"in_reply_to":"f42df708_f5ec2484","updated":"2025-03-12 10:27:15.000000000","message":"It is not a config error today without PCI in Placement. I think nova actually supports this both in the config parsing and in the pci device pool matching logic:\n\n* config parsing logic: https://github.com/openstack/nova/blob/0d484ce37d86e989c8abdf57aec5e334f68206ef/nova/pci/request.py#L172\n* pool matching logic implementing OR between the specs https://github.com/openstack/nova/blob/0d484ce37d86e989c8abdf57aec5e334f68206ef/nova/pci/utils.py#L75","commit_id":"08ee86505cc3aee9024e2fd67c68a6aae2ae967d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"1518bdc47cf3a65929d203b78374b18686c734c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4677ed44_6e202ea1","updated":"2025-03-12 08:07:19.000000000","message":"We have a \"placement\" error message in such kind of configuration. But that\u0027s great to have it documented. 👍️","commit_id":"08ee86505cc3aee9024e2fd67c68a6aae2ae967d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"aeef3495ccea97b01c02755215a498fe6295fda0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5a01a119_71f51988","updated":"2025-06-11 14:25:33.000000000","message":"okay, eventually I\u0027m cool","commit_id":"c3f392dd8e895c457abd55d82d58f1bb400ccff6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b5885d5a1e370adc669eed6402357e8944663fca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"70b14bfc_54ebc6a7","updated":"2025-06-11 23:09:39.000000000","message":"recheck parent timed out","commit_id":"c3f392dd8e895c457abd55d82d58f1bb400ccff6"}],"doc/source/admin/pci-passthrough.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fdfeefe08e183cbea25b7e908b5442a763bf3cf8","unresolved":true,"context_lines":[{"line_number":435,"context_line":"   While nova supported configuring :oslo.config:option:`pci.alias` where an"},{"line_number":436,"context_line":"   alias name is repeated and therefore associated to multiple alias"},{"line_number":437,"context_line":"   specification such configuration is not supported when PCI tracking in"},{"line_number":438,"context_line":"   Placement is enabled."},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"The nova-compute service makes sure that existing instances with PCI"},{"line_number":441,"context_line":"allocations in the nova DB will have a corresponding PCI allocation in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f6515b75_d9ba6ad7","line":438,"updated":"2025-03-11 17:55:06.000000000","message":"that a bug\nalais names were intened to be unique\n\nwe have never inteded to suprot a relationship \n\nso \"supports\" is incorrect","commit_id":"08ee86505cc3aee9024e2fd67c68a6aae2ae967d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"73a50020fcbc3b313bbf03c6a61fb663ac76d0d1","unresolved":true,"context_lines":[{"line_number":435,"context_line":"   While nova supported configuring :oslo.config:option:`pci.alias` where an"},{"line_number":436,"context_line":"   alias name is repeated and therefore associated to multiple alias"},{"line_number":437,"context_line":"   specification such configuration is not supported when PCI tracking in"},{"line_number":438,"context_line":"   Placement is enabled."},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"The nova-compute service makes sure that existing instances with PCI"},{"line_number":441,"context_line":"allocations in the nova DB will have a corresponding PCI allocation in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0e0a48bd_e2f315ff","line":438,"in_reply_to":"0d11e9c8_a3dc5141","updated":"2025-06-04 16:09:06.000000000","message":"agreed with gibi, aliases are supported to be unfortunately the same","commit_id":"08ee86505cc3aee9024e2fd67c68a6aae2ae967d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"780bfd1a1e3780f88b9d7dfdd0a25f6612bf2bd9","unresolved":true,"context_lines":[{"line_number":435,"context_line":"   While nova supported configuring :oslo.config:option:`pci.alias` where an"},{"line_number":436,"context_line":"   alias name is repeated and therefore associated to multiple alias"},{"line_number":437,"context_line":"   specification such configuration is not supported when PCI tracking in"},{"line_number":438,"context_line":"   Placement is enabled."},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"The nova-compute service makes sure that existing instances with PCI"},{"line_number":441,"context_line":"allocations in the nova DB will have a corresponding PCI allocation in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0d11e9c8_a3dc5141","line":438,"in_reply_to":"f6515b75_d9ba6ad7","updated":"2025-03-12 10:27:15.000000000","message":"unfortunately it is not a bug, alias names are not needed to be unique, so nova supported (still supports without PCI in Placement) an alias with multiple specs and implements a OR relationship between them in the device pool matching logic.","commit_id":"08ee86505cc3aee9024e2fd67c68a6aae2ae967d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"99e4610064a5982bcd42a03c63c5b17ef2a19d01","unresolved":true,"context_lines":[{"line_number":439,"context_line":".. important::"},{"line_number":440,"context_line":"   While nova supported configuring :oslo.config:option:`pci.alias` where an"},{"line_number":441,"context_line":"   alias name is repeated and therefore associated to multiple alias"},{"line_number":442,"context_line":"   specification such configuration is not supported when PCI tracking in"},{"line_number":443,"context_line":"   Placement is enabled."},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"The nova-compute service makes sure that existing instances with PCI"}],"source_content_type":"text/x-rst","patch_set":5,"id":"aa7d9441_bf1c3f95","line":442,"range":{"start_line":442,"start_character":3,"end_line":442,"end_character":16},"updated":"2025-06-11 14:03:25.000000000","message":"\"specifications,\"","commit_id":"2c4eebb8a7e7e89da723e7c847a2e99873716d0c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"41fdac45add39daa7a6f83b19685c35c050cf79c","unresolved":false,"context_lines":[{"line_number":439,"context_line":".. important::"},{"line_number":440,"context_line":"   While nova supported configuring :oslo.config:option:`pci.alias` where an"},{"line_number":441,"context_line":"   alias name is repeated and therefore associated to multiple alias"},{"line_number":442,"context_line":"   specification such configuration is not supported when PCI tracking in"},{"line_number":443,"context_line":"   Placement is enabled."},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"The nova-compute service makes sure that existing instances with PCI"}],"source_content_type":"text/x-rst","patch_set":5,"id":"a7729bb7_ab6a3dca","line":442,"range":{"start_line":442,"start_character":3,"end_line":442,"end_character":16},"in_reply_to":"aa7d9441_bf1c3f95","updated":"2025-06-11 14:23:49.000000000","message":"Done","commit_id":"2c4eebb8a7e7e89da723e7c847a2e99873716d0c"}]}