)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fd5be058570b33a0f00d5ec925c49ca4dd967be5","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: This triggered an error in a functional test involving both a"},{"line_number":15,"context_line":"port request and a flavor-based request (mixed mode). The functional"},{"line_number":16,"context_line":"test will be provided in a subsequent FUP patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint migrate-vfio-devices-using-kernel-variant-drivers"},{"line_number":19,"context_line":"Change-Id: Icbeaadd94658ed44917d724446d484f6497f29e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"32efbb31_ba51d9d5","line":16,"updated":"2025-03-14 12:24:00.000000000","message":"For the future reader here is some context we pulled together from core reviewers\u0027 memory and old specs:\n* for a while live-migration did not use the claim object at all and fully relied on the update_availabled-resources periodics to keep the compute resource view eventually consistent / correct after an incoming migration\n* the NUMA aware live migration feature added the claim object usage to the live migration code path but only for NUMA aware VMs\n* the PCI claim happens outside of the claim object due to historical reasons so that happens for a VMs not just for NUMA aware VMs\n* the check being removed from the claim codepath is a duplicate. The same check is already done by the live_migration task in the conductor. So it is OK to be removed instead of extended to cover the new feature.","commit_id":"88a43963d07c671e75be3761396d036b46b8b69e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98fe49f6bbb0e0466994ec44eaa9cecd4130a2e6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: This triggered an error in a functional test involving both a"},{"line_number":15,"context_line":"port request and a flavor-based request (mixed mode). The functional"},{"line_number":16,"context_line":"test will be provided in a subsequent FUP patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint migrate-vfio-devices-using-kernel-variant-drivers"},{"line_number":19,"context_line":"Change-Id: Icbeaadd94658ed44917d724446d484f6497f29e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c8c31358_5a7c894b","line":16,"in_reply_to":"28aae715_07d65e08","updated":"2025-03-25 14:04:31.000000000","message":"Acknowledged","commit_id":"88a43963d07c671e75be3761396d036b46b8b69e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5a1478deb8cee57a6104e0b8758ba1c855faf109","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: This triggered an error in a functional test involving both a"},{"line_number":15,"context_line":"port request and a flavor-based request (mixed mode). The functional"},{"line_number":16,"context_line":"test will be provided in a subsequent FUP patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint migrate-vfio-devices-using-kernel-variant-drivers"},{"line_number":19,"context_line":"Change-Id: Icbeaadd94658ed44917d724446d484f6497f29e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"28aae715_07d65e08","line":16,"in_reply_to":"32efbb31_ba51d9d5","updated":"2025-03-14 13:42:17.000000000","message":"yep that all checkout with my understanding as well.","commit_id":"88a43963d07c671e75be3761396d036b46b8b69e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ebceb1388c6e84c68ce36f4b9755e2c8afeb217d","unresolved":true,"context_lines":[{"line_number":27,"context_line":"The _test_pci() check was redundant, as a similar verification"},{"line_number":28,"context_line":"is already performed earlier in the migration process."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Related-Bug: 2103636"},{"line_number":31,"context_line":"Implements: blueprint migrate-vfio-devices-using-kernel-variant-drivers"},{"line_number":32,"context_line":"Change-Id: Icbeaadd94658ed44917d724446d484f6497f29e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"18c3bf1d_e635a80f","line":30,"updated":"2025-03-20 15:25:03.000000000","message":"Closes-Bug: #2103636","commit_id":"e093d09337fb6152952e22b0e077c1d29c75f8fa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"b60ac7e4f9389fe65c23c123fa1e369011a32fba","unresolved":false,"context_lines":[{"line_number":27,"context_line":"The _test_pci() check was redundant, as a similar verification"},{"line_number":28,"context_line":"is already performed earlier in the migration process."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Related-Bug: 2103636"},{"line_number":31,"context_line":"Implements: blueprint migrate-vfio-devices-using-kernel-variant-drivers"},{"line_number":32,"context_line":"Change-Id: Icbeaadd94658ed44917d724446d484f6497f29e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f7fc7c08_c48a1066","line":30,"in_reply_to":"18c3bf1d_e635a80f","updated":"2025-03-25 13:34:52.000000000","message":"Done","commit_id":"e093d09337fb6152952e22b0e077c1d29c75f8fa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"745bfc5516da2cb4786e783db9100f0dcab55e42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4476d0c2_9973b7bd","updated":"2025-03-14 12:27:47.000000000","message":"Looks good to me after understanding the context. I\u0027m holding +W as we are RC1.","commit_id":"88a43963d07c671e75be3761396d036b46b8b69e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3d2ed562740d6bc16eb511d478a01a838c4fb24d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7106dd36_124d0aa6","updated":"2025-03-13 09:37:40.000000000","message":"recheck many post failures","commit_id":"88a43963d07c671e75be3761396d036b46b8b69e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f7d4176b9fef7c992c36ad8110982e781e9b8dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79ac5e17_ddfbb38a","updated":"2025-03-12 18:31:00.000000000","message":"recheck the connection to libvirt dropped\n\nthe nova live migration job is failign on this we are testing live migration in other jobs that passed but droping to +1 until this can run again.\n\ni think this is unrelated to yoru change but i have not debugged it fully\nlets see if it repoduces again.","commit_id":"88a43963d07c671e75be3761396d036b46b8b69e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"cb1699f8d865f6037351883415a3c5c19526686c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1bf879dd_fac49be3","updated":"2025-03-17 14:07:18.000000000","message":"was just a rebase and was already running on the gate","commit_id":"90925bef0af95f3b0da327939a113a7877f27971"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ebceb1388c6e84c68ce36f4b9755e2c8afeb217d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1457d7d5_9661e2fd","updated":"2025-03-20 15:25:03.000000000","message":"please fix the commit message, this patch not just related to the bug but actually fixing it. Then I will +2 it","commit_id":"e093d09337fb6152952e22b0e077c1d29c75f8fa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98fe49f6bbb0e0466994ec44eaa9cecd4130a2e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"79632ac5_2c1671a6","updated":"2025-03-25 14:04:31.000000000","message":"only the commit message change to reflect that this closes the bug so re-adding +2","commit_id":"ba11320c4d11062c75aa0189d76a1f114f20e70e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9dc2cf44e5a813fa34571185074471f5bfc38779","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5948392_9bf5cfd3","updated":"2025-03-26 08:08:32.000000000","message":"recheck nova-next timed out","commit_id":"ba11320c4d11062c75aa0189d76a1f114f20e70e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"383b17c1365da2cd1313095cf1716de5bd17da13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b8b9b94b_010c0277","updated":"2025-03-26 12:35:41.000000000","message":"recheck POST_FAILURE","commit_id":"4e4262cd3dfc6e2c1b0859882d2bd4dceb8ed7d8"}],"nova/tests/unit/compute/test_claims.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6493d2b04cd45793dcbf12b5970ed4da4997bd59","unresolved":true,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"class LiveMigrationClaimTestCase(ClaimTestCase):"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def test_live_migration_claim_bad_pci_request(self):"},{"line_number":376,"context_line":"        flavor \u003d self._fake_flavor()"},{"line_number":377,"context_line":"        instance \u003d self._fake_instance()"},{"line_number":378,"context_line":"        instance.numa_topology \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"c73a75ce_e84fbb19","side":"PARENT","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":49},"updated":"2025-03-12 18:26:38.000000000","message":"we could update this to assert the calim actully pases now but that will be tested transitivly by another test that is added in a follow up patch\n\nhttps://review.opendev.org/c/openstack/nova/+/944106/2/nova/tests/functional/libvirt/test_pci_sriov_servers.py#1611\n\nspecificly this request for cpu pinning\n\nhttps://review.opendev.org/c/openstack/nova/+/944106/2/nova/tests/functional/libvirt/test_pci_sriov_servers.py#2000\n\nenables the numa live migration code which was previosuly using this updated codepath.","commit_id":"442c4b5d86fde1c1c0cf8c1de4710bbe9217f8c4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"745bfc5516da2cb4786e783db9100f0dcab55e42","unresolved":true,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"class LiveMigrationClaimTestCase(ClaimTestCase):"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def test_live_migration_claim_bad_pci_request(self):"},{"line_number":376,"context_line":"        flavor \u003d self._fake_flavor()"},{"line_number":377,"context_line":"        instance \u003d self._fake_instance()"},{"line_number":378,"context_line":"        instance.numa_topology \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"fe6dbcde_f2ae8bae","side":"PARENT","line":375,"range":{"start_line":375,"start_character":8,"end_line":375,"end_character":49},"in_reply_to":"c73a75ce_e84fbb19","updated":"2025-03-14 12:27:47.000000000","message":"I\u0027m OK to test this with a positive functional test in a later pathc","commit_id":"442c4b5d86fde1c1c0cf8c1de4710bbe9217f8c4"}]}