)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e76b90f19752b3a859ad06a50176be43ade50225","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It adds the alias tag, which libvirt provides to specify the hostdev"},{"line_number":13,"context_line":"name, and the address tag, which indicates the address seen by"},{"line_number":14,"context_line":"the guest."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"These two fields will be used in a subsequent patch to improve the"},{"line_number":17,"context_line":"comparison between source and destination XMLs during migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8277fbd4_fa7e02f7","line":14,"updated":"2025-03-25 18:40:38.000000000","message":"actully we generate the aliss tag in some case but yes libvirt will add one if we dont.\n\nwe dint update this when we made that change so i agree its good to get these back in sync.","commit_id":"a89a642a309725f9f05b793f8aa772c8caca6447"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"71dfb22ea142ba8a71db2e0602e6d1fde2a30d25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12033c49_d55b62a7","updated":"2025-03-25 15:30:31.000000000","message":"This looks good. (not worth to respin due to my nit alone)","commit_id":"a89a642a309725f9f05b793f8aa772c8caca6447"}],"nova/tests/fixtures/libvirt.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"71dfb22ea142ba8a71db2e0602e6d1fde2a30d25","unresolved":true,"context_lines":[{"line_number":1588,"context_line":"        \u003c/interface\u003e\u0027\u0027\u0027 % nic"},{"line_number":1589,"context_line":""},{"line_number":1590,"context_line":"        hostdevs \u003d \u0027\u0027"},{"line_number":1591,"context_line":"        for (index, hostdev) in enumerate(self._def[\u0027devices\u0027][\u0027hostdevs\u0027]):"},{"line_number":1592,"context_line":"            if hostdev[\u0027type\u0027] \u003d\u003d \u0027mdev\u0027:"},{"line_number":1593,"context_line":"                hostdevs +\u003d \u0027\u0027\u0027\u003chostdev mode\u003d\u0027subsystem\u0027 type\u003d\u0027%(type)s\u0027 model\u003d\u0027%(model)s\u0027\u003e"},{"line_number":1594,"context_line":"    \u003csource\u003e"}],"source_content_type":"text/x-python","patch_set":2,"id":"308df0d3_9abd36df","line":1591,"updated":"2025-03-25 15:30:31.000000000","message":"nit: you don\u0027t need the parentheses around index, and hostdev\n\n```\n\u003e\u003e\u003e for index, item in enumerate([\"a\"]*5):\n...     print(index, item)\n...     \n0 a\n1 a\n2 a\n3 a\n4 a\n```","commit_id":"a89a642a309725f9f05b793f8aa772c8caca6447"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"9aed897fcb6571dde3492b85dc31eca9f129fdfe","unresolved":true,"context_lines":[{"line_number":1588,"context_line":"        \u003c/interface\u003e\u0027\u0027\u0027 % nic"},{"line_number":1589,"context_line":""},{"line_number":1590,"context_line":"        hostdevs \u003d \u0027\u0027"},{"line_number":1591,"context_line":"        for (index, hostdev) in enumerate(self._def[\u0027devices\u0027][\u0027hostdevs\u0027]):"},{"line_number":1592,"context_line":"            if hostdev[\u0027type\u0027] \u003d\u003d \u0027mdev\u0027:"},{"line_number":1593,"context_line":"                hostdevs +\u003d \u0027\u0027\u0027\u003chostdev mode\u003d\u0027subsystem\u0027 type\u003d\u0027%(type)s\u0027 model\u003d\u0027%(model)s\u0027\u003e"},{"line_number":1594,"context_line":"    \u003csource\u003e"}],"source_content_type":"text/x-python","patch_set":2,"id":"3e1822f7_782db41c","line":1591,"in_reply_to":"308df0d3_9abd36df","updated":"2025-03-25 17:32:35.000000000","message":"Arf, sorry, there\u0027s too much Rust here. :)\nI\u0027ll remove them, although I think it is easier to read with the parenthesis.","commit_id":"a89a642a309725f9f05b793f8aa772c8caca6447"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"97b1a107e287708823356e531d911111d3917d45","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"        \u003c/interface\u003e\u0027\u0027\u0027 % nic"},{"line_number":1589,"context_line":""},{"line_number":1590,"context_line":"        hostdevs \u003d \u0027\u0027"},{"line_number":1591,"context_line":"        for (index, hostdev) in enumerate(self._def[\u0027devices\u0027][\u0027hostdevs\u0027]):"},{"line_number":1592,"context_line":"            if hostdev[\u0027type\u0027] \u003d\u003d \u0027mdev\u0027:"},{"line_number":1593,"context_line":"                hostdevs +\u003d \u0027\u0027\u0027\u003chostdev mode\u003d\u0027subsystem\u0027 type\u003d\u0027%(type)s\u0027 model\u003d\u0027%(model)s\u0027\u003e"},{"line_number":1594,"context_line":"    \u003csource\u003e"}],"source_content_type":"text/x-python","patch_set":2,"id":"463c9077_2202c0f9","line":1591,"in_reply_to":"3e1822f7_782db41c","updated":"2025-03-26 09:04:48.000000000","message":"Done","commit_id":"a89a642a309725f9f05b793f8aa772c8caca6447"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2f686936dd26bc7e4fd03bc3cb42df88abc5666","unresolved":true,"context_lines":[{"line_number":1604,"context_line":"    \u003calias name\u003d\u0027hostdev{index}\u0027/\u003e"},{"line_number":1605,"context_line":"    \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x{vslot:02x}\u0027 function\u003d\u00270x0\u0027/\u003e"},{"line_number":1606,"context_line":"    \u003c/hostdev\u003e"},{"line_number":1607,"context_line":"            \u0027\u0027\u0027.format(index\u003dindex, vslot\u003dindex + 5, **hostdev)  # noqa"},{"line_number":1608,"context_line":""},{"line_number":1609,"context_line":"        vpmems \u003d \u0027\u0027"},{"line_number":1610,"context_line":"        for vpmem in self._def[\u0027devices\u0027][\u0027vpmems\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a07ad95b_f0b9637b","line":1607,"range":{"start_line":1607,"start_character":15,"end_line":1607,"end_character":23},"updated":"2025-03-26 12:57:07.000000000","message":"strictly speaking, there was no need to change form sting interpolation to format sting here. That partly obscures what you were actually changing, and it\u0027s inconsistent with the rest of the function.\n\nso it would have been preferable to not do both the addtion of the alias and this style change in one go.","commit_id":"98226b60f3fe7b20e8d7f208c12f8d0086cd83d0"}]}