)]}'
{"id":"openstack%2Fnova~945595","triplet_id":"openstack%2Fnova~stable%2F2024.1~Ifa2df89f27e58e1e64ce046edeaf6e49a7c89490","project":"openstack/nova","branch":"stable/2024.1","topic":"lun-device-serial-stable/2024.1","attention_set":{},"removed_from_attention_set":{"13425":{"account":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"last_update":"2025-03-26 14:31:03.000000000","reason":"\u003cGERRIT_ACCOUNT_13425\u003e replied on the change","reason_account":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"}}},"hashtags":[],"change_id":"Ifa2df89f27e58e1e64ce046edeaf6e49a7c89490","subject":"Avoid setting serial on raw LUN devices","status":"ABANDONED","created":"2025-03-26 14:08:25.000000000","updated":"2025-10-31 13:49:01.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":918089,"cherry_pick_of_patch_set":3,"meta_rev_id":"29cc868d6331573de8b57213618f4f20b4973d35","_number":945595,"virtual_id_number":945595,"owner":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:check","value":1,"date":"2025-03-26 16:07:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":-1,"date":"2025-03-26 14:26:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-26 14:08:25.000000000","updated_by":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"CC"},{"updated":"2025-03-26 14:26:37.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2025-03-26 14:35:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-03-26 16:07:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-03-27 05:48:45.000000000","updated_by":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"reviewer":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-10-31 13:49:01.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"450b7f13e61f8566b95cfd679a776fbea2692958","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"date":"2025-03-26 14:08:25.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"c6820540d0a2a5c9907a9b1a706f2afad9a39f56","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2025-03-26 14:26:37.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"56de5166bee758a3fdae1b7d329eb04e56515689","author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"date":"2025-03-26 14:31:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e43dab4041f959ad4a0d0dd52854b88609a03e39","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-03-26 14:35:58.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e2fc782bcef8471fa4c4cac465dc9d7a\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/74646f0b58fb468b935b4efd8fd28f8b : SUCCESS in 17m 11s (non-voting)\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/14f6b857dca74a44989714a92604763e : SUCCESS in 13m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a62e7d0bed4c7e78e6e3ca5d4bd34267ea7a398d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-03-26 16:07:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d4d1fbc07ec2418fa73a2b803b63b8e2\n\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/1ca8e5947c004174ab63af393e6b123c : SUCCESS in 54m 30s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/fc81f1954e6b4a65b1f2e2811dca6f36 : SUCCESS in 1h 46m 09s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/39e3396ef1f64078bd690e478e825255 : SUCCESS in 52m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9876e4a0fb9f4ad4a981a21271f5566e : SUCCESS in 18m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e01d2776227e434498aacbdb38f6215f : SUCCESS in 8m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6d2fefc1bfcb4e43943f1ee6911734d5 : SUCCESS in 16m 02s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/7af65db881af469784e6795c9f3c71a5 : SUCCESS in 11m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/83c42ecb21d04ee09aabcf8e6ead57a1 : SUCCESS in 9m 11s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/226ca65811084849b9295e95cdca3d56 : SUCCESS in 41m 53s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/1c1fd53669ec4d4e91560462a9d3ab19 : SUCCESS in 1h 49m 00s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/e05095a15a1a4e2cbcb3a9e5ea9cdac1 : SUCCESS in 54m 55s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/afcc167800ac4b49931915cada4513bc : SUCCESS in 2m 35s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5c27faa4bf3747f5949f9e57c50e2284 : SUCCESS in 24m 54s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/72bdd718de8b427dbae6a7880902f9f9 : SUCCESS in 23m 31s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/aa0924625de3417d83a122949833f4fd : SUCCESS in 27m 24s\n- tempest-integrated-compute-enforce-scope-new-defaults https://zuul.opendev.org/t/openstack/build/89702d14f65d4616901fe5528b6f717f : SUCCESS in 1h 36m 59s\n- tempest-integrated-compute-rbac-old-defaults https://zuul.opendev.org/t/openstack/build/ee96ae2109d9415ea9596169033e8477 : SUCCESS in 1h 56m 04s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/2e10470afd9945f9a2374a14996e00d1 : SUCCESS in 1h 08m 35s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5626a76776d542b8b38a27620a8a52c2 : SUCCESS in 53m 41s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/227be05e6a014120982a8bdb616b341e : SUCCESS in 24m 12s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/1ce0ed12884e4a44a3ad8223373c71d8 : SUCCESS in 17m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"10d73b43736a818ae8a76bf7bcf4db79e11290a5","tag":"autogenerated:sap-openstack-ci~result","author":{"_account_id":36571,"name":"vmwareapi CI run by SAP","display_name":"vmwareapi CI run by SAP","email":"openstack-ci@sap.com","username":"sap-openstack-ci","status":"CI account for integration tests of the Nova vmwareapi driver","tags":["SERVICE_USER"]},"date":"2025-03-27 05:48:45.000000000","message":"Patch Set 1:\n\nIgnore for now: Test failed. Logs on \u003chttp://openstack-ci-logs.global.cloud.sap/openstack-nova-945595-gcwrg/index.html\u003e","accounts_in_message":[],"_revision_number":1},{"id":"29cc868d6331573de8b57213618f4f20b4973d35","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-10-31 13:49:01.000000000","message":"Abandoned\n\nstable/2024.1 branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/2024.1 if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"76ff66199acb6623248f56181dbf8e78181bb6eb","revisions":{"76ff66199acb6623248f56181dbf8e78181bb6eb":{"kind":"REWORK","_number":1,"created":"2025-03-26 14:08:25.000000000","uploader":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"ref":"refs/changes/95/945595/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/95/945595/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/945595/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/945595/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/95/945595/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/95/945595/1"}}},"commit":{"parents":[{"commit":"a21bf290ccc467c8fec0768879e80a1e0d504f2b","subject":"Merge \"libvirt: Fix regression of listDevices() return type\" into stable/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a21bf290ccc467c8fec0768879e80a1e0d504f2b"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2024-05-03 15:55:50.000000000","tz":-420},"committer":{"name":"Simon Dodsley","email":"simon@purestorage.com","date":"2025-03-26 14:08:25.000000000","tz":0},"subject":"Avoid setting serial on raw LUN devices","message":"Avoid setting serial on raw LUN devices\n\nLibvirt now enforces that device\u003d\"lun\" (i.e. raw device passthrough)\ndisks must not have the \u003cserial\u003e property set. We recently enabled\nthe ability to manage devices by alias instead of serial, but to\nfully enable this use-case we need to avoid putting serial in the\nXML to appease libvirt.\n\nRelated-Bug: #2065084\nChange-Id: Ifa2df89f27e58e1e64ce046edeaf6e49a7c89490\n(cherry picked from commit 575ff86a4f1572786d66639f774405fbc074fdb1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/76ff66199acb6623248f56181dbf8e78181bb6eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/76ff66199acb6623248f56181dbf8e78181bb6eb"}]},"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}