)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0df030965a9eac288092b4b71b5fa4e475490d81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9212025d_a505f13a","updated":"2025-03-26 19:58:43.000000000","message":"close, can you refactor the test to be more explcit about what we are asserting","commit_id":"1038f1a8c0bd177e95e6c544f7b2c96eac30c449"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4ac17da7b09cc2cb9b9e171d8e87b4298366b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3d6d077c_980256ca","updated":"2025-05-30 07:59:41.000000000","message":"Looks good to me","commit_id":"2180c205b4ab8f4646fb10b0ea4f7f6498ee8a72"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7f5841369f1ac96e3dec2476ad04ec75fd5fb854","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"056c1ec4_6b0fa569","updated":"2025-05-27 16:53:05.000000000","message":"i need to lood context on this again but i think this is more or less good\n\nwe could add a release note but i think im also ok without that.\n\nlets see what others think","commit_id":"2180c205b4ab8f4646fb10b0ea4f7f6498ee8a72"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"95ac2b23925f2a438fc5bb3bec8602d5fd7e8091","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"434f30c5_333ebb5e","updated":"2025-03-27 15:01:00.000000000","message":"recheck nova-live-migration POST_FAILURE","commit_id":"2180c205b4ab8f4646fb10b0ea4f7f6498ee8a72"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0df030965a9eac288092b4b71b5fa4e475490d81","unresolved":true,"context_lines":[{"line_number":9249,"context_line":"            if device.root_name \u003d\u003d \u0027memballoon\u0027 and device.model !\u003d \u0027none\u0027:"},{"line_number":9250,"context_line":"                disabled \u003d False"},{"line_number":9251,"context_line":"                break"},{"line_number":9252,"context_line":"        self.assertTrue(disabled)"},{"line_number":9253,"context_line":""},{"line_number":9254,"context_line":"    def test_get_guest_memory_balloon_config_period_value(self):"},{"line_number":9255,"context_line":"        self.flags(mem_stats_period_seconds\u003d21, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e43f6e99_12aa0775","line":9252,"updated":"2025-03-26 19:58:43.000000000","message":"you shoudl realy do this as two assert.\n\nyou need to assert that the element is present\nand that the model is \"none\"\nbecaus if the eleemnt is not there it will be added by livbirt and the device will be enebled.\n\nand if it is there an the model is anything oother then none its also not disabled properly.","commit_id":"1038f1a8c0bd177e95e6c544f7b2c96eac30c449"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09562ffbf2a0294bf891aa68efddf7e7ff0a91a1","unresolved":false,"context_lines":[{"line_number":9249,"context_line":"            if device.root_name \u003d\u003d \u0027memballoon\u0027 and device.model !\u003d \u0027none\u0027:"},{"line_number":9250,"context_line":"                disabled \u003d False"},{"line_number":9251,"context_line":"                break"},{"line_number":9252,"context_line":"        self.assertTrue(disabled)"},{"line_number":9253,"context_line":""},{"line_number":9254,"context_line":"    def test_get_guest_memory_balloon_config_period_value(self):"},{"line_number":9255,"context_line":"        self.flags(mem_stats_period_seconds\u003d21, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e390a83b_64e02da2","line":9252,"in_reply_to":"e43f6e99_12aa0775","updated":"2025-03-27 08:40:20.000000000","message":"Done","commit_id":"1038f1a8c0bd177e95e6c544f7b2c96eac30c449"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09562ffbf2a0294bf891aa68efddf7e7ff0a91a1","unresolved":true,"context_lines":[{"line_number":9244,"context_line":"                                            image_meta)"},{"line_number":9245,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":9246,"context_line":"                                     image_meta, disk_info)"},{"line_number":9247,"context_line":"        exist \u003d False"},{"line_number":9248,"context_line":"        dev_model \u003d \u0027\u0027"},{"line_number":9249,"context_line":"        for device in cfg.devices:"},{"line_number":9250,"context_line":"            if device.root_name \u003d\u003d \u0027memballoon\u0027:"},{"line_number":9251,"context_line":"                exist \u003d True"},{"line_number":9252,"context_line":"                dev_model \u003d device.model"},{"line_number":9253,"context_line":"                break"},{"line_number":9254,"context_line":"        self.assertTrue(exist)"},{"line_number":9255,"context_line":"        self.assertEqual(\u0027none\u0027, dev_model)"},{"line_number":9256,"context_line":""},{"line_number":9257,"context_line":"    def test_get_guest_memory_balloon_config_period_value(self):"},{"line_number":9258,"context_line":"        self.flags(mem_stats_period_seconds\u003d21, group\u003d\u0027libvirt\u0027)"},{"line_number":9259,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7d677ac_3ee7d220","line":9256,"range":{"start_line":9247,"start_character":7,"end_line":9256,"end_character":1},"updated":"2025-03-27 08:40:20.000000000","message":"i would have done this slightly differntly but sure this works\n\n```suggestion\n        mem_balloon \u003d None\n        for device in cfg.devices:\n            if device.root_name \u003d\u003d \u0027memballoon\u0027:\n                mem_ballon \u003d device\n                break\n        self.assertIsNotNone(mem_balloon)\n        self.assertEqual(\u0027none\u0027, mem_balloon.model)\n\n```","commit_id":"7e9f0f34beca55d560a15855a6ecef7d7479785f"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"851a930a5b6d8b6f312a05d1d9029ff5ff52adef","unresolved":true,"context_lines":[{"line_number":9244,"context_line":"                                            image_meta)"},{"line_number":9245,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":9246,"context_line":"                                     image_meta, disk_info)"},{"line_number":9247,"context_line":"        exist \u003d False"},{"line_number":9248,"context_line":"        dev_model \u003d \u0027\u0027"},{"line_number":9249,"context_line":"        for device in cfg.devices:"},{"line_number":9250,"context_line":"            if device.root_name \u003d\u003d \u0027memballoon\u0027:"},{"line_number":9251,"context_line":"                exist \u003d True"},{"line_number":9252,"context_line":"                dev_model \u003d device.model"},{"line_number":9253,"context_line":"                break"},{"line_number":9254,"context_line":"        self.assertTrue(exist)"},{"line_number":9255,"context_line":"        self.assertEqual(\u0027none\u0027, dev_model)"},{"line_number":9256,"context_line":""},{"line_number":9257,"context_line":"    def test_get_guest_memory_balloon_config_period_value(self):"},{"line_number":9258,"context_line":"        self.flags(mem_stats_period_seconds\u003d21, group\u003d\u0027libvirt\u0027)"},{"line_number":9259,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c697c6cf_36496355","line":9256,"range":{"start_line":9247,"start_character":7,"end_line":9256,"end_character":1},"in_reply_to":"b7d677ac_3ee7d220","updated":"2025-03-27 10:33:56.000000000","message":"yes, it looks more readable, as it uses one variable for it to work.\n\nI will update patch with this change.\n\nThanks!","commit_id":"7e9f0f34beca55d560a15855a6ecef7d7479785f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7f5841369f1ac96e3dec2476ad04ec75fd5fb854","unresolved":false,"context_lines":[{"line_number":9244,"context_line":"                                            image_meta)"},{"line_number":9245,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":9246,"context_line":"                                     image_meta, disk_info)"},{"line_number":9247,"context_line":"        exist \u003d False"},{"line_number":9248,"context_line":"        dev_model \u003d \u0027\u0027"},{"line_number":9249,"context_line":"        for device in cfg.devices:"},{"line_number":9250,"context_line":"            if device.root_name \u003d\u003d \u0027memballoon\u0027:"},{"line_number":9251,"context_line":"                exist \u003d True"},{"line_number":9252,"context_line":"                dev_model \u003d device.model"},{"line_number":9253,"context_line":"                break"},{"line_number":9254,"context_line":"        self.assertTrue(exist)"},{"line_number":9255,"context_line":"        self.assertEqual(\u0027none\u0027, dev_model)"},{"line_number":9256,"context_line":""},{"line_number":9257,"context_line":"    def test_get_guest_memory_balloon_config_period_value(self):"},{"line_number":9258,"context_line":"        self.flags(mem_stats_period_seconds\u003d21, group\u003d\u0027libvirt\u0027)"},{"line_number":9259,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d2ec6779_acb35fa7","line":9256,"range":{"start_line":9247,"start_character":7,"end_line":9256,"end_character":1},"in_reply_to":"c697c6cf_36496355","updated":"2025-05-27 16:53:05.000000000","message":"Done","commit_id":"7e9f0f34beca55d560a15855a6ecef7d7479785f"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0df030965a9eac288092b4b71b5fa4e475490d81","unresolved":true,"context_lines":[{"line_number":7764,"context_line":"            else:"},{"line_number":7765,"context_line":"                balloon \u003d vconfig.LibvirtConfigMemoryBalloon()"},{"line_number":7766,"context_line":"                balloon.model \u003d \u0027none\u0027"},{"line_number":7767,"context_line":"                guest.add_device(balloon)"},{"line_number":7768,"context_line":""},{"line_number":7769,"context_line":"    @staticmethod"},{"line_number":7770,"context_line":"    def _guest_add_watchdog_action(guest, flavor, image_meta):"}],"source_content_type":"text/x-python","patch_set":1,"id":"03af82fc_c7836494","line":7767,"updated":"2025-03-26 19:58:43.000000000","message":"the fix looks fine to me","commit_id":"1038f1a8c0bd177e95e6c544f7b2c96eac30c449"}]}